)]}'
{"manifests/packages.pp":[{"author":{"_account_id":12715,"name":"John Trowbridge","email":"trown@redhat.com","username":"trown"},"change_message_id":"48fec921619b60878ef6aa0254d9c286af017ce9","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  if $enable_upgrade {"},{"line_number":50,"context_line":"    Package \u003c| |\u003e { ensure \u003d\u003e \u0027latest\u0027 }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    case $::osfamily {"},{"line_number":53,"context_line":"      \u0027RedHat\u0027: {"},{"line_number":54,"context_line":"        $pkg_upgrade_cmd \u003d \u0027yum -y update\u0027"},{"line_number":55,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"fa6399be_6011d85c","line":52,"updated":"2016-10-14 19:26:11.000000000","message":"do we need this case block both here and in the upgrades class we pull in below?","commit_id":"2349dcccdff89fd83c327167edaacbb7b714aa26"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"954486c72d9b048966ab3f2c922983ca00b45a70","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  if $enable_upgrade {"},{"line_number":50,"context_line":"    Package \u003c| |\u003e { ensure \u003d\u003e \u0027latest\u0027 }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    case $::osfamily {"},{"line_number":53,"context_line":"      \u0027RedHat\u0027: {"},{"line_number":54,"context_line":"        $pkg_upgrade_cmd \u003d \u0027yum -y update\u0027"},{"line_number":55,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"fa6399be_4fb31f0a","line":52,"in_reply_to":"fa6399be_6011d85c","updated":"2016-10-14 22:17:45.000000000","message":"Done","commit_id":"2349dcccdff89fd83c327167edaacbb7b714aa26"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"617d0c25604d070eabf7d11f5f505bcb764baf29","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    # So we\u0027re sure that services will be able to restart with the new version"},{"line_number":63,"context_line":"    # of the package."},{"line_number":64,"context_line":"    ensure_resource(\u0027class\u0027, \u0027tripleo::packages::upgrades\u0027, {"},{"line_number":65,"context_line":"      \u0027stage\u0027 \u003d\u003e \u0027setup\u0027,"},{"line_number":66,"context_line":"    })"},{"line_number":67,"context_line":"  }"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"fa6399be_7cbd0ed7","line":65,"updated":"2016-10-14 16:04:27.000000000","message":"does \u0027stage\u0027 need to be in quotes?","commit_id":"2349dcccdff89fd83c327167edaacbb7b714aa26"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"86053fa8ad4962ed8691b2570df835a083262ccd","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    # So we\u0027re sure that services will be able to restart with the new version"},{"line_number":63,"context_line":"    # of the package."},{"line_number":64,"context_line":"    ensure_resource(\u0027class\u0027, \u0027tripleo::packages::upgrades\u0027, {"},{"line_number":65,"context_line":"      \u0027stage\u0027 \u003d\u003e \u0027setup\u0027,"},{"line_number":66,"context_line":"    })"},{"line_number":67,"context_line":"  }"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"fa6399be_2f77d602","line":65,"in_reply_to":"fa6399be_7cbd0ed7","updated":"2016-10-14 16:40:19.000000000","message":"yeah, when using ensure_resource parameters names need to be single quoted.","commit_id":"2349dcccdff89fd83c327167edaacbb7b714aa26"}],"manifests/packages/upgrades.pp":[{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"80f2ef3ac38b28d7ef140c403c84b578044e43f3","unresolved":false,"context_lines":[{"line_number":20,"context_line":"class tripleo::packages::upgrades {"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  # required for stages"},{"line_number":23,"context_line":"  include ::stdlib"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  case $::osfamily {"},{"line_number":26,"context_line":"    \u0027RedHat\u0027: {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa6399be_79e0c0cd","line":23,"updated":"2016-10-14 15:50:10.000000000","message":"This shouldn\u0027t be needed.","commit_id":"c792bba4f257e732704ad5de725823ed0962694e"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"0b615e68b26dc62a1479b9d6dccbb84056c36efc","unresolved":false,"context_lines":[{"line_number":20,"context_line":"class tripleo::packages::upgrades {"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  # required for stages"},{"line_number":23,"context_line":"  include ::stdlib"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  case $::osfamily {"},{"line_number":26,"context_line":"    \u0027RedHat\u0027: {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa6399be_5953fc38","line":23,"in_reply_to":"fa6399be_79e0c0cd","updated":"2016-10-14 15:58:47.000000000","message":"Right, but I\u0027ve seen some cases where catalog failed. I can\u0027t recall if it was a specific puppet version or if it was for unit tests.","commit_id":"c792bba4f257e732704ad5de725823ed0962694e"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"80f2ef3ac38b28d7ef140c403c84b578044e43f3","unresolved":false,"context_lines":[{"line_number":27,"context_line":"      $pkg_upgrade_cmd \u003d \u0027yum -y update\u0027"},{"line_number":28,"context_line":"    }"},{"line_number":29,"context_line":"    default: {"},{"line_number":30,"context_line":"      warning(\u0027Please specify a package upgrade command for distribution.\u0027)"},{"line_number":31,"context_line":"    }"},{"line_number":32,"context_line":"  }"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa6399be_b9fdf86f","line":30,"updated":"2016-10-14 15:50:10.000000000","message":"This should be an error as the pkg_upgrade_cmd will be empty in the exec.","commit_id":"c792bba4f257e732704ad5de725823ed0962694e"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"0b615e68b26dc62a1479b9d6dccbb84056c36efc","unresolved":false,"context_lines":[{"line_number":27,"context_line":"      $pkg_upgrade_cmd \u003d \u0027yum -y update\u0027"},{"line_number":28,"context_line":"    }"},{"line_number":29,"context_line":"    default: {"},{"line_number":30,"context_line":"      warning(\u0027Please specify a package upgrade command for distribution.\u0027)"},{"line_number":31,"context_line":"    }"},{"line_number":32,"context_line":"  }"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa6399be_f90f7034","line":30,"in_reply_to":"fa6399be_b9fdf86f","updated":"2016-10-14 15:58:47.000000000","message":"Done","commit_id":"c792bba4f257e732704ad5de725823ed0962694e"}],"spec/classes/tripleo_packages_spec.rb":[{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"80f2ef3ac38b28d7ef140c403c84b578044e43f3","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    end"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    it \u0027should contain upgrade exec\u0027 do"},{"line_number":33,"context_line":"        is_expected.to contain_exec(\u0027package-upgrade\u0027).with(:command \u003d\u003e \u0027yum -y update\u0027)"},{"line_number":34,"context_line":"    end"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"fa6399be_997f54df","line":33,"updated":"2016-10-14 15:50:10.000000000","message":"This won\u0027t work.  The class now has a class with packages::upgrade, not the exec resource.","commit_id":"c792bba4f257e732704ad5de725823ed0962694e"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"0b615e68b26dc62a1479b9d6dccbb84056c36efc","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    end"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    it \u0027should contain upgrade exec\u0027 do"},{"line_number":33,"context_line":"        is_expected.to contain_exec(\u0027package-upgrade\u0027).with(:command \u003d\u003e \u0027yum -y update\u0027)"},{"line_number":34,"context_line":"    end"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"fa6399be_7c850e58","line":33,"in_reply_to":"fa6399be_997f54df","updated":"2016-10-14 15:58:47.000000000","message":"I tested it and test run fine.","commit_id":"c792bba4f257e732704ad5de725823ed0962694e"}]}