)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"92f4f9e152ec9160ca983a0116495dcc9b62a309","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Removes logic dependent on \u0027odl_on_controller\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since moving to composable service/roles there was some logic here that"},{"line_number":10,"context_line":"was relying on a variable to enable ODL rather than enabling the service"},{"line_number":11,"context_line":"itself to decide where ODL was enabled.  Now that ODL and ODL OVS"},{"line_number":12,"context_line":"configuration are split into 2 different services we can make these"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_fe40c737","line":9,"range":{"start_line":9,"start_character":16,"end_line":9,"end_character":26},"updated":"2016-10-18 15:31:44.000000000","message":"nit compossible","commit_id":"4cf346d257611f88a00d30350c3d062fd32cd83e"},{"author":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"change_message_id":"3d8a55bfee0cef234d380bbc8c06ad80248782e9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Removes logic dependent on \u0027odl_on_controller\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since moving to composable service/roles there was some logic here that"},{"line_number":10,"context_line":"was relying on a variable to enable ODL rather than enabling the service"},{"line_number":11,"context_line":"itself to decide where ODL was enabled.  Now that ODL and ODL OVS"},{"line_number":12,"context_line":"configuration are split into 2 different services we can make these"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_b87c75ec","line":9,"range":{"start_line":9,"start_character":16,"end_line":9,"end_character":26},"in_reply_to":"fa6399be_fe40c737","updated":"2016-10-19 14:13:14.000000000","message":"I think composability and compossibility are 2 different things:\nhttps://en.wikipedia.org/wiki/Composability\nhttps://en.wikipedia.org/wiki/Compossibility","commit_id":"4cf346d257611f88a00d30350c3d062fd32cd83e"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"92f4f9e152ec9160ca983a0116495dcc9b62a309","unresolved":false,"context_lines":[{"line_number":10,"context_line":"was relying on a variable to enable ODL rather than enabling the service"},{"line_number":11,"context_line":"itself to decide where ODL was enabled.  Now that ODL and ODL OVS"},{"line_number":12,"context_line":"configuration are split into 2 different services we can make these"},{"line_number":13,"context_line":"truly composable."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Partial-Bug: 1633625"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_1eac9bec","line":13,"range":{"start_line":13,"start_character":6,"end_line":13,"end_character":16},"updated":"2016-10-18 15:31:44.000000000","message":"nit: compossible","commit_id":"4cf346d257611f88a00d30350c3d062fd32cd83e"}],"manifests/profile/base/neutron/opendaylight.pp":[{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"92f4f9e152ec9160ca983a0116495dcc9b62a309","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  }"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  if $step \u003e\u003d 1 {"},{"line_number":41,"context_line":"    # Configure ODL only on first controller"},{"line_number":42,"context_line":"    if $primary_controller \u003d\u003d downcase($::hostname) {"},{"line_number":43,"context_line":"      include ::opendaylight"},{"line_number":44,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa6399be_73c6b017","line":41,"range":{"start_line":41,"start_character":15,"end_line":41,"end_character":16},"updated":"2016-10-18 15:31:44.000000000","message":"just curious if the comment needs to be updated","commit_id":"4cf346d257611f88a00d30350c3d062fd32cd83e"},{"author":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"change_message_id":"3d8a55bfee0cef234d380bbc8c06ad80248782e9","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  }"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  if $step \u003e\u003d 1 {"},{"line_number":41,"context_line":"    # Configure ODL only on first controller"},{"line_number":42,"context_line":"    if $primary_controller \u003d\u003d downcase($::hostname) {"},{"line_number":43,"context_line":"      include ::opendaylight"},{"line_number":44,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa6399be_5878b9f2","line":41,"range":{"start_line":41,"start_character":15,"end_line":41,"end_character":16},"in_reply_to":"fa6399be_73c6b017","updated":"2016-10-19 14:13:14.000000000","message":"This is still applicable as we only support installing on the first controller for hte time being.","commit_id":"4cf346d257611f88a00d30350c3d062fd32cd83e"}],"manifests/profile/base/neutron/plugins/ovs/opendaylight.pp":[{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"0f108600fec280fdd2ce4b3840cd3de8e71618e9","unresolved":false,"context_lines":[{"line_number":48,"context_line":") {"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":51,"context_line":"    $opendaylight_controller_ip \u003d $odl_api_ips[0]"},{"line_number":52,"context_line":"    $odl_url_ip \u003d hiera(\u0027opendaylight_api_vip\u0027)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    if ! $opendaylight_controller_ip { fail(\u0027OpenDaylight Controller IP is Empty\u0027) }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa6399be_c757bac8","line":51,"range":{"start_line":51,"start_character":35,"end_line":51,"end_character":46},"updated":"2016-10-18 13:53:21.000000000","message":"It looks like we only use this to ensure odl is enabled/running, so can we just check odl_url_ip instead, as opendaylight_api_vip will be undef if the service isn\u0027t enabled?","commit_id":"4cf346d257611f88a00d30350c3d062fd32cd83e"},{"author":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"change_message_id":"819ffe5d49586f0d3177b9e4b30394511ce4edfc","unresolved":false,"context_lines":[{"line_number":48,"context_line":") {"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":51,"context_line":"    $opendaylight_controller_ip \u003d $odl_api_ips[0]"},{"line_number":52,"context_line":"    $odl_url_ip \u003d hiera(\u0027opendaylight_api_vip\u0027)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    if ! $opendaylight_controller_ip { fail(\u0027OpenDaylight Controller IP is Empty\u0027) }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa6399be_58a70b4f","line":51,"range":{"start_line":51,"start_character":35,"end_line":51,"end_character":46},"in_reply_to":"fa6399be_c757bac8","updated":"2016-10-18 15:10:52.000000000","message":"So there are 2 things happening.  The first is as you mentioned where we are building a URL to check to make sure ODL is up (using VIP).  This is required because OVS is not allowed to connect to ODL before it is all the way up and this is a NorthBound check.  The second piece (after we verify ODL is up) is we configure OVS to point to ODL.  This is considered the SouthBound and it should point to the physical IP of ODL.  When we add HA support for ODL, the connection string will look something like:\nodl_ovsdb_iface \u003d\u003e \"tcp:${odl_api_ips[0]}:6640,tcp:${odl_api_ips[1]}:6640,tcp:${odl_api_ips[2]}:6640\"\n\nThen ODL decides which one is master and which other 2 are standby.  I don\u0027t think we want HAproxy interfering in SouthBound OVS side.","commit_id":"4cf346d257611f88a00d30350c3d062fd32cd83e"}]}