)]}'
{"manifests/profile/base/nova/api.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"73ffca1e6c6f57f03244f5bd4200194feed0d2a9","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  if $step \u003e\u003d 4 or ($step \u003e\u003d 3 and $sync_db) {"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    if hiera(\u0027nova::use_ipv6\u0027, false) {"},{"line_number":43,"context_line":"      $memcache_servers \u003d suffix(hiera(\u0027memcached_node_ips_v6\u0027), \u0027:11211\u0027)"},{"line_number":44,"context_line":"    } else {"},{"line_number":45,"context_line":"      $memcache_servers \u003d suffix(hiera(\u0027memcached_node_ips\u0027), \u0027:11211\u0027)"},{"line_number":46,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa6399be_0698f769","line":43,"updated":"2016-10-17 19:02:26.000000000","message":"I have seen issues in the past where brackets were missing in hiera but required by puppet.\n\nI would rather do something like:\n  suffix(any2array(normalize_ip_for_uri(hiera(\u0027memcached_node_ips_v6\u0027))), \u0027:11211\u0027)","commit_id":"d01f443b9de61c68e666ae0250f2c0fe60d00f62"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"73ffca1e6c6f57f03244f5bd4200194feed0d2a9","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    if hiera(\u0027nova::use_ipv6\u0027, false) {"},{"line_number":43,"context_line":"      $memcache_servers \u003d suffix(hiera(\u0027memcached_node_ips_v6\u0027), \u0027:11211\u0027)"},{"line_number":44,"context_line":"    } else {"},{"line_number":45,"context_line":"      $memcache_servers \u003d suffix(hiera(\u0027memcached_node_ips\u0027), \u0027:11211\u0027)"},{"line_number":46,"context_line":"    }"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    class { \u0027::nova::keystone::authtoken\u0027:"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa6399be_269dfb59","line":45,"updated":"2016-10-17 19:02:26.000000000","message":"dito","commit_id":"d01f443b9de61c68e666ae0250f2c0fe60d00f62"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"8b3660f6289c9553bfc581600d96e701410e27af","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    }"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    class { \u0027::nova::keystone::authtoken\u0027:"},{"line_number":49,"context_line":"      memcached_servers \u003d\u003e $memcache_servers"},{"line_number":50,"context_line":"    }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    class { \u0027::nova::api\u0027:"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"fa6399be_8e0956e0","line":49,"updated":"2016-10-18 16:41:36.000000000","message":"Speaking from previous experiances, it was found that if you have multiple memcached servers and some go away (crashed/not available/etc) you actually have a performance degradation due to the way the underlying memcache library pools the memache servers. It\u0027s actually better to just configure a single localhost memcache for this rather than a pool of them. I know it\u0027s a bug that we dont\u0027 set it,  but we probably should come up with a single solution and apply it everywhere than just set it here for nova. I grepped around and we don\u0027t appear to properly set this anywhere.","commit_id":"2e234e2e3510e405de2ff97754b96681bf49bcff"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ecd8b943a50e9d2db4a5cbfae7cef17192e44b6d","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    }"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    class { \u0027::nova::keystone::authtoken\u0027:"},{"line_number":49,"context_line":"      memcached_servers \u003d\u003e $memcache_servers"},{"line_number":50,"context_line":"    }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    class { \u0027::nova::api\u0027:"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"fa6399be_96688423","line":49,"in_reply_to":"fa6399be_8e0956e0","updated":"2016-10-18 22:04:29.000000000","message":"by the way I created Bug 1634646 around my previous comment. Since this bug is a regression, we can fix it now and provide a better solution later in Ocata","commit_id":"2e234e2e3510e405de2ff97754b96681bf49bcff"}]}