)]}'
{"manifests/glance/nfs_mount.pp":[{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"8c038954bf2acd5f9b383ec2ce6b8afed1658dc1","unresolved":false,"context_lines":[{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"# [*options*]"},{"line_number":25,"context_line":"#   (Optional) NFS mount options. Defaults to"},{"line_number":26,"context_line":"#   \u0027context\u003dsystem_u:object_r:glance_var_lib_t:s0\u0027"},{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"# [*edit_fstab*]"},{"line_number":29,"context_line":"#   (Optional) Whether to persist the mount info to fstab."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da6895a0_29d93922","line":26,"range":{"start_line":26,"start_character":4,"end_line":26,"end_character":10},"updated":"2016-10-21 15:09:02.000000000","message":"add \"intr,\" here as well?","commit_id":"cebde4715550b8833a9c7014f1f8db7fd72f84f3"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"853b1b9d52d3e4fa70d20b2be6bbb8104942ace8","unresolved":false,"context_lines":[{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"# [*options*]"},{"line_number":25,"context_line":"#   (Optional) NFS mount options. Defaults to"},{"line_number":26,"context_line":"#   \u0027context\u003dsystem_u:object_r:glance_var_lib_t:s0\u0027"},{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"# [*edit_fstab*]"},{"line_number":29,"context_line":"#   (Optional) Whether to persist the mount info to fstab."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da6895a0_6f041115","line":26,"range":{"start_line":26,"start_character":4,"end_line":26,"end_character":10},"in_reply_to":"da6895a0_29d93922","updated":"2016-10-21 15:43:34.000000000","message":"Thanks","commit_id":"cebde4715550b8833a9c7014f1f8db7fd72f84f3"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"8c038954bf2acd5f9b383ec2ce6b8afed1658dc1","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  $fstab_prepend_options \u003d \u0027bg\u0027"},{"line_number":47,"context_line":") {"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  $images_dir \u003d \u0027/var/lib/glance/images\u0027"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  if $options and $options !\u003d \u0027\u0027 {"},{"line_number":52,"context_line":"    $options_part \u003d \"-o ${options}\""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da6895a0_294779bc","line":49,"updated":"2016-10-21 15:09:02.000000000","message":"is this worth making a parameter with the default set to /var/lib/glance/images? If glance can never point to any other path, then it is probably not worth pursuing","commit_id":"cebde4715550b8833a9c7014f1f8db7fd72f84f3"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"853b1b9d52d3e4fa70d20b2be6bbb8104942ace8","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  $fstab_prepend_options \u003d \u0027bg\u0027"},{"line_number":47,"context_line":") {"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  $images_dir \u003d \u0027/var/lib/glance/images\u0027"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  if $options and $options !\u003d \u0027\u0027 {"},{"line_number":52,"context_line":"    $options_part \u003d \"-o ${options}\""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da6895a0_0f3555d9","line":49,"in_reply_to":"da6895a0_294779bc","updated":"2016-10-21 15:43:34.000000000","message":"I\u0027m not aware of any use case with storing them elsewhere (also selinux plays a role in that, IIRC). I could perhaps turn this into a param if i have to do a change that will require me to retest this patch, but i also think it\u0027s probably not worth pursuing.","commit_id":"cebde4715550b8833a9c7014f1f8db7fd72f84f3"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"8fed6c7aa765369523907d35f6303103f2e2caca","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  file { $images_dir:"},{"line_number":64,"context_line":"    ensure \u003d\u003e directory,"},{"line_number":65,"context_line":"  } -\u003e"},{"line_number":66,"context_line":"  exec { \u0027NFS mount for glance file backend\u0027:"},{"line_number":67,"context_line":"    path    \u003d\u003e [\u0027/usr/sbin\u0027, \u0027/usr/bin\u0027],"},{"line_number":68,"context_line":"    command \u003d\u003e \"mount -t nfs \u0027${share}\u0027 \u0027${images_dir}\u0027 ${options_part}\","},{"line_number":69,"context_line":"    unless  \u003d\u003e \"mount | grep \u0027 ${images_dir} \u0027\","}],"source_content_type":"text/x-puppet","patch_set":3,"id":"da6895a0_e3467422","line":66,"updated":"2016-10-21 22:25:07.000000000","message":"Is there a reason to not use the mount resource type for this?\nhttps://docs.puppet.com/puppet/latest/reference/types/mount.html","commit_id":"ad4e331917a2da9f2fd8215369736896348244fd"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"7b99aa2074364f7f7cd5b62c0257b5475604be92","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  file { $images_dir:"},{"line_number":64,"context_line":"    ensure \u003d\u003e directory,"},{"line_number":65,"context_line":"  } -\u003e"},{"line_number":66,"context_line":"  exec { \u0027NFS mount for glance file backend\u0027:"},{"line_number":67,"context_line":"    path    \u003d\u003e [\u0027/usr/sbin\u0027, \u0027/usr/bin\u0027],"},{"line_number":68,"context_line":"    command \u003d\u003e \"mount -t nfs \u0027${share}\u0027 \u0027${images_dir}\u0027 ${options_part}\","},{"line_number":69,"context_line":"    unless  \u003d\u003e \"mount | grep \u0027 ${images_dir} \u0027\","}],"source_content_type":"text/x-puppet","patch_set":3,"id":"da6895a0_ffca4e6d","line":66,"in_reply_to":"da6895a0_e3467422","updated":"2016-10-25 14:49:00.000000000","message":"Ah i didn\u0027t know this existed, thanks. I\u0027ll try it and update the patch.","commit_id":"ad4e331917a2da9f2fd8215369736896348244fd"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"38279c1719f944e675c55ff1228f2701832d1905","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  file { $images_dir:"},{"line_number":64,"context_line":"    ensure \u003d\u003e directory,"},{"line_number":65,"context_line":"  } -\u003e"},{"line_number":66,"context_line":"  exec { \u0027NFS mount for glance file backend\u0027:"},{"line_number":67,"context_line":"    path    \u003d\u003e [\u0027/usr/sbin\u0027, \u0027/usr/bin\u0027],"},{"line_number":68,"context_line":"    command \u003d\u003e \"mount -t nfs \u0027${share}\u0027 \u0027${images_dir}\u0027 ${options_part}\","},{"line_number":69,"context_line":"    unless  \u003d\u003e \"mount | grep \u0027 ${images_dir} \u0027\","}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba5da102_0031b10b","line":66,"in_reply_to":"da6895a0_ffca4e6d","updated":"2016-10-27 08:52:50.000000000","message":"Hmm the mount resource cannot mount the share without writing it to fstab first, and apparently it has broken idempotency -- it writes the entry into fstab each puppet step, even when it\u0027s already present. Perhaps the issue is due to some unwanted interaction with the file_line below, but we need to keep that -- we want the bg option only in fstab, not on initial mount. (Don\u0027t block the machine boot if the share cannot be mounted, but do block the initial mount on deployment, so that we don\u0027t silently ignore the error.)\n\nI gave it a few tries but don\u0027t think there\u0027s a reasonable way to make the mount resource work in this case and still keep all the functionality we want here. I think we should go with the current state.","commit_id":"ad4e331917a2da9f2fd8215369736896348244fd"}]}
