)]}'
{"manifests/profile/pacemaker/database/redis.pp":[{"author":{"_account_id":12715,"name":"John Trowbridge","email":"trown@redhat.com","username":"trown"},"change_message_id":"42b4f8b7b6eb45503e61aa5725895ad33523a4a8","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    # Until puppet-redis grows support for /etc/security/limits.conf/redis.conf"},{"line_number":54,"context_line":"    # we best explicitely set the file limit only in the pacemaker profile"},{"line_number":55,"context_line":"    # (the base profile does not need it as it is using systemd which has"},{"line_number":56,"context_line":"    # the limits set there)"},{"line_number":57,"context_line":"    file { \u0027/etc/security/limits.d/redis.conf\u0027:"},{"line_number":58,"context_line":"      content \u003d\u003e inline_template(\"redis soft nofile \u003c%\u003d @redis_file_limit %\u003e\\nredis hard nofile \u003c%\u003d @redis_file_limit %\u003e\\n\"),"},{"line_number":59,"context_line":"      owner   \u003d\u003e \u00270\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"da6895a0_75778dd4","line":56,"updated":"2016-10-21 12:56:50.000000000","message":"could we reference the puppet-redis bug for this here?","commit_id":"84c343df558a6f2eabca73a965c42eb25f24c290"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"5df10c95a95fdf1408322019d0c88c9fb6f4339d","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    # Until puppet-redis grows support for /etc/security/limits.conf/redis.conf"},{"line_number":54,"context_line":"    # we best explicitely set the file limit only in the pacemaker profile"},{"line_number":55,"context_line":"    # (the base profile does not need it as it is using systemd which has"},{"line_number":56,"context_line":"    # the limits set there)"},{"line_number":57,"context_line":"    file { \u0027/etc/security/limits.d/redis.conf\u0027:"},{"line_number":58,"context_line":"      content \u003d\u003e inline_template(\"redis soft nofile \u003c%\u003d @redis_file_limit %\u003e\\nredis hard nofile \u003c%\u003d @redis_file_limit %\u003e\\n\"),"},{"line_number":59,"context_line":"      owner   \u003d\u003e \u00270\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"da6895a0_c95cf8ef","line":56,"in_reply_to":"da6895a0_75778dd4","updated":"2016-10-25 13:45:50.000000000","message":"Ack sounds reasonable, will do","commit_id":"84c343df558a6f2eabca73a965c42eb25f24c290"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"d5965ce191122b258d6218391cfd2280af141afc","unresolved":false,"context_lines":[{"line_number":58,"context_line":"      content \u003d\u003e inline_template(\"redis soft nofile \u003c%\u003d @redis_file_limit %\u003e\\nredis hard nofile \u003c%\u003d @redis_file_limit %\u003e\\n\"),"},{"line_number":59,"context_line":"      owner   \u003d\u003e \u00270\u0027,"},{"line_number":60,"context_line":"      group   \u003d\u003e \u00270\u0027,"},{"line_number":61,"context_line":"      mode    \u003d\u003e \u00270644\u0027,"},{"line_number":62,"context_line":"    }"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    if $pacemaker_master and hiera(\u0027stack_action\u0027) \u003d\u003d \u0027UPDATE\u0027 {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"da6895a0_c62a272c","line":61,"updated":"2016-10-25 13:14:53.000000000","message":"I would like to see a \"notify\" on the Redis service so we make sure any change in this file with restart Redis (I guess we need it?) At least making sure we manage this file before starting Redis would be safer.","commit_id":"84c343df558a6f2eabca73a965c42eb25f24c290"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"5df10c95a95fdf1408322019d0c88c9fb6f4339d","unresolved":false,"context_lines":[{"line_number":58,"context_line":"      content \u003d\u003e inline_template(\"redis soft nofile \u003c%\u003d @redis_file_limit %\u003e\\nredis hard nofile \u003c%\u003d @redis_file_limit %\u003e\\n\"),"},{"line_number":59,"context_line":"      owner   \u003d\u003e \u00270\u0027,"},{"line_number":60,"context_line":"      group   \u003d\u003e \u00270\u0027,"},{"line_number":61,"context_line":"      mode    \u003d\u003e \u00270644\u0027,"},{"line_number":62,"context_line":"    }"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    if $pacemaker_master and hiera(\u0027stack_action\u0027) \u003d\u003d \u0027UPDATE\u0027 {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"da6895a0_89d76022","line":61,"in_reply_to":"da6895a0_c62a272c","updated":"2016-10-25 13:45:50.000000000","message":"We do make sure we have this file due to step ordering. I am not sure how we would do the notify thing since it is managed by pacemaker. I.e. if I add a subscribe \u003d\u003e File[\u0027/etc/security/limits.d/redis.conf\u0027] it still would not work on any non bootstrap nodes no?","commit_id":"84c343df558a6f2eabca73a965c42eb25f24c290"}]}