)]}'
{"manifests/profile/base/haproxy.pp":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"cf18c945188f0ffb16dfe345d29a2a3db1db2fb7","unresolved":false,"context_lines":[{"line_number":95,"context_line":"          command     \u003d\u003e \u0027systemctl reload haproxy\u0027,"},{"line_number":96,"context_line":"          path        \u003d\u003e [\u0027/usr/bin\u0027, \u0027/usr/sbin\u0027],"},{"line_number":97,"context_line":"          refreshonly \u003d\u003e true,"},{"line_number":98,"context_line":"          onlyif      \u003d\u003e \u0027systemctl is-active haproxy | grep -q active\u0027,"},{"line_number":99,"context_line":"          subscribe   \u003d\u003e Class[\u0027::haproxy\u0027]"},{"line_number":100,"context_line":"        }"},{"line_number":101,"context_line":"        Haproxy::Listen\u003c||\u003e ~\u003e Exec[\u0027haproxy-reload\u0027]"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba5da102_c89b22c8","line":98,"range":{"start_line":98,"start_character":26,"end_line":98,"end_character":53},"updated":"2016-10-31 10:04:33.000000000","message":"just wondering if we want to combine what we had before with this ^^^? haproxy is still pcmk managed if I recall correctly\n\nbut after having just also read the bug and commit message closer... looks like that conditional fails here so the whole point was to change that (i.e. it wasn\u0027t reloaded because the cluster wasn\u0027t in maintenance mode\n\nThe thing we wanted to avoid was making changes to the CIB (like new/update resource or constraint definitions) unless we were in maintenance mode. I hope the haproxy reload here (almost every time, whenever this gets run and haproxy is-active) won\u0027t cause problems (thinking about upgrades here)... wonder if marius has tested this in that scenario too?","commit_id":"c01acb0c4930ecbef7de1ed876afa6120fe2ee35"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"896260cbbc9436d63a69836259415f09dfab21a9","unresolved":false,"context_lines":[{"line_number":95,"context_line":"          command     \u003d\u003e \u0027systemctl reload haproxy\u0027,"},{"line_number":96,"context_line":"          path        \u003d\u003e [\u0027/usr/bin\u0027, \u0027/usr/sbin\u0027],"},{"line_number":97,"context_line":"          refreshonly \u003d\u003e true,"},{"line_number":98,"context_line":"          onlyif      \u003d\u003e \u0027systemctl is-active haproxy | grep -q active\u0027,"},{"line_number":99,"context_line":"          subscribe   \u003d\u003e Class[\u0027::haproxy\u0027]"},{"line_number":100,"context_line":"        }"},{"line_number":101,"context_line":"        Haproxy::Listen\u003c||\u003e ~\u003e Exec[\u0027haproxy-reload\u0027]"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba5da102_e31ba77e","line":98,"range":{"start_line":98,"start_character":26,"end_line":98,"end_character":53},"in_reply_to":"ba5da102_c89b22c8","updated":"2016-10-31 11:14:59.000000000","message":"overall though it looks sane to me to remove pcs references from the non-pcmk profile\n\nalso afaik \u0027reload\u0027 should not stop/start the service so this should be safe to do even when pcmk is not in maintenance mode","commit_id":"c01acb0c4930ecbef7de1ed876afa6120fe2ee35"}]}
