)]}'
{"manifests/haproxy.pp":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"e9d2a661c9d9f0e2a6329dbc95d9bccaacff97b0","unresolved":false,"context_lines":[{"line_number":1094,"context_line":"      \u0027stick-table\u0027    \u003d\u003e \u0027type ip size 1000\u0027,"},{"line_number":1095,"context_line":"      \u0027stick\u0027          \u003d\u003e \u0027on dst\u0027,"},{"line_number":1096,"context_line":"    }"},{"line_number":1097,"context_line":"    $mysql_member_options \u003d [\u0027backup\u0027, \u0027port 9200\u0027, \u0027on-marked-down shutdown-sessions\u0027, \u0027check\u0027, \u0027inter 1s\u0027]"},{"line_number":1098,"context_line":"  } else {"},{"line_number":1099,"context_line":"    $mysql_listen_options \u003d {"},{"line_number":1100,"context_line":"      \u0027timeout client\u0027 \u003d\u003e \u002790m\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a629dbe_9aa6f3bf","line":1097,"updated":"2016-11-08 09:55:09.000000000","message":"if mysql needs a different check interval, we should make that configurable through a class parameter. Can make it so? Also, this removes the rise and fall parameters from the mysql frontend, is this intended?","commit_id":"e4aeab5929c5cd628bb4496f620d0bbbad8c4862"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"05affa88f95b00a89246bb61a82f21ce031a3c77","unresolved":false,"context_lines":[{"line_number":1094,"context_line":"      \u0027stick-table\u0027    \u003d\u003e \u0027type ip size 1000\u0027,"},{"line_number":1095,"context_line":"      \u0027stick\u0027          \u003d\u003e \u0027on dst\u0027,"},{"line_number":1096,"context_line":"    }"},{"line_number":1097,"context_line":"    $mysql_member_options \u003d [\u0027backup\u0027, \u0027port 9200\u0027, \u0027on-marked-down shutdown-sessions\u0027, \u0027check\u0027, \u0027inter 1s\u0027]"},{"line_number":1098,"context_line":"  } else {"},{"line_number":1099,"context_line":"    $mysql_listen_options \u003d {"},{"line_number":1100,"context_line":"      \u0027timeout client\u0027 \u003d\u003e \u002790m\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a629dbe_6e2b24ec","line":1097,"in_reply_to":"9a629dbe_0e7aa824","updated":"2016-11-08 10:15:37.000000000","message":"Chris, alright, it\u0027s fine then. But I would insist in adding it as a parameter. Deployers will still want to control how stuff is configured and the way it\u0027s coded at the moment doesn\u0027t allow for that.","commit_id":"e4aeab5929c5cd628bb4496f620d0bbbad8c4862"},{"author":{"_account_id":6449,"name":"Chris Jones","email":"cmsj@tenshu.net","username":"cmsj"},"change_message_id":"185e8ecba10965444c6ce4bfe0bd347752ce4329","unresolved":false,"context_lines":[{"line_number":1094,"context_line":"      \u0027stick-table\u0027    \u003d\u003e \u0027type ip size 1000\u0027,"},{"line_number":1095,"context_line":"      \u0027stick\u0027          \u003d\u003e \u0027on dst\u0027,"},{"line_number":1096,"context_line":"    }"},{"line_number":1097,"context_line":"    $mysql_member_options \u003d [\u0027backup\u0027, \u0027port 9200\u0027, \u0027on-marked-down shutdown-sessions\u0027, \u0027check\u0027, \u0027inter 1s\u0027]"},{"line_number":1098,"context_line":"  } else {"},{"line_number":1099,"context_line":"    $mysql_listen_options \u003d {"},{"line_number":1100,"context_line":"      \u0027timeout client\u0027 \u003d\u003e \u002790m\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a629dbe_0e7aa824","line":1097,"in_reply_to":"9a629dbe_9aa6f3bf","updated":"2016-11-08 10:12:22.000000000","message":"Removing the rise and fall parameters is very much intended. The purpose of this patch is to get a failed mysql node out of rotation as quickly as possible, to prevent the OpenStack services connected to that node, from returning API errors because their database connection is broken. The current defaults of \"inter 2000\" \"fall 5\" mean a failed mysql node remains in rotation for 10 seconds, which has caused confusion and delay for real world operators (see the bugzillas linked in https://bugs.launchpad.net/tripleo/+bug/1639189 )\n\nI could make $mysql_member_options a class parameter, but it would be for the whole set of options, not just the check interval, and I would still propose that the defaults (when $mysql_clustercheck is true) be the values I have proposed here.\nI\u0027m not strictly opposed to making it a parameter, but is it necessary?","commit_id":"e4aeab5929c5cd628bb4496f620d0bbbad8c4862"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"76aab608fe9fa32e9028fb0e96abfc1e48ed5a38","unresolved":false,"context_lines":[{"line_number":494,"context_line":"  $ironic_inspector            \u003d hiera(\u0027ironic_inspector_enabled\u0027, false),"},{"line_number":495,"context_line":"  $mysql                       \u003d hiera(\u0027mysql_enabled\u0027, false),"},{"line_number":496,"context_line":"  $mysql_clustercheck          \u003d false,"},{"line_number":497,"context_line":"  $mysql_member_options        \u003d undef,"},{"line_number":498,"context_line":"  $rabbitmq                    \u003d false,"},{"line_number":499,"context_line":"  $docker_registry             \u003d hiera(\u0027enable_docker_registry\u0027, false),"},{"line_number":500,"context_line":"  $redis                       \u003d hiera(\u0027redis_enabled\u0027, false),"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9a629dbe_c4edf18c","line":497,"updated":"2016-11-08 11:01:41.000000000","message":"why not default to [\u0027backup\u0027, \u0027port 9200\u0027, \u0027on-marked-down shutdown-sessions\u0027, \u0027check\u0027, \u0027inter 1s\u0027]","commit_id":"943e49435621062a1c898de4b2edccf48c59fc16"},{"author":{"_account_id":6449,"name":"Chris Jones","email":"cmsj@tenshu.net","username":"cmsj"},"change_message_id":"0f953c60241074c3c961539de1749dd60c7e3b0b","unresolved":false,"context_lines":[{"line_number":494,"context_line":"  $ironic_inspector            \u003d hiera(\u0027ironic_inspector_enabled\u0027, false),"},{"line_number":495,"context_line":"  $mysql                       \u003d hiera(\u0027mysql_enabled\u0027, false),"},{"line_number":496,"context_line":"  $mysql_clustercheck          \u003d false,"},{"line_number":497,"context_line":"  $mysql_member_options        \u003d undef,"},{"line_number":498,"context_line":"  $rabbitmq                    \u003d false,"},{"line_number":499,"context_line":"  $docker_registry             \u003d hiera(\u0027enable_docker_registry\u0027, false),"},{"line_number":500,"context_line":"  $redis                       \u003d hiera(\u0027redis_enabled\u0027, false),"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9a629dbe_87369b01","line":497,"in_reply_to":"9a629dbe_c4edf18c","updated":"2016-11-08 11:21:44.000000000","message":"So, my reading of this class is that where $mysql_clustercheck is set to false, there are no on-marked-down actions because the operator has said they don\u0027t want mysql being supervised, so I could change the interval of the check, but my thinking was that since no action is going to be taken, it matters much less in this case, and I would just leave those defaults unchanged.","commit_id":"943e49435621062a1c898de4b2edccf48c59fc16"}]}
