)]}'
{"manifests/haproxy.pp":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"9bec1ccd37f574a0e1a1e414b77dc236f3e8a228","unresolved":false,"context_lines":[{"line_number":596,"context_line":"    $controller_hosts_names_real \u003d downcase(any2array(split($controller_hosts_names, \u0027,\u0027)))"},{"line_number":597,"context_line":"  }"},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"  # This code will be removed once we switch undercloud and overcloud to use both haproxy \u0026 keepalived roles."},{"line_number":600,"context_line":"  if $keepalived {"},{"line_number":601,"context_line":"    include ::tripleo::keepalived"},{"line_number":602,"context_line":"    # Make sure keepalive starts before haproxy."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a629dbe_924c0544","line":599,"updated":"2016-11-08 16:33:24.000000000","message":"I\u0027m curious if this is going to be a problem, but I don\u0027t remember the context of this comment enough to say for sure.  In any case, it looks like this is a reasonable change based on the existing state of the manifest.  Hopefully if this block gets removed the dependency will get moved to an appropriate new location.","commit_id":"1fada1db400fe886777d337833ff2198c7c72ced"}],"manifests/keepalived.pp":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"0015e3f5d299005edc958f84e04c32ddaab62b2d","unresolved":false,"context_lines":[{"line_number":160,"context_line":"  }"},{"line_number":161,"context_line":"  # Make sure keepalive starts before haproxy."},{"line_number":162,"context_line":"  if (defined(Class[\u0027::tripleo::haproxy\u0027])) {"},{"line_number":163,"context_line":"    Class[\u0027::keepalived::service\u0027] -\u003e Class[\u0027::tripleo::haproxy\u0027]"},{"line_number":164,"context_line":"  }"},{"line_number":165,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9a629dbe_0e6b881f","line":163,"updated":"2016-11-08 10:19:11.000000000","message":"I\u0027m not opposed to this, but why is this needed? Wasn\u0027t the dependency to the haproxy class sufficient?","commit_id":"36753ff9189126db5f65c2ec1adeaf4a6e72ced7"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"f4b3f114fe25ce0c228a56032cfd2601af453b9a","unresolved":false,"context_lines":[{"line_number":160,"context_line":"  }"},{"line_number":161,"context_line":"  # Make sure keepalive starts before haproxy."},{"line_number":162,"context_line":"  if (defined(Class[\u0027::tripleo::haproxy\u0027])) {"},{"line_number":163,"context_line":"    Class[\u0027::keepalived::service\u0027] -\u003e Class[\u0027::tripleo::haproxy\u0027]"},{"line_number":164,"context_line":"  }"},{"line_number":165,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9a629dbe_d173f1af","line":163,"in_reply_to":"9a629dbe_0e0aa826","updated":"2016-11-08 10:27:44.000000000","message":"well, if making this use the tripleo::haproxy resource makes it work, I\u0027m fine with this, backporting is a bit problematic now, but squashing the two commits that touched this code should be alright.","commit_id":"36753ff9189126db5f65c2ec1adeaf4a6e72ced7"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f4564a824f006fa34d5a6e9067854b8a5e4d7310","unresolved":false,"context_lines":[{"line_number":160,"context_line":"  }"},{"line_number":161,"context_line":"  # Make sure keepalive starts before haproxy."},{"line_number":162,"context_line":"  if (defined(Class[\u0027::tripleo::haproxy\u0027])) {"},{"line_number":163,"context_line":"    Class[\u0027::keepalived::service\u0027] -\u003e Class[\u0027::tripleo::haproxy\u0027]"},{"line_number":164,"context_line":"  }"},{"line_number":165,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9a629dbe_0e0aa826","line":163,"in_reply_to":"9a629dbe_0e6b881f","updated":"2016-11-08 10:26:01.000000000","message":"thanks for looking and irc chat jaosorior as you pointed out on irc \n\n12:17 #tripleo: \u003c jaosorior\u003e chem, marios https://github.com/openstack/puppet-tripleo/blob/master/manifests/haproxy.pp#L672\n\n\nchem do you have traces on the error you got (maybe it would be best to add a note at https://bugzilla.redhat.com/show_bug.cgi?id\u003d1388283#c23 with that info and point from here but w/e)","commit_id":"36753ff9189126db5f65c2ec1adeaf4a6e72ced7"}]}
