)]}'
{"manifests/profile/base/ceph/rgw.pp":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"fb51e542dc651d2b5ff13d5fb4f2efb7084e2703","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  if $step \u003e\u003d 3 {"},{"line_number":53,"context_line":"    $rgw_name \u003d hiera(\u0027ceph::profile::params::rgw_name\u0027, \u0027radosgw.gateway\u0027)"},{"line_number":54,"context_line":"    $civetweb_bind_ip_real \u003d enclose_ipv6($civetweb_bind_ip)"},{"line_number":55,"context_line":"    ceph::rgw { $rgw_name:"},{"line_number":56,"context_line":"      frontend_type \u003d\u003e \u0027civetweb\u0027,"},{"line_number":57,"context_line":"      rgw_frontends \u003d\u003e \"civetweb port\u003d${civetweb_bin_ip_real}:${civetweb_bind_port}\""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a629dbe_9fa84edd","line":54,"range":{"start_line":54,"start_character":29,"end_line":54,"end_character":41},"updated":"2016-11-09 20:13:44.000000000","message":"What is the difference between this and bracket_me_maybe ^W normalize_ip_for_uri?  AFAIK we use that everywhere else we\u0027re doing something similar.","commit_id":"39cb5c9e2c77ee3da3634d50c0adaac995304d84"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"0a51a74e1b6955c40c1147d9ddb4fcf2c0aa1de1","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  if $step \u003e\u003d 3 {"},{"line_number":53,"context_line":"    $rgw_name \u003d hiera(\u0027ceph::profile::params::rgw_name\u0027, \u0027radosgw.gateway\u0027)"},{"line_number":54,"context_line":"    $civetweb_bind_ip_real \u003d enclose_ipv6($civetweb_bind_ip)"},{"line_number":55,"context_line":"    ceph::rgw { $rgw_name:"},{"line_number":56,"context_line":"      frontend_type \u003d\u003e \u0027civetweb\u0027,"},{"line_number":57,"context_line":"      rgw_frontends \u003d\u003e \"civetweb port\u003d${civetweb_bin_ip_real}:${civetweb_bind_port}\""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a629dbe_e9418564","line":54,"range":{"start_line":54,"start_character":29,"end_line":54,"end_character":41},"in_reply_to":"9a629dbe_9fa84edd","updated":"2016-11-10 09:31:59.000000000","message":"enclose_ipv6 depends on stdlib instead of puppet-openstack, but I guess it doesn\u0027t make any difference for puppet-tripleo, will update","commit_id":"39cb5c9e2c77ee3da3634d50c0adaac995304d84"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"ab477b29bc7666e7220f9f84cbed218ccf6d3f59","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  if $step \u003e\u003d 3 {"},{"line_number":53,"context_line":"    $rgw_name \u003d hiera(\u0027ceph::profile::params::rgw_name\u0027, \u0027radosgw.gateway\u0027)"},{"line_number":54,"context_line":"    $civetweb_bind_ip_real \u003d enclose_ipv6($civetweb_bind_ip)"},{"line_number":55,"context_line":"    ceph::rgw { $rgw_name:"},{"line_number":56,"context_line":"      frontend_type \u003d\u003e \u0027civetweb\u0027,"},{"line_number":57,"context_line":"      rgw_frontends \u003d\u003e \"civetweb port\u003d${civetweb_bin_ip_real}:${civetweb_bind_port}\""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a629dbe_e80a4489","line":54,"range":{"start_line":54,"start_character":29,"end_line":54,"end_character":41},"in_reply_to":"9a629dbe_e9418564","updated":"2016-11-10 17:41:17.000000000","message":"Okay.  Makes me wonder why we wrote our own then. :-/","commit_id":"39cb5c9e2c77ee3da3634d50c0adaac995304d84"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"cdce66b3ffc420124303ceae35d6c9d385204554","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  include ::tripleo::profile::base::ceph"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  if $step \u003e\u003d 3 {"},{"line_number":45,"context_line":"    include ::ceph::profile::rgw"},{"line_number":46,"context_line":"    $rgw_name \u003d hiera(\u0027ceph::profile::params::rgw_name\u0027, \u0027radosgw.gateway\u0027)"},{"line_number":47,"context_line":"    ceph::key { \"client.${rgw_name}\":"},{"line_number":48,"context_line":"      secret  \u003d\u003e $rgw_key,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"9a629dbe_94a1be96","side":"PARENT","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":32},"updated":"2016-11-11 15:11:43.000000000","message":"So this included ::ceph::profile::base which gets lost if when you removed this. You\u0027ll need to also include ::ceph::profile::base in the new code so you don\u0027t lose the ceph configuration.","commit_id":"f5a20ed5911324311b02773dde8a917eb82ddc0c"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"7c9289e7c2af88dddd0009c30b8a61ed49b4d09b","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  include ::tripleo::profile::base::ceph"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  if $step \u003e\u003d 3 {"},{"line_number":45,"context_line":"    include ::ceph::profile::rgw"},{"line_number":46,"context_line":"    $rgw_name \u003d hiera(\u0027ceph::profile::params::rgw_name\u0027, \u0027radosgw.gateway\u0027)"},{"line_number":47,"context_line":"    ceph::key { \"client.${rgw_name}\":"},{"line_number":48,"context_line":"      secret  \u003d\u003e $rgw_key,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"9a629dbe_543d66db","side":"PARENT","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":32},"in_reply_to":"9a629dbe_94a1be96","updated":"2016-11-11 15:22:20.000000000","message":"ack, thanks!","commit_id":"f5a20ed5911324311b02773dde8a917eb82ddc0c"}]}
