)]}'
{"manifests/haproxy.pp":[{"author":{"_account_id":12715,"name":"John Trowbridge","email":"trown@redhat.com","username":"trown"},"change_message_id":"adf2ec7526b8b3080de07ff63b044d062ff78ccf","unresolved":false,"context_lines":[{"line_number":449,"context_line":"class tripleo::haproxy ("},{"line_number":450,"context_line":"  $controller_virtual_ip,"},{"line_number":451,"context_line":"  $public_virtual_ip,"},{"line_number":452,"context_line":"  $keepalived                  \u003d hiera(\u0027keepalived_enabled\u0027, false),"},{"line_number":453,"context_line":"  $haproxy_service_manage      \u003d true,"},{"line_number":454,"context_line":"  $haproxy_global_maxconn      \u003d 20480,"},{"line_number":455,"context_line":"  $haproxy_default_maxconn     \u003d 4096,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a77a97e_b437d9fd","line":452,"updated":"2016-11-17 17:45:52.000000000","message":"shouldn\u0027t we keep default to true here?","commit_id":"92f9c952d6cbb0c11c8457de0e49748f3adf667e"},{"author":{"_account_id":12715,"name":"John Trowbridge","email":"trown@redhat.com","username":"trown"},"change_message_id":"cb410a5804cf3e7fbe7cdfeff0936092f83a38f9","unresolved":false,"context_lines":[{"line_number":449,"context_line":"class tripleo::haproxy ("},{"line_number":450,"context_line":"  $controller_virtual_ip,"},{"line_number":451,"context_line":"  $public_virtual_ip,"},{"line_number":452,"context_line":"  $keepalived                  \u003d hiera(\u0027keepalived_enabled\u0027, false),"},{"line_number":453,"context_line":"  $haproxy_service_manage      \u003d true,"},{"line_number":454,"context_line":"  $haproxy_global_maxconn      \u003d 20480,"},{"line_number":455,"context_line":"  $haproxy_default_maxconn     \u003d 4096,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a77a97e_45886671","line":452,"in_reply_to":"7a77a97e_2820aff6","updated":"2016-11-18 13:53:25.000000000","message":"ok, that makes sense. thanks","commit_id":"92f9c952d6cbb0c11c8457de0e49748f3adf667e"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"dc2b9104444ab67552a74159896a1087209b90f8","unresolved":false,"context_lines":[{"line_number":449,"context_line":"class tripleo::haproxy ("},{"line_number":450,"context_line":"  $controller_virtual_ip,"},{"line_number":451,"context_line":"  $public_virtual_ip,"},{"line_number":452,"context_line":"  $keepalived                  \u003d hiera(\u0027keepalived_enabled\u0027, false),"},{"line_number":453,"context_line":"  $haproxy_service_manage      \u003d true,"},{"line_number":454,"context_line":"  $haproxy_global_maxconn      \u003d 20480,"},{"line_number":455,"context_line":"  $haproxy_default_maxconn     \u003d 4096,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a77a97e_2820aff6","line":452,"in_reply_to":"7a77a97e_b437d9fd","updated":"2016-11-18 09:26:39.000000000","message":"No, because otherwise when keepalived is disabled, hiera will still return true, instead of false when keepalived_enabled is undefined (it ends up undef when the composable service is disabled, but will always be \"true\" when it\u0027s enabled.","commit_id":"92f9c952d6cbb0c11c8457de0e49748f3adf667e"}]}