)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"af274ced369a59725e33d0e0542841dbcb43fe65","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Also there is no need to have a Cassandra and Zookeeper dedicated"},{"line_number":13,"context_line":"classes, as we leverage this through the use of the midonet_openstack"},{"line_number":14,"context_line":"puppet module."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I2f17aeeac2d1b121be0d445ff555320d5af5d270"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a71b18c_1171d4e0","line":15,"updated":"2016-12-02 12:56:27.000000000","message":"Depends-On: I0eb25afbd084ce3cafa055cd42a500439ce21953 \n\n?? i.e. only remove these modules once we know they are no longer being used, i.e. when the templates which were using them go away and the new ones are added for the new modules.","commit_id":"2ea79efb816b269b65cd36e20e4a1577ea6904ae"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"743835eb1f2750d54127dd5c478050e870f51181","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Delete MidoNet deprecated classes and their tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"MidoNet no longer uses the API component. It has been renamed to"},{"line_number":10,"context_line":"\"cluster\" as it can be seen on the docs at docs.midonet.org."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Also there is no need to have a Cassandra and Zookeeper dedicated"},{"line_number":13,"context_line":"classes, as we leverage this through the use of the midonet_openstack"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a71b18c_1f68c486","line":10,"updated":"2016-12-05 09:02:34.000000000","message":"would be nice if you pointed at something more specific here :) like something explaining the rename, or some doc that references \u0027cluster\u0027 or whatever, just saying, no pushback on this","commit_id":"a06aaa9d8eb56f9ae93f4d646c8aa0e05b8c2548"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"743835eb1f2750d54127dd5c478050e870f51181","unresolved":false,"context_lines":[{"line_number":14,"context_line":"puppet module."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I2f17aeeac2d1b121be0d445ff555320d5af5d270"},{"line_number":17,"context_line":"Depends-On: I0eb25afbd084ce3cafa055cd42a500439ce21953"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a71b18c_3f0740cb","line":17,"updated":"2016-12-05 09:02:34.000000000","message":"thanks","commit_id":"a06aaa9d8eb56f9ae93f4d646c8aa0e05b8c2548"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2011daed2cc003875393599fe47602be83c8835e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"puppet module."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I2f17aeeac2d1b121be0d445ff555320d5af5d270"},{"line_number":18,"context_line":"Partial-Bug: #1647302"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3a71b18c_c2bb65c2","line":18,"range":{"start_line":18,"start_character":14,"end_line":18,"end_character":21},"updated":"2016-12-07 10:18:10.000000000","message":"thanks for the bug but did you mean to remove the depends on I0eb25afbd084ce3cafa055cd42a500439ce21953 makes sense to keep it imo anyway","commit_id":"6b081ab4d1f3eebfded2fee8aa5fafec06c34b4e"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2be7cbd69e337566a1c65a17319720caf6aa5876","unresolved":false,"context_lines":[{"line_number":15,"context_line":"puppet module."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I2f17aeeac2d1b121be0d445ff555320d5af5d270"},{"line_number":18,"context_line":"Partial-Bug: #1647302"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3a71b18c_da1ee55e","line":18,"range":{"start_line":18,"start_character":14,"end_line":18,"end_character":21},"in_reply_to":"3a71b18c_ae1d7274","updated":"2016-12-07 12:34:55.000000000","message":"hey, thanks for looking. I\u0027m removing my -1 while I understand more. Why is there a circular dependency? This can depend on the THT @ https://review.openstack.org/#/c/396692/  and that in turn depends on the puppet-tripleo changes. \n\n[EDIT]: OK, so I checked the first of those puppet-tripleo depends on and it looks like you have this in the shortlog ... for example the midonet agent one has this in dependency via git https://review.openstack.org/gitweb?p\u003dopenstack/puppet-tripleo.git;a\u003dshortlog;h\u003d0085fc99f03982b0df6ac14a4f72c62166b1efa4","commit_id":"6b081ab4d1f3eebfded2fee8aa5fafec06c34b4e"},{"author":{"_account_id":22064,"name":"Alejandro Andreu","email":"alejandroandreu@openmailbox.org","username":"alejandro"},"change_message_id":"7c8bbb06e4836cb207ad39daa23cb32542aee4de","unresolved":false,"context_lines":[{"line_number":15,"context_line":"puppet module."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I2f17aeeac2d1b121be0d445ff555320d5af5d270"},{"line_number":18,"context_line":"Partial-Bug: #1647302"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3a71b18c_ae1d7274","line":18,"range":{"start_line":18,"start_character":14,"end_line":18,"end_character":21},"in_reply_to":"3a71b18c_c2bb65c2","updated":"2016-12-07 11:51:07.000000000","message":"Yeah I meant to remove the Depends-On, as if it stayed we would run into a circular dependency cycle. I did set the Depends-On as a homemade \"Close-Bug\", but now I set it properly on https://review.openstack.org/#/c/396692/","commit_id":"6b081ab4d1f3eebfded2fee8aa5fafec06c34b4e"}]}