)]}'
{"manifests/pacemaker/remote_create.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0f2d16e0d58fa8c8349349fdba8133b12ae7b0b8","unresolved":false,"context_lines":[{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"define tripleo::pacemaker::remote_create($node_names, $node_ips,"},{"line_number":44,"context_line":"  $reconnect_interval\u003d60, $monitor_interval\u003d20, $tries\u003d1, $try_sleep\u003d60) {"},{"line_number":45,"context_line":"  # Creates a { \"node\" \u003d\u003e \"ip_address\", ...} hash"},{"line_number":46,"context_line":"  $remotes_hash \u003d hash(zip($node_names, $node_ips))"},{"line_number":47,"context_line":"  $cmd \u003d sprintf(\u0027/usr/sbin/pcs resource create %s remote server\u003d%s reconnect_interval\u003d%s op monitor interval\u003d%s\u0027,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"1a6eadb0_140312b9","line":44,"updated":"2016-12-15 23:55:16.000000000","message":"Please fix formatting of the parameters","commit_id":"e4e83ce4f1d2afc2035e845e4abcf73efcf9ee82"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"b7ac9755fb7a829a135a599432415b0a7ee671e4","unresolved":false,"context_lines":[{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"define tripleo::pacemaker::remote_create($node_names, $node_ips,"},{"line_number":44,"context_line":"  $reconnect_interval\u003d60, $monitor_interval\u003d20, $tries\u003d1, $try_sleep\u003d60) {"},{"line_number":45,"context_line":"  # Creates a { \"node\" \u003d\u003e \"ip_address\", ...} hash"},{"line_number":46,"context_line":"  $remotes_hash \u003d hash(zip($node_names, $node_ips))"},{"line_number":47,"context_line":"  $cmd \u003d sprintf(\u0027/usr/sbin/pcs resource create %s remote server\u003d%s reconnect_interval\u003d%s op monitor interval\u003d%s\u0027,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"1a6eadb0_83f1a16d","line":44,"in_reply_to":"1a6eadb0_140312b9","updated":"2016-12-16 06:48:00.000000000","message":"Ack, will do","commit_id":"e4e83ce4f1d2afc2035e845e4abcf73efcf9ee82"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"7775339dc6b4b9b98d1d94b5174efa6e06005a2e","unresolved":false,"context_lines":[{"line_number":40,"context_line":"#   The time to sleep in seconds between ‘tries’. Defaults to 60"},{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"define tripleo::pacemaker::remote_create("},{"line_number":44,"context_line":"  $node_names,"},{"line_number":45,"context_line":"  $node_ips,"},{"line_number":46,"context_line":"  $reconnect_interval \u003d 60,"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"5a3905b3_98fbcfc0","line":43,"updated":"2017-01-23 13:15:41.000000000","message":"why don\u0027t we have it in puppet-pacemaker?","commit_id":"a8fc3d47d3a39b5ded66b8b8bab595f095f43bff"}],"manifests/profile/base/pacemaker.pp":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"268b9c656a303f452995bc03198c0b1bcd213f90","unresolved":false,"context_lines":[{"line_number":62,"context_line":"  $remote_try_sleep          \u003d hiera(\u0027pacemaker_remote_try_sleep\u0027, 60),"},{"line_number":63,"context_line":") {"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  if count($remote_short_node_names) !\u003d count($remote_node_ips) {"},{"line_number":66,"context_line":"    fail(\"Count of ${remote_short_node_names} is not equal to count of ${remote_node_ips}\")"},{"line_number":67,"context_line":"  }"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":15,"id":"5a3905b3_0ef1236b","line":65,"updated":"2017-01-24 10:48:22.000000000","message":"curious if this is an actual issue and what caused it?","commit_id":"730efdb4e3febb52ef6c5c05593356fc3be193a2"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"5e31c489bf0ffb251a2468fc72b1a8d661836557","unresolved":false,"context_lines":[{"line_number":62,"context_line":"  $remote_try_sleep          \u003d hiera(\u0027pacemaker_remote_try_sleep\u0027, 60),"},{"line_number":63,"context_line":") {"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  if count($remote_short_node_names) !\u003d count($remote_node_ips) {"},{"line_number":66,"context_line":"    fail(\"Count of ${remote_short_node_names} is not equal to count of ${remote_node_ips}\")"},{"line_number":67,"context_line":"  }"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":15,"id":"5a3905b3_9b5472ca","line":65,"in_reply_to":"5a3905b3_0ef1236b","updated":"2017-01-24 11:53:14.000000000","message":"Nope not an actual issue, just thought it be nice to fail should anything like that ever happen (it can\u0027t as things would explode in so many other different ways). See it like a very pessimistic assert ;)","commit_id":"730efdb4e3febb52ef6c5c05593356fc3be193a2"}],"manifests/profile/base/pacemaker_remote.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0f2d16e0d58fa8c8349349fdba8133b12ae7b0b8","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  $step           \u003d hiera(\u0027step\u0027),"},{"line_number":32,"context_line":"  $remote_authkey \u003d undef,"},{"line_number":33,"context_line":") {"},{"line_number":34,"context_line":"  if $remote_authkey {"},{"line_number":35,"context_line":"    # Starting with 7.3 we have a separate pacemaker-remote package"},{"line_number":36,"context_line":"    if $::operatingsystemrelease \u003d~ /7\\.[012]*$/ {"},{"line_number":37,"context_line":"      $packages \u003d [\u0027pacemaker\u0027,\u0027pcs\u0027,\u0027fence-agents-all\u0027,\u0027pacemaker-libs\u0027]"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"1a6eadb0_34fe4eae","line":34,"updated":"2016-12-15 23:55:16.000000000","message":"It\u0027s not exactly clear unless you look at the code but it seems that rather than say using something like enable_pacemaker_remote, we\u0027re using the existing of the auth key as if we should install/configure pacemaker remote. Should we also add a flag in there as well to allow people to enable/disable this functionality even if the key exists?","commit_id":"e4e83ce4f1d2afc2035e845e4abcf73efcf9ee82"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"b7ac9755fb7a829a135a599432415b0a7ee671e4","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  $step           \u003d hiera(\u0027step\u0027),"},{"line_number":32,"context_line":"  $remote_authkey \u003d undef,"},{"line_number":33,"context_line":") {"},{"line_number":34,"context_line":"  if $remote_authkey {"},{"line_number":35,"context_line":"    # Starting with 7.3 we have a separate pacemaker-remote package"},{"line_number":36,"context_line":"    if $::operatingsystemrelease \u003d~ /7\\.[012]*$/ {"},{"line_number":37,"context_line":"      $packages \u003d [\u0027pacemaker\u0027,\u0027pcs\u0027,\u0027fence-agents-all\u0027,\u0027pacemaker-libs\u0027]"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"1a6eadb0_439309fa","line":34,"in_reply_to":"1a6eadb0_34fe4eae","updated":"2016-12-16 06:48:00.000000000","message":"So if you include this tripleo profile you are basically saying \"configure pacemaker remote\", so I don\u0027t think we need another parameter. What I\u0027ll do though is I will just bail out if it is undefined, which is a more sensible thing todo and makes things a bit cleaner","commit_id":"e4e83ce4f1d2afc2035e845e4abcf73efcf9ee82"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"6767df3154e0d09b76f165b3e756721c72788dd7","unresolved":false,"context_lines":[{"line_number":59,"context_line":"  } -\u003e"},{"line_number":60,"context_line":"  service { \u0027pacemaker_remote\u0027:"},{"line_number":61,"context_line":"    ensure \u003d\u003e running,"},{"line_number":62,"context_line":"    enable \u003d\u003e true,"},{"line_number":63,"context_line":"  }"},{"line_number":64,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"da4df55a_e827f70f","line":62,"updated":"2016-12-23 18:56:43.000000000","message":"IMHO this block or even the whole class should be managed in puppet-pacemaker","commit_id":"f2048c4e7432dd2d91b3588614762898f57024d1"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"eb92915fa0b4b40eb14a1ba632f8c8d31c417d36","unresolved":false,"context_lines":[{"line_number":59,"context_line":"  } -\u003e"},{"line_number":60,"context_line":"  service { \u0027pacemaker_remote\u0027:"},{"line_number":61,"context_line":"    ensure \u003d\u003e running,"},{"line_number":62,"context_line":"    enable \u003d\u003e true,"},{"line_number":63,"context_line":"  }"},{"line_number":64,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"da4df55a_abb5e9ee","line":62,"in_reply_to":"da4df55a_e827f70f","updated":"2016-12-23 19:34:40.000000000","message":"I did not do it because it would have been not integrated with the main corosync class anyway, so there would not be too much point in doing it there. I guess in terms of layering it can make sense though. I will look into it","commit_id":"f2048c4e7432dd2d91b3588614762898f57024d1"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"268b9c656a303f452995bc03198c0b1bcd213f90","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  $step           \u003d hiera(\u0027step\u0027),"},{"line_number":32,"context_line":"  $remote_authkey \u003d undef,"},{"line_number":33,"context_line":") {"},{"line_number":34,"context_line":"  if $remote_authkey \u003d\u003d undef {"},{"line_number":35,"context_line":"    fail(\u0027The tripleo::profile::base::pacemaker_remote manifest was included without specifying a remote_authkey\u0027)"},{"line_number":36,"context_line":"  }"},{"line_number":37,"context_line":"  class { \u0027::pacemaker::remote\u0027:"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"5a3905b3_8e619307","line":34,"updated":"2017-01-24 10:48:22.000000000","message":"could we just leave remote_authkey unset to make it a required parameter?","commit_id":"730efdb4e3febb52ef6c5c05593356fc3be193a2"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"5e31c489bf0ffb251a2468fc72b1a8d661836557","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  $step           \u003d hiera(\u0027step\u0027),"},{"line_number":32,"context_line":"  $remote_authkey \u003d undef,"},{"line_number":33,"context_line":") {"},{"line_number":34,"context_line":"  if $remote_authkey \u003d\u003d undef {"},{"line_number":35,"context_line":"    fail(\u0027The tripleo::profile::base::pacemaker_remote manifest was included without specifying a remote_authkey\u0027)"},{"line_number":36,"context_line":"  }"},{"line_number":37,"context_line":"  class { \u0027::pacemaker::remote\u0027:"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"5a3905b3_7b1ee60c","line":34,"in_reply_to":"5a3905b3_8e619307","updated":"2017-01-24 11:53:14.000000000","message":"I guess I could, I kind of like the the nicer error message. But will amend","commit_id":"730efdb4e3febb52ef6c5c05593356fc3be193a2"}]}
