)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"4ae06774914e5f9f6d831970c73ef97c8ed00c01","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Enable ml2.pp to call networking-fujitsu manifest in puppet-neutron."},{"line_number":10,"context_line":"The implementation in puppet-neutron is in progress separately."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5eb2c2a9c50b5991d62f4b6d74b83351c86b02de"},{"line_number":13,"context_line":"Implements: blueprint integration-networking-fujitsu"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a71b18c_bedea4da","line":12,"updated":"2016-12-06 17:50:59.000000000","message":"Probably should have a Depends-On: I37a502b43eb7d91bfe20625248ed117eae3ca535 since the fujitsu stuff has yet to be merged in puppet-neutron.","commit_id":"68aa3b5efd4208e75b1e7be61fac163b6f4f8598"},{"author":{"_account_id":24313,"name":"Koki Sanagi","email":"sanagi.koki@jp.fujitsu.com","username":"sanagikoki"},"change_message_id":"5bca38f6d56a82189e37219917eee5639f925d88","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Enable ml2.pp to call networking-fujitsu manifest in puppet-neutron."},{"line_number":10,"context_line":"The implementation in puppet-neutron is in progress separately."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5eb2c2a9c50b5991d62f4b6d74b83351c86b02de"},{"line_number":13,"context_line":"Implements: blueprint integration-networking-fujitsu"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a71b18c_3659d48e","line":12,"in_reply_to":"3a71b18c_bedea4da","updated":"2016-12-06 20:34:12.000000000","message":"I\u0027ll fix it on next PS.","commit_id":"68aa3b5efd4208e75b1e7be61fac163b6f4f8598"}],"manifests/profile/base/neutron/plugins/ml2.pp":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"67b12602d138376d93e492430f389a8893f3c7d6","unresolved":false,"context_lines":[{"line_number":72,"context_line":"      include ::tripleo::profile::base::neutron::plugins::ml2::ovn"},{"line_number":73,"context_line":"    }"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    if \u0027fujitsu_cfab\u0027 in $mechanism_drivers {"},{"line_number":76,"context_line":"      include ::neutron::plugins::ml2::fujitsu::cfab"},{"line_number":77,"context_line":"    }"},{"line_number":78,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3a71b18c_71055d78","line":75,"updated":"2016-12-11 18:58:40.000000000","message":"don\u0027t you also need to include neutron::plugins::ml2::fujitsu to install the package?","commit_id":"605363613faba042537b1ffbb0c0f1fb5ec786b2"},{"author":{"_account_id":24313,"name":"Koki Sanagi","email":"sanagi.koki@jp.fujitsu.com","username":"sanagikoki"},"change_message_id":"7d170e74a443aeae087704080beba6f4ab8d131b","unresolved":false,"context_lines":[{"line_number":72,"context_line":"      include ::tripleo::profile::base::neutron::plugins::ml2::ovn"},{"line_number":73,"context_line":"    }"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    if \u0027fujitsu_cfab\u0027 in $mechanism_drivers {"},{"line_number":76,"context_line":"      include ::neutron::plugins::ml2::fujitsu::cfab"},{"line_number":77,"context_line":"    }"},{"line_number":78,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1a6eadb0_86340fdf","line":75,"in_reply_to":"3a71b18c_71055d78","updated":"2016-12-12 19:54:51.000000000","message":"Right. I\u0027ll take care of it in next PS. Thanks!","commit_id":"605363613faba042537b1ffbb0c0f1fb5ec786b2"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"042bd6babeef6fba629264e6307ba7a2875a729b","unresolved":false,"context_lines":[{"line_number":72,"context_line":"      include ::tripleo::profile::base::neutron::plugins::ml2::ovn"},{"line_number":73,"context_line":"    }"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    if \u0027fujitsu_cfab\u0027 in $mechanism_drivers {"},{"line_number":76,"context_line":"      include ::neutron::plugins::ml2::fujitsu"},{"line_number":77,"context_line":"      include ::neutron::plugins::ml2::fujitsu::cfab"},{"line_number":78,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a6eadb0_6df22fd4","line":75,"updated":"2016-12-14 00:26:35.000000000","message":"Quick question.  If we support another mechanism driver, we should add a definition like as follows, shouldn\u0027t we?\n\n\u003e if \u0027fujitsu_new_mech\u0027 in $mechanism_drivers {\n\u003e     include ::neutron::plugins::ml2::fujitsu\n\u003e     include ::neutron::plugins::ml2::fujitsu::new_mech","commit_id":"22c78358d0ccc89fb5c05bb36f0b7125da8141f9"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"8619757289e66e0f913c87f3eff7714767602934","unresolved":false,"context_lines":[{"line_number":72,"context_line":"      include ::tripleo::profile::base::neutron::plugins::ml2::ovn"},{"line_number":73,"context_line":"    }"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    if \u0027fujitsu_cfab\u0027 in $mechanism_drivers {"},{"line_number":76,"context_line":"      include ::neutron::plugins::ml2::fujitsu"},{"line_number":77,"context_line":"      include ::neutron::plugins::ml2::fujitsu::cfab"},{"line_number":78,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a6eadb0_ac1fb706","line":75,"in_reply_to":"1a6eadb0_5dc098e0","updated":"2016-12-14 20:03:52.000000000","message":"oh sorry read that wrong, yea you\u0027re right. you\u0027d just add a new block","commit_id":"22c78358d0ccc89fb5c05bb36f0b7125da8141f9"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f3a98e1da6ef19cff955615ce36ad6bbadd42884","unresolved":false,"context_lines":[{"line_number":72,"context_line":"      include ::tripleo::profile::base::neutron::plugins::ml2::ovn"},{"line_number":73,"context_line":"    }"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    if \u0027fujitsu_cfab\u0027 in $mechanism_drivers {"},{"line_number":76,"context_line":"      include ::neutron::plugins::ml2::fujitsu"},{"line_number":77,"context_line":"      include ::neutron::plugins::ml2::fujitsu::cfab"},{"line_number":78,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a6eadb0_5dc098e0","line":75,"in_reply_to":"1a6eadb0_6df22fd4","updated":"2016-12-14 16:49:58.000000000","message":"no, you could just use:\n\nif \u0027fujitsu_cfab\u0027 in $mechanism_drivers or \u0027fujitsu_new_thing\u0027 in $mechanism_drivers { ... }","commit_id":"22c78358d0ccc89fb5c05bb36f0b7125da8141f9"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"5b2a503f0fc3b0a6b148303e3e29fe42a06f4998","unresolved":false,"context_lines":[{"line_number":72,"context_line":"      include ::tripleo::profile::base::neutron::plugins::ml2::ovn"},{"line_number":73,"context_line":"    }"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    if \u0027fujitsu_cfab\u0027 in $mechanism_drivers {"},{"line_number":76,"context_line":"      include ::neutron::plugins::ml2::fujitsu"},{"line_number":77,"context_line":"      include ::neutron::plugins::ml2::fujitsu::cfab"},{"line_number":78,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a6eadb0_57f85549","line":75,"in_reply_to":"1a6eadb0_ac1fb706","updated":"2016-12-15 09:23:07.000000000","message":"Thanks! I understand.","commit_id":"22c78358d0ccc89fb5c05bb36f0b7125da8141f9"}]}
