)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"541195f1c28c368ad94974226e9a92aa40bd1605","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"1a6eadb0_d713b30b","line":13,"updated":"2016-12-14 13:18:39.000000000","message":"I think it misses the Depends-On: I42861afcac221478dcb68be13b6dbc2533a7f158","commit_id":"7595c626983becb9e351b133832bbe594b32d3f8"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"0034881119e64893b6f89706e5f68ae5ffa9d5fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"1a6eadb0_d2ce61b3","line":13,"in_reply_to":"1a6eadb0_d713b30b","updated":"2016-12-14 13:32:16.000000000","message":"sorry wrong id, please disregard","commit_id":"7595c626983becb9e351b133832bbe594b32d3f8"}],"manifests/profile/base/ceph/rgw.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"76fbe7e933bfcba01b3bcafb1a75e13bb7d17fbe","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        rgw_keystone_url     \u003d\u003e $keystone_url,"},{"line_number":89,"context_line":"        rgw_keystone_version \u003d\u003e $rgw_keystone_version,"},{"line_number":90,"context_line":"      }"},{"line_number":91,"context_line":"    }"},{"line_number":92,"context_line":"  }"},{"line_number":93,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3a71b18c_592cca98","line":91,"updated":"2016-12-06 17:55:25.000000000","message":"Please cover this if/else logic in the test","commit_id":"68522073c425dc56c796c1b26fc61b45add0b205"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"a5c1856c830548d2cfcd0bac5efa22377df0d848","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  $keystone_admin_token,"},{"line_number":49,"context_line":"  $keystone_url,"},{"line_number":50,"context_line":"  $rgw_key,"},{"line_number":51,"context_line":"  $rgw_keystone_version \u003d hiera(\u0027tripleo::profile::base::ceph::rgw::rgw_keystone_version\u0027,\u0027v2.0\u0027),"},{"line_number":52,"context_line":"  $civetweb_bind_ip     \u003d \u0027127.0.0.1\u0027,"},{"line_number":53,"context_line":"  $civetweb_bind_port   \u003d \u00278080\u0027,"},{"line_number":54,"context_line":"  $step                 \u003d hiera(\u0027step\u0027),"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"da4df55a_211eac0c","line":51,"updated":"2016-12-22 18:01:08.000000000","message":"this can be given as param from thta and default to v2.0 here","commit_id":"55a64df1390c7d322212bfbb867d5345b9e5d220"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"a5c1856c830548d2cfcd0bac5efa22377df0d848","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        use_pki                     \u003d\u003e false,"},{"line_number":91,"context_line":"        rgw_keystone_url            \u003d\u003e $keystone_url,"},{"line_number":92,"context_line":"        rgw_keystone_version        \u003d\u003e $rgw_keystone_version,"},{"line_number":93,"context_line":"        rgw_keystone_admin_user     \u003d\u003e hiera(\u0027ceph::rgw::keystone::auth::user\u0027),"},{"line_number":94,"context_line":"        rgw_keystone_admin_password \u003d\u003e hiera(\u0027ceph::rgw::keystone::auth::password\u0027),"},{"line_number":95,"context_line":"        rgw_keystone_admin_project  \u003d\u003e hiera(\u0027ceph::rgw::keystone::auth::project\u0027),"},{"line_number":96,"context_line":"        rgw_keystone_admin_domain   \u003d\u003e hiera(\u0027ceph::rgw::keystone::auth::domain\u0027),"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"da4df55a_81c75811","line":93,"updated":"2016-12-22 18:01:08.000000000","message":"these 4 can be guven from tht as\n\n  ::ceph::profile::params::","commit_id":"55a64df1390c7d322212bfbb867d5345b9e5d220"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"6d9bf0bb8820328acfe024a5575a884dccb41c92","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        use_pki                     \u003d\u003e false,"},{"line_number":82,"context_line":"        rgw_keystone_admin_token    \u003d\u003e $keystone_admin_token,"},{"line_number":83,"context_line":"        rgw_keystone_url            \u003d\u003e $keystone_url,"},{"line_number":84,"context_line":"      }"},{"line_number":85,"context_line":"    }"},{"line_number":86,"context_line":"    else"},{"line_number":87,"context_line":"    {"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"da4df55a_9da5f405","line":84,"updated":"2016-12-22 22:04:57.000000000","message":"I think we missed to add the user parameter for the v2.0 case","commit_id":"9b4aaf479330b4702dc8f38b47db4f779568a017"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"8e5d013ecb31c247f4f1058d0c2eaec89b79c4d9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Red Hat, Inc.  #"},{"line_number":2,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"# a copy of the License at"}],"source_content_type":"text/x-puppet","patch_set":32,"id":"ba5201f7_53e76b3f","line":1,"updated":"2017-01-06 13:11:00.000000000","message":"this change is unrelated. Please remove that.","commit_id":"24915ae20da477631facd10ff523cc2769d9d4c9"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"06e77602adf8f4ba671184458ceef063ebab5aff","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  $civetweb_bind_ip            \u003d \u0027127.0.0.1\u0027,"},{"line_number":64,"context_line":"  $civetweb_bind_port          \u003d \u00278080\u0027,"},{"line_number":65,"context_line":"  $rgw_keystone_version        \u003d \u0027v2.0\u0027,"},{"line_number":66,"context_line":"  $rgw_keystone_admin_domain   \u003d \u0027rgw_domain\u0027,"},{"line_number":67,"context_line":"  $rgw_keystone_admin_project  \u003d \u0027rgw_project\u0027,"},{"line_number":68,"context_line":"  $rgw_keystone_admin_user     \u003d \u0027rgw_user\u0027,"},{"line_number":69,"context_line":"  $rgw_keystone_admin_password \u003d \u0027rgw_password\u0027,"}],"source_content_type":"text/x-puppet","patch_set":37,"id":"ba5201f7_c24a64ac","line":66,"updated":"2017-01-09 15:38:15.000000000","message":"I think these four (l66 \u003e l69) are not needed, they can be given via ceph::profile::params , see https://github.com/openstack/puppet-ceph/blob/master/manifests/rgw/keystone.pp#L86-L89","commit_id":"5d80ad63dda87bf6b8d48a9c3fa70a4822c9a907"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"a8f978bb4b5f2f88d9ad89636b9e00b88dc2e5fe","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        use_pki                     \u003d\u003e false,"},{"line_number":108,"context_line":"        rgw_keystone_url            \u003d\u003e $keystone_url,"},{"line_number":109,"context_line":"        rgw_keystone_version        \u003d\u003e $rgw_keystone_version,"},{"line_number":110,"context_line":"        rgw_keystone_admin_domain   \u003d\u003e $rgw_keystone_admin_domain,"},{"line_number":111,"context_line":"        rgw_keystone_admin_project  \u003d\u003e $rgw_keystone_admin_project,"},{"line_number":112,"context_line":"        rgw_keystone_admin_user     \u003d\u003e $rgw_keystone_admin_user,"},{"line_number":113,"context_line":"        rgw_keystone_admin_password \u003d\u003e $rgw_keystone_admin_password,"}],"source_content_type":"text/x-puppet","patch_set":37,"id":"ba5201f7_e5169257","line":110,"updated":"2017-01-09 15:54:57.000000000","message":"if so, these can be removed as well","commit_id":"5d80ad63dda87bf6b8d48a9c3fa70a4822c9a907"}],"spec/classes/tripleo_profile_base_ceph_rgw_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"37bad6ed8295d0687c96e2f8a06e0f9e7fbe1abb","unresolved":false,"context_lines":[{"line_number":23,"context_line":"      class { \u0027::tripleo::profile::base::ceph\u0027:"},{"line_number":24,"context_line":"        step \u003d\u003e #{params[:step]}"},{"line_number":25,"context_line":"      }"},{"line_number":26,"context_line":"      class { \u0027ceph::profile::params\u0027:"},{"line_number":27,"context_line":"        rgw_keystone_admin_domain   \u003d\u003e \u0027rgw_domain\u0027,"},{"line_number":28,"context_line":"        rgw_keystone_admin_project  \u003d\u003e \u0027rgw_project\u0027,"},{"line_number":29,"context_line":"        rgw_keystone_admin_user     \u003d\u003e \u0027rgw_user\u0027,"},{"line_number":30,"context_line":"        rgw_keystone_admin_password \u003d\u003e \u0027rgw_password\u0027"},{"line_number":31,"context_line":"      }"},{"line_number":32,"context_line":"      eof"},{"line_number":33,"context_line":"    end"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":9,"id":"3a71b18c_5a42eeae","line":31,"range":{"start_line":26,"start_character":0,"end_line":31,"end_character":7},"updated":"2016-12-07 00:05:38.000000000","message":"This is already included in ::tripleo::profile::base::ceph::rgw. So you\u0027ll need to provide these via hiera for the tests, https://github.com/openstack/puppet-tripleo/blob/master/spec/fixtures/hieradata/default.yaml#L16","commit_id":"e749c9e3a3cc8dea7950b7c7bf8666ffed6545e2"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"8f076c69c4c55c367de0bc23120468d0355cdd10","unresolved":false,"context_lines":[{"line_number":23,"context_line":"      class { \u0027::tripleo::profile::base::ceph\u0027:"},{"line_number":24,"context_line":"        step \u003d\u003e #{params[:step]}"},{"line_number":25,"context_line":"      }"},{"line_number":26,"context_line":"      class { \u0027ceph::profile::params\u0027:"},{"line_number":27,"context_line":"        rgw_keystone_admin_domain   \u003d\u003e \u0027rgw_domain\u0027,"},{"line_number":28,"context_line":"        rgw_keystone_admin_project  \u003d\u003e \u0027rgw_project\u0027,"},{"line_number":29,"context_line":"        rgw_keystone_admin_user     \u003d\u003e \u0027rgw_user\u0027,"},{"line_number":30,"context_line":"        rgw_keystone_admin_password \u003d\u003e \u0027rgw_password\u0027"},{"line_number":31,"context_line":"      }"},{"line_number":32,"context_line":"      eof"},{"line_number":33,"context_line":"    end"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":9,"id":"3a71b18c_91e1c02c","line":31,"range":{"start_line":26,"start_character":0,"end_line":31,"end_character":7},"in_reply_to":"3a71b18c_5a42eeae","updated":"2016-12-07 07:51:24.000000000","message":"that is much more civilized.","commit_id":"e749c9e3a3cc8dea7950b7c7bf8666ffed6545e2"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"37bad6ed8295d0687c96e2f8a06e0f9e7fbe1abb","unresolved":false,"context_lines":[{"line_number":92,"context_line":"      end"},{"line_number":93,"context_line":"    end"},{"line_number":94,"context_line":"    context \u0027with step 4 with keystone v3\u0027 do"},{"line_number":95,"context_line":"      let(:params) { default_params.merge({ :rgw_keystone_version \u003d\u003e \u0027v3\u0027 }) }"},{"line_number":96,"context_line":"      it \u0027should include rgw configuration\u0027 do"},{"line_number":97,"context_line":"        is_expected.to contain_ceph__rgw__keystone(\u0027radosgw.gateway\u0027).with("},{"line_number":98,"context_line":"          :rgw_keystone_accepted_roles \u003d\u003e \u0027_member_, Member\u0027,"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"3a71b18c_da7b5ef3","line":95,"range":{"start_line":95,"start_character":42,"end_line":95,"end_character":74},"updated":"2016-12-07 00:05:38.000000000","message":"This needs to include :step \u003d\u003e 4 or you get that rp_env error","commit_id":"e749c9e3a3cc8dea7950b7c7bf8666ffed6545e2"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"8f076c69c4c55c367de0bc23120468d0355cdd10","unresolved":false,"context_lines":[{"line_number":92,"context_line":"      end"},{"line_number":93,"context_line":"    end"},{"line_number":94,"context_line":"    context \u0027with step 4 with keystone v3\u0027 do"},{"line_number":95,"context_line":"      let(:params) { default_params.merge({ :rgw_keystone_version \u003d\u003e \u0027v3\u0027 }) }"},{"line_number":96,"context_line":"      it \u0027should include rgw configuration\u0027 do"},{"line_number":97,"context_line":"        is_expected.to contain_ceph__rgw__keystone(\u0027radosgw.gateway\u0027).with("},{"line_number":98,"context_line":"          :rgw_keystone_accepted_roles \u003d\u003e \u0027_member_, Member\u0027,"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"3a71b18c_71e6e444","line":95,"range":{"start_line":95,"start_character":42,"end_line":95,"end_character":74},"in_reply_to":"3a71b18c_da7b5ef3","updated":"2016-12-07 07:51:24.000000000","message":"Done","commit_id":"e749c9e3a3cc8dea7950b7c7bf8666ffed6545e2"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"a8f978bb4b5f2f88d9ad89636b9e00b88dc2e5fe","unresolved":false,"context_lines":[{"line_number":93,"context_line":"          :rgw_keystone_accepted_roles \u003d\u003e [\"admin\", \"_member_\", \"Member\"],"},{"line_number":94,"context_line":"          :use_pki                     \u003d\u003e false,"},{"line_number":95,"context_line":"          :rgw_keystone_url            \u003d\u003e \u0027url\u0027,"},{"line_number":96,"context_line":"          :rgw_keystone_admin_domain   \u003d\u003e \u0027rgw_domain\u0027,"},{"line_number":97,"context_line":"          :rgw_keystone_admin_project  \u003d\u003e \u0027rgw_project\u0027,"},{"line_number":98,"context_line":"          :rgw_keystone_admin_user     \u003d\u003e \u0027rgw_user\u0027,"},{"line_number":99,"context_line":"          :rgw_keystone_admin_password \u003d\u003e \u0027rgw_password\u0027,"}],"source_content_type":"text/x-ruby","patch_set":37,"id":"ba5201f7_a81c616b","line":96,"updated":"2017-01-09 15:54:57.000000000","message":"here too","commit_id":"5d80ad63dda87bf6b8d48a9c3fa70a4822c9a907"}]}