)]}'
{"manifests/haproxy.pp":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"82062397b46fcbf89292acbc7d9d69823529f19b","unresolved":false,"context_lines":[{"line_number":164,"context_line":"#"},{"line_number":165,"context_line":"# [*nova_placement*]"},{"line_number":166,"context_line":"#  (optional) Enable or not Nova Placement API binding"},{"line_number":167,"context_line":"#  Defaults to hiera(\u0027nova_placement_enabled\u0027, false)"},{"line_number":168,"context_line":"#"},{"line_number":169,"context_line":"# [*nova_metadata*]"},{"line_number":170,"context_line":"#  (optional) Enable or not Nova metadata binding"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3a71b18c_36eda6ef","line":167,"updated":"2016-12-05 10:25:25.000000000","message":"Just for reference, the current plan is that the placement surface will need to be running before any nova-compute nodes are upgraded to ocata.","commit_id":"200e2f0c4f28b2079958ff34b79bd794afb735e9"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"3bb28b86df96d44c98a1a78983e1a374b02df43f","unresolved":false,"context_lines":[{"line_number":952,"context_line":"            \u0027set-header X-Forwarded-Proto http if !{ ssl_fc }\u0027],"},{"line_number":953,"context_line":"      },"},{"line_number":954,"context_line":"      public_ssl_port   \u003d\u003e $ports[nova_placement_ssl_port],"},{"line_number":955,"context_line":"      service_network   \u003d\u003e $nova_osapi_network,"},{"line_number":956,"context_line":"      member_options    \u003d\u003e union($haproxy_member_options, $internal_tls_member_options),"},{"line_number":957,"context_line":"    }"},{"line_number":958,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"ba5201f7_cf24d90e","line":955,"updated":"2017-01-11 15:51:54.000000000","message":"uhm.... wait up, so nova placement will always use the same network as nova API? is this intended? It\u0027s not a big deal, but just wanted to know. Or will we also get a hiera entry (which needs a parameter) for the nova placement network like we do with all the other services?","commit_id":"858b220cc36a296efd49106f9358c70e38a29b21"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"9fc55ac79eab026fa9acaca2ddc4a4be55e0d90d","unresolved":false,"context_lines":[{"line_number":952,"context_line":"            \u0027set-header X-Forwarded-Proto http if !{ ssl_fc }\u0027],"},{"line_number":953,"context_line":"      },"},{"line_number":954,"context_line":"      public_ssl_port   \u003d\u003e $ports[nova_placement_ssl_port],"},{"line_number":955,"context_line":"      service_network   \u003d\u003e $nova_osapi_network,"},{"line_number":956,"context_line":"      member_options    \u003d\u003e union($haproxy_member_options, $internal_tls_member_options),"},{"line_number":957,"context_line":"    }"},{"line_number":958,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"ba5201f7_5bb41d34","line":955,"in_reply_to":"ba5201f7_cf24d90e","updated":"2017-01-11 19:46:12.000000000","message":"yes for now, as it is for some other nova services. I guess if one day placement api goes out of nova, we can maybe move out to a dedicated network?","commit_id":"858b220cc36a296efd49106f9358c70e38a29b21"}],"manifests/profile/base/database/mysql.pp":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"32ff75fc63cf1f8eb718731e3683c280bee889e8","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        }),"},{"line_number":248,"context_line":"      }"},{"line_number":249,"context_line":"    }"},{"line_number":250,"context_line":"    if hiera(\u0027nova_api_enabled\u0027, false) {"},{"line_number":251,"context_line":"      include ::nova::db::mysql_placement"},{"line_number":252,"context_line":"    }"},{"line_number":253,"context_line":"    if hiera(\u0027sahara_api_enabled\u0027, false) {"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"ba5201f7_84f2e198","line":250,"updated":"2017-01-10 21:16:05.000000000","message":"s/nova_api/nova_placement","commit_id":"29d7a323fd1a2347c06b5fc56ad73b1c27c9a900"}]}
