)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"6348497921ed7b017157aea7e540dbff1f195d49","unresolved":false,"context_lines":[{"line_number":10,"context_line":"should be managed by Pacemaker to make sure there is always a single"},{"line_number":11,"context_line":"instance running."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ic63dc5cffece38942d305f538f71dd58a5d50789"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a71b18c_7e3a4ce8","line":13,"updated":"2016-12-06 17:54:11.000000000","message":"Depends-On: If00c85d69cb4b3d2c0c34dd6d2ee2c1fc3db4a2f","commit_id":"bae41bff7ab2abd5d463f9cbaa11829a9a8fde6a"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"c06359e2de11c1208b033001e5cc068d82fe7ce4","unresolved":false,"context_lines":[{"line_number":10,"context_line":"should be managed by Pacemaker to make sure there is always a single"},{"line_number":11,"context_line":"instance running."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ic63dc5cffece38942d305f538f71dd58a5d50789"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a71b18c_0a7cabea","line":13,"in_reply_to":"3a71b18c_7e3a4ce8","updated":"2016-12-06 22:18:01.000000000","message":"yeah, thanks","commit_id":"bae41bff7ab2abd5d463f9cbaa11829a9a8fde6a"}],"manifests/profile/pacemaker/ceph/rbdmirror.pp":[{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"a900407cefee493305e3be1b512f85d1ba42e7d5","unresolved":false,"context_lines":[{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"class tripleo::profile::pacemaker::ceph::rbdmirror ("},{"line_number":35,"context_line":"  $bootstrap_node \u003d hiera(\u0027bootstrap_nodeid\u0027),"},{"line_number":36,"context_line":"  $client_name    \u003d \u0027rbd-mirror\u0027,"},{"line_number":37,"context_line":"  $step           \u003d hiera(\u0027step\u0027),"},{"line_number":38,"context_line":") {"},{"line_number":39,"context_line":"  Service \u003c| tag \u003d\u003d \u0027ceph-rbd-mirror\u0027 |\u003e {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a71b18c_52b91ccb","line":36,"range":{"start_line":36,"start_character":21,"end_line":36,"end_character":31},"updated":"2016-12-06 09:04:41.000000000","message":"his should default to openstack as it is the cephx client with rights to the OSP pools.","commit_id":"85b4b9ad7f4f41025056d8f5f5464b5d1ba0c937"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"a900407cefee493305e3be1b512f85d1ba42e7d5","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    }"},{"line_number":59,"context_line":"  }"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  if $step \u003e\u003d 4 and $pacemaker_master and hiera(\u0027stack_action\u0027) \u003d\u003d \u0027UPDATE\u0027 {"},{"line_number":62,"context_line":"    Ceph_config\u003c||\u003e ~\u003e Tripleo::Pacemaker::Resource_restart_flag[\"ceph-rbd-mirror@${client_name}\"]"},{"line_number":63,"context_line":"    tripleo::pacemaker::resource_restart_flag { \"ceph-rbd-mirror@${client_name}\": }"},{"line_number":64,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a71b18c_5292fc4c","line":61,"range":{"start_line":61,"start_character":5,"end_line":61,"end_character":15},"updated":"2016-12-06 09:04:41.000000000","message":"from our conversation, this needs to be step \u003e\u003d 3","commit_id":"85b4b9ad7f4f41025056d8f5f5464b5d1ba0c937"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"6348497921ed7b017157aea7e540dbff1f195d49","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    }"},{"line_number":61,"context_line":"  }"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  if $step \u003e\u003d 3 and $pacemaker_master and hiera(\u0027stack_action\u0027) \u003d\u003d \u0027UPDATE\u0027 {"},{"line_number":64,"context_line":"    Ceph_config\u003c||\u003e ~\u003e Tripleo::Pacemaker::Resource_restart_flag[\"ceph-rbd-mirror@${client_name}\"]"},{"line_number":65,"context_line":"    tripleo::pacemaker::resource_restart_flag { \"ceph-rbd-mirror@${client_name}\": }"},{"line_number":66,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3a71b18c_5e3750fe","line":63,"updated":"2016-12-06 17:54:11.000000000","message":"stack_action should be a parameter so you could test this in the rspec tests.  This is the kinda of thing we really need to be testing in rspec","commit_id":"bae41bff7ab2abd5d463f9cbaa11829a9a8fde6a"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"c06359e2de11c1208b033001e5cc068d82fe7ce4","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    }"},{"line_number":61,"context_line":"  }"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  if $step \u003e\u003d 3 and $pacemaker_master and hiera(\u0027stack_action\u0027) \u003d\u003d \u0027UPDATE\u0027 {"},{"line_number":64,"context_line":"    Ceph_config\u003c||\u003e ~\u003e Tripleo::Pacemaker::Resource_restart_flag[\"ceph-rbd-mirror@${client_name}\"]"},{"line_number":65,"context_line":"    tripleo::pacemaker::resource_restart_flag { \"ceph-rbd-mirror@${client_name}\": }"},{"line_number":66,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3a71b18c_ea43efac","line":63,"in_reply_to":"3a71b18c_5e3750fe","updated":"2016-12-06 22:18:01.000000000","message":"yes it should, I was talking about this very same thing you pointed out before to a few other guys today.\n\nthough in this particular case this is just doing the same thing that we\u0027re already doing for the other pacemaker profiles; I will fix it here and in the others with a follow-up patch","commit_id":"bae41bff7ab2abd5d463f9cbaa11829a9a8fde6a"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"1717442afcdcebea995924059af5f1093b38b536","unresolved":false,"context_lines":[{"line_number":37,"context_line":"#   Defaults to hiera(\u0027step\u0027)"},{"line_number":38,"context_line":"#"},{"line_number":39,"context_line":"class tripleo::profile::pacemaker::ceph::rbdmirror ("},{"line_number":40,"context_line":"  $bootstrap_node \u003d hiera(\u0027bootstrap_nodeid\u0027),"},{"line_number":41,"context_line":"  $client_name    \u003d \u0027openstack\u0027,"},{"line_number":42,"context_line":"  $stack_action   \u003d hiera(\u0027stack_action\u0027),"},{"line_number":43,"context_line":"  $step           \u003d hiera(\u0027step\u0027),"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7a3c09a3_6e00dd34","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":46},"updated":"2017-01-18 15:21:12.000000000","message":"note that you will want to use ceph_rbdmirror_bootstrap_short_node_name here. Otherwise when you deploy this service a across multiple roles, pacemaker_master will be true on the first node of both roles and barf. Can be done as a follow up patch as well (since technically it won\u0027t exist until the tht change is merged), just don\u0027t forget it.","commit_id":"004544542c75c21607941f1a67c6e0c34ef4024d"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"d159d9287bc9c764b1097e1eb42332b00ffd7e4a","unresolved":false,"context_lines":[{"line_number":37,"context_line":"#   Defaults to hiera(\u0027step\u0027)"},{"line_number":38,"context_line":"#"},{"line_number":39,"context_line":"class tripleo::profile::pacemaker::ceph::rbdmirror ("},{"line_number":40,"context_line":"  $bootstrap_node \u003d hiera(\u0027bootstrap_nodeid\u0027),"},{"line_number":41,"context_line":"  $client_name    \u003d \u0027openstack\u0027,"},{"line_number":42,"context_line":"  $stack_action   \u003d hiera(\u0027stack_action\u0027),"},{"line_number":43,"context_line":"  $step           \u003d hiera(\u0027step\u0027),"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7a3c09a3_f1ee7020","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":46},"in_reply_to":"7a3c09a3_6e00dd34","updated":"2017-01-18 15:21:57.000000000","message":"right, we just merged a fix for that, updating!","commit_id":"004544542c75c21607941f1a67c6e0c34ef4024d"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"5c3711cd142be067aa71c818cf9ad32c58aeb7d1","unresolved":false,"context_lines":[{"line_number":38,"context_line":"#"},{"line_number":39,"context_line":"class tripleo::profile::pacemaker::ceph::rbdmirror ("},{"line_number":40,"context_line":"  $bootstrap_node \u003d hiera(\u0027bootstrap_nodeid\u0027),"},{"line_number":41,"context_line":"  $client_name    \u003d \u0027openstack\u0027,"},{"line_number":42,"context_line":"  $stack_action   \u003d hiera(\u0027stack_action\u0027),"},{"line_number":43,"context_line":"  $step           \u003d hiera(\u0027step\u0027),"},{"line_number":44,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"da4df55a_fa0fcf85","line":41,"updated":"2016-12-23 11:53:43.000000000","message":"keith, I am not sure if this key has enough privileges though","commit_id":"004544542c75c21607941f1a67c6e0c34ef4024d"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"155f5073a4b8ffda4f9c42cf58af44dfde1fcf67","unresolved":false,"context_lines":[{"line_number":38,"context_line":"#"},{"line_number":39,"context_line":"class tripleo::profile::pacemaker::ceph::rbdmirror ("},{"line_number":40,"context_line":"  $bootstrap_node \u003d hiera(\u0027bootstrap_nodeid\u0027),"},{"line_number":41,"context_line":"  $client_name    \u003d \u0027openstack\u0027,"},{"line_number":42,"context_line":"  $stack_action   \u003d hiera(\u0027stack_action\u0027),"},{"line_number":43,"context_line":"  $step           \u003d hiera(\u0027step\u0027),"},{"line_number":44,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7a3c09a3_f1091096","line":41,"in_reply_to":"da4df55a_8e0913e0","updated":"2017-01-18 15:28:00.000000000","message":"so we might end up changing this into a specific key provisioned on both sides","commit_id":"004544542c75c21607941f1a67c6e0c34ef4024d"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"90ae38406b671875e43c17cb3917d35eac53ebfb","unresolved":false,"context_lines":[{"line_number":38,"context_line":"#"},{"line_number":39,"context_line":"class tripleo::profile::pacemaker::ceph::rbdmirror ("},{"line_number":40,"context_line":"  $bootstrap_node \u003d hiera(\u0027bootstrap_nodeid\u0027),"},{"line_number":41,"context_line":"  $client_name    \u003d \u0027openstack\u0027,"},{"line_number":42,"context_line":"  $stack_action   \u003d hiera(\u0027stack_action\u0027),"},{"line_number":43,"context_line":"  $step           \u003d hiera(\u0027step\u0027),"},{"line_number":44,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"da4df55a_8e0913e0","line":41,"in_reply_to":"da4df55a_fa0fcf85","updated":"2016-12-23 20:28:16.000000000","message":"This is going to be complicated. The client.openstack key has sufficient permissions but I think we are going to run into client name collisions. In (1), the note says the rbd-mirror daemon needs to connect to both clusters at the same time. The \"Configuring Pool Mirroring\" of (2) shows an example client keyring being created. The client names seem to be unique on both sides. \"local\" on the local cluster named \"local\" and \"remote\" on the cluster named \"remote\". Both sides seem to need the cluster conig and client keyring of the other side. OSPd deploys the Ceph cluster with the name \u0027ceph\u0027 with each cluster config being \u0027ceph.conf\u0027. We may need a RFE to have OSPd uniquely name the Ceph cluster and client keyring. \n\n1: http://docs.ceph.com/docs/master/rbd/rbd-mirroring/#rbd-mirror-daemon\n2: https://access.redhat.com/documentation/en/red-hat-ceph-storage/2/paged/block-device-guide/chapter-4-block-device-mirroring","commit_id":"004544542c75c21607941f1a67c6e0c34ef4024d"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"5c3711cd142be067aa71c818cf9ad32c58aeb7d1","unresolved":false,"context_lines":[{"line_number":66,"context_line":"      # NOTE(gfidente): systemd uses the @ sign but it is an invalid"},{"line_number":67,"context_line":"      # character in a pcmk resource name, so we need to use it only"},{"line_number":68,"context_line":"      # for the name of the service"},{"line_number":69,"context_line":"      service_name \u003d\u003e \"ceph-rbd-mirror@${client_name}\""},{"line_number":70,"context_line":"    }"},{"line_number":71,"context_line":"  }"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":7,"id":"da4df55a_1a4013a5","line":69,"updated":"2016-12-23 11:53:43.000000000","message":"looks like pcs doesn\u0027t support named instances yet, so we\u0027ll need to fix that first","commit_id":"004544542c75c21607941f1a67c6e0c34ef4024d"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"420ab26f9438ac7c0d492beb33de7d8af781c058","unresolved":false,"context_lines":[{"line_number":66,"context_line":"      # NOTE(gfidente): systemd uses the @ sign but it is an invalid"},{"line_number":67,"context_line":"      # character in a pcmk resource name, so we need to use it only"},{"line_number":68,"context_line":"      # for the name of the service"},{"line_number":69,"context_line":"      service_name \u003d\u003e \"ceph-rbd-mirror@${client_name}\""},{"line_number":70,"context_line":"    }"},{"line_number":71,"context_line":"  }"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7a3c09a3_8b9d4968","line":69,"in_reply_to":"da4df55a_1a4013a5","updated":"2017-01-17 12:21:17.000000000","message":"For the record the fixes will be in pcs-0.9.152-10.el7_3.1.x86_64 and later versions. Am working so that centos has it ASAP","commit_id":"004544542c75c21607941f1a67c6e0c34ef4024d"}]}