)]}'
{"manifests/profile/base/database/mongodb.pp":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"96192a331065a9dca7a68204031ebfeb52e6d626","unresolved":false,"context_lines":[{"line_number":64,"context_line":"      require \u003d\u003e Package[\u0027mongodb-server\u0027],"},{"line_number":65,"context_line":"      content \u003d\u003e \u0027.include /usr/lib/systemd/system/mongod.service"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    [Service]"},{"line_number":68,"context_line":"    MemoryLimit\u003d20G\u0027,"},{"line_number":69,"context_line":"    }"},{"line_number":70,"context_line":"  }"},{"line_number":71,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a57fde8_78eed5ed","line":68,"range":{"start_line":67,"start_character":5,"end_line":68,"end_character":15},"updated":"2017-01-12 09:15:05.000000000","message":"So I assume we have to do things this way because there is no such thing as \u0027memory_limit\u0027 in puppet-mongo - from a very brief poke at https://github.com/puppetlabs/puppetlabs-mongodb/search?utf8\u003d%E2%9C%93\u0026q\u003dlimit it looks like there isn\u0027t but just checking \u0026 trying to understand.","commit_id":"b8e204a4bb8e7e3e3cd3961b1e71c5729c2b256f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"fb9e3904dbf582cf85573338aaa2b1978f94d155","unresolved":false,"context_lines":[{"line_number":64,"context_line":"      require \u003d\u003e Package[\u0027mongodb-server\u0027],"},{"line_number":65,"context_line":"      content \u003d\u003e \u0027.include /usr/lib/systemd/system/mongod.service"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    [Service]"},{"line_number":68,"context_line":"    MemoryLimit\u003d20G\u0027,"},{"line_number":69,"context_line":"    }"},{"line_number":70,"context_line":"  }"},{"line_number":71,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a3c09a3_eadd2e43","line":68,"range":{"start_line":67,"start_character":5,"end_line":68,"end_character":15},"in_reply_to":"7a3c09a3_873cc794","updated":"2017-01-16 08:34:24.000000000","message":"wow, besides eveything else I totally missed that pradk wasn\u0027t using the class parameter he defined above... Dimitri ++","commit_id":"b8e204a4bb8e7e3e3cd3961b1e71c5729c2b256f"},{"author":{"_account_id":14270,"name":"Dimitri Savineau","email":"dsavinea@redhat.com","username":"dsavineau"},"change_message_id":"0f55a328938a614b972e516ce77948053ac6cc70","unresolved":false,"context_lines":[{"line_number":64,"context_line":"      require \u003d\u003e Package[\u0027mongodb-server\u0027],"},{"line_number":65,"context_line":"      content \u003d\u003e \u0027.include /usr/lib/systemd/system/mongod.service"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    [Service]"},{"line_number":68,"context_line":"    MemoryLimit\u003d20G\u0027,"},{"line_number":69,"context_line":"    }"},{"line_number":70,"context_line":"  }"},{"line_number":71,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a3c09a3_873cc794","line":68,"range":{"start_line":67,"start_character":5,"end_line":68,"end_character":15},"in_reply_to":"9a57fde8_41ecb4c7","updated":"2017-01-13 21:21:48.000000000","message":"This will never work until systemd is reload (systemctl daemon-reload).\nBecause you\u0027re overriding only one parameter for this service you should not use /etc/systemd/system/mongod.service (even if it\u0027s working correctly) but use /etc/systemd/system/mongod.service.d/memory.conf with only the Service section.\nFinally you should put the memory limit value as a parameter because if you\u0027re using a dedicated node for mongodb with 128G (or more), you don\u0027t want to only use 20G","commit_id":"b8e204a4bb8e7e3e3cd3961b1e71c5729c2b256f"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"c4744c7c2373e868e2bb86cb9c980ec827efe669","unresolved":false,"context_lines":[{"line_number":64,"context_line":"      require \u003d\u003e Package[\u0027mongodb-server\u0027],"},{"line_number":65,"context_line":"      content \u003d\u003e \u0027.include /usr/lib/systemd/system/mongod.service"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    [Service]"},{"line_number":68,"context_line":"    MemoryLimit\u003d20G\u0027,"},{"line_number":69,"context_line":"    }"},{"line_number":70,"context_line":"  }"},{"line_number":71,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a57fde8_41ecb4c7","line":68,"range":{"start_line":67,"start_character":5,"end_line":68,"end_character":15},"in_reply_to":"9a57fde8_78eed5ed","updated":"2017-01-12 13:34:55.000000000","message":"Thats correct. Either this or use cgroups","commit_id":"b8e204a4bb8e7e3e3cd3961b1e71c5729c2b256f"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d98259788a42750ee3263320345790a15393ba11","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    }"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    # Limit memory utilization"},{"line_number":65,"context_line":"    file {\u0027/etc/systemd/system/mongod.service.d/memory.conf\u0027:"},{"line_number":66,"context_line":"      owner   \u003d\u003e \u0027root\u0027,"},{"line_number":67,"context_line":"      group   \u003d\u003e \u0027root\u0027,"},{"line_number":68,"context_line":"      mode    \u003d\u003e \u00270644\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a3c09a3_7b5648cf","line":65,"updated":"2017-01-16 23:08:57.000000000","message":"Just to follow up, it\u0027s in the process of getting packaged and I\u0027m keeping an eye on it. https://github.com/camptocamp/puppet-systemd/blob/master/manifests/service_limits.pp is what you\u0027d want since it does both of these things in one easy to consume interface.","commit_id":"6b35943ff1716fd9cbf9fae4c19ee10363439ea4"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"280d42e4b5e29ee34f92d0be3fb07043bfa30c93","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    }"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    # Limit memory utilization"},{"line_number":65,"context_line":"    file {\u0027/etc/systemd/system/mongod.service.d/memory.conf\u0027:"},{"line_number":66,"context_line":"      owner   \u003d\u003e \u0027root\u0027,"},{"line_number":67,"context_line":"      group   \u003d\u003e \u0027root\u0027,"},{"line_number":68,"context_line":"      mode    \u003d\u003e \u00270644\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a3c09a3_08fb3848","line":65,"updated":"2017-01-16 22:56:48.000000000","message":"Let\u0027s not manage this ourselves. I have previously requested the use of puppet-systemd for such things. I believe it\u0027s packaged and we should be using that instead for these types of customizations.  I think the rdo distgit exists for puppet-systemd but we need to finish getting it packaged.","commit_id":"6b35943ff1716fd9cbf9fae4c19ee10363439ea4"},{"author":{"_account_id":14270,"name":"Dimitri Savineau","email":"dsavinea@redhat.com","username":"dsavineau"},"change_message_id":"770fe9f6f59df59284a68f8e20266e031b55628e","unresolved":false,"context_lines":[{"line_number":66,"context_line":"      owner   \u003d\u003e \u0027root\u0027,"},{"line_number":67,"context_line":"      group   \u003d\u003e \u0027root\u0027,"},{"line_number":68,"context_line":"      mode    \u003d\u003e \u00270644\u0027,"},{"line_number":69,"context_line":"      require \u003d\u003e Package[\u0027mongodb-server\u0027],"},{"line_number":70,"context_line":"      content \u003d\u003e \""},{"line_number":71,"context_line":"    [Service]"},{"line_number":72,"context_line":"    MemoryLimit\u003d\\\"${memory_limit}\\\"\","}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a3c09a3_a7cb4652","line":69,"updated":"2017-01-16 15:58:03.000000000","message":"Error: Could not find dependency Package[mongodb-server] for File[/etc/systemd/system/mongod.service.d/memory.conf] at /etc/puppet/modules/tripleo/manifests/profile/base/database/mongodb.pp\n\nMore than the above error in the CI, I guess you have to create first the directory /etc/systemd/system/mongod.service.d/","commit_id":"6b35943ff1716fd9cbf9fae4c19ee10363439ea4"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f1f3f95b63007138ac1ace8a297fb74fe34dc1e8","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    # Limit memory utilization"},{"line_number":65,"context_line":"    ::systemd::service_limits { \u0027mongodb.service\u0027:"},{"line_number":66,"context_line":"      limits \u003d\u003e {"},{"line_number":67,"context_line":"        \u0027MemoryLimit\u0027 \u003d\u003e $memory_limit"},{"line_number":68,"context_line":"      }"},{"line_number":69,"context_line":"    }"},{"line_number":70,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9a30ddce_4300d5aa","line":67,"range":{"start_line":67,"start_character":9,"end_line":67,"end_character":20},"updated":"2017-03-08 23:47:07.000000000","message":"Also it was pointed out that MemoryLimit is not currently supported by the upstream module, so we\u0027ll need a version with that. \n\nhttps://github.com/camptocamp/puppet-systemd/blob/master/templates/limits.erb","commit_id":"39e3cc201cd71c0a7cfcbac8712d4963e84005c4"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"0ebdf48c75acf7e7e3ab254a8bbec8c6e2b94791","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    }"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    # Limit memory utilization"},{"line_number":65,"context_line":"    ::systemd::service_limits { \u0027mongodb.service\u0027:"},{"line_number":66,"context_line":"      limits \u003d\u003e {"},{"line_number":67,"context_line":"        \u0027MemoryLimit\u0027 \u003d\u003e $memory_limit"},{"line_number":68,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"dfeb2761_e3c88175","line":65,"range":{"start_line":65,"start_character":33,"end_line":65,"end_character":48},"updated":"2017-03-30 22:59:56.000000000","message":"this should be mongod.service","commit_id":"a269fc16c90e88c414d618648fe55aa6baf9dcf6"}],"releasenotes/notes/restrict-mongodb-memory-c19d69638b63feb4.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"251e3e9c1dd4616126bc8a7954616e6ee53aed6a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Add a way for mongodb to limit amount of ememory it comsumes"},{"line_number":4,"context_line":"    with systemd."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ffe62b97_05b377ea","line":3,"range":{"start_line":3,"start_character":45,"end_line":3,"end_character":46},"updated":"2017-03-30 07:37:39.000000000","message":".","commit_id":"cd27aa7387aa2945c6484aa06e950735d0d89a02"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"251e3e9c1dd4616126bc8a7954616e6ee53aed6a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Add a way for mongodb to limit amount of ememory it comsumes"},{"line_number":4,"context_line":"    with systemd."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ffe62b97_a5f16b97","line":4,"updated":"2017-03-30 07:37:39.000000000","message":"and since you\u0027ve gone to the trouble ;) may as well add the parameter name","commit_id":"cd27aa7387aa2945c6484aa06e950735d0d89a02"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c0400dcc2c73df9fb58b53144530b2f0f7bf7b38","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Add a way for mongodb to limit amount of memory it comsumes"},{"line_number":4,"context_line":"    with systemd. A new param memory_limit has been added to"},{"line_number":5,"context_line":"    tripleo::profile::base::database::mongodb class with"},{"line_number":6,"context_line":"    default limit of 20G."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"dfeb2761_2424260d","line":3,"range":{"start_line":3,"start_character":57,"end_line":3,"end_character":58},"updated":"2017-03-31 08:25:52.000000000","message":".","commit_id":"8150e247908b64bbb19a5208b429615ccbd1e3fd"}]}