)]}'
{"id":"openstack%2Fpuppet-tripleo~422425","triplet_id":"openstack%2Fpuppet-tripleo~master~I94f083a6fee75c5f3015ae32715377061fdead2d","project":"openstack/puppet-tripleo","branch":"master","topic":"bug/1657108","hashtags":[],"change_id":"I94f083a6fee75c5f3015ae32715377061fdead2d","subject":"Empty /etc/sysconfig/iptables if purge is true and it contains the stock iptables rules","status":"ABANDONED","created":"2017-01-19 07:18:37.000000000","updated":"2017-01-20 06:14:51.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a13d2eeeb2622da718c36855800dbced2e4469a5","_number":422425,"virtual_id_number":422425,"owner":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},{"_account_id":6449,"name":"Chris Jones","email":"cmsj@tenshu.net","username":"cmsj"},{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":1,"date":"2017-01-19 08:46:15.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"value":2,"date":"2017-01-19 09:13:03.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"value":2,"date":"2017-01-19 09:09:48.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6449,"name":"Chris Jones","email":"cmsj@tenshu.net","username":"cmsj"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"all":[{"value":-1,"date":"2017-01-19 19:05:23.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},{"date":"2017-01-19 07:39:32.000000000","_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},{"_account_id":6449,"name":"Chris Jones","email":"cmsj@tenshu.net","username":"cmsj"},{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},{"_account_id":6449,"name":"Chris Jones","email":"cmsj@tenshu.net","username":"cmsj"},{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-01-19 07:19:20.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2017-01-19 07:19:32.000000000","updated_by":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"reviewer":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"state":"REVIEWER"},{"updated":"2017-01-19 07:20:53.000000000","updated_by":{"_account_id":6449,"name":"Chris Jones","email":"cmsj@tenshu.net","username":"cmsj"},"reviewer":{"_account_id":6449,"name":"Chris Jones","email":"cmsj@tenshu.net","username":"cmsj"},"state":"REVIEWER"},{"updated":"2017-01-19 07:39:32.000000000","updated_by":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"reviewer":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"state":"REVIEWER"},{"updated":"2017-01-19 08:46:15.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-01-19 09:09:48.000000000","updated_by":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"reviewer":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"state":"REVIEWER"},{"updated":"2017-01-19 09:13:03.000000000","updated_by":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"reviewer":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"state":"REVIEWER"}],"messages":[{"id":"aecc67dc1bfbb8ce48a79ca2f9b0bb9ebc762548","author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"date":"2017-01-19 07:18:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a98c9075d3a119317a5a5a783db418cbec7e9487","author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"date":"2017-01-19 07:20:17.000000000","message":"Patch Set 1:\n\nOk so here is a possible approach without tweaking the image build process. I tested it and it works as expected. It is clearly a limited approach but I think it covers the main issue here.","accounts_in_message":[],"_revision_number":1},{"id":"29422fade2d62fe8e3ee4e376280ba1dd67b457a","author":{"_account_id":6449,"name":"Chris Jones","email":"cmsj@tenshu.net","username":"cmsj"},"date":"2017-01-19 07:23:45.000000000","message":"Patch Set 1: Code-Review+1\n\nlgtm. I wonder if it might be helpful to have the echo put in a comment saying that it was this module that erased the file?","accounts_in_message":[],"_revision_number":1},{"id":"32cf7ed832c4e26cd5d42a05a033a8713057562b","author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"date":"2017-01-19 07:27:03.000000000","message":"Patch Set 1:\n\nAlso note that for this to work out of the box we will need a THT patch that changes the default of PurgeFirewallRules to \u0027true\u0027","accounts_in_message":[],"_revision_number":1},{"id":"22763d579dcb7c5d9cf718d438581ad02b5b2594","author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"date":"2017-01-19 07:38:03.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"26da04715cd7ea3e5edfaea76958cc25681e8ffc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-19 08:46:15.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-puppet-tripleo-puppet-lint http://logs.openstack.org/25/422425/2/check/gate-puppet-tripleo-puppet-lint/a9b0310/ : SUCCESS in 2m 44s\n- gate-puppet-tripleo-puppet-syntax-3-centos-7 http://logs.openstack.org/25/422425/2/check/gate-puppet-tripleo-puppet-syntax-3-centos-7/6997127/ : SUCCESS in 2m 35s\n- gate-puppet-tripleo-puppet-syntax-4-centos-7 http://logs.openstack.org/25/422425/2/check/gate-puppet-tripleo-puppet-syntax-4-centos-7/9cf8869/ : SUCCESS in 2m 30s\n- gate-tripleo-ci-centos-7-nonha-multinode http://logs.openstack.org/25/422425/2/check/gate-tripleo-ci-centos-7-nonha-multinode/a34360b/ : SUCCESS in 51m 56s\n- gate-tripleo-ci-centos-7-nonha-multinode-updates-nv http://logs.openstack.org/25/422425/2/check/gate-tripleo-ci-centos-7-nonha-multinode-updates-nv/384f9e5/ : SUCCESS in 1h 06m 19s (non-voting)\n- gate-tripleo-ci-centos-7-undercloud http://logs.openstack.org/25/422425/2/check/gate-tripleo-ci-centos-7-undercloud/1bb5be6/ : SUCCESS in 25m 57s\n- gate-tripleo-ci-centos-7-undercloud-upgrades-nv http://logs.openstack.org/25/422425/2/check/gate-tripleo-ci-centos-7-undercloud-upgrades-nv/8f7c7ac/ : FAILURE in 33m 03s (non-voting)\n- gate-puppet-tripleo-puppet-unit-4.5-centos-7 http://logs.openstack.org/25/422425/2/check/gate-puppet-tripleo-puppet-unit-4.5-centos-7/3ab1c9a/ : SUCCESS in 10m 01s\n- gate-puppet-tripleo-puppet-unit-latest-centos-7 http://logs.openstack.org/25/422425/2/check/gate-puppet-tripleo-puppet-unit-latest-centos-7/a95c928/ : SUCCESS in 10m 13s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"172a36264d3218ad9a40993005412f7446a88cc7","author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"date":"2017-01-19 09:09:48.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"8f99775e0e392d436bf9d6698ce5e6ae44d311e5","author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"date":"2017-01-19 09:13:03.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"9ce0b30f9265fabe91ef7f98137d78796358dee4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-19 09:46:30.000000000","message":"Patch Set 2:\n\nBuild failed (check-tripleo pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- gate-tripleo-ci-centos-7-ovb-ha http://logs.openstack.org/25/422425/2/check-tripleo/gate-tripleo-ci-centos-7-ovb-ha/e668772/ : SUCCESS in 1h 56m 51s\n- gate-tripleo-ci-centos-7-ovb-nonha http://logs.openstack.org/25/422425/2/check-tripleo/gate-tripleo-ci-centos-7-ovb-nonha/19fed75/ : SUCCESS in 1h 37m 27s\n- gate-tripleo-ci-centos-7-ovb-updates http://logs.openstack.org/25/422425/2/check-tripleo/gate-tripleo-ci-centos-7-ovb-updates/7de6f48/ : FAILURE in 2h 08m 14s","accounts_in_message":[],"_revision_number":2},{"id":"3761d7b619371cb713b868ef711256448197b5d9","author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"date":"2017-01-19 19:05:23.000000000","message":"Patch Set 2: Workflow-1","accounts_in_message":[],"_revision_number":2},{"id":"2dbfd845bafa1931287025ace81b7fd6b5a6ed7a","author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"date":"2017-01-20 06:14:51.000000000","message":"Abandoned\n\nAbandoned in favour of https://review.openstack.org/#/c/422475/ and https://review.openstack.org/#/c/422472/ aka clear the file in the image building process","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"34cb77fb98c0c07db61ecbaea0eca5b8052b52f3","revisions":{"96911b5c0a3728ea53ce8e8c39318c02ede062ff":{"kind":"REWORK","_number":1,"created":"2017-01-19 07:18:37.000000000","uploader":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"ref":"refs/changes/25/422425/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-tripleo","ref":"refs/changes/25/422425/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/25/422425/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/25/422425/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/25/422425/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-tripleo refs/changes/25/422425/1"}}},"commit":{"parents":[{"commit":"3b3699ac9929ab459eec4ff2ad978c438f5dfadb","subject":"Merge \"Remove legacy flag and use composable interface\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/3b3699ac9929ab459eec4ff2ad978c438f5dfadb"}]}],"author":{"name":"Michele Baldessari","email":"michele@acksyn.org","date":"2017-01-19 07:10:02.000000000","tz":60},"committer":{"name":"Michele Baldessari","email":"michele@acksyn.org","date":"2017-01-19 07:17:56.000000000","tz":60},"subject":"Empty /etc/sysconfig/iptables if purge is true and it contains the stock iptables rules","message":"Empty /etc/sysconfig/iptables if purge is true and it contains the stock iptables rules\n\nDue to https://bugs.launchpad.net/tripleo/+bug/1657108 and\nhttps://tickets.puppetlabs.com/browse/MODULES-3184 purging does not work\nif /etc/sysconfig/iptables is populated and the iptables service is\nstopped. So wo empty the iptables file *only* if it contains the stock\nrules contained in the iptables package. The content of this file has\nnot changed since its inception, so grepping for the string should be\nmoderately safe. The LP bug contains the full background about this\nissue. This approach implements proposal E) as described in the bug.\n\nChange-Id: I94f083a6fee75c5f3015ae32715377061fdead2d\nPartial-Bug: #1657108\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/96911b5c0a3728ea53ce8e8c39318c02ede062ff"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/96911b5c0a3728ea53ce8e8c39318c02ede062ff"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"3b3699ac9929ab459eec4ff2ad978c438f5dfadb","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"34cb77fb98c0c07db61ecbaea0eca5b8052b52f3":{"kind":"REWORK","_number":2,"created":"2017-01-19 07:38:03.000000000","uploader":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"ref":"refs/changes/25/422425/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-tripleo","ref":"refs/changes/25/422425/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/25/422425/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/25/422425/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/25/422425/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-tripleo refs/changes/25/422425/2"}}},"commit":{"parents":[{"commit":"3b3699ac9929ab459eec4ff2ad978c438f5dfadb","subject":"Merge \"Remove legacy flag and use composable interface\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/3b3699ac9929ab459eec4ff2ad978c438f5dfadb"}]}],"author":{"name":"Michele Baldessari","email":"michele@acksyn.org","date":"2017-01-19 07:10:02.000000000","tz":60},"committer":{"name":"Michele Baldessari","email":"michele@acksyn.org","date":"2017-01-19 07:37:44.000000000","tz":60},"subject":"Empty /etc/sysconfig/iptables if purge is true and it contains the stock iptables rules","message":"Empty /etc/sysconfig/iptables if purge is true and it contains the stock iptables rules\n\nDue to https://bugs.launchpad.net/tripleo/+bug/1657108 and\nhttps://tickets.puppetlabs.com/browse/MODULES-3184 purging does not work\nif /etc/sysconfig/iptables is populated and the iptables service is\nstopped. So wo empty the iptables file *only* if it contains the stock\nrules contained in the iptables package. The content of this file has\nnot changed since its inception, so grepping for the string should be\nmoderately safe. The LP bug contains the full background about this\nissue. This approach implements proposal E) as described in the bug.\n\nChange-Id: I94f083a6fee75c5f3015ae32715377061fdead2d\nPartial-Bug: #1657108\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/34cb77fb98c0c07db61ecbaea0eca5b8052b52f3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/34cb77fb98c0c07db61ecbaea0eca5b8052b52f3"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"3b3699ac9929ab459eec4ff2ad978c438f5dfadb","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}