)]}'
{"manifests/profile/base/nova.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"5fd6fc4d619ee62cb12c1071e22aed37c260d769","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        }"},{"line_number":147,"context_line":"      }"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"      $services_enabled \u003d hiera(\u0027service_names\u0027, [])"},{"line_number":150,"context_line":"      if !empty($migration_ssh_key) and \u0027sshd\u0027 in $services_enabled {"},{"line_number":151,"context_line":"        # Nova SSH tunnel setup (cold-migration)"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"df140735_5fdb111a","line":149,"range":{"start_line":149,"start_character":26,"end_line":149,"end_character":52},"updated":"2017-06-01 12:27:59.000000000","message":"I missed this. :( should be a parameter","commit_id":"8d0509748a7efd26d09d07941eae390e627d9c72"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"5237d6d279ed926cc906c7f5cb16f81ed25f670d","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        }"},{"line_number":147,"context_line":"      }"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"      $services_enabled \u003d hiera(\u0027service_names\u0027, [])"},{"line_number":150,"context_line":"      if !empty($migration_ssh_key) and \u0027sshd\u0027 in $services_enabled {"},{"line_number":151,"context_line":"        # Nova SSH tunnel setup (cold-migration)"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"df140735_e08362cb","line":149,"range":{"start_line":149,"start_character":26,"end_line":149,"end_character":52},"in_reply_to":"df140735_409a0e6e","updated":"2017-06-01 13:58:28.000000000","message":"right but we should have a spec test that properly exercises both the conditions for the if clause below which is easier when it\u0027s a param instead","commit_id":"8d0509748a7efd26d09d07941eae390e627d9c72"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"42620b71bc31e8a391f63daa60811be325259449","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        }"},{"line_number":147,"context_line":"      }"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"      $services_enabled \u003d hiera(\u0027service_names\u0027, [])"},{"line_number":150,"context_line":"      if !empty($migration_ssh_key) and \u0027sshd\u0027 in $services_enabled {"},{"line_number":151,"context_line":"        # Nova SSH tunnel setup (cold-migration)"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"df140735_409a0e6e","line":149,"range":{"start_line":149,"start_character":26,"end_line":149,"end_character":52},"in_reply_to":"df140735_5fdb111a","updated":"2017-06-01 13:52:05.000000000","message":"Maybe, but only really for spec tests. It\u0027s just there because we depend on the tripleo sshd service being included on the role too, and we don\u0027t have a way to declare service deps in t-h-t.","commit_id":"8d0509748a7efd26d09d07941eae390e627d9c72"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"c66383aaff193c14554c95e6ff08e4ba539f0e0a","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        }"},{"line_number":147,"context_line":"      }"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"      $services_enabled \u003d hiera(\u0027service_names\u0027, [])"},{"line_number":150,"context_line":"      if !empty($migration_ssh_key) and \u0027sshd\u0027 in $services_enabled {"},{"line_number":151,"context_line":"        # Nova SSH tunnel setup (cold-migration)"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"df140735_b4736fb1","line":149,"range":{"start_line":149,"start_character":26,"end_line":149,"end_character":52},"in_reply_to":"df140735_e08362cb","updated":"2017-06-01 14:11:24.000000000","message":"Logic doesn\u0027t work in any case as we noop the package resource unless it\u0027s a deployed server environment. Follow up in https://review.openstack.org/462720","commit_id":"8d0509748a7efd26d09d07941eae390e627d9c72"}]}