)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"414e62e6f625057669f3fe246fcafb09f61b1e07","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Pradeep Kilambi \u003cpkilambi@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-06-13 07:50:49 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move gnocchi upgrade and api to step 4"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If2ae48b21389e76fd638c0b48c148a5d4f227630"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"7f231b9d_a1722a48","line":7,"updated":"2017-06-13 12:58:17.000000000","message":"please take some time to write a commit message, that explain why we\u0027re doing this change.","commit_id":"d2ff3de230aa47bbaeab61bb67614775c2a42648"}],"manifests/profile/base/gnocchi/api.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7d7d5138ffb799edfd14cd06cde33b1cf86da782","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    class { \u0027::gnocchi::wsgi::apache\u0027:"},{"line_number":100,"context_line":"      ssl_cert \u003d\u003e $tls_certfile,"},{"line_number":101,"context_line":"      ssl_key  \u003d\u003e $tls_keyfile,"},{"line_number":102,"context_line":"    }"},{"line_number":103,"context_line":"  }"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"  if $step \u003e\u003d 4 {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"df140735_7814ca4e","line":102,"updated":"2017-05-31 16:07:25.000000000","message":"So here\u0027s the problem, the configuration needs to be in step 3 or during updates this gets unconfigured between step 3 and 4.  If gnocchi needs to be up after some other service that also resides within apache, gnocchi needs to handle that better or this cannot reside on the controlers.  Can we configure ::gnocchi::wsgi::apache in step3 but leave the rest in step4 maybe?","commit_id":"74bf41aa395fd3e652b857c9a1a1c3420cd0aa11"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"39d744ce4305f42f5081b42cb50140cddc9c1bee","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    class { \u0027::gnocchi::wsgi::apache\u0027:"},{"line_number":100,"context_line":"      ssl_cert \u003d\u003e $tls_certfile,"},{"line_number":101,"context_line":"      ssl_key  \u003d\u003e $tls_keyfile,"},{"line_number":102,"context_line":"    }"},{"line_number":103,"context_line":"  }"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"  if $step \u003e\u003d 4 {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"df140735_3b6accb2","line":102,"in_reply_to":"df140735_7814ca4e","updated":"2017-05-31 16:11:32.000000000","message":"So the part that gets unconfigured is just the wsgi::apache config part? if thats the only part then yea we could try that. We just need to ensure when gnocchi::api comes up live, the storage is configured and gnocchi-upgrade is run.","commit_id":"74bf41aa395fd3e652b857c9a1a1c3420cd0aa11"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"19574574266d928f9adde36aaf69255c4cc20686","unresolved":false,"context_lines":[{"line_number":106,"context_line":"      coordination_url \u003d\u003e join([\u0027redis://:\u0027, $gnocchi_redis_password, \u0027@\u0027, normalize_ip_for_uri($redis_vip), \u0027:6379/\u0027]),"},{"line_number":107,"context_line":"    }"},{"line_number":108,"context_line":"    case $gnocchi_backend {"},{"line_number":109,"context_line":"      \u0027swift\u0027: { include ::gnocchi::storage::swift }"},{"line_number":110,"context_line":"      \u0027file\u0027: { include ::gnocchi::storage::file }"},{"line_number":111,"context_line":"      \u0027rbd\u0027: { include ::gnocchi::storage::ceph }"},{"line_number":112,"context_line":"      default: { fail(\u0027Unrecognized gnocchi_backend parameter.\u0027) }"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7f231b9d_4ca5d503","line":109,"updated":"2017-06-13 09:22:32.000000000","message":"This might have issues when swift is ran. Cause if swift is not available and the db-sync takes place, it\u0027ll fail.","commit_id":"11babfff39e465d0f3e5b3a0846e96fd731a7a3b"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"4f6739b98126f5d7463bcb8d39e8e81422883362","unresolved":false,"context_lines":[{"line_number":106,"context_line":"      coordination_url \u003d\u003e join([\u0027redis://:\u0027, $gnocchi_redis_password, \u0027@\u0027, normalize_ip_for_uri($redis_vip), \u0027:6379/\u0027]),"},{"line_number":107,"context_line":"    }"},{"line_number":108,"context_line":"    case $gnocchi_backend {"},{"line_number":109,"context_line":"      \u0027swift\u0027: { include ::gnocchi::storage::swift }"},{"line_number":110,"context_line":"      \u0027file\u0027: { include ::gnocchi::storage::file }"},{"line_number":111,"context_line":"      \u0027rbd\u0027: { include ::gnocchi::storage::ceph }"},{"line_number":112,"context_line":"      default: { fail(\u0027Unrecognized gnocchi_backend parameter.\u0027) }"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7f231b9d_b5eb8cda","line":109,"in_reply_to":"7f231b9d_4ca5d503","updated":"2017-06-13 11:02:00.000000000","message":"This is precisely the issue i\u0027m trying to address. Currently swift comes up in step4, while gnocchi-upgrade runs in step 3. I moved upgrade to step4 as well. If there is a better way to handle this lemme know. I guess if both are at step4 swift could come up later? The problem is we can only move to step 4. If we move to step5 ceilometer will fail.","commit_id":"11babfff39e465d0f3e5b3a0846e96fd731a7a3b"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"27fad7498f4fae2bc17b774e656cdb494f749332","unresolved":false,"context_lines":[{"line_number":106,"context_line":"      coordination_url \u003d\u003e join([\u0027redis://:\u0027, $gnocchi_redis_password, \u0027@\u0027, normalize_ip_for_uri($redis_vip), \u0027:6379/\u0027]),"},{"line_number":107,"context_line":"    }"},{"line_number":108,"context_line":"    case $gnocchi_backend {"},{"line_number":109,"context_line":"      \u0027swift\u0027: { include ::gnocchi::storage::swift }"},{"line_number":110,"context_line":"      \u0027file\u0027: { include ::gnocchi::storage::file }"},{"line_number":111,"context_line":"      \u0027rbd\u0027: { include ::gnocchi::storage::ceph }"},{"line_number":112,"context_line":"      default: { fail(\u0027Unrecognized gnocchi_backend parameter.\u0027) }"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7f231b9d_15fa4074","line":109,"in_reply_to":"7f231b9d_b5eb8cda","updated":"2017-06-13 11:07:11.000000000","message":"In that case, you need to do:\n\n-      \u0027swift\u0027: { include ::gnocchi::storage::swift }\n+      \u0027swift\u0027: {\n+        include ::gnocchi::storage::swif:\n+        # db-sync will execute for the backend storage. So we need swift proxy\n+        # to be available at this point.\n+        Class\u003c| title \u003d\u003d \u0027::swift::proxy\u0027 |\u003e ~\u003e Class[\u0027Gnocchi::db::sync\u0027]\n+      }","commit_id":"11babfff39e465d0f3e5b3a0846e96fd731a7a3b"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"877650e94df0395f5d002b80b528f3350b7bbc71","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    case $gnocchi_backend {"},{"line_number":101,"context_line":"      \u0027swift\u0027: {"},{"line_number":102,"context_line":"        include ::gnocchi::storage::swift"},{"line_number":103,"context_line":"        include ::swift::deps"},{"line_number":104,"context_line":"        # Ensure we have swift proxy available before running gnocchi-upgrade"},{"line_number":105,"context_line":"        # as storage is initialized at this point."},{"line_number":106,"context_line":"        Anchor\u003c| title \u003d\u003d \u0027swift::service::end\u0027 |\u003e ~\u003e Class[\u0027Gnocchi::db::sync\u0027]"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"7f231b9d_a6b579cf","line":103,"range":{"start_line":103,"start_character":8,"end_line":103,"end_character":29},"updated":"2017-06-14 12:20:48.000000000","message":"would this be an issue for standalone node or container deployments?","commit_id":"1a7c1937db0988962813bd6a6d1feea69a3868f0"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"cfe6cd4f4aeedfb06ed7ecb99ce071b462c7af41","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    case $gnocchi_backend {"},{"line_number":101,"context_line":"      \u0027swift\u0027: {"},{"line_number":102,"context_line":"        include ::gnocchi::storage::swift"},{"line_number":103,"context_line":"        include ::swift::deps"},{"line_number":104,"context_line":"        # Ensure we have swift proxy available before running gnocchi-upgrade"},{"line_number":105,"context_line":"        # as storage is initialized at this point."},{"line_number":106,"context_line":"        Anchor\u003c| title \u003d\u003d \u0027swift::service::end\u0027 |\u003e ~\u003e Class[\u0027Gnocchi::db::sync\u0027]"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"7f231b9d_2c8f0776","line":103,"range":{"start_line":103,"start_character":8,"end_line":103,"end_character":29},"in_reply_to":"7f231b9d_a6b579cf","updated":"2017-06-14 14:33:11.000000000","message":"It\u0027s not an issue. It merely includes the anchors.","commit_id":"1a7c1937db0988962813bd6a6d1feea69a3868f0"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"ef221855257647ed0c50f42b8bbf3baab638b4e7","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    class { \u0027::gnocchi::wsgi::apache\u0027:"},{"line_number":115,"context_line":"      ssl_cert \u003d\u003e $tls_certfile,"},{"line_number":116,"context_line":"      ssl_key  \u003d\u003e $tls_keyfile,"},{"line_number":117,"context_line":"    }"},{"line_number":118,"context_line":"  }"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"7f231b9d_06eb0adc","line":117,"updated":"2017-06-14 13:36:30.000000000","message":"I dont think we want to move apache to step 4. That will cause restarts i believe. See comment from Alex.","commit_id":"1a7c1937db0988962813bd6a6d1feea69a3868f0"}]}