)]}'
{"manifests/profile/base/docker.pp":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"b2a3c0c4ea6beed67e3b5db10ef0b90c94a929e1","unresolved":false,"context_lines":[{"line_number":68,"context_line":"  $storage_options \u003d \u0027-s overlay2\u0027,"},{"line_number":69,"context_line":"  $step \u003d hiera(\u0027step\u0027),"},{"line_number":70,"context_line":"  $configure_libvirt_polkit \u003d undef,"},{"line_number":71,"context_line":"  $docker_nova_uid \u003d 42436,"},{"line_number":72,"context_line":"  $services_enabled \u003d hiera(\u0027service_names\u0027, [])"},{"line_number":73,"context_line":") {"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bf091321_bed28f33","line":71,"range":{"start_line":71,"start_character":21,"end_line":71,"end_character":26},"updated":"2017-06-08 08:32:42.000000000","message":"Hopefully this is stable enough, i don\u0027t think Kolla would have a reason to change this number.\n\nhttps://github.com/openstack/kolla/blob/87c2a058ebacc08c258e1aa98b59c838bec0c885/kolla/common/config.py#L759-L762","commit_id":"016cef3ea729e1e3aed948ff3d07d650a5d92884"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ea3c6a9080cdb0e5a8cfac3a891dbb01e2ae0172","unresolved":false,"context_lines":[{"line_number":169,"context_line":"      shell   \u003d\u003e \u0027/sbin/nologin\u0027,"},{"line_number":170,"context_line":"      comment \u003d\u003e \u0027OpenStack Nova Daemons\u0027,"},{"line_number":171,"context_line":"      groups  \u003d\u003e [\u0027nobody\u0027]"},{"line_number":172,"context_line":"    }"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    # Similar to the polkit rule in the openstack-nova rpm spec"},{"line_number":175,"context_line":"    # but allow both the \u0027docker_nova\u0027 and \u0027nova\u0027 user"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"df140735_175f0b0f","line":172,"updated":"2017-06-07 16:38:09.000000000","message":"Maybe we should create a openstack-nova-docker package with all these bits?  Seems like a better solution than doing it in puppet. We could also ensure the polkit with the package. It seems like a cleaner implementation.","commit_id":"016cef3ea729e1e3aed948ff3d07d650a5d92884"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"04aa2676daa898115cab3be2c3a90d275dd5ab71","unresolved":false,"context_lines":[{"line_number":169,"context_line":"      shell   \u003d\u003e \u0027/sbin/nologin\u0027,"},{"line_number":170,"context_line":"      comment \u003d\u003e \u0027OpenStack Nova Daemons\u0027,"},{"line_number":171,"context_line":"      groups  \u003d\u003e [\u0027nobody\u0027]"},{"line_number":172,"context_line":"    }"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    # Similar to the polkit rule in the openstack-nova rpm spec"},{"line_number":175,"context_line":"    # but allow both the \u0027docker_nova\u0027 and \u0027nova\u0027 user"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"df140735_37532fe5","line":172,"in_reply_to":"df140735_175f0b0f","updated":"2017-06-07 16:44:24.000000000","message":"Keep in mind this is a short term workaround to unlock live-migration. I\u0027m planning to refactor the packaging once the initial implementation lands (e.g split nova migration package into a client \u0026 target pkg).","commit_id":"016cef3ea729e1e3aed948ff3d07d650a5d92884"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"6e7f26bcd07346fe802e66c6adbf861d58dde643","unresolved":false,"context_lines":[{"line_number":169,"context_line":"      shell   \u003d\u003e \u0027/sbin/nologin\u0027,"},{"line_number":170,"context_line":"      comment \u003d\u003e \u0027OpenStack Nova Daemons\u0027,"},{"line_number":171,"context_line":"      groups  \u003d\u003e [\u0027nobody\u0027]"},{"line_number":172,"context_line":"    }"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    # Similar to the polkit rule in the openstack-nova rpm spec"},{"line_number":175,"context_line":"    # but allow both the \u0027docker_nova\u0027 and \u0027nova\u0027 user"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"df140735_37efafea","line":172,"in_reply_to":"df140735_37532fe5","updated":"2017-06-07 16:48:12.000000000","message":"good ol\u0027 tech debt. openstack-nova-migration-docker? :D  Are we going to be stuck with this work around past pike or is the hope to land it by M3?  If we aren\u0027t going to be able to land it by M3, i\u0027d rather have an openstack-nova-migration-docker package as I think the upgrade process would be better handled via packaging obsoletes then trying to undo the puppet bits later","commit_id":"016cef3ea729e1e3aed948ff3d07d650a5d92884"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"f7781b339138a1f13de5717cbd8541c70f41a665","unresolved":false,"context_lines":[{"line_number":169,"context_line":"      shell   \u003d\u003e \u0027/sbin/nologin\u0027,"},{"line_number":170,"context_line":"      comment \u003d\u003e \u0027OpenStack Nova Daemons\u0027,"},{"line_number":171,"context_line":"      groups  \u003d\u003e [\u0027nobody\u0027]"},{"line_number":172,"context_line":"    }"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    # Similar to the polkit rule in the openstack-nova rpm spec"},{"line_number":175,"context_line":"    # but allow both the \u0027docker_nova\u0027 and \u0027nova\u0027 user"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"df140735_72c1b580","line":172,"in_reply_to":"df140735_37efafea","updated":"2017-06-07 17:30:12.000000000","message":"raised https://bugs.launchpad.net/tripleo/+bug/1696504 to track this","commit_id":"016cef3ea729e1e3aed948ff3d07d650a5d92884"}]}