)]}'
{"manifests/profile/base/neutron/ovs.pp":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"af1d0bfa9b74d4ad656fff1e397866045cb86099","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        owner  \u003d\u003e \u0027qemu\u0027,"},{"line_number":42,"context_line":"        group  \u003d\u003e \u0027qemu\u0027,"},{"line_number":43,"context_line":"        mode   \u003d\u003e \u00270775\u0027,"},{"line_number":44,"context_line":"        before \u003d\u003e Exec[$vhostuser_socket_dir],"},{"line_number":45,"context_line":"      }"},{"line_number":46,"context_line":"      exec { $vhostuser_socket_dir:"},{"line_number":47,"context_line":"        command \u003d\u003e \"restorecon ${vhostuser_socket_dir}\","}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5f201791_ef71b8a9","line":44,"updated":"2017-06-27 15:37:23.000000000","message":"why not use notify here? does the same thing and will trigger a refresh as well.","commit_id":"96dd402b92a4f3c3a7686e473aa2cc8e8b20e914"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"5c39e9bc4880f927ff9d29db97d0323fabb6326a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"      }"},{"line_number":46,"context_line":"      exec { $vhostuser_socket_dir:"},{"line_number":47,"context_line":"        command \u003d\u003e \"restorecon ${vhostuser_socket_dir}\","},{"line_number":48,"context_line":"        path    \u003d\u003e [\u0027/sbin\u0027, \u0027/usr/sbin\u0027],"},{"line_number":49,"context_line":"      }"},{"line_number":50,"context_line":"    }"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5f201791_9cce0958","line":48,"updated":"2017-06-27 13:27:24.000000000","message":"do we want it refreshonly \u003d\u003e true perhaps? For idempotency sake.","commit_id":"96dd402b92a4f3c3a7686e473aa2cc8e8b20e914"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"af1d0bfa9b74d4ad656fff1e397866045cb86099","unresolved":false,"context_lines":[{"line_number":45,"context_line":"      }"},{"line_number":46,"context_line":"      exec { $vhostuser_socket_dir:"},{"line_number":47,"context_line":"        command \u003d\u003e \"restorecon ${vhostuser_socket_dir}\","},{"line_number":48,"context_line":"        path    \u003d\u003e [\u0027/sbin\u0027, \u0027/usr/sbin\u0027],"},{"line_number":49,"context_line":"      }"},{"line_number":50,"context_line":"    }"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5f201791_0f6f54c5","line":48,"in_reply_to":"5f201791_9cce0958","updated":"2017-06-27 15:37:23.000000000","message":"I agree.","commit_id":"96dd402b92a4f3c3a7686e473aa2cc8e8b20e914"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"b45dd72c56fd4791f26fb5a62e11a077405ca361","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        ensure \u003d\u003e directory,"},{"line_number":41,"context_line":"        owner  \u003d\u003e \u0027qemu\u0027,"},{"line_number":42,"context_line":"        group  \u003d\u003e \u0027qemu\u0027,"},{"line_number":43,"context_line":"        mode   \u003d\u003e \u00270775\u0027,"},{"line_number":44,"context_line":"      }"},{"line_number":45,"context_line":"      exec { $vhostuser_socket_dir:"},{"line_number":46,"context_line":"        command     \u003d\u003e \"restorecon ${vhostuser_socket_dir}\","}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5f201791_22b1e247","line":43,"updated":"2017-06-28 13:41:27.000000000","message":"I think we should rather use:\nhttps://docs.puppet.com/puppet/latest/type.html#file-attribute-selinux_ignore_defaults\n\nand set selinux_ignore_defaults to True. If SElinux already manage the label for this directory, Puppet will not try to override it.","commit_id":"8658381f27a526f3598778792b66af3610a944ae"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"08ddac95db293368f3396a7a60e2756fbbeae1aa","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        ensure \u003d\u003e directory,"},{"line_number":41,"context_line":"        owner  \u003d\u003e \u0027qemu\u0027,"},{"line_number":42,"context_line":"        group  \u003d\u003e \u0027qemu\u0027,"},{"line_number":43,"context_line":"        mode   \u003d\u003e \u00270775\u0027,"},{"line_number":44,"context_line":"      }"},{"line_number":45,"context_line":"      exec { $vhostuser_socket_dir:"},{"line_number":46,"context_line":"        command     \u003d\u003e \"restorecon ${vhostuser_socket_dir}\","}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3f1d235d_e3ff5c32","line":43,"in_reply_to":"5f201791_22b1e247","updated":"2017-06-29 08:08:51.000000000","message":"Thanks for the direction. After using the param  selinux_ignore_defaults \u003d\u003e false, it works for me. which turns out to be the default value. Hence this patch is not required. I\u0027ll abandon this patch.","commit_id":"8658381f27a526f3598778792b66af3610a944ae"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"b45dd72c56fd4791f26fb5a62e11a077405ca361","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        group  \u003d\u003e \u0027qemu\u0027,"},{"line_number":43,"context_line":"        mode   \u003d\u003e \u00270775\u0027,"},{"line_number":44,"context_line":"      }"},{"line_number":45,"context_line":"      exec { $vhostuser_socket_dir:"},{"line_number":46,"context_line":"        command     \u003d\u003e \"restorecon ${vhostuser_socket_dir}\","},{"line_number":47,"context_line":"        path        \u003d\u003e [\u0027/sbin\u0027, \u0027/usr/sbin\u0027],"},{"line_number":48,"context_line":"        subscribe   \u003d\u003e File[$vhostuser_socket_dir],"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5f201791_02aca6ea","line":45,"updated":"2017-06-28 13:41:27.000000000","message":"Remove this hack please.","commit_id":"8658381f27a526f3598778792b66af3610a944ae"}]}