)]}'
{"manifests/haproxy/endpoint.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c7d306d0605874cc4f4a352dbb56ee11727ca950","unresolved":false,"context_lines":[{"line_number":104,"context_line":"  $internal_certificates_specs \u003d {},"},{"line_number":105,"context_line":"  $service_network             \u003d undef,"},{"line_number":106,"context_line":") {"},{"line_number":107,"context_line":"  # if containerized, do not configure firewall during the docker-puppet step"},{"line_number":108,"context_line":"  if $::uuid \u003d\u003d \u0027docker\u0027 and hiera(\u0027step\u0027, 0) \u003e 2 {"},{"line_number":109,"context_line":"    $manage_firewall \u003d false"},{"line_number":110,"context_line":"  } else {"},{"line_number":111,"context_line":"    $manage_firewall \u003d hiera(\u0027tripleo::firewall::manage_firewall\u0027, true)"},{"line_number":112,"context_line":"  }"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"  if $public_virtual_ip {"},{"line_number":115,"context_line":"    # service exposed to the public network"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ff346bd7_e172b0e3","line":112,"range":{"start_line":107,"start_character":0,"end_line":112,"end_character":3},"updated":"2017-07-21 21:14:06.000000000","message":"Rather than put this in this class, let\u0027s make this a parameter and update the calling classes to pass in $manage_firewall with this logic. I think it\u0027s all handled in haproxy.pp.  I actually don\u0027t like the current structure of haproxy.pp but i think this belongs only there and this shouldn\u0027t have hiera lookups in it.","commit_id":"490ec551811a79f5a83241b362ee7316791fd8cc"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"eb78e02ba0ca88408e8babe40c16d6c454b778ad","unresolved":false,"context_lines":[{"line_number":104,"context_line":"  $internal_certificates_specs \u003d {},"},{"line_number":105,"context_line":"  $service_network             \u003d undef,"},{"line_number":106,"context_line":") {"},{"line_number":107,"context_line":"  # if containerized, do not configure firewall during the docker-puppet step"},{"line_number":108,"context_line":"  if $::uuid \u003d\u003d \u0027docker\u0027 and hiera(\u0027step\u0027, 0) \u003e 2 {"},{"line_number":109,"context_line":"    $manage_firewall \u003d false"},{"line_number":110,"context_line":"  } else {"},{"line_number":111,"context_line":"    $manage_firewall \u003d hiera(\u0027tripleo::firewall::manage_firewall\u0027, true)"},{"line_number":112,"context_line":"  }"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"  if $public_virtual_ip {"},{"line_number":115,"context_line":"    # service exposed to the public network"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ff346bd7_b2802a8d","line":112,"range":{"start_line":107,"start_character":0,"end_line":112,"end_character":3},"in_reply_to":"ff346bd7_6c9b09c9","updated":"2017-07-25 13:46:12.000000000","message":"Yea the problem is that this isn\u0027t actually a profile. Neither is the tripleo::haproxy class.  But the tripleo::haproxy class is basically the haproxy profile just not properly structured and is already full of hiera calls. This is something that is a helper class so the manage_firewall should just be a param","commit_id":"490ec551811a79f5a83241b362ee7316791fd8cc"},{"author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"change_message_id":"798273f80aaa9747725aab13a1bd37015372d719","unresolved":false,"context_lines":[{"line_number":104,"context_line":"  $internal_certificates_specs \u003d {},"},{"line_number":105,"context_line":"  $service_network             \u003d undef,"},{"line_number":106,"context_line":") {"},{"line_number":107,"context_line":"  # if containerized, do not configure firewall during the docker-puppet step"},{"line_number":108,"context_line":"  if $::uuid \u003d\u003d \u0027docker\u0027 and hiera(\u0027step\u0027, 0) \u003e 2 {"},{"line_number":109,"context_line":"    $manage_firewall \u003d false"},{"line_number":110,"context_line":"  } else {"},{"line_number":111,"context_line":"    $manage_firewall \u003d hiera(\u0027tripleo::firewall::manage_firewall\u0027, true)"},{"line_number":112,"context_line":"  }"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"  if $public_virtual_ip {"},{"line_number":115,"context_line":"    # service exposed to the public network"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ff346bd7_6c9b09c9","line":112,"range":{"start_line":107,"start_character":0,"end_line":112,"end_character":3},"in_reply_to":"ff346bd7_e172b0e3","updated":"2017-07-25 12:38:53.000000000","message":"Ack, I exposed that manage_firewall flag as argument in every impacted profile.\n\nThe intent of the call is now clearer in the associated yaml service file: https://review.openstack.org/#/c/474183/3/docker/services/haproxy.yaml","commit_id":"490ec551811a79f5a83241b362ee7316791fd8cc"}]}