)]}'
{"manifests/haproxy.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"1de528177d7674d932b0d6f4c57dcb7878fbfbbd","unresolved":false,"context_lines":[{"line_number":281,"context_line":"#  Defaults to hiera(\u0027ironic_inspector_enabled\u0027, false)"},{"line_number":282,"context_line":"#"},{"line_number":283,"context_line":"# [*octavia*]"},{"line_number":284,"context_line":"#  (optional) Enable or not Octavia APII binding"},{"line_number":285,"context_line":"#  Defaults to hiera(\u0027octavia_api_enabled\u0027, false)"},{"line_number":286,"context_line":"#"},{"line_number":287,"context_line":"# [*mysql*]"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bf3e73b7_99735f4e","line":284,"updated":"2017-08-04 22:46:03.000000000","message":"nit: API","commit_id":"4082ec3f246493d2dccc64bc7ec2c6d72ff5cb8b"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"c83f764a117370d206cebd25b732777fe54d4228","unresolved":false,"context_lines":[{"line_number":476,"context_line":"#  Defaults to hiera(\u0027etcd_network\u0027, undef)"},{"line_number":477,"context_line":"#"},{"line_number":478,"context_line":"# [*octavia_network*]"},{"line_number":479,"context_line":"#  (optional) Specify the network octavia is running on.  "},{"line_number":480,"context_line":"#  Defaults to hiera(\u0027octavia_api_network\u0027, undef)"},{"line_number":481,"context_line":"#"},{"line_number":482,"context_line":"# [*opendaylight_network*]"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3f4b6375_9d0c5343","line":479,"updated":"2017-10-30 13:21:29.000000000","message":"whitespace","commit_id":"f7af90b6cb4e674ecae034587408ef670fc06ec8"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"c83f764a117370d206cebd25b732777fe54d4228","unresolved":false,"context_lines":[{"line_number":1510,"context_line":"      mode           \u003d\u003e \u0027http\u0027,"},{"line_number":1511,"context_line":"      listen_options \u003d\u003e {"},{"line_number":1512,"context_line":"        \u0027balance\u0027 \u003d\u003e \u0027source\u0027,"},{"line_number":1513,"context_line":"      },"},{"line_number":1514,"context_line":"    }"},{"line_number":1515,"context_line":"  }"},{"line_number":1516,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3f4b6375_af07d618","line":1513,"updated":"2017-10-30 13:21:29.000000000","message":"Note that the way you have this set up right now will only enable octavia in the internal network. Do you need it in the external network as well?","commit_id":"f7af90b6cb4e674ecae034587408ef670fc06ec8"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"529b33d2295d10e670cce9ad4248a7ce8d2c9b28","unresolved":false,"context_lines":[{"line_number":1508,"context_line":"      public_virtual_ip \u003d\u003e $public_virtual_ip,"},{"line_number":1509,"context_line":"      internal_ip       \u003d\u003e unique([hiera(\u0027octavia_api_vip\u0027, $controller_virtual_ip), $controller_virtual_ip]),"},{"line_number":1510,"context_line":"      service_port      \u003d\u003e $ports[octavia_api_port],"},{"line_number":1511,"context_line":"      ip_addresses      \u003d\u003e hiera(\u0027octavia_api_node_ips\u0027, $controller_hosts_real),"},{"line_number":1512,"context_line":"      server_names      \u003d\u003e hiera(\u0027octavia_api_node_names\u0027, $controller_hosts_names_real),"},{"line_number":1513,"context_line":"      public_ssl_port   \u003d\u003e $ports[octavia_api_ssl_port],"},{"line_number":1514,"context_line":"      service_network   \u003d\u003e $octavia_network,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3f4b6375_740c0942","line":1511,"range":{"start_line":1511,"start_character":58,"end_line":1511,"end_character":79},"updated":"2017-10-30 17:29:57.000000000","message":"I know this is replicating the same pattern from previous services, but I wonder if we should remove this - the service_name_ips hiera should always be set provided the service is added to the ServiceNetMap or ServiceNetMapDefaults, but in the case where that is forgotten, we\u0027ll wire in the controller host IPs regardless of what roles the service is actually running on?","commit_id":"a449726b83769779474ebd712ec1392fe9446887"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"16de6a0748da36d88416ad3460fc6be7dfd11af8","unresolved":false,"context_lines":[{"line_number":1508,"context_line":"      public_virtual_ip \u003d\u003e $public_virtual_ip,"},{"line_number":1509,"context_line":"      internal_ip       \u003d\u003e unique([hiera(\u0027octavia_api_vip\u0027, $controller_virtual_ip), $controller_virtual_ip]),"},{"line_number":1510,"context_line":"      service_port      \u003d\u003e $ports[octavia_api_port],"},{"line_number":1511,"context_line":"      ip_addresses      \u003d\u003e hiera(\u0027octavia_api_node_ips\u0027, $controller_hosts_real),"},{"line_number":1512,"context_line":"      server_names      \u003d\u003e hiera(\u0027octavia_api_node_names\u0027, $controller_hosts_names_real),"},{"line_number":1513,"context_line":"      public_ssl_port   \u003d\u003e $ports[octavia_api_ssl_port],"},{"line_number":1514,"context_line":"      service_network   \u003d\u003e $octavia_network,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3f4b6375_ba46eb20","line":1511,"range":{"start_line":1511,"start_character":58,"end_line":1511,"end_character":79},"in_reply_to":"3f4b6375_740c0942","updated":"2017-10-30 17:36:16.000000000","message":"I think this is the case where it\u0027s ran in the undercloud via instack-undercloud. But yeah, I don\u0027t think we need this here.","commit_id":"a449726b83769779474ebd712ec1392fe9446887"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"60140ac5806a668d54fd27b40756083624deb99c","unresolved":false,"context_lines":[{"line_number":476,"context_line":"#  Defaults to hiera(\u0027etcd_network\u0027, undef)"},{"line_number":477,"context_line":"#"},{"line_number":478,"context_line":"# [*octavia_network*]"},{"line_number":479,"context_line":"#  (optional) Specify the network octavia is running on.  "},{"line_number":480,"context_line":"#  Defaults to hiera(\u0027octavia_api_network\u0027, undef)"},{"line_number":481,"context_line":"#"},{"line_number":482,"context_line":"# [*opendaylight_network*]"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3f4b6375_361f9d71","line":479,"range":{"start_line":479,"start_character":56,"end_line":479,"end_character":58},"updated":"2017-10-31 12:06:43.000000000","message":"trailing whitespace","commit_id":"9f6d2d77a7f439e6b1ee2c54c9f7e5f87fe416ba"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"cac898e6adf9c3672fcb45bca96d61b5e5e7dfc0","unresolved":false,"context_lines":[{"line_number":1506,"context_line":"  if $octavia {"},{"line_number":1507,"context_line":"    ::tripleo::haproxy::endpoint { \u0027octavia\u0027:"},{"line_number":1508,"context_line":"      public_virtual_ip \u003d\u003e $public_virtual_ip,"},{"line_number":1509,"context_line":"      internal_ip       \u003d\u003e unique([hiera(\u0027octavia_api_vip\u0027, $controller_virtual_ip), $controller_virtual_ip]),"},{"line_number":1510,"context_line":"      service_port      \u003d\u003e $ports[octavia_api_port],"},{"line_number":1511,"context_line":"      ip_addresses      \u003d\u003e hiera(\u0027octavia_api_node_ips\u0027),"},{"line_number":1512,"context_line":"      server_names      \u003d\u003e hiera(\u0027octavia_api_node_names\u0027),"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3f4b6375_0cf374a0","line":1509,"updated":"2017-10-31 13:13:22.000000000","message":"I think all you would need is:\n\nhiera(\u0027octavia_api_vip\u0027)","commit_id":"9f6d2d77a7f439e6b1ee2c54c9f7e5f87fe416ba"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"89235e15341f91e0451cdc8748a7c3495b7e6086","unresolved":false,"context_lines":[{"line_number":1529,"context_line":"      server_names      \u003d\u003e hiera(\u0027octavia_api_node_names\u0027),"},{"line_number":1530,"context_line":"      public_ssl_port   \u003d\u003e $ports[octavia_api_ssl_port],"},{"line_number":1531,"context_line":"      service_network   \u003d\u003e $octavia_network,"},{"line_number":1532,"context_line":"      listen_options    \u003d\u003e {"},{"line_number":1533,"context_line":"        \u0027balance\u0027 \u003d\u003e \u0027source\u0027,"},{"line_number":1534,"context_line":"      },"},{"line_number":1535,"context_line":"    }"},{"line_number":1536,"context_line":"  }"},{"line_number":1537,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":7,"id":"ff82abbf_fe278811","line":1534,"range":{"start_line":1532,"start_character":0,"end_line":1534,"end_character":8},"updated":"2017-11-22 21:04:51.000000000","message":"So this overwrites the default listen options. I think it should be merge($default_listen_options, { \u0027balance\u0027 \u003d\u003e \u0027source\u0027 }). Do you actually need source loadbalancing or did you copy/paste from opendaylight?","commit_id":"8671d25c57ff609ce046addc4988cec27dc50e25"},{"author":{"_account_id":18746,"name":"Alex Stafeyev","email":"alexo101087@gmail.com","username":"AlexSTafeyev"},"change_message_id":"c3c89a7ce6ed22cf1129586228001e9ee4bbd710","unresolved":false,"context_lines":[{"line_number":294,"context_line":"#  Defaults to hiera(\u0027kubernetes_master_enabled\u0027, false)"},{"line_number":295,"context_line":"#"},{"line_number":296,"context_line":"# [*octavia*]"},{"line_number":297,"context_line":"#  (optional) Enable or not Octavia APII binding"},{"line_number":298,"context_line":"#  Defaults to hiera(\u0027octavia_api_enabled\u0027, false)"},{"line_number":299,"context_line":"#"},{"line_number":300,"context_line":"# [*mysql*]"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3fa0c359_90898f27","line":297,"range":{"start_line":297,"start_character":38,"end_line":297,"end_character":40},"updated":"2018-02-19 07:10:52.000000000","message":"Should be double I ?","commit_id":"c410f608cab1ed2199ba8a8c90621127a1efda5d"}]}
