)]}'
{"manifests/certmonger/haproxy.pp":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"9e53f032da0bf1b8452618f27cacdca0be3a5733","unresolved":false,"context_lines":[{"line_number":94,"context_line":"      group  \u003d\u003e \u0027haproxy\u0027,"},{"line_number":95,"context_line":"      tag    \u003d\u003e \u0027haproxy-cert\u0027,"},{"line_number":96,"context_line":"    }"},{"line_number":97,"context_line":"    Package\u003c| name \u003d\u003d $::haproxy::params::package_name |\u003e -\u003e Concat[$service_pem]"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    concat::fragment { \"${title}-cert-fragment\":"},{"line_number":100,"context_line":"      target  \u003d\u003e $service_pem,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9f436f4f_69d7c925","line":97,"range":{"start_line":97,"start_character":57,"end_line":97,"end_character":60},"updated":"2017-08-08 07:04:29.000000000","message":"this part is clear enough (but why do we need to move it, result is the same no?)","commit_id":"6fb85879090f36f23e3693b4a5f3c3971046a250"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"7c57032cfa441611b15ee9e4651870b9b91fb3d7","unresolved":false,"context_lines":[{"line_number":94,"context_line":"      group  \u003d\u003e \u0027haproxy\u0027,"},{"line_number":95,"context_line":"      tag    \u003d\u003e \u0027haproxy-cert\u0027,"},{"line_number":96,"context_line":"    }"},{"line_number":97,"context_line":"    Package\u003c| name \u003d\u003d $::haproxy::params::package_name |\u003e -\u003e Concat[$service_pem]"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    concat::fragment { \"${title}-cert-fragment\":"},{"line_number":100,"context_line":"      target  \u003d\u003e $service_pem,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9f436f4f_f83700e3","line":97,"range":{"start_line":97,"start_character":57,"end_line":97,"end_character":60},"in_reply_to":"9f436f4f_69d7c925","updated":"2017-08-08 08:12:35.000000000","message":"Cause now we\u0027re using a resource collector (the \u003c| |\u003e ) notation. And before it actually required the class to be in the catalog. This has the effect that it makes this dependency kinda optional.\n\nIf the haproxy package is in the resource catalog, then do that (install) before the concat is done. Else, no biggie.","commit_id":"6fb85879090f36f23e3693b4a5f3c3971046a250"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"927ca53bb85c54fdf5c21c208260cdcd2bd5b36c","unresolved":false,"context_lines":[{"line_number":94,"context_line":"      group  \u003d\u003e \u0027haproxy\u0027,"},{"line_number":95,"context_line":"      tag    \u003d\u003e \u0027haproxy-cert\u0027,"},{"line_number":96,"context_line":"    }"},{"line_number":97,"context_line":"    Package\u003c| name \u003d\u003d $::haproxy::params::package_name |\u003e -\u003e Concat[$service_pem]"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    concat::fragment { \"${title}-cert-fragment\":"},{"line_number":100,"context_line":"      target  \u003d\u003e $service_pem,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9f436f4f_7403fd43","line":97,"range":{"start_line":97,"start_character":57,"end_line":97,"end_character":60},"in_reply_to":"9f436f4f_f83700e3","updated":"2017-08-09 06:48:15.000000000","message":"thanks jaosorior","commit_id":"6fb85879090f36f23e3693b4a5f3c3971046a250"}],"manifests/profile/base/certmonger_user.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"99ef596035ec0eab00888e19b5b603e2c79c6f8a","unresolved":false,"context_lines":[{"line_number":80,"context_line":"  unless empty($haproxy_certificates_specs) {"},{"line_number":81,"context_line":"    $reload_haproxy \u003d [\u0027systemctl reload haproxy\u0027]"},{"line_number":82,"context_line":"    Class[\u0027::tripleo::certmonger::ca::crl\u0027] ~\u003e Haproxy::Balancermember\u003c||\u003e"},{"line_number":83,"context_line":"    if defined(Class[\u0027::haproxy\u0027]) {"},{"line_number":84,"context_line":"      Class[\u0027::tripleo::certmonger::ca::crl\u0027] ~\u003e Class[\u0027::haproxy\u0027]"},{"line_number":85,"context_line":"    }"},{"line_number":86,"context_line":"  } else {"},{"line_number":87,"context_line":"    $reload_haproxy \u003d []"},{"line_number":88,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bf3e73b7_001912d6","line":85,"range":{"start_line":83,"start_character":0,"end_line":85,"end_character":5},"updated":"2017-08-07 15:01:26.000000000","message":"The dangers of this defined is that we\u0027d need to ensure that ::haproxy is declared before this because I think depending on the load ordering this might not be included even if declared in the manifest.  I guess this is just a word of warning. Something like would have to live in THT to do this without the defined but that seems to be really complex","commit_id":"6fb85879090f36f23e3693b4a5f3c3971046a250"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"9e53f032da0bf1b8452618f27cacdca0be3a5733","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  class { \u0027::tripleo::certmonger::ca::crl\u0027 :"},{"line_number":90,"context_line":"    reload_cmds \u003d\u003e $reload_haproxy,"},{"line_number":91,"context_line":"  }"},{"line_number":92,"context_line":"  Certmonger_certificate\u003c||\u003e -\u003e Class[\u0027::tripleo::certmonger::ca::crl\u0027]"},{"line_number":93,"context_line":"  include ::tripleo::certmonger::ca::libvirt"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"  unless empty($apache_certificates_specs) {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9f436f4f_e9cbb96f","line":92,"range":{"start_line":92,"start_character":24,"end_line":92,"end_character":33},"updated":"2017-08-08 07:04:29.000000000","message":"why is this one necessary then (refresh crl after the certificates are generated too?)","commit_id":"6fb85879090f36f23e3693b4a5f3c3971046a250"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"927ca53bb85c54fdf5c21c208260cdcd2bd5b36c","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  class { \u0027::tripleo::certmonger::ca::crl\u0027 :"},{"line_number":90,"context_line":"    reload_cmds \u003d\u003e $reload_haproxy,"},{"line_number":91,"context_line":"  }"},{"line_number":92,"context_line":"  Certmonger_certificate\u003c||\u003e -\u003e Class[\u0027::tripleo::certmonger::ca::crl\u0027]"},{"line_number":93,"context_line":"  include ::tripleo::certmonger::ca::libvirt"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"  unless empty($apache_certificates_specs) {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9f436f4f_f4948dea","line":92,"range":{"start_line":92,"start_character":24,"end_line":92,"end_character":33},"in_reply_to":"9f436f4f_7851d00e","updated":"2017-08-09 06:48:15.000000000","message":"thanks for the explanation","commit_id":"6fb85879090f36f23e3693b4a5f3c3971046a250"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"7c57032cfa441611b15ee9e4651870b9b91fb3d7","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  class { \u0027::tripleo::certmonger::ca::crl\u0027 :"},{"line_number":90,"context_line":"    reload_cmds \u003d\u003e $reload_haproxy,"},{"line_number":91,"context_line":"  }"},{"line_number":92,"context_line":"  Certmonger_certificate\u003c||\u003e -\u003e Class[\u0027::tripleo::certmonger::ca::crl\u0027]"},{"line_number":93,"context_line":"  include ::tripleo::certmonger::ca::libvirt"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"  unless empty($apache_certificates_specs) {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9f436f4f_7851d00e","line":92,"range":{"start_line":92,"start_character":24,"end_line":92,"end_character":33},"in_reply_to":"9f436f4f_e9cbb96f","updated":"2017-08-08 08:12:35.000000000","message":"It\u0027s actually not fuuuully necessary. Just thought it would be better to define some sort of order, since getting the CRL is quite expensive (a very big file) so might as well not do it at the same time. as to not overload the FreeIPA server (or whatever other CA is being used)","commit_id":"6fb85879090f36f23e3693b4a5f3c3971046a250"}]}