)]}'
{"manifests/profile/base/docker.pp":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"0cce0c4334e3b3d42aba914730d6d571b0256367","unresolved":false,"context_lines":[{"line_number":66,"context_line":"  $docker_options \u003d \u0027--log-driver\u003djournald --signature-verification\u003dfalse --iptables\u003dfalse\u0027,"},{"line_number":67,"context_line":"  $configure_storage \u003d true,"},{"line_number":68,"context_line":"  $storage_options \u003d \u0027-s overlay2\u0027,"},{"line_number":69,"context_line":"  $step \u003d 1,"},{"line_number":70,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":71,"context_line":"  $insecure_registry_address \u003d undef,"},{"line_number":72,"context_line":"  $docker_namespace \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9f436f4f_5b11cf5c","line":69,"range":{"start_line":69,"start_character":2,"end_line":69,"end_character":12},"updated":"2017-08-14 11:02:24.000000000","message":"Seems like this shouldn\u0027t be here.","commit_id":"a34596c3f9964d06bd9350f6a5622423eeb5362b"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"7bb1b288d51ef198bea286a35870eb2926e849b0","unresolved":false,"context_lines":[{"line_number":66,"context_line":"  $docker_options \u003d \u0027--log-driver\u003djournald --signature-verification\u003dfalse --iptables\u003dfalse\u0027,"},{"line_number":67,"context_line":"  $configure_storage \u003d true,"},{"line_number":68,"context_line":"  $storage_options \u003d \u0027-s overlay2\u0027,"},{"line_number":69,"context_line":"  $step \u003d 1,"},{"line_number":70,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":71,"context_line":"  $insecure_registry_address \u003d undef,"},{"line_number":72,"context_line":"  $docker_namespace \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9f436f4f_83b64edc","line":69,"range":{"start_line":69,"start_character":2,"end_line":69,"end_character":12},"in_reply_to":"9f436f4f_5b11cf5c","updated":"2017-08-17 14:56:12.000000000","message":"Ah right i needed to add this locally to get the specs running (probably Ruby/Puppet version issue on my env), and then i forgot it there... Thanks!","commit_id":"a34596c3f9964d06bd9350f6a5622423eeb5362b"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"97f84dbcae89fa792260e36de3a539150dcebd2e","unresolved":false,"context_lines":[{"line_number":110,"context_line":"      $registry_changes \u003d [ \"set INSECURE_REGISTRY \u0027\\\"--insecure-registry ${insecure_registry_address}\\\"\u0027\" ]"},{"line_number":111,"context_line":"    } elsif $insecure_registries {"},{"line_number":112,"context_line":"      $registry_changes \u003d [ join([\u0027set INSECURE_REGISTRY \\\u0027\"--insecure-registry \u0027,"},{"line_number":113,"context_line":"                                  join($insecure_registries, \" --insecure-registry \"),"},{"line_number":114,"context_line":"                                  \u0027\"\\\u0027\u0027], \u0027\u0027) ]"},{"line_number":115,"context_line":"    } else {"},{"line_number":116,"context_line":"      $registry_changes \u003d [ \u0027rm INSECURE_REGISTRY\u0027 ]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9f436f4f_cfd1a7cf","line":113,"range":{"start_line":113,"start_character":61,"end_line":113,"end_character":84},"updated":"2017-08-11 12:09:01.000000000","message":"this makes puppet-lint fail:\n\nhttp://logs.openstack.org/12/492612/2/check/gate-puppet-tripleo-puppet-lint/ece4be2/console.html#_2017-08-11_10_26_26_284294","commit_id":"a34596c3f9964d06bd9350f6a5622423eeb5362b"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"7bb1b288d51ef198bea286a35870eb2926e849b0","unresolved":false,"context_lines":[{"line_number":110,"context_line":"      $registry_changes \u003d [ \"set INSECURE_REGISTRY \u0027\\\"--insecure-registry ${insecure_registry_address}\\\"\u0027\" ]"},{"line_number":111,"context_line":"    } elsif $insecure_registries {"},{"line_number":112,"context_line":"      $registry_changes \u003d [ join([\u0027set INSECURE_REGISTRY \\\u0027\"--insecure-registry \u0027,"},{"line_number":113,"context_line":"                                  join($insecure_registries, \" --insecure-registry \"),"},{"line_number":114,"context_line":"                                  \u0027\"\\\u0027\u0027], \u0027\u0027) ]"},{"line_number":115,"context_line":"    } else {"},{"line_number":116,"context_line":"      $registry_changes \u003d [ \u0027rm INSECURE_REGISTRY\u0027 ]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9f436f4f_2338c23b","line":113,"range":{"start_line":113,"start_character":61,"end_line":113,"end_character":84},"in_reply_to":"9f436f4f_cfd1a7cf","updated":"2017-08-17 14:56:12.000000000","message":"Ack, thanks!","commit_id":"a34596c3f9964d06bd9350f6a5622423eeb5362b"}],"spec/classes/tripleo_profile_base_docker_spec.rb":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"14c9a4a637a5e57713140cd0cb41e2b1b06e8b85","unresolved":false,"context_lines":[{"line_number":72,"context_line":"      it_raises \u0027a Puppet::Error\u0027, /You must provide a \\$docker_namespace in order to configure insecure registry/"},{"line_number":73,"context_line":"    end"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    context \u0027with step 1 and insecure_registry configured but no docker_namespace\u0027 do"},{"line_number":76,"context_line":"      let(:params) { {"},{"line_number":77,"context_line":"          :insecure_registry \u003d\u003e true,"},{"line_number":78,"context_line":"          :step              \u003d\u003e 1,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9f436f4f_f13b37e8","line":75,"updated":"2017-08-11 08:37:59.000000000","message":"Could you please keep the \u0027with step 1 and registry_mirror configured\u0027 test intact?","commit_id":"c74a031832548db559cfd0b232d173b2125f5b68"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"b7dc4fff4c7265a7ae04f2ff8cbb4cb88d572502","unresolved":false,"context_lines":[{"line_number":72,"context_line":"      it_raises \u0027a Puppet::Error\u0027, /You must provide a \\$docker_namespace in order to configure insecure registry/"},{"line_number":73,"context_line":"    end"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    context \u0027with step 1 and insecure_registry configured but no docker_namespace\u0027 do"},{"line_number":76,"context_line":"      let(:params) { {"},{"line_number":77,"context_line":"          :insecure_registry \u003d\u003e true,"},{"line_number":78,"context_line":"          :step              \u003d\u003e 1,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9f436f4f_5850e35d","line":75,"in_reply_to":"9f436f4f_f13b37e8","updated":"2017-08-11 09:26:34.000000000","message":"Ouch! I meant to copy it, not replace it :))","commit_id":"c74a031832548db559cfd0b232d173b2125f5b68"}]}
