)]}'
{"files/stunnel.service":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"94362f095b0ccef71c44aeb8f074f2b65039387b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"Description\u003dSSL tunnel for network daemons"},{"line_number":3,"context_line":"After\u003dnetwork.target"},{"line_number":4,"context_line":"After\u003dsyslog.target"},{"line_number":5,"context_line":" "},{"line_number":6,"context_line":"[Install]"},{"line_number":7,"context_line":"WantedBy\u003dmulti-user.target"},{"line_number":8,"context_line":"Alias\u003dstunnel.target"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"7f287b81_d4228601","line":5,"updated":"2017-08-24 14:56:18.000000000","message":"ah the empty spaces","commit_id":"8b8a402c0222d028fbb5a255d0569c55b7ce94c2"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"5922001a4763cffdfee287507c281970ddb72832","unresolved":false,"context_lines":[{"line_number":16,"context_line":"TimeoutSec\u003d600"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Restart\u003dalways"},{"line_number":19,"context_line":"PrivateTmp\u003dfalse"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"7f287b81_41dfae0c","line":19,"updated":"2017-08-28 11:05:45.000000000","message":"Indeed there\u0027s no service file in the RPM on CentOS. But there is one on Fedora, so hopefully CentOS will get it too at some point.","commit_id":"f85199c77826017e383534051ada57ef1ea4ddcc"}],"manifests/stunnel.pp":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"94362f095b0ccef71c44aeb8f074f2b65039387b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  $manage_service \u003d true,"},{"line_number":30,"context_line":"  $service_ensure \u003d \u0027running\u0027,"},{"line_number":31,"context_line":"){"},{"line_number":32,"context_line":"  package { \u0027stunnel\u0027:"},{"line_number":33,"context_line":"    ensure \u003d\u003e \u0027present\u0027"},{"line_number":34,"context_line":"  }"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7f287b81_d4672651","line":32,"updated":"2017-08-24 14:56:18.000000000","message":"not sure we want to do this in tripleo","commit_id":"8b8a402c0222d028fbb5a255d0569c55b7ce94c2"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"a0fec17ffaf565b34f48122a53407777d2937de4","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  $manage_service \u003d true,"},{"line_number":30,"context_line":"  $service_ensure \u003d \u0027running\u0027,"},{"line_number":31,"context_line":"){"},{"line_number":32,"context_line":"  package { \u0027stunnel\u0027:"},{"line_number":33,"context_line":"    ensure \u003d\u003e \u0027present\u0027"},{"line_number":34,"context_line":"  }"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7f287b81_f9120709","line":32,"in_reply_to":"7f287b81_d4672651","updated":"2017-08-25 04:56:18.000000000","message":"It\u0027s being done anyway by the regular puppet manifests. It\u0027ll just get ignored in a regular deployment.","commit_id":"8b8a402c0222d028fbb5a255d0569c55b7ce94c2"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"1830cb352db6767a2562a6c2219b9619a918807a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"#   container."},{"line_number":32,"context_line":"#   Defaults to \u0027no\u0027"},{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"class tripleo::stunnel ("},{"line_number":35,"context_line":"  $manage_service \u003d true,"},{"line_number":36,"context_line":"  $service_ensure \u003d \u0027running\u0027,"},{"line_number":37,"context_line":"  $foreground     \u003d \u0027no\u0027,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7f287b81_cfb3cf97","line":34,"range":{"start_line":34,"start_character":6,"end_line":34,"end_character":22},"updated":"2017-08-28 07:12:37.000000000","message":"is there an existing tht review for this? I don\u0027t get anything grepping for stunnel on master","commit_id":"f85199c77826017e383534051ada57ef1ea4ddcc"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"dfdb1fc9a0bc4658b32c75881374913629082105","unresolved":false,"context_lines":[{"line_number":31,"context_line":"#   container."},{"line_number":32,"context_line":"#   Defaults to \u0027no\u0027"},{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"class tripleo::stunnel ("},{"line_number":35,"context_line":"  $manage_service \u003d true,"},{"line_number":36,"context_line":"  $service_ensure \u003d \u0027running\u0027,"},{"line_number":37,"context_line":"  $foreground     \u003d \u0027no\u0027,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7f287b81_8f7ee7ac","line":34,"range":{"start_line":34,"start_character":6,"end_line":34,"end_character":22},"in_reply_to":"7f287b81_cfb3cf97","updated":"2017-08-28 07:13:51.000000000","message":"yep, \"Related changes\" points to it. It\u0027s this one: https://review.openstack.org/#/c/496616/","commit_id":"f85199c77826017e383534051ada57ef1ea4ddcc"}],"manifests/stunnel/service_proxy.pp":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"626f6ae2d2c9a5ca3ad1d28eca0be8458fefda11","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  concat::fragment { \"stunnel-service-${name}\":"},{"line_number":55,"context_line":"    target   \u003d\u003e \u0027/etc/stunnel/stunnel.conf\u0027,"},{"line_number":56,"context_line":"    order    \u003d\u003e \"20-${name}\","},{"line_number":57,"context_line":"    template \u003d\u003e template(\u0027tripleo/stunnel/service\u0027),"},{"line_number":58,"context_line":"  }"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  Concat::Fragment[\"stunnel-service-${name}\"] ~\u003e Service\u003c| title \u003d\u003d \u0027stunnel\u0027 |\u003e"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7f287b81_1db5d1cd","line":57,"range":{"start_line":57,"start_character":42,"end_line":57,"end_character":49},"updated":"2017-08-24 16:22:17.000000000","message":"service.erb","commit_id":"8b8a402c0222d028fbb5a255d0569c55b7ce94c2"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"3ce7131eb70fc705432e1e88e1f895560889af0c","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  concat::fragment { \"stunnel-service-${name}\":"},{"line_number":55,"context_line":"    target   \u003d\u003e \u0027/etc/stunnel/stunnel.conf\u0027,"},{"line_number":56,"context_line":"    order    \u003d\u003e \"20-${name}\","},{"line_number":57,"context_line":"    content  \u003d\u003e template(\u0027tripleo/stunnel.service.erb\u0027),"},{"line_number":58,"context_line":"  }"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  Concat::Fragment[\"stunnel-service-${name}\"] ~\u003e Service\u003c| title \u003d\u003d \u0027stunnel\u0027 |\u003e"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7f287b81_1ff493f1","line":57,"range":{"start_line":57,"start_character":41,"end_line":57,"end_character":42},"updated":"2017-08-25 06:35:39.000000000","message":"oops","commit_id":"37989472d28342674c929b26c7b13ef31e142778"}],"templates/stunnel/service.erb":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"5922001a4763cffdfee287507c281970ddb72832","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"7f287b81_01cf6629","line":7,"updated":"2017-08-28 11:05:45.000000000","message":"fwiw there\u0027s a puppet module for stunnel at \n\n    https://github.com/puppetlabs/puppetlabs-stunnel\n\nWe don\u0027t need to go that route though if what we have here is sufficient.","commit_id":"f85199c77826017e383534051ada57ef1ea4ddcc"}]}
