)]}'
{"manifests/haproxy.pp":[{"author":{"_account_id":22380,"name":"Josh Hershberg","email":"jhershbe@redhat.com","username":"jhershbe"},"change_message_id":"24078d16615aa77e021b51c0915ba24ff2e3d4fe","unresolved":false,"context_lines":[{"line_number":1489,"context_line":"      },"},{"line_number":1490,"context_line":"    }"},{"line_number":1491,"context_line":""},{"line_number":1492,"context_line":"    ::tripleo::haproxy::endpoint { \u0027opendaylight_ws\u0027:"},{"line_number":1493,"context_line":"      public_virtual_ip         \u003d\u003e $public_virtual_ip,"},{"line_number":1494,"context_line":"      internal_ip               \u003d\u003e unique([hiera(\u0027opendaylight_api_vip\u0027, $controller_virtual_ip), $controller_virtual_ip]),"},{"line_number":1495,"context_line":"      service_port              \u003d\u003e $ports[opendaylight_ws_port],"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3f4b6375_4573b6b2","line":1492,"updated":"2017-10-29 07:05:19.000000000","message":"Just want to check...prior to the actual websocket connection there are two \"registration\" REST calls that must be executed on the same server as the websocket server. Will that be the case here?","commit_id":"bf3fe58323abd460f11316b34954beed4e6f78df"},{"author":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"change_message_id":"1f03f9bdeefc0887895dbef027d7858ed821c440","unresolved":false,"context_lines":[{"line_number":1489,"context_line":"      },"},{"line_number":1490,"context_line":"    }"},{"line_number":1491,"context_line":""},{"line_number":1492,"context_line":"    ::tripleo::haproxy::endpoint { \u0027opendaylight_ws\u0027:"},{"line_number":1493,"context_line":"      public_virtual_ip         \u003d\u003e $public_virtual_ip,"},{"line_number":1494,"context_line":"      internal_ip               \u003d\u003e unique([hiera(\u0027opendaylight_api_vip\u0027, $controller_virtual_ip), $controller_virtual_ip]),"},{"line_number":1495,"context_line":"      service_port              \u003d\u003e $ports[opendaylight_ws_port],"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3f4b6375_3c7eb069","line":1492,"in_reply_to":"3f4b6375_4573b6b2","updated":"2017-11-07 23:36:06.000000000","message":"We could add balance source (like in the opendaylight endpoint) which would make sure that is the case.","commit_id":"bf3fe58323abd460f11316b34954beed4e6f78df"},{"author":{"_account_id":22380,"name":"Josh Hershberg","email":"jhershbe@redhat.com","username":"jhershbe"},"change_message_id":"24078d16615aa77e021b51c0915ba24ff2e3d4fe","unresolved":false,"context_lines":[{"line_number":1504,"context_line":"        # timeouts get overridden by others at certain times of the connection."},{"line_number":1505,"context_line":"        # The following values were taken from the following site:"},{"line_number":1506,"context_line":"        # http://blog.haproxy.com/2012/11/07/websockets-load-balancing-with-haproxy/"},{"line_number":1507,"context_line":"        \u0027timeout\u0027 \u003d\u003e [\u0027connect 5s\u0027, \u0027client 25s\u0027, \u0027server 25s\u0027, \u0027tunnel 3600s\u0027],"},{"line_number":1508,"context_line":"      },"},{"line_number":1509,"context_line":"    }"},{"line_number":1510,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3f4b6375_8579ae94","line":1507,"range":{"start_line":1507,"start_character":64,"end_line":1507,"end_character":78},"updated":"2017-10-29 07:05:19.000000000","message":"What would cause the tunnel to time out? I am pretty sure I saw keep-alives flowing between client and server but I am curious about what this is.","commit_id":"bf3fe58323abd460f11316b34954beed4e6f78df"},{"author":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"change_message_id":"1f03f9bdeefc0887895dbef027d7858ed821c440","unresolved":false,"context_lines":[{"line_number":1504,"context_line":"        # timeouts get overridden by others at certain times of the connection."},{"line_number":1505,"context_line":"        # The following values were taken from the following site:"},{"line_number":1506,"context_line":"        # http://blog.haproxy.com/2012/11/07/websockets-load-balancing-with-haproxy/"},{"line_number":1507,"context_line":"        \u0027timeout\u0027 \u003d\u003e [\u0027connect 5s\u0027, \u0027client 25s\u0027, \u0027server 25s\u0027, \u0027tunnel 3600s\u0027],"},{"line_number":1508,"context_line":"      },"},{"line_number":1509,"context_line":"    }"},{"line_number":1510,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3f4b6375_dce31c33","line":1507,"range":{"start_line":1507,"start_character":64,"end_line":1507,"end_character":78},"in_reply_to":"3f4b6375_8579ae94","updated":"2017-11-07 23:36:06.000000000","message":"Inactivity across the tunnel:\nhttps://cbonte.github.io/haproxy-dconv/1.7/configuration.html#4-timeout%20tunnel","commit_id":"bf3fe58323abd460f11316b34954beed4e6f78df"},{"author":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"change_message_id":"df50b2a1a1ec80e74cadf39af6f3cee79610f133","unresolved":false,"context_lines":[{"line_number":1490,"context_line":"    }"},{"line_number":1491,"context_line":""},{"line_number":1492,"context_line":"    ::tripleo::haproxy::endpoint { \u0027opendaylight_ws\u0027:"},{"line_number":1493,"context_line":"      public_virtual_ip         \u003d\u003e $public_virtual_ip,"},{"line_number":1494,"context_line":"      internal_ip               \u003d\u003e unique([hiera(\u0027opendaylight_api_vip\u0027, $controller_virtual_ip), $controller_virtual_ip]),"},{"line_number":1495,"context_line":"      service_port              \u003d\u003e $ports[opendaylight_ws_port],"},{"line_number":1496,"context_line":"      ip_addresses              \u003d\u003e hiera(\u0027opendaylight_api_node_ip\u0027, $controller_hosts_real),"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ff82abbf_30032a45","line":1493,"range":{"start_line":1493,"start_character":6,"end_line":1493,"end_character":54},"updated":"2017-11-20 15:40:30.000000000","message":"we dont want to expose external network here.  Should remove this.","commit_id":"5b3048ffafd21bfb619b6f356417d768ac3b53c7"},{"author":{"_account_id":20866,"name":"Janki Chhatbar","email":"jchhatba@redhat.com","username":"janki"},"change_message_id":"b411b3b3d571e1dac8c2876df3d27cce57c72fd3","unresolved":false,"context_lines":[{"line_number":1493,"context_line":"      public_virtual_ip         \u003d\u003e $public_virtual_ip,"},{"line_number":1494,"context_line":"      internal_ip               \u003d\u003e unique([hiera(\u0027opendaylight_api_vip\u0027, $controller_virtual_ip), $controller_virtual_ip]),"},{"line_number":1495,"context_line":"      service_port              \u003d\u003e $ports[opendaylight_ws_port],"},{"line_number":1496,"context_line":"      ip_addresses              \u003d\u003e hiera(\u0027opendaylight_api_node_ip\u0027, $controller_hosts_real),"},{"line_number":1497,"context_line":"      server_names              \u003d\u003e hiera(\u0027opendaylight_api_node_names\u0027, $controller_hosts_names_real),"},{"line_number":1498,"context_line":"      mode                      \u003d\u003e \u0027http\u0027,"},{"line_number":1499,"context_line":"      haproxy_listen_bind_param \u003d\u003e [],  # We don\u0027t use a transparent proxy here"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1f485f77_96edd1b8","line":1496,"range":{"start_line":1496,"start_character":42,"end_line":1496,"end_character":67},"updated":"2017-11-16 15:32:17.000000000","message":"should be opendaylight_api_node_ips?","commit_id":"5b3048ffafd21bfb619b6f356417d768ac3b53c7"},{"author":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"change_message_id":"df50b2a1a1ec80e74cadf39af6f3cee79610f133","unresolved":false,"context_lines":[{"line_number":1493,"context_line":"      public_virtual_ip         \u003d\u003e $public_virtual_ip,"},{"line_number":1494,"context_line":"      internal_ip               \u003d\u003e unique([hiera(\u0027opendaylight_api_vip\u0027, $controller_virtual_ip), $controller_virtual_ip]),"},{"line_number":1495,"context_line":"      service_port              \u003d\u003e $ports[opendaylight_ws_port],"},{"line_number":1496,"context_line":"      ip_addresses              \u003d\u003e hiera(\u0027opendaylight_api_node_ip\u0027, $controller_hosts_real),"},{"line_number":1497,"context_line":"      server_names              \u003d\u003e hiera(\u0027opendaylight_api_node_names\u0027, $controller_hosts_names_real),"},{"line_number":1498,"context_line":"      mode                      \u003d\u003e \u0027http\u0027,"},{"line_number":1499,"context_line":"      haproxy_listen_bind_param \u003d\u003e [],  # We don\u0027t use a transparent proxy here"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ff82abbf_9060f634","line":1496,"range":{"start_line":1496,"start_character":42,"end_line":1496,"end_character":67},"in_reply_to":"1f485f77_96edd1b8","updated":"2017-11-20 15:40:30.000000000","message":"Done","commit_id":"5b3048ffafd21bfb619b6f356417d768ac3b53c7"},{"author":{"_account_id":20866,"name":"Janki Chhatbar","email":"jchhatba@redhat.com","username":"janki"},"change_message_id":"1aac6b2aa2613b8b876f31a35d4e482a63129358","unresolved":false,"context_lines":[{"line_number":1496,"context_line":"      ip_addresses              \u003d\u003e hiera(\u0027opendaylight_api_node_ip\u0027, $controller_hosts_real),"},{"line_number":1497,"context_line":"      server_names              \u003d\u003e hiera(\u0027opendaylight_api_node_names\u0027, $controller_hosts_names_real),"},{"line_number":1498,"context_line":"      mode                      \u003d\u003e \u0027http\u0027,"},{"line_number":1499,"context_line":"      haproxy_listen_bind_param \u003d\u003e [],  # We don\u0027t use a transparent proxy here"},{"line_number":1500,"context_line":"      listen_options            \u003d\u003e {"},{"line_number":1501,"context_line":"        # NOTE(jaosorior): Websockets have more overhead in establishing"},{"line_number":1502,"context_line":"        # connections than regular HTTP connections. Also, since it begins"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1f485f77_cfa3f99d","line":1499,"range":{"start_line":1499,"start_character":6,"end_line":1499,"end_character":44},"updated":"2017-11-14 14:52:53.000000000","message":"we need transparent mode here","commit_id":"5b3048ffafd21bfb619b6f356417d768ac3b53c7"},{"author":{"_account_id":20866,"name":"Janki Chhatbar","email":"jchhatba@redhat.com","username":"janki"},"change_message_id":"b411b3b3d571e1dac8c2876df3d27cce57c72fd3","unresolved":false,"context_lines":[{"line_number":1496,"context_line":"      ip_addresses              \u003d\u003e hiera(\u0027opendaylight_api_node_ip\u0027, $controller_hosts_real),"},{"line_number":1497,"context_line":"      server_names              \u003d\u003e hiera(\u0027opendaylight_api_node_names\u0027, $controller_hosts_names_real),"},{"line_number":1498,"context_line":"      mode                      \u003d\u003e \u0027http\u0027,"},{"line_number":1499,"context_line":"      haproxy_listen_bind_param \u003d\u003e [],  # We don\u0027t use a transparent proxy here"},{"line_number":1500,"context_line":"      listen_options            \u003d\u003e {"},{"line_number":1501,"context_line":"        # NOTE(jaosorior): Websockets have more overhead in establishing"},{"line_number":1502,"context_line":"        # connections than regular HTTP connections. Also, since it begins"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1f485f77_d6f7c98a","line":1499,"range":{"start_line":1499,"start_character":6,"end_line":1499,"end_character":44},"in_reply_to":"1f485f77_cfa3f99d","updated":"2017-11-16 15:32:17.000000000","message":"Need to test this more.","commit_id":"5b3048ffafd21bfb619b6f356417d768ac3b53c7"},{"author":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"change_message_id":"df50b2a1a1ec80e74cadf39af6f3cee79610f133","unresolved":false,"context_lines":[{"line_number":1496,"context_line":"      ip_addresses              \u003d\u003e hiera(\u0027opendaylight_api_node_ip\u0027, $controller_hosts_real),"},{"line_number":1497,"context_line":"      server_names              \u003d\u003e hiera(\u0027opendaylight_api_node_names\u0027, $controller_hosts_names_real),"},{"line_number":1498,"context_line":"      mode                      \u003d\u003e \u0027http\u0027,"},{"line_number":1499,"context_line":"      haproxy_listen_bind_param \u003d\u003e [],  # We don\u0027t use a transparent proxy here"},{"line_number":1500,"context_line":"      listen_options            \u003d\u003e {"},{"line_number":1501,"context_line":"        # NOTE(jaosorior): Websockets have more overhead in establishing"},{"line_number":1502,"context_line":"        # connections than regular HTTP connections. Also, since it begins"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ff82abbf_50002e35","line":1499,"range":{"start_line":1499,"start_character":6,"end_line":1499,"end_character":44},"in_reply_to":"1f485f77_d6f7c98a","updated":"2017-11-20 15:40:30.000000000","message":"I\u0027ll enable it in next patch set and test it out.","commit_id":"5b3048ffafd21bfb619b6f356417d768ac3b53c7"}]}