)]}'
{"Puppetfile_extras":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"b702215e9a3640892e2ac9ca14f647fe0cb50220","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"mod \u0027ceph\u0027,"},{"line_number":5,"context_line":"  :git \u003d\u003e \u0027https://github.com/openstack/puppet-ceph\u0027,"},{"line_number":6,"context_line":"  :ref \u003d\u003e \u0027master\u0027"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"mod \u0027haproxy\u0027,"},{"line_number":9,"context_line":"  :git \u003d\u003e \u0027https://github.com/puppetlabs/puppetlabs-haproxy\u0027,"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"1f485f77_eb0c3ced","line":6,"updated":"2017-11-15 20:01:06.000000000","message":"stable/jewel","commit_id":"3d6eac0164fa06971648997c92e678c6c690637a"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"2f9f83ad1447e5151f311dd6835cb9f2dc53f518","unresolved":false,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"## TripleO Puppet modules"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"mod \u0027ceph\u0027,"},{"line_number":5,"context_line":"  :git \u003d\u003e \u0027https://github.com/openstack/puppet-ceph\u0027,"},{"line_number":6,"context_line":"  :ref \u003d\u003e \u0027stable/jewel\u0027"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"mod \u0027haproxy\u0027,"},{"line_number":9,"context_line":"  :git \u003d\u003e \u0027https://github.com/puppetlabs/puppetlabs-haproxy\u0027,"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"1f485f77_d967fae8","line":6,"range":{"start_line":4,"start_character":0,"end_line":6,"end_character":24},"updated":"2017-11-16 15:46:57.000000000","message":"This is already included there https://github.com/openstack/puppet-openstack-integration/blob/master/Puppetfile#L16..L19, so yours make a duplicate.\n\nNot sure why you don\u0027t point to master as well. stable/pike of puppet-openstack-integration is pointing to stable/jewel but master should point to master, no ?","commit_id":"b4250382cc146103bfc697d8cdecc747e28eadff"}],"manifests/profile/base/manila/share.pp":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"ff37104b29fa3a72b14facda08958f8e1f491c76","unresolved":false,"context_lines":[{"line_number":133,"context_line":"          cephfs_cluster_name          \u003d\u003e hiera(\u0027manila::backend::cephfsnative::cephfs_cluster_name\u0027),"},{"line_number":134,"context_line":"          cephfs_enable_snapshots      \u003d\u003e hiera(\u0027manila::backend::cephfsnative::cephfs_enable_snapshots\u0027),"},{"line_number":135,"context_line":"        }"},{"line_number":136,"context_line":"        $keyring_path \u003d \"/etc/ceph/ceph.client.${cephfs_auth_id}.keyring\""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        exec{ \"exec-setfacl-${cephfs_auth_id}}\":"},{"line_number":139,"context_line":"          path    \u003d\u003e [\u0027/bin\u0027, \u0027/usr/bin\u0027 ],"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"df87a7cf_16e7bce6","line":136,"updated":"2017-12-05 16:50:34.000000000","message":"the error in scenario004 [1] is real; I think this line conflicts with l146 ... I think lines 138-143 can/should probably go at the same level of line 146, so you don\u0027t need line 136?\n\n1. http://logs.openstack.org/31/519531/8/check/tripleo-ci-centos-7-scenario004-multinode-oooq-container/82fb370/logs/subnode-2/var/log/journal.txt.gz#_Nov_27_17_02_15","commit_id":"0ea3053d6af021b41072e612193e739de8f7e037"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"d5bcad1d3abb98fe3d39e9c492686b1d4ca156d6","unresolved":false,"context_lines":[{"line_number":133,"context_line":"          cephfs_cluster_name          \u003d\u003e hiera(\u0027manila::backend::cephfsnative::cephfs_cluster_name\u0027),"},{"line_number":134,"context_line":"          cephfs_enable_snapshots      \u003d\u003e hiera(\u0027manila::backend::cephfsnative::cephfs_enable_snapshots\u0027),"},{"line_number":135,"context_line":"        }"},{"line_number":136,"context_line":"        $keyring_path \u003d \"/etc/ceph/ceph.client.${cephfs_auth_id}.keyring\""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        exec{ \"exec-setfacl-${cephfs_auth_id}}\":"},{"line_number":139,"context_line":"          path    \u003d\u003e [\u0027/bin\u0027, \u0027/usr/bin\u0027 ],"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"df87a7cf_896086a7","line":136,"in_reply_to":"df87a7cf_16e7bce6","updated":"2017-12-05 20:45:21.000000000","message":"You\u0027re right. I must have gotten lost when I had to rebase.","commit_id":"0ea3053d6af021b41072e612193e739de8f7e037"}],"metadata.json":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"b702215e9a3640892e2ac9ca14f647fe0cb50220","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    { \"name\": \"puppetlabs/stdlib\", \"version_requirement\": \"\u003e\u003d 4.12.0 \u003c 5.0.0\" },"},{"line_number":27,"context_line":"    { \"name\": \"sensu/sensu\" },"},{"line_number":28,"context_line":"    { \"name\": \"yelp/uchiwa\" },"},{"line_number":29,"context_line":"    { \"name\": \"openstack/ceph\"}"},{"line_number":30,"context_line":"  ]"},{"line_number":31,"context_line":"}"}],"source_content_type":"application/json","patch_set":4,"id":"1f485f77_4b68f085","line":29,"updated":"2017-11-15 20:01:06.000000000","message":"openstack/puppet-ceph","commit_id":"3d6eac0164fa06971648997c92e678c6c690637a"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ed3c69b975b86c7f04283d783363fac829c8175b","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    { \"name\": \"puppetlabs/stdlib\", \"version_requirement\": \"\u003e\u003d 4.12.0 \u003c 5.0.0\" },"},{"line_number":27,"context_line":"    { \"name\": \"sensu/sensu\" },"},{"line_number":28,"context_line":"    { \"name\": \"yelp/uchiwa\" },"},{"line_number":29,"context_line":"    { \"name\": \"openstack/ceph\"}"},{"line_number":30,"context_line":"  ]"},{"line_number":31,"context_line":"}"}],"source_content_type":"application/json","patch_set":4,"id":"1f485f77_46990777","line":29,"in_reply_to":"1f485f77_4b68f085","updated":"2017-11-15 20:44:57.000000000","message":"no this is correct","commit_id":"3d6eac0164fa06971648997c92e678c6c690637a"}],"spec/classes/tripleo_profile_base_gnocchi_api_spec.rb":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"b702215e9a3640892e2ac9ca14f647fe0cb50220","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    let(:pre_condition) do"},{"line_number":22,"context_line":"      \""},{"line_number":23,"context_line":"        class { \u0027::tripleo::profile::base::gnocchi\u0027: step \u003d\u003e #{params[:step]}, }"},{"line_number":24,"context_line":"        class { \u0027::ceph::key\u0027: name \u003d\u003e \u0027openstack\u0027, secret \u003d\u003e \u0027SeCrEt\u0027, }"},{"line_number":25,"context_line":"      \""},{"line_number":26,"context_line":"    end"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":4,"id":"1f485f77_cbce20b3","line":24,"updated":"2017-11-15 20:01:06.000000000","message":"should not be necessary","commit_id":"3d6eac0164fa06971648997c92e678c6c690637a"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"b702215e9a3640892e2ac9ca14f647fe0cb50220","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        :gnocchi_backend \u003d\u003e \u0027rbd\u0027,"},{"line_number":99,"context_line":"        :gnocchi_redis_password \u003d\u003e \u0027gnocchi\u0027,"},{"line_number":100,"context_line":"        :redis_vip \u003d\u003e \u0027127.0.0.1\u0027,"},{"line_number":101,"context_line":"        :gnocchi_rbd_client_name \u003d\u003e \u0027openstack\u0027"},{"line_number":102,"context_line":"      } }"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"      it {"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"1f485f77_8bc4a892","line":101,"updated":"2017-11-15 20:01:06.000000000","message":"not necessary","commit_id":"3d6eac0164fa06971648997c92e678c6c690637a"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"2fdf530b6059c9fa0d27ac2173d830207add3b54","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        :gnocchi_backend \u003d\u003e \u0027rbd\u0027,"},{"line_number":99,"context_line":"        :gnocchi_redis_password \u003d\u003e \u0027gnocchi\u0027,"},{"line_number":100,"context_line":"        :redis_vip \u003d\u003e \u0027127.0.0.1\u0027,"},{"line_number":101,"context_line":"        :gnocchi_rbd_client_name \u003d\u003e \u0027openstack\u0027"},{"line_number":102,"context_line":"      } }"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"      it {"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"1f485f77_ffb50d7f","line":101,"in_reply_to":"1f485f77_8bc4a892","updated":"2017-11-16 03:20:25.000000000","message":"Without this the exec comes out to be exec-setfacl-gnocchi-gnocchi. \n\nWeird.","commit_id":"3d6eac0164fa06971648997c92e678c6c690637a"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"b702215e9a3640892e2ac9ca14f647fe0cb50220","unresolved":false,"context_lines":[{"line_number":111,"context_line":"          :redis_url \u003d\u003e \u0027redis://:gnocchi@127.0.0.1:6379/\u0027"},{"line_number":112,"context_line":"        )"},{"line_number":113,"context_line":"        is_expected.to contain_class(\u0027gnocchi::storage::ceph\u0027)"},{"line_number":114,"context_line":"      }"},{"line_number":115,"context_line":"    end"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    context \u0027with step 5 on bootstrap\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"1f485f77_ab752466","line":114,"updated":"2017-11-15 20:01:06.000000000","message":"add here something like:\n\n  is_expected.to contain_exec(\u0027exec-setfacl-openstack-gnocchi\u0027)","commit_id":"3d6eac0164fa06971648997c92e678c6c690637a"}]}
