)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"1cb3f41e101aab4fcd35beb27e63e71d84a57fee","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Including new modules to be deployed with the Swift proxy"},{"line_number":10,"context_line":"These new modules enable barbican support in Swift"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: https://review.openstack.org/525323"},{"line_number":13,"context_line":"Change-Id: I1ceda973733acb081967ab04a5fd57eb1609c9a7"},{"line_number":14,"context_line":"Signed-off-by: Thiago da Silva \u003cthiago@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa0c359_932500c5","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":47},"updated":"2018-02-08 13:41:26.000000000","message":"This is this change. I don\u0027t think you want that","commit_id":"1ecee26242eb2d62d931479c51858630b1f46824"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"e7e1b8ba2ca89e53e1a953a31695a9ae8eb24287","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Including new modules to be deployed with the Swift proxy"},{"line_number":10,"context_line":"These new modules enable barbican support in Swift"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: https://review.openstack.org/525323"},{"line_number":13,"context_line":"Change-Id: I1ceda973733acb081967ab04a5fd57eb1609c9a7"},{"line_number":14,"context_line":"Signed-off-by: Thiago da Silva \u003cthiago@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa0c359_9eff4733","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":47},"in_reply_to":"3fa0c359_932500c5","updated":"2018-02-08 14:02:33.000000000","message":"thanks, got the patches mixed up, should be fixed now","commit_id":"1ecee26242eb2d62d931479c51858630b1f46824"}],"manifests/profile/base/swift/proxy.pp":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"9a8d2ade0c40fb2615fa54694594ab0720c8f0eb","unresolved":false,"context_lines":[{"line_number":180,"context_line":"    include ::swift::proxy::account_quotas"},{"line_number":181,"context_line":"    include ::swift::proxy::encryption"},{"line_number":182,"context_line":"    include ::swift::proxy::kms_keymaster"},{"line_number":183,"context_line":"    include ::swift::keymaster"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    class { \u0027::swift::objectexpirer\u0027:"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3fa0c359_fe31ab0c","line":183,"updated":"2018-02-08 14:07:46.000000000","message":"This usese the barbican keymanager as the default manager. This would be problematic if barbican is not enabled. I suggest you use the \"barbican_api_enabled\" hiera key to verify that it\u0027s possible to use it, and include this conditionally depending on that.","commit_id":"61fa4912b90e5dced0fb629c1154362eaabe9be6"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"238e044a5ef35ca202bc415c936e306b18973d6f","unresolved":false,"context_lines":[{"line_number":180,"context_line":"    include ::swift::proxy::account_quotas"},{"line_number":181,"context_line":"    include ::swift::proxy::encryption"},{"line_number":182,"context_line":"    include ::swift::proxy::kms_keymaster"},{"line_number":183,"context_line":"    include ::swift::keymaster"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    class { \u0027::swift::objectexpirer\u0027:"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3fa0c359_65a3c39f","line":183,"in_reply_to":"3fa0c359_1966f152","updated":"2018-02-08 17:54:35.000000000","message":"I think he\u0027s talking about the default value in ::swift::keymaster. Does it get ignored unless kms_keymaster is enabled in the pipeline or whatever?","commit_id":"61fa4912b90e5dced0fb629c1154362eaabe9be6"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"60a2f4ceca80fea23e73692eafe284e19ca2b809","unresolved":false,"context_lines":[{"line_number":180,"context_line":"    include ::swift::proxy::account_quotas"},{"line_number":181,"context_line":"    include ::swift::proxy::encryption"},{"line_number":182,"context_line":"    include ::swift::proxy::kms_keymaster"},{"line_number":183,"context_line":"    include ::swift::keymaster"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    class { \u0027::swift::objectexpirer\u0027:"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3fa0c359_c02ba52d","line":183,"in_reply_to":"3fa0c359_65a3c39f","updated":"2018-02-08 18:23:45.000000000","message":"correct. If it\u0027s not in the pipeline it doesn\u0027t really matter. During my tests this worked out ok. I tested the patch with Barbican both enabled/disabled.","commit_id":"61fa4912b90e5dced0fb629c1154362eaabe9be6"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"7287e134c8585268cc079396fc2e0325c432e11c","unresolved":false,"context_lines":[{"line_number":180,"context_line":"    include ::swift::proxy::account_quotas"},{"line_number":181,"context_line":"    include ::swift::proxy::encryption"},{"line_number":182,"context_line":"    include ::swift::proxy::kms_keymaster"},{"line_number":183,"context_line":"    include ::swift::keymaster"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    class { \u0027::swift::objectexpirer\u0027:"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3fa0c359_1966f152","line":183,"in_reply_to":"3fa0c359_fe31ab0c","updated":"2018-02-08 14:27:01.000000000","message":"I added a check in the THT to make sure to include these two middlewares in the swift proxy pipeline only if encryption was enabled. These include here only add the default filter configuration without actually adding anything to the pipeline, so that if Barbican is not enabled, it wouldn\u0027t make any difference.","commit_id":"61fa4912b90e5dced0fb629c1154362eaabe9be6"}]}