)]}'
{"id":"openstack%2Fpuppet-tripleo~551749","triplet_id":"openstack%2Fpuppet-tripleo~stable%2Fpike~I1ab3a52306b91baadb70d2210a378417087f1ecf","project":"openstack/puppet-tripleo","branch":"stable/pike","topic":"bug/1747960","hashtags":[],"change_id":"I1ab3a52306b91baadb70d2210a378417087f1ecf","subject":"firewall: don\u0027t reload IPtables after cleanup","status":"MERGED","created":"2018-03-11 07:35:30.000000000","updated":"2018-03-14 08:56:14.000000000","submitted":"2018-03-14 08:56:14.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"551749-1521017774877-ae768c8a","meta_rev_id":"8646c8efbb17169a026f236e6c4241467db44d79","_number":551749,"virtual_id_number":551749,"owner":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2018-03-14 08:56:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2018-03-13 06:58:25.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},{"value":0,"_account_id":27248,"name":"Prateek Goel","email":"prateek.goel2@tatacommunications.com","username":"prateek.goel"},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":2,"date":"2018-03-13 13:59:15.000000000","_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},{"value":1,"date":"2018-03-13 03:33:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":27248,"name":"Prateek Goel","email":"prateek.goel2@tatacommunications.com","username":"prateek.goel"},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},{"value":0,"_account_id":27248,"name":"Prateek Goel","email":"prateek.goel2@tatacommunications.com","username":"prateek.goel"},{"value":1,"date":"2018-03-13 14:02:26.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"_account_id":27248,"name":"Prateek Goel","email":"prateek.goel2@tatacommunications.com","username":"prateek.goel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-03-13 03:33:52.000000000","updated_by":{"_account_id":27248,"name":"Prateek Goel","email":"prateek.goel2@tatacommunications.com","username":"prateek.goel"},"reviewer":{"_account_id":27248,"name":"Prateek Goel","email":"prateek.goel2@tatacommunications.com","username":"prateek.goel"},"state":"REVIEWER"},{"updated":"2018-03-13 06:58:25.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2018-03-13 13:59:15.000000000","updated_by":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"reviewer":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"state":"REVIEWER"},{"updated":"2018-03-14 08:56:14.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"baeab0e5a526ebbb335de436d604124971b5a97e","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2018-03-11 07:35:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b01b8a43e5f00876ee29b397344c6cafce8baf2a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-11 09:49:48.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint http://logs.openstack.org/49/551749/1/check/puppet-openstack-lint/62586fb/ : SUCCESS in 4m 02s\n- puppet-openstack-syntax-4 http://logs.openstack.org/49/551749/1/check/puppet-openstack-syntax-4/0f44d52/ : SUCCESS in 3m 35s\n- puppet-openstack-unit-4.8-centos-7 http://logs.openstack.org/49/551749/1/check/puppet-openstack-unit-4.8-centos-7/0942b8f/ : SUCCESS in 20m 42s\n- tripleo-ci-centos-7-undercloud-oooq http://logs.openstack.org/49/551749/1/check/tripleo-ci-centos-7-undercloud-oooq/093a5f3/ : SUCCESS in 1h 00m 19s\n- tripleo-ci-centos-7-undercloud-upgrades http://logs.openstack.org/49/551749/1/check/tripleo-ci-centos-7-undercloud-upgrades/8bdb887/ : SUCCESS in 1h 12m 07s (non-voting)\n- tripleo-ci-centos-7-containers-multinode http://logs.openstack.org/49/551749/1/check/tripleo-ci-centos-7-containers-multinode/e370864/ : SUCCESS in 2h 12m 21s","accounts_in_message":[],"_revision_number":1},{"id":"81bca5f1972cb61bf8faf687985fa6864f1c1b56","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2018-03-11 13:42:33.000000000","message":"Patch Set 2: Published edit on patch set 1.","accounts_in_message":[],"_revision_number":2},{"id":"33c6bdb5bbe15a482556d5875d8e3d33f9ec75fb","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-11 15:03:11.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- puppet-openstack-lint http://logs.openstack.org/49/551749/2/check/puppet-openstack-lint/40a2f09/ : SUCCESS in 3m 59s\n- puppet-openstack-syntax-4 http://logs.openstack.org/49/551749/2/check/puppet-openstack-syntax-4/13ceb10/ : SUCCESS in 3m 16s\n- puppet-openstack-unit-4.8-centos-7 http://logs.openstack.org/49/551749/2/check/puppet-openstack-unit-4.8-centos-7/b147d5f/ : SUCCESS in 22m 16s\n- tripleo-ci-centos-7-undercloud-oooq http://logs.openstack.org/49/551749/2/check/tripleo-ci-centos-7-undercloud-oooq/36ae56f/ : FAILURE in 26m 51s\n- tripleo-ci-centos-7-undercloud-upgrades http://logs.openstack.org/49/551749/2/check/tripleo-ci-centos-7-undercloud-upgrades/fedaa95/ : SUCCESS in 1h 15m 20s (non-voting)\n- tripleo-ci-centos-7-containers-multinode http://logs.openstack.org/49/551749/2/check/tripleo-ci-centos-7-containers-multinode/c752946/ : FAILURE in 41m 29s","accounts_in_message":[],"_revision_number":2},{"id":"72029a0867b1ed6654a717413c64694b4c8770fb","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2018-03-11 19:19:22.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"7e42b638e67a62f8b695108e79fd2b976f7be288","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2018-03-11 21:33:44.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"860736c676aa346cb0d47aced75c783d3413d01f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-11 23:50:45.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint http://logs.openstack.org/49/551749/4/check/puppet-openstack-lint/865abca/ : SUCCESS in 3m 40s\n- puppet-openstack-syntax-4 http://logs.openstack.org/49/551749/4/check/puppet-openstack-syntax-4/fc5205d/ : SUCCESS in 3m 07s\n- puppet-openstack-unit-4.8-centos-7 http://logs.openstack.org/49/551749/4/check/puppet-openstack-unit-4.8-centos-7/9ce6cfd/ : SUCCESS in 23m 32s\n- tripleo-ci-centos-7-undercloud-oooq http://logs.openstack.org/49/551749/4/check/tripleo-ci-centos-7-undercloud-oooq/0513934/ : SUCCESS in 1h 02m 06s\n- tripleo-ci-centos-7-undercloud-upgrades http://logs.openstack.org/49/551749/4/check/tripleo-ci-centos-7-undercloud-upgrades/c7dc705/ : SUCCESS in 1h 09m 01s (non-voting)\n- tripleo-ci-centos-7-containers-multinode http://logs.openstack.org/49/551749/4/check/tripleo-ci-centos-7-containers-multinode/b5e13e0/ : SUCCESS in 2h 15m 11s","accounts_in_message":[],"_revision_number":4},{"id":"75a5d9bf9ac83b3d76c177a6b0401f1de4ee4b99","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2018-03-12 16:37:44.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"c1de90974fa66cc965a72bb8fff8314b95f34684","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-12 20:59:29.000000000","message":"Patch Set 5: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- puppet-openstack-lint http://logs.openstack.org/49/551749/5/check/puppet-openstack-lint/477cee9/ : SUCCESS in 4m 28s\n- puppet-openstack-syntax-4 http://logs.openstack.org/49/551749/5/check/puppet-openstack-syntax-4/a4c50bd/ : SUCCESS in 3m 27s\n- puppet-openstack-unit-4.8-centos-7 http://logs.openstack.org/49/551749/5/check/puppet-openstack-unit-4.8-centos-7/bbe3e5a/ : FAILURE in 23m 45s\n- tripleo-ci-centos-7-undercloud-oooq http://logs.openstack.org/49/551749/5/check/tripleo-ci-centos-7-undercloud-oooq/7f85bdd/ : RETRY_LIMIT in 5m 53s\n- tripleo-ci-centos-7-undercloud-upgrades http://logs.openstack.org/49/551749/5/check/tripleo-ci-centos-7-undercloud-upgrades/45eeee6/ : SUCCESS in 1h 15m 11s (non-voting)\n- tripleo-ci-centos-7-containers-multinode http://logs.openstack.org/49/551749/5/check/tripleo-ci-centos-7-containers-multinode/1f9c829/ : SUCCESS in 2h 19m 01s","accounts_in_message":[],"_revision_number":5},{"id":"b9676d4a5bdac00df0cdc09832a691062bbce36e","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2018-03-12 22:37:52.000000000","message":"Patch Set 6: Patch Set 5 was rebased","accounts_in_message":[],"_revision_number":6},{"id":"a21c1a92ffa92e60bf19f2b7734af0aace16c23c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-13 01:26:46.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint http://logs.openstack.org/49/551749/6/check/puppet-openstack-lint/dc5e0af/ : SUCCESS in 9m 25s\n- puppet-openstack-syntax-4 http://logs.openstack.org/49/551749/6/check/puppet-openstack-syntax-4/8cca8c7/ : SUCCESS in 2m 49s\n- puppet-openstack-unit-4.8-centos-7 http://logs.openstack.org/49/551749/6/check/puppet-openstack-unit-4.8-centos-7/6b045a5/ : SUCCESS in 23m 33s\n- tripleo-ci-centos-7-undercloud-oooq http://logs.openstack.org/49/551749/6/check/tripleo-ci-centos-7-undercloud-oooq/c7b8c7f/ : SUCCESS in 1h 06m 36s\n- tripleo-ci-centos-7-undercloud-upgrades http://logs.openstack.org/49/551749/6/check/tripleo-ci-centos-7-undercloud-upgrades/85048cd/ : SUCCESS in 1h 14m 37s (non-voting)\n- tripleo-ci-centos-7-containers-multinode http://logs.openstack.org/49/551749/6/check/tripleo-ci-centos-7-containers-multinode/84b5bd5/ : SUCCESS in 2h 42m 27s","accounts_in_message":[],"_revision_number":6},{"id":"b138093791fe6fd2e9cbfb10ac6f903b3d9f7c7c","author":{"_account_id":27248,"name":"Prateek Goel","email":"prateek.goel2@tatacommunications.com","username":"prateek.goel"},"date":"2018-03-13 03:33:52.000000000","message":"Patch Set 6: Code-Review+1","accounts_in_message":[],"_revision_number":6},{"id":"5f73a3ad5f87c4c96ff9a3af5b916110acdb6b30","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2018-03-13 06:58:25.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded.\n\n- gate-tripleo-ci-centos-7-containers-multinode-upgrades-pike-nv https://review.rdoproject.org/jenkins/job/gate-tripleo-ci-centos-7-containers-multinode-upgrades-pike-nv/91/ : SUCCESS in 2h 33m 21s (non-voting)\n- gate-tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001-pike https://review.rdoproject.org/jenkins/job/gate-tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001-pike/635/ : SUCCESS in 2h 02m 42s\n- gate-tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset022-pike https://review.rdoproject.org/jenkins/job/gate-tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset022-pike/689/ : SUCCESS in 2h 00m 20s\n- gate-tripleo-ci-centos-7-ovb-1ctlr_1comp_1ceph-featureset024-pike https://review.rdoproject.org/jenkins/job/gate-tripleo-ci-centos-7-ovb-1ctlr_1comp_1ceph-featureset024-pike/690/ : SUCCESS in 1h 56m 12s","accounts_in_message":[],"_revision_number":6},{"id":"57805121cff0cef67fefa287c5266ec222b7e6b7","author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"date":"2018-03-13 13:59:15.000000000","message":"Patch Set 6: Code-Review+2","accounts_in_message":[],"_revision_number":6},{"id":"eaad62938d63cb5e077e877c7f0666c06f2c465b","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2018-03-13 14:02:26.000000000","message":"Patch Set 6: Workflow+1","accounts_in_message":[],"_revision_number":6},{"id":"3e4508c44db0aba7c121fbccbf41aa9aef80ed99","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-14 04:33:27.000000000","message":"Patch Set 6: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":6},{"id":"6c39bfe7b48f22591fb781bca9168209aab8aa50","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-14 08:56:14.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":6},{"id":"be99d8ae11587d6f2ddd5ce29518cb4232b39d62","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-14 08:56:14.000000000","message":"Patch Set 6: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint http://logs.openstack.org/49/551749/6/gate/puppet-openstack-lint/e5505d6/ : SUCCESS in 4m 21s\n- puppet-openstack-syntax-4 http://logs.openstack.org/49/551749/6/gate/puppet-openstack-syntax-4/b86c551/ : SUCCESS in 3m 50s\n- puppet-openstack-unit-4.8-centos-7 http://logs.openstack.org/49/551749/6/gate/puppet-openstack-unit-4.8-centos-7/c6f55b1/ : SUCCESS in 23m 58s\n- tripleo-ci-centos-7-undercloud-oooq http://logs.openstack.org/49/551749/6/gate/tripleo-ci-centos-7-undercloud-oooq/117784b/ : SUCCESS in 1h 12m 15s\n- tripleo-ci-centos-7-containers-multinode http://logs.openstack.org/49/551749/6/gate/tripleo-ci-centos-7-containers-multinode/f8bd47d/ : SUCCESS in 2h 25m 22s","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"c95c51c9516dc8ca7b599bb7299c35276fb02eab","revisions":{"a0df1013223fa9d721b0c9aee87e869460511ce6":{"kind":"REWORK","_number":1,"created":"2018-03-11 07:35:30.000000000","uploader":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"ref":"refs/changes/49/551749/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-tripleo","ref":"refs/changes/49/551749/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/49/551749/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/49/551749/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/49/551749/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-tripleo refs/changes/49/551749/1"}}},"commit":{"parents":[{"commit":"6e4aeda8c487dbb38937cb06bd170c3212821c9d","subject":"Fix stack update with rabbitmq containers","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/6e4aeda8c487dbb38937cb06bd170c3212821c9d"}]}],"author":{"name":"Emilien Macchi","email":"emilien@redhat.com","date":"2018-03-11 07:30:19.000000000","tz":60},"committer":{"name":"Emilien Macchi","email":"emilien@redhat.com","date":"2018-03-11 07:35:18.000000000","tz":60},"subject":"firewall: make the execs more reliable","message":"firewall: make the execs more reliable\n\n- Use grep -q to figure out if neutron rules exist.\n  That way, nothing will be written to stdout but we\u0027ll just\n  have the return code.\n\n- Before reloading iptables, check that the service is actually active.\n  Some deployments don\u0027t run ip6tables, so we shouldn\u0027t attempt to\n  release the service.\n\nrhbz#1541528\nRelated-Bug: #1747960\n\nChange-Id: I1ab3a52306b91baadb70d2210a378417087f1ecf\n(cherry picked from commit 5fc0b5600d7bd1c2e032c8bfd1d9a550e8165845)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/a0df1013223fa9d721b0c9aee87e869460511ce6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/a0df1013223fa9d721b0c9aee87e869460511ce6"}]},"branch":"refs/heads/stable/pike"},"bdbd4a8409d80991611758b58bf65972b1bc151b":{"kind":"REWORK","_number":2,"created":"2018-03-11 13:42:33.000000000","uploader":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"ref":"refs/changes/49/551749/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-tripleo","ref":"refs/changes/49/551749/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/49/551749/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/49/551749/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/49/551749/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-tripleo refs/changes/49/551749/2"}}},"commit":{"parents":[{"commit":"6e4aeda8c487dbb38937cb06bd170c3212821c9d","subject":"Fix stack update with rabbitmq containers","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/6e4aeda8c487dbb38937cb06bd170c3212821c9d"}]}],"author":{"name":"Emilien Macchi","email":"emilien@redhat.com","date":"2018-03-11 07:30:19.000000000","tz":60},"committer":{"name":"Emilien Macchi","email":"emilien@redhat.com","date":"2018-03-11 13:42:17.000000000","tz":0},"subject":"firewall: make the execs more reliable","message":"firewall: make the execs more reliable\n\n- Use grep -q to figure out if neutron rules exist.\n  That way, nothing will be written to stdout but we\u0027ll just\n  have the return code.\n\n- Before reloading iptables, check that the service is actually active.\n  Some deployments don\u0027t run ip6tables, so we shouldn\u0027t attempt to\n  release the service.\n\nrhbz#1541528\nRelated-Bug: #1747960\n\nChange-Id: I1ab3a52306b91baadb70d2210a378417087f1ecf\n(cherry picked from commit 5fc0b5600d7bd1c2e032c8bfd1d9a550e8165845)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/bdbd4a8409d80991611758b58bf65972b1bc151b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/bdbd4a8409d80991611758b58bf65972b1bc151b"}]},"branch":"refs/heads/stable/pike"},"8b14c7d8e878b12bc1b742d2dd6fd8a1da8e2a28":{"kind":"REWORK","_number":3,"created":"2018-03-11 19:19:22.000000000","uploader":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"ref":"refs/changes/49/551749/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-tripleo","ref":"refs/changes/49/551749/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/49/551749/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/49/551749/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/49/551749/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-tripleo refs/changes/49/551749/3"}}},"commit":{"parents":[{"commit":"6e4aeda8c487dbb38937cb06bd170c3212821c9d","subject":"Fix stack update with rabbitmq containers","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/6e4aeda8c487dbb38937cb06bd170c3212821c9d"}]}],"author":{"name":"Emilien Macchi","email":"emilien@redhat.com","date":"2018-03-11 07:30:19.000000000","tz":60},"committer":{"name":"Emilien Macchi","email":"emilien@redhat.com","date":"2018-03-11 19:19:22.000000000","tz":0},"subject":"firewall: make the execs more reliable","message":"firewall: make the execs more reliable\n\n- Use grep -q to figure out if neutron rules exist.\n  That way, nothing will be written to stdout but we\u0027ll just\n  have the return code.\n\n- Before reloading iptables, check that the service is actually active.\n  Some deployments don\u0027t run ip6tables, so we shouldn\u0027t attempt to\n  release the service.\n\nrhbz#1541528\nRelated-Bug: #1747960\n\nChange-Id: I1ab3a52306b91baadb70d2210a378417087f1ecf\n(cherry picked from commit 5fc0b5600d7bd1c2e032c8bfd1d9a550e8165845)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/8b14c7d8e878b12bc1b742d2dd6fd8a1da8e2a28"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/8b14c7d8e878b12bc1b742d2dd6fd8a1da8e2a28"}]},"branch":"refs/heads/stable/pike"},"57a13d7ce78a9e3bd59fec80fdd5dc7490b01049":{"kind":"NO_CHANGE","_number":4,"created":"2018-03-11 21:33:44.000000000","uploader":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"ref":"refs/changes/49/551749/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-tripleo","ref":"refs/changes/49/551749/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/49/551749/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/49/551749/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/49/551749/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-tripleo refs/changes/49/551749/4"}}},"commit":{"parents":[{"commit":"6e4aeda8c487dbb38937cb06bd170c3212821c9d","subject":"Fix stack update with rabbitmq containers","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/6e4aeda8c487dbb38937cb06bd170c3212821c9d"}]}],"author":{"name":"Emilien Macchi","email":"emilien@redhat.com","date":"2018-03-11 07:30:19.000000000","tz":60},"committer":{"name":"Emilien Macchi","email":"emilien@redhat.com","date":"2018-03-11 21:33:44.000000000","tz":0},"subject":"firewall: make the execs more reliable","message":"firewall: make the execs more reliable\n\n- Use grep -q to figure out if neutron rules exist.\n  That way, nothing will be written to stdout but we\u0027ll just\n  have the return code.\n\n- Before reloading iptables, check that the service is actually active.\n  Some deployments don\u0027t run ip6tables, so we shouldn\u0027t attempt to\n  release the service.\n\nrhbz#1541528\nRelated-Bug: #1747960\n\nChange-Id: I1ab3a52306b91baadb70d2210a378417087f1ecf\n(cherry picked from commit 5fc0b5600d7bd1c2e032c8bfd1d9a550e8165845)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/57a13d7ce78a9e3bd59fec80fdd5dc7490b01049"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/57a13d7ce78a9e3bd59fec80fdd5dc7490b01049"}]},"branch":"refs/heads/stable/pike"},"8576dfb57e5496e7debe33929dceba7e339cecb3":{"kind":"REWORK","_number":5,"created":"2018-03-12 16:37:44.000000000","uploader":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"ref":"refs/changes/49/551749/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-tripleo","ref":"refs/changes/49/551749/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/49/551749/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/49/551749/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/49/551749/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-tripleo refs/changes/49/551749/5"}}},"commit":{"parents":[{"commit":"6e4aeda8c487dbb38937cb06bd170c3212821c9d","subject":"Fix stack update with rabbitmq containers","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/6e4aeda8c487dbb38937cb06bd170c3212821c9d"}]}],"author":{"name":"Emilien Macchi","email":"emilien@redhat.com","date":"2018-03-11 07:30:19.000000000","tz":60},"committer":{"name":"Emilien Macchi","email":"emilien@redhat.com","date":"2018-03-12 16:37:44.000000000","tz":0},"subject":"firewall: don\u0027t reload IPtables after cleanup","message":"firewall: don\u0027t reload IPtables after cleanup\n\nThis patch stops the IPtables reload when doing Neutron rules cleanup.\n\nFull context:\npuppetlabs-firewall only manages the current state of iptables\nrules and writes out the rules to a file to ensure they are\npersisted. We are specifically running the following commands after the\niptables rules to ensure the persisted file does not contain any\nephemeral neutron rules. Neutron assumes the iptables rules are not\npersisted so it may cause an issue if the rule is loaded on boot\n(or via iptables restart). If an operator needs to reload iptables\nfor any reason, they may need to manually reload the appropriate\nneutron agent to restore these iptables rules.\n\nrhbz#1541528\nRelated-Bug: #1747960\nChange-Id: I1ab3a52306b91baadb70d2210a378417087f1ecf\n(cherry picked from commit 5fc0b5600d7bd1c2e032c8bfd1d9a550e8165845)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/8576dfb57e5496e7debe33929dceba7e339cecb3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/8576dfb57e5496e7debe33929dceba7e339cecb3"}]},"branch":"refs/heads/stable/pike"},"c95c51c9516dc8ca7b599bb7299c35276fb02eab":{"kind":"TRIVIAL_REBASE","_number":6,"created":"2018-03-12 22:37:52.000000000","uploader":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"ref":"refs/changes/49/551749/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-tripleo","ref":"refs/changes/49/551749/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/49/551749/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/49/551749/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/49/551749/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-tripleo refs/changes/49/551749/6"}}},"commit":{"parents":[{"commit":"8777c2911a2de899bf0cb58487973962cf3ebcee","subject":"Pin puppet-systemd","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/8777c2911a2de899bf0cb58487973962cf3ebcee"}]}],"author":{"name":"Emilien Macchi","email":"emilien@redhat.com","date":"2018-03-11 07:30:19.000000000","tz":60},"committer":{"name":"Emilien Macchi","email":"emilien@redhat.com","date":"2018-03-12 22:37:52.000000000","tz":0},"subject":"firewall: don\u0027t reload IPtables after cleanup","message":"firewall: don\u0027t reload IPtables after cleanup\n\nThis patch stops the IPtables reload when doing Neutron rules cleanup.\n\nFull context:\npuppetlabs-firewall only manages the current state of iptables\nrules and writes out the rules to a file to ensure they are\npersisted. We are specifically running the following commands after the\niptables rules to ensure the persisted file does not contain any\nephemeral neutron rules. Neutron assumes the iptables rules are not\npersisted so it may cause an issue if the rule is loaded on boot\n(or via iptables restart). If an operator needs to reload iptables\nfor any reason, they may need to manually reload the appropriate\nneutron agent to restore these iptables rules.\n\nrhbz#1541528\nRelated-Bug: #1747960\nChange-Id: I1ab3a52306b91baadb70d2210a378417087f1ecf\n(cherry picked from commit 5fc0b5600d7bd1c2e032c8bfd1d9a550e8165845)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/c95c51c9516dc8ca7b599bb7299c35276fb02eab"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/c95c51c9516dc8ca7b599bb7299c35276fb02eab"}]},"branch":"refs/heads/stable/pike"}},"requirements":[],"submit_records":[],"submit_requirements":[]}