)]}'
{"templates/docker_distribution/registry_config.yml.erb":[{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"4a324ea45f193aa2a847aa9098e8ddbabb36139d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"        rootdirectory: /var/lib/registry"},{"line_number":10,"context_line":"http:"},{"line_number":11,"context_line":"\u003c% if @registry_host \u003d~ /:/ -%\u003e"},{"line_number":12,"context_line":"    addr: [\u003c%\u003d @registry_host %\u003e]:\u003c%\u003d @registry_port %\u003e"},{"line_number":13,"context_line":"\u003c% else -%\u003e"},{"line_number":14,"context_line":"    addr: \u003c%\u003d @registry_host %\u003e:\u003c%\u003d @registry_port %\u003e"},{"line_number":15,"context_line":"\u003c% end -%\u003e"}],"source_content_type":"application/x-erb","patch_set":1,"id":"df7087c5_5d8d4f2f","line":12,"updated":"2018-03-21 12:48:06.000000000","message":"Needs quotes","commit_id":"5a2e49620f742301a08b9f0b9fdf62d03046048c"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"610a379a4975df268856682c9bebd6666af7f7b9","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    filesystem:"},{"line_number":9,"context_line":"        rootdirectory: /var/lib/registry"},{"line_number":10,"context_line":"http:"},{"line_number":11,"context_line":"\u003c% if @registry_host \u003d~ /:/ -%\u003e"},{"line_number":12,"context_line":"    addr: \"[\u003c%\u003d @registry_host %\u003e]:\u003c%\u003d @registry_port %\u003e\""},{"line_number":13,"context_line":"\u003c% else -%\u003e"},{"line_number":14,"context_line":"    addr: \u003c%\u003d @registry_host %\u003e:\u003c%\u003d @registry_port %\u003e"}],"source_content_type":"application/x-erb","patch_set":2,"id":"bf659307_b235c6dc","line":11,"range":{"start_line":11,"start_character":6,"end_line":11,"end_character":28},"updated":"2018-03-27 12:40:37.000000000","message":"I wonder if we could use rubys IPAddr[1] class here instead of the regex to make it more clear what is going on?\n\npseudo code:\n\u003c% require \u0027ipaddr\u0027 %\u003e\n\u003c% if IPAddr.new(@registry_host).ipv6? -%\u003e\n\nhttps://docs.ruby-lang.org/en/2.0.0/IPAddr.html","commit_id":"0ebb1aeec74af99cd0ed3fc7cc78c98749bca3f9"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d86bb0fc504099e1ccb01711d1cf2aeb1317f217","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    filesystem:"},{"line_number":9,"context_line":"        rootdirectory: /var/lib/registry"},{"line_number":10,"context_line":"http:"},{"line_number":11,"context_line":"\u003c% if @registry_host \u003d~ /:/ -%\u003e"},{"line_number":12,"context_line":"    addr: \"[\u003c%\u003d @registry_host %\u003e]:\u003c%\u003d @registry_port %\u003e\""},{"line_number":13,"context_line":"\u003c% else -%\u003e"},{"line_number":14,"context_line":"    addr: \u003c%\u003d @registry_host %\u003e:\u003c%\u003d @registry_port %\u003e"}],"source_content_type":"application/x-erb","patch_set":2,"id":"5f7c97a3_665b2e87","line":11,"updated":"2018-05-03 16:52:37.000000000","message":"Just rename this var and fix this up in tripleo::profile::base::docker_registry. We have a puppet function to wrap hosts in quotes.  normalize_ip_for_uri($value)\n\nhttps://github.com/openstack/puppet-openstacklib/blob/master/lib/puppet/parser/functions/normalize_ip_for_uri.rb\n\nJust do this in the class and then we don\u0027t need this if/else in the erb","commit_id":"0ebb1aeec74af99cd0ed3fc7cc78c98749bca3f9"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"5e06a6132dd0ea7a20cc776ae657393cb404c9a0","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    filesystem:"},{"line_number":9,"context_line":"        rootdirectory: /var/lib/registry"},{"line_number":10,"context_line":"http:"},{"line_number":11,"context_line":"\u003c% if @registry_host \u003d~ /:/ -%\u003e"},{"line_number":12,"context_line":"    addr: \"[\u003c%\u003d @registry_host %\u003e]:\u003c%\u003d @registry_port %\u003e\""},{"line_number":13,"context_line":"\u003c% else -%\u003e"},{"line_number":14,"context_line":"    addr: \u003c%\u003d @registry_host %\u003e:\u003c%\u003d @registry_port %\u003e"}],"source_content_type":"application/x-erb","patch_set":2,"id":"3fce034c_94ea880c","line":11,"in_reply_to":"5f7c97a3_665b2e87","updated":"2019-04-19 06:53:17.000000000","message":"Done","commit_id":"0ebb1aeec74af99cd0ed3fc7cc78c98749bca3f9"}]}