)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"e96004ddd870c5f41822cc8fe1d91c657ac5aca4","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This can cause problem during upgrade from Mitaka.  The previous host"},{"line_number":13,"context_line":"value (defaulting to python socket.gethostname) could return only the"},{"line_number":14,"context_line":"hostname[0] then when upgrade we thus changing this identifier.  At"},{"line_number":15,"context_line":"restart nova/neutron create *new* agents.  Those agents are then"},{"line_number":16,"context_line":"unaware of existing workload."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9f6a8fd7_3036e352","line":14,"range":{"start_line":14,"start_character":12,"end_line":14,"end_character":62},"updated":"2018-04-26 08:57:53.000000000","message":"Need rephrasing.","commit_id":"0b192345f3de4f72c5c961f0db8f7ffe9aed7f6b"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"e96004ddd870c5f41822cc8fe1d91c657ac5aca4","unresolved":false,"context_lines":[{"line_number":22,"context_line":"For nova it\u0027s no longer possible to send commands to (before upgrade)"},{"line_number":23,"context_line":"existing vm anymore."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"This patch check the current live value of the host parameter through"},{"line_number":26,"context_line":"a fact and set the nova::host and neutron::host value to it if we are"},{"line_number":27,"context_line":"not in a deployment (upgrade/update)"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9f6a8fd7_9046cfbf","line":25,"updated":"2018-04-26 08:57:53.000000000","message":"s","commit_id":"0b192345f3de4f72c5c961f0db8f7ffe9aed7f6b"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"f9e8614b112262334809a6eb02b95022720c126b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"For nova, we directly use nova-manage to get the current live value."},{"line_number":30,"context_line":"Using the mysql parameter directly has the advantage that it\u0027s defined"},{"line_number":31,"context_line":"on all type of node (controller *and* compute).  As a matter of fact"},{"line_number":32,"context_line":"the auth required parameter are usually not defined on compute node."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"For neutron, when auth is available in the configuration (on"},{"line_number":35,"context_line":"Controller) we use that.  There is no neutron-manage equivalent here"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9f6a8fd7_ca7d0f1d","line":32,"range":{"start_line":32,"start_character":4,"end_line":32,"end_character":27},"updated":"2018-05-02 09:18:24.000000000","message":"required auth parameters?","commit_id":"0b192345f3de4f72c5c961f0db8f7ffe9aed7f6b"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"e96004ddd870c5f41822cc8fe1d91c657ac5aca4","unresolved":false,"context_lines":[{"line_number":29,"context_line":"For nova, we directly use nova-manage to get the current live value."},{"line_number":30,"context_line":"Using the mysql parameter directly has the advantage that it\u0027s defined"},{"line_number":31,"context_line":"on all type of node (controller *and* compute).  As a matter of fact"},{"line_number":32,"context_line":"the auth required parameter are usually not defined on compute node."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"For neutron, when auth is available in the configuration (on"},{"line_number":35,"context_line":"Controller) we use that.  There is no neutron-manage equivalent here"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9f6a8fd7_100cff91","line":32,"updated":"2018-04-26 08:57:53.000000000","message":"s","commit_id":"0b192345f3de4f72c5c961f0db8f7ffe9aed7f6b"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"e96004ddd870c5f41822cc8fe1d91c657ac5aca4","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"[0] https://bugzilla.redhat.com/show_bug.cgi?id\u003d1499201"},{"line_number":47,"context_line":"[1] https://review.openstack.org/#/c/560855/"},{"line_number":48,"context_line":"[2] need to be backported to ocata https://review.openstack.org/#/q/I8f075a5ad869ef0dc72a700dcb7be0b6efca787a"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Partial-Bug: #1763322"},{"line_number":51,"context_line":"Change-Id: Ieb92ff161d1684c214382c5eb6b5949efc3fe75c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9f6a8fd7_f0694b24","line":48,"range":{"start_line":48,"start_character":4,"end_line":48,"end_character":109},"updated":"2018-04-26 08:57:53.000000000","message":"Wrong link formating.","commit_id":"0b192345f3de4f72c5c961f0db8f7ffe9aed7f6b"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"e3e0812aec5fe9fef40258ec2100a5e59a882281","unresolved":false,"context_lines":[{"line_number":40,"context_line":"sorry."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"This patch is newton only as it\u0027s where we are setting for the first"},{"line_number":43,"context_line":"time this parameter.  After that (ocata on) we use[2] to make sure"},{"line_number":44,"context_line":"that those parameters are never rewritten."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"[0] https://bugzilla.redhat.com/show_bug.cgi?id\u003d1499201"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5f7c97a3_71e67deb","line":43,"range":{"start_line":43,"start_character":49,"end_line":43,"end_character":50},"updated":"2018-05-04 13:03:54.000000000","message":"so do we need that one to merge first/doesn\u0027t matter","commit_id":"6938b5d1f2747416338ce188068d7a967cba617b"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"626cb304d52af757c3cbef7657eb7eefe2382972","unresolved":false,"context_lines":[{"line_number":40,"context_line":"sorry."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"This patch is newton only as it\u0027s where we are setting for the first"},{"line_number":43,"context_line":"time this parameter.  After that (ocata on) we use[2] to make sure"},{"line_number":44,"context_line":"that those parameters are never rewritten."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"[0] https://bugzilla.redhat.com/show_bug.cgi?id\u003d1499201"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5f7c97a3_d10af188","line":43,"range":{"start_line":43,"start_character":49,"end_line":43,"end_character":50},"in_reply_to":"5f7c97a3_71e67deb","updated":"2018-05-04 13:05:29.000000000","message":"Doesn\u0027t matter for mitaka to newton upgrade, this patch is self-contained.","commit_id":"6938b5d1f2747416338ce188068d7a967cba617b"}],"lib/facter/current_config_hosts.rb":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"f9e8614b112262334809a6eb02b95022720c126b","unresolved":false,"context_lines":[{"line_number":21,"context_line":"end"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def get_live_value_from_auth(component)"},{"line_number":24,"context_line":"  provider_file \u003d \"/etc/puppet/modules/#{component}/lib/puppet/provider/#{component}.rb\""},{"line_number":25,"context_line":"  if File.exists?(provider_file)"},{"line_number":26,"context_line":"    require_relative(provider_file)"},{"line_number":27,"context_line":"    auth_env \u003d get_auth(component)"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"9f6a8fd7_eaf49389","line":24,"range":{"start_line":24,"start_character":19,"end_line":24,"end_character":38},"updated":"2018-05-02 09:18:24.000000000","message":"doubt it\u0027s a safe assumption in general but I guess we can get away with it in this case","commit_id":"0b192345f3de4f72c5c961f0db8f7ffe9aed7f6b"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"16edd4be5073203e99e11d9d550f044d125ddc58","unresolved":false,"context_lines":[{"line_number":21,"context_line":"end"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def get_live_value_from_auth(component)"},{"line_number":24,"context_line":"  provider_file \u003d \"/etc/puppet/modules/#{component}/lib/puppet/provider/#{component}.rb\""},{"line_number":25,"context_line":"  if File.exists?(provider_file)"},{"line_number":26,"context_line":"    require_relative(provider_file)"},{"line_number":27,"context_line":"    auth_env \u003d get_auth(component)"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"5f7c97a3_1e240c0d","line":24,"range":{"start_line":24,"start_character":19,"end_line":24,"end_character":38},"in_reply_to":"9f6a8fd7_eaf49389","updated":"2018-05-03 09:53:27.000000000","message":"Added a comment.","commit_id":"0b192345f3de4f72c5c961f0db8f7ffe9aed7f6b"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"f9e8614b112262334809a6eb02b95022720c126b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"end"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"def get_nova_live_value"},{"line_number":44,"context_line":"  nova_manage_stdin \u003d \u0027/tmp/get-nova-host\u0027"},{"line_number":45,"context_line":"  File.open(nova_manage_stdin, \u0027w\u0027) do |nova_cmd|"},{"line_number":46,"context_line":"    nova_cmd.puts(\"import nova.conf\\nprint nova.conf.CONF.host\")"},{"line_number":47,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"9f6a8fd7_0ad1c7cd","line":44,"range":{"start_line":44,"start_character":22,"end_line":44,"end_character":42},"updated":"2018-05-02 09:18:24.000000000","message":"can we use Tempfile and unlink it when we\u0027re done","commit_id":"0b192345f3de4f72c5c961f0db8f7ffe9aed7f6b"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"16edd4be5073203e99e11d9d550f044d125ddc58","unresolved":false,"context_lines":[{"line_number":41,"context_line":"end"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"def get_nova_live_value"},{"line_number":44,"context_line":"  nova_manage_stdin \u003d \u0027/tmp/get-nova-host\u0027"},{"line_number":45,"context_line":"  File.open(nova_manage_stdin, \u0027w\u0027) do |nova_cmd|"},{"line_number":46,"context_line":"    nova_cmd.puts(\"import nova.conf\\nprint nova.conf.CONF.host\")"},{"line_number":47,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"5f7c97a3_9e7d7ce9","line":44,"range":{"start_line":44,"start_character":22,"end_line":44,"end_character":42},"in_reply_to":"9f6a8fd7_0ad1c7cd","updated":"2018-05-03 09:53:27.000000000","message":"Good point, done.","commit_id":"0b192345f3de4f72c5c961f0db8f7ffe9aed7f6b"}],"manifests/profile/base/neutron.pp":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"f9e8614b112262334809a6eb02b95022720c126b","unresolved":false,"context_lines":[{"line_number":74,"context_line":"      } else {"},{"line_number":75,"context_line":"        # We fail instead of blindly changing that value as it can"},{"line_number":76,"context_line":"        # break the overcloud."},{"line_number":77,"context_line":"        fail(\"We couldn\u0027t get the live value of the neutron agent, please contact support.\")"},{"line_number":78,"context_line":"      }"},{"line_number":79,"context_line":"    } else {"},{"line_number":80,"context_line":"      $host_real \u003d hiera(\u0027neutron::host\u0027)"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9f6a8fd7_6ac163e4","line":77,"range":{"start_line":77,"start_character":67,"end_line":77,"end_character":90},"updated":"2018-05-02 09:18:24.000000000","message":"if you\u0027re downstream :-)","commit_id":"0b192345f3de4f72c5c961f0db8f7ffe9aed7f6b"}]}