)]}'
{"manifests/profile/base/neutron/server.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"1d5be542bea08c966331331be4a2734dacced4d2","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    include ::neutron::quota"},{"line_number":147,"context_line":"  }"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"  if $step \u003e\u003d4 and hiera(\u0027designate_api_enabled\u0027, false) {"},{"line_number":150,"context_line":"    include ::neutron::designate"},{"line_number":151,"context_line":"  }"},{"line_number":152,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5f7c97a3_f52466b1","line":149,"updated":"2018-05-23 21:53:04.000000000","message":"I\u0027m not sure if it\u0027s still a problem, but I think","commit_id":"99ff7408952774fac2a0bc76c43277722f814b93"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"19d4317c42787cd29dcb8afd4c7d6f74c5051108","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    include ::neutron::quota"},{"line_number":147,"context_line":"  }"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"  if $step \u003e\u003d4 and hiera(\u0027designate_api_enabled\u0027, false) {"},{"line_number":150,"context_line":"    include ::neutron::designate"},{"line_number":151,"context_line":"  }"},{"line_number":152,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5f7c97a3_6773bf81","line":149,"in_reply_to":"5f7c97a3_51176546","updated":"2018-05-24 16:29:58.000000000","message":"Thanks, I think I handled it (except the testing part...).","commit_id":"99ff7408952774fac2a0bc76c43277722f814b93"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d298a63b1ea78a405e673db496a050074885ff38","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    include ::neutron::quota"},{"line_number":147,"context_line":"  }"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"  if $step \u003e\u003d4 and hiera(\u0027designate_api_enabled\u0027, false) {"},{"line_number":150,"context_line":"    include ::neutron::designate"},{"line_number":151,"context_line":"  }"},{"line_number":152,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5f7c97a3_51176546","line":149,"in_reply_to":"5f7c97a3_f52466b1","updated":"2018-05-24 13:22:35.000000000","message":"I guess I hit submit on the wrong window. Anyway, I think this needs to go in ::tripleo::profile::base::neutron because that\u0027s where the config gets written out for neutron.  After ::neutron::config should be ok https://github.com/openstack/puppet-tripleo/blob/master/manifests/profile/base/neutron.pp#L136\n\n\nWhat I was saying previously was going to be about idempotency as this wouldn\u0027t add the config until step 4 which means it might be removed during step3 of a deployment.  Alternatively, if you want to leave it here because it is only needed by neutron server, please move it to L146 and just wrap it in an if $designate { ... }\n\nAlso please move the hiera call to a class parameter which would allow for unit testing this","commit_id":"99ff7408952774fac2a0bc76c43277722f814b93"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"0449d9c6e22ed858455ec1ec9a0af3f73d9cc289","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    include ::neutron::quota"},{"line_number":147,"context_line":"  }"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"  if $step \u003e\u003d4 and hiera(\u0027designate_api_enabled\u0027, false) {"},{"line_number":150,"context_line":"    include ::neutron::designate"},{"line_number":151,"context_line":"  }"},{"line_number":152,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5f7c97a3_64450243","line":149,"in_reply_to":"5f7c97a3_f52466b1","updated":"2018-05-24 07:43:59.000000000","message":"Sorry? :)","commit_id":"99ff7408952774fac2a0bc76c43277722f814b93"}]}