)]}'
{"manifests/profile/base/metrics/collectd.pp":[{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"13ccf0d8144999318bcbffea77d1a7d42375769e","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        port          \u003d\u003e $_collectd_port,"},{"line_number":222,"context_line":"        securitylevel \u003d\u003e $_collectd_securitylevel,"},{"line_number":223,"context_line":"      }"},{"line_number":224,"context_line":"    } elsif !empty($gnocchi_server) or !empty($gnocchi_keystone_auth_url) {"},{"line_number":225,"context_line":"      if !empty($gnocchi_server) {"},{"line_number":226,"context_line":"        $gci_server \u003d $gnocchi_server"},{"line_number":227,"context_line":"      } else {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"5f7c97a3_1ecc6d5f","side":"PARENT","line":224,"updated":"2018-06-22 13:55:27.000000000","message":"dont we need to retain this conditional for gnocchi?","commit_id":"cab0d34affeb171215e2bb288df7d478049e79cf"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"dc498bc9e0886d512df52a8513a5ccca648659e5","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        port          \u003d\u003e $_collectd_port,"},{"line_number":222,"context_line":"        securitylevel \u003d\u003e $_collectd_securitylevel,"},{"line_number":223,"context_line":"      }"},{"line_number":224,"context_line":"    } elsif !empty($gnocchi_server) or !empty($gnocchi_keystone_auth_url) {"},{"line_number":225,"context_line":"      if !empty($gnocchi_server) {"},{"line_number":226,"context_line":"        $gci_server \u003d $gnocchi_server"},{"line_number":227,"context_line":"      } else {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"5f7c97a3_2da485b8","side":"PARENT","line":224,"in_reply_to":"5f7c97a3_1ecc6d5f","updated":"2018-06-25 09:06:24.000000000","message":"Right, if we want to be able to not use any write plugin provided by us, we need to keep it. Gonna fix that.","commit_id":"cab0d34affeb171215e2bb288df7d478049e79cf"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"ce14fa8b2f6578ce25299fbecfcdf07e7a9b8d85","unresolved":false,"context_lines":[{"line_number":164,"context_line":"# [*amqp_password*]"},{"line_number":165,"context_line":"#  (Optional) String. Password part of credentials used to authenticate"},{"line_number":166,"context_line":"#  to the AMQP 1.0 intermediary."},{"line_number":167,"context_line":"#  Defaults to undef"},{"line_number":168,"context_line":"#"},{"line_number":169,"context_line":"# [*amqp_address*]"},{"line_number":170,"context_line":"#  (Optional) String. This option specifies the prefix for the send-to value"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"5f7c97a3_ff9dfcb9","line":167,"updated":"2018-07-17 17:18:53.000000000","message":"shouldn\u0027t this be guest? do you want this manifest to default to undef or guest?\n\nnot sure why you used the default value (guest) for user, but not password.","commit_id":"411046e271a9fcd6ff86eb85a7a23bd3da5b2571"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"aab833e1969dac9d15113cfd03992b0b18dbd7e8","unresolved":false,"context_lines":[{"line_number":164,"context_line":"# [*amqp_password*]"},{"line_number":165,"context_line":"#  (Optional) String. Password part of credentials used to authenticate"},{"line_number":166,"context_line":"#  to the AMQP 1.0 intermediary."},{"line_number":167,"context_line":"#  Defaults to undef"},{"line_number":168,"context_line":"#"},{"line_number":169,"context_line":"# [*amqp_address*]"},{"line_number":170,"context_line":"#  (Optional) String. This option specifies the prefix for the send-to value"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"5f7c97a3_53cdb22c","line":167,"in_reply_to":"5f7c97a3_ff9dfcb9","updated":"2018-07-20 18:28:02.000000000","message":"Ah right, the amqp_user above is defaulting to undef. Documentation typo, gonna fix that.","commit_id":"411046e271a9fcd6ff86eb85a7a23bd3da5b2571"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"724788e214b851808f0914d71ad5254e415b2485","unresolved":false,"context_lines":[{"line_number":276,"context_line":"        port          \u003d\u003e $_collectd_port,"},{"line_number":277,"context_line":"        securitylevel \u003d\u003e $_collectd_securitylevel,"},{"line_number":278,"context_line":"      }"},{"line_number":279,"context_line":"    } elsif !empty($amqp_host) {"},{"line_number":280,"context_line":"      class { \u0027::collectd::plugin::amqp1\u0027:"},{"line_number":281,"context_line":"        ensure         \u003d\u003e \u0027present\u0027,"},{"line_number":282,"context_line":"        manage_package \u003d\u003e true,"},{"line_number":283,"context_line":"        transport      \u003d\u003e $amqp_transport_name,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"5f7c97a3_999b69c6","line":280,"range":{"start_line":279,"start_character":6,"end_line":280,"end_character":42},"updated":"2018-07-20 19:25:20.000000000","message":"Since you touched the tests anyway, Can we add test coverage in rspec for this condition.","commit_id":"3bf1c12dc06d5ebb6d468e96282c50cc8b18e089"}]}
