)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"10177cfef034ffdeab94143e71397f8c39ce8d59","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use user and group instead of ensure_resource"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is required so that puppet tag filtering can be used to ensure"},{"line_number":10,"context_line":"this runs inside the mistral-executor container image during"},{"line_number":11,"context_line":"docker-puppet.py config."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_4db94fea","line":9,"range":{"start_line":9,"start_character":25,"end_line":9,"end_character":45},"updated":"2018-06-18 07:17:00.000000000","message":"Would the ensure resource work with an explicit tag as well?\nThen we can leave it unchanged.","commit_id":"6c3c5b08a1703c3bc0283521ce42dc01ab37fb05"}],"lib/facter/docker_group_gid.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"30bea65375a15fea48b0384fe665fb0fec63f682","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  setcode do"},{"line_number":18,"context_line":"    begin"},{"line_number":19,"context_line":"      File::Stat.new(\"/var/run/docker.sock\").gid"},{"line_number":20,"context_line":"    rescue"},{"line_number":21,"context_line":"    end"},{"line_number":22,"context_line":"  end"},{"line_number":23,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5f7c97a3_d53e18b8","line":20,"updated":"2018-06-19 21:35:06.000000000","message":"You\u0027d have to add nil here to have it actually return nil. In ruby it returns the last statement value so you have to provide something","commit_id":"e8a6c02d2f4ea870d7bb1f4e5197238dbd4fce4a"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"44708c216d844175a2ab5f25d61071fba01214c9","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  setcode do"},{"line_number":18,"context_line":"    begin"},{"line_number":19,"context_line":"      File::Stat.new(\"/var/run/docker.sock\").gid"},{"line_number":20,"context_line":"    rescue"},{"line_number":21,"context_line":"    end"},{"line_number":22,"context_line":"  end"},{"line_number":23,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5f7c97a3_75f1446a","line":20,"in_reply_to":"5f7c97a3_d53e18b8","updated":"2018-06-19 22:18:44.000000000","message":"Done","commit_id":"e8a6c02d2f4ea870d7bb1f4e5197238dbd4fce4a"}],"manifests/profile/base/mistral/executor.pp":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"ad1bd8601a9c101f4b2488ac1f245c35f0993132","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    include ::mistral::executor"},{"line_number":50,"context_line":"    if $docker_group {"},{"line_number":51,"context_line":"      ensure_resource(\u0027group\u0027, \u0027docker\u0027, {"},{"line_number":52,"context_line":"        \u0027ensure\u0027 \u003d\u003e \u0027present\u0027,"},{"line_number":53,"context_line":"      })"},{"line_number":54,"context_line":"      ensure_resource(\u0027user\u0027, \u0027mistral\u0027, {"},{"line_number":55,"context_line":"        \u0027name\u0027   \u003d\u003e \u0027mistral\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5f7c97a3_2d865315","side":"PARENT","line":52,"updated":"2018-06-18 07:19:31.000000000","message":"\u0027tag\u0027 \u003d\u003e \u0027group\u0027, ?","commit_id":"0fdf746fd5b40cdfc468727bac0b7700ec020005"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"ad1bd8601a9c101f4b2488ac1f245c35f0993132","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        \u0027ensure\u0027 \u003d\u003e \u0027present\u0027,"},{"line_number":53,"context_line":"      })"},{"line_number":54,"context_line":"      ensure_resource(\u0027user\u0027, \u0027mistral\u0027, {"},{"line_number":55,"context_line":"        \u0027name\u0027   \u003d\u003e \u0027mistral\u0027,"},{"line_number":56,"context_line":"        \u0027groups\u0027 \u003d\u003e \u0027docker\u0027,"},{"line_number":57,"context_line":"      })"},{"line_number":58,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5f7c97a3_ed77fb3a","side":"PARENT","line":55,"updated":"2018-06-18 07:19:31.000000000","message":"\u0027tag\u0027 \u003d\u003e \u0027user\u0027, ?","commit_id":"0fdf746fd5b40cdfc468727bac0b7700ec020005"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"76ed83b2c33787af2937cd93a08a2e7cbe0f4ffe","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  if $step \u003e\u003d 4 or ($step \u003e\u003d 3 and $sync_db)  {"},{"line_number":49,"context_line":"    include ::mistral::executor"},{"line_number":50,"context_line":"    if $docker_group {"},{"line_number":51,"context_line":"      group { \u0027docker\u0027:"},{"line_number":52,"context_line":"        ensure  \u003d\u003e \u0027present\u0027,"},{"line_number":53,"context_line":"        name    \u003d\u003e \u0027docker\u0027,"},{"line_number":54,"context_line":"        gid     \u003d\u003e hiera(\u0027docker_group_gid\u0027),"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5f7c97a3_2dd3b3d7","line":51,"updated":"2018-06-18 07:37:50.000000000","message":"Here is a worked example of a function wrapped with a tag:\n\nanchor {\u0027foo\u0027: tag \u003d\u003e \u0027foo\u0027}\nensure_resource(\u0027user\u0027, \u0027foo\u0027, {\u0027ensure\u0027 \u003d\u003e \u0027absent\u0027})                                                                                                                                                      \nAnchor[\u0027foo\u0027] -\u003e User[\u0027foo\u0027]\n\nthen it is only evaluated if there was --tag \u0027foo\u0027 specified in the puppet apply call :)","commit_id":"6c3c5b08a1703c3bc0283521ce42dc01ab37fb05"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"7612f58880b63d1eae117ded5ac88a806fff65bd","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  if $step \u003e\u003d 4 or ($step \u003e\u003d 3 and $sync_db)  {"},{"line_number":49,"context_line":"    include ::mistral::executor"},{"line_number":50,"context_line":"    if $docker_group {"},{"line_number":51,"context_line":"      group { \u0027docker\u0027:"},{"line_number":52,"context_line":"        ensure  \u003d\u003e \u0027present\u0027,"},{"line_number":53,"context_line":"        name    \u003d\u003e \u0027docker\u0027,"},{"line_number":54,"context_line":"        gid     \u003d\u003e hiera(\u0027docker_group_gid\u0027),"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5f7c97a3_116fe428","line":51,"in_reply_to":"5f7c97a3_2dd3b3d7","updated":"2018-06-18 20:53:46.000000000","message":"It could be that tagging for user,group would still work with ensure_resource. I\u0027ll try that again","commit_id":"6c3c5b08a1703c3bc0283521ce42dc01ab37fb05"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"dc752508d420c9c8ebf5a0cd989c54fd2d53c4a9","unresolved":false,"context_lines":[{"line_number":51,"context_line":"      ensure_resource(\u0027group\u0027, \u0027docker\u0027, {"},{"line_number":52,"context_line":"        \u0027ensure\u0027 \u003d\u003e \u0027present\u0027,"},{"line_number":53,"context_line":"        \u0027tag\u0027    \u003d\u003e \u0027group\u0027,"},{"line_number":54,"context_line":"        \u0027gid\u0027    \u003d\u003e hiera(\u0027docker_group_gid\u0027),"},{"line_number":55,"context_line":"      })"},{"line_number":56,"context_line":"      ensure_resource(\u0027user\u0027, \u0027mistral\u0027, {"},{"line_number":57,"context_line":"        \u0027name\u0027   \u003d\u003e \u0027mistral\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5f7c97a3_35a66c11","line":54,"range":{"start_line":54,"start_character":20,"end_line":54,"end_character":45},"updated":"2018-06-19 21:37:02.000000000","message":"This needs to be $facts[\u0027docker_group_id\u0027] or $::docker_group_id\n\nhttps://puppet.com/docs/puppet/5.3/lang_facts_and_builtin_vars.html#accessing-facts-from-puppet-code","commit_id":"e8a6c02d2f4ea870d7bb1f4e5197238dbd4fce4a"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"44708c216d844175a2ab5f25d61071fba01214c9","unresolved":false,"context_lines":[{"line_number":51,"context_line":"      ensure_resource(\u0027group\u0027, \u0027docker\u0027, {"},{"line_number":52,"context_line":"        \u0027ensure\u0027 \u003d\u003e \u0027present\u0027,"},{"line_number":53,"context_line":"        \u0027tag\u0027    \u003d\u003e \u0027group\u0027,"},{"line_number":54,"context_line":"        \u0027gid\u0027    \u003d\u003e hiera(\u0027docker_group_gid\u0027),"},{"line_number":55,"context_line":"      })"},{"line_number":56,"context_line":"      ensure_resource(\u0027user\u0027, \u0027mistral\u0027, {"},{"line_number":57,"context_line":"        \u0027name\u0027   \u003d\u003e \u0027mistral\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5f7c97a3_d501383b","line":54,"range":{"start_line":54,"start_character":20,"end_line":54,"end_character":45},"in_reply_to":"5f7c97a3_35a66c11","updated":"2018-06-19 22:18:44.000000000","message":"Done","commit_id":"e8a6c02d2f4ea870d7bb1f4e5197238dbd4fce4a"}]}