)]}'
{"manifests/fencing.pp":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"ab9c3f110cf1de9645de093da71ba5fecd38c969","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  $all_devices \u003d $config[\u0027devices\u0027]"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  if $::uuid !\u003d \u0027docker\u0027 {"},{"line_number":71,"context_line":"    $xvm_devices \u003d local_fence_devices(\u0027fence_xvm\u0027, $all_devices)"},{"line_number":72,"context_line":"    create_resources(\u0027pacemaker::stonith::fence_xvm\u0027, $xvm_devices, $common_params)"},{"line_number":73,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5f7c97a3_1b01b507","line":70,"updated":"2018-07-19 15:00:02.000000000","message":"Interesting! But I hope this isn\u0027t too fragile. I see that it relies on [1], but if something like [2] ever merges then L70 will no longer work.\n\n[1] https://github.com/openstack/tripleo-heat-templates/blob/master/docker/docker-puppet.py#L240\n[2] https://review.openstack.org/559182","commit_id":"27ba244ce78cc1631cb85a2b05cd6f84d38299a2"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"4b6b7b94ec779c3d4ba7a0fc77b5894fb139ab8d","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  $all_devices \u003d $config[\u0027devices\u0027]"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  if $::uuid !\u003d \u0027docker\u0027 {"},{"line_number":71,"context_line":"    $xvm_devices \u003d local_fence_devices(\u0027fence_xvm\u0027, $all_devices)"},{"line_number":72,"context_line":"    create_resources(\u0027pacemaker::stonith::fence_xvm\u0027, $xvm_devices, $common_params)"},{"line_number":73,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5f7c97a3_7ed3f7d3","line":70,"in_reply_to":"5f7c97a3_1b01b507","updated":"2018-07-19 15:26:28.000000000","message":"Meh if that [2] lands, we need to also fix up manifests/profile/base/database/mysql/client.pp. Does anyone know what other means there are in puppet to detect that we are inside a docker container? (short of checking for the /.dockerenv file) ?","commit_id":"27ba244ce78cc1631cb85a2b05cd6f84d38299a2"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"933a0cb0711383338c0cf99c2e7866119b08dc98","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  $all_devices \u003d $config[\u0027devices\u0027]"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  if $::uuid !\u003d \u0027docker\u0027 {"},{"line_number":71,"context_line":"    $xvm_devices \u003d local_fence_devices(\u0027fence_xvm\u0027, $all_devices)"},{"line_number":72,"context_line":"    create_resources(\u0027pacemaker::stonith::fence_xvm\u0027, $xvm_devices, $common_params)"},{"line_number":73,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5f7c97a3_849b2262","line":70,"in_reply_to":"5f7c97a3_2153203c","updated":"2018-07-19 16:26:26.000000000","message":"Agreed, I like the second idea as it is a bit more well defined. I\u0027ll throw a comment on the other review. Thanks for bringing this up, Alan!","commit_id":"27ba244ce78cc1631cb85a2b05cd6f84d38299a2"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"d9c9e76257bd2440254530bf017759c80b68faa3","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  $all_devices \u003d $config[\u0027devices\u0027]"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  if $::uuid !\u003d \u0027docker\u0027 {"},{"line_number":71,"context_line":"    $xvm_devices \u003d local_fence_devices(\u0027fence_xvm\u0027, $all_devices)"},{"line_number":72,"context_line":"    create_resources(\u0027pacemaker::stonith::fence_xvm\u0027, $xvm_devices, $common_params)"},{"line_number":73,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5f7c97a3_2153203c","line":70,"in_reply_to":"5f7c97a3_7ed3f7d3","updated":"2018-07-19 16:04:57.000000000","message":"Well, it could look for the presence of an environment variable like KOLLA_BASE_DISTRO.\n\n[root@overcloud-controller-0 ~]# docker exec -ti cinder_scheduler env | grep KOLLA\nKOLLA_CONFIG_STRATEGY\u003dCOPY_ALWAYS\nKOLLA_BASE_DISTRO\u003dcentos\nKOLLA_INSTALL_TYPE\u003dbinary\nKOLLA_INSTALL_METATYPE\u003drdo\n\nOr, maybe we add another custom puppet fact to docker_apply.sh, like:\n\nFACTER_in_container\u003dtrue\n\nThen test if the \u0027in_container\u0027 fact is defined.","commit_id":"27ba244ce78cc1631cb85a2b05cd6f84d38299a2"}]}
