)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"6a72f0b44ce497d298554c7f9e8fb7d3bbc7ef4d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Cédric Jeanneret \u003ccjeanner@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-07-19 14:38:55 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Corrected vrrp script for haproxy status"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, on a containerized undercloud, we get error messages from"},{"line_number":10,"context_line":"keepalived container:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_5a0870d6","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":9},"updated":"2018-07-20 09:51:43.000000000","message":"nit: correct","commit_id":"01665afac803b0c507885b524bca9359abd7561b"}],"manifests/keepalived.pp":[{"author":{"_account_id":27427,"name":"David Peacock","email":"dpeacock@redhat.com","username":"davidjpeacock"},"change_message_id":"aa5cae62f7c8c6fd628b36cc0a9b932343827f36","unresolved":false,"context_lines":[{"line_number":99,"context_line":"  case $::osfamily {"},{"line_number":100,"context_line":"    \u0027RedHat\u0027: {"},{"line_number":101,"context_line":"      $keepalived_name_is_process \u003d false"},{"line_number":102,"context_line":"      $keepalived_vrrp_script     \u003d \u0027test -f /var/run/haproxy.pid\u0027"},{"line_number":103,"context_line":"    } # RedHat"},{"line_number":104,"context_line":"    \u0027Debian\u0027: {"},{"line_number":105,"context_line":"      $keepalived_name_is_process \u003d true"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5f7c97a3_4a4afa82","line":102,"updated":"2018-07-19 12:05:33.000000000","message":"hmmm, what about actually checking for the existence of a running PID?  There\u0027s a possibility to find the daemon dead with an orphaned PID file left in situ, meaning this will give a misleading result.","commit_id":"11b9f99deb4507c4f218e1c684c1d891f3a5acb9"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"c46f7287883e47080ce8b846b53b904e226a157d","unresolved":false,"context_lines":[{"line_number":99,"context_line":"  case $::osfamily {"},{"line_number":100,"context_line":"    \u0027RedHat\u0027: {"},{"line_number":101,"context_line":"      $keepalived_name_is_process \u003d false"},{"line_number":102,"context_line":"      $keepalived_vrrp_script     \u003d \u0027test -f /var/run/haproxy.pid\u0027"},{"line_number":103,"context_line":"    } # RedHat"},{"line_number":104,"context_line":"    \u0027Debian\u0027: {"},{"line_number":105,"context_line":"      $keepalived_name_is_process \u003d true"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5f7c97a3_c5acbdef","line":102,"in_reply_to":"5f7c97a3_4a4afa82","updated":"2018-07-19 12:14:34.000000000","message":"hmm right. will check if pidof or the like exists in the container.","commit_id":"11b9f99deb4507c4f218e1c684c1d891f3a5acb9"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"2fc3b7391433257d0a0a49d01eb3907b97e0750e","unresolved":false,"context_lines":[{"line_number":99,"context_line":"  case $::osfamily {"},{"line_number":100,"context_line":"    \u0027RedHat\u0027: {"},{"line_number":101,"context_line":"      $keepalived_name_is_process \u003d false"},{"line_number":102,"context_line":"      $keepalived_vrrp_script     \u003d \u0027test -f /var/run/haproxy.pid \u0026\u0026 pgrep -F /var/run/haproxy.pid\u0027"},{"line_number":103,"context_line":"    } # RedHat"},{"line_number":104,"context_line":"    \u0027Debian\u0027: {"},{"line_number":105,"context_line":"      $keepalived_name_is_process \u003d true"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5f7c97a3_5d3f0ade","line":102,"range":{"start_line":102,"start_character":1,"end_line":102,"end_character":97},"updated":"2018-07-20 11:27:35.000000000","message":"Does https://github.com/openstack/tripleo-heat-templates/blob/master/docker/services/keepalived.yaml#L63 not work on the containerized undercloud? (i.e. does that one need fixing as well?)","commit_id":"ffd56ef311ecce8b908663ec238b67e189747c97"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"a29f666ce312eca5c136badc776ef2fbe6909e68","unresolved":false,"context_lines":[{"line_number":99,"context_line":"  case $::osfamily {"},{"line_number":100,"context_line":"    \u0027RedHat\u0027: {"},{"line_number":101,"context_line":"      $keepalived_name_is_process \u003d false"},{"line_number":102,"context_line":"      $keepalived_vrrp_script     \u003d \u0027test -f /var/run/haproxy.pid \u0026\u0026 pgrep -F /var/run/haproxy.pid\u0027"},{"line_number":103,"context_line":"    } # RedHat"},{"line_number":104,"context_line":"    \u0027Debian\u0027: {"},{"line_number":105,"context_line":"      $keepalived_name_is_process \u003d true"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5f7c97a3_10c3b98b","line":102,"range":{"start_line":102,"start_character":1,"end_line":102,"end_character":97},"in_reply_to":"5f7c97a3_10dad977","updated":"2018-07-20 11:42:20.000000000","message":"ugh, that was two separate commands, and whoami returned root","commit_id":"ffd56ef311ecce8b908663ec238b67e189747c97"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"dbc3a6a45e0bb324772d29d32fefbacebbab085d","unresolved":false,"context_lines":[{"line_number":99,"context_line":"  case $::osfamily {"},{"line_number":100,"context_line":"    \u0027RedHat\u0027: {"},{"line_number":101,"context_line":"      $keepalived_name_is_process \u003d false"},{"line_number":102,"context_line":"      $keepalived_vrrp_script     \u003d \u0027test -f /var/run/haproxy.pid \u0026\u0026 pgrep -F /var/run/haproxy.pid\u0027"},{"line_number":103,"context_line":"    } # RedHat"},{"line_number":104,"context_line":"    \u0027Debian\u0027: {"},{"line_number":105,"context_line":"      $keepalived_name_is_process \u003d true"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5f7c97a3_b07685a2","line":102,"range":{"start_line":102,"start_character":1,"end_line":102,"end_character":97},"in_reply_to":"5f7c97a3_5d3f0ade","updated":"2018-07-20 11:36:44.000000000","message":"user-access to the socket is always granted I think - so that one is also valid. Didn\u0027t think about this possibility, I was focused on the pid and existence of a process.\n\nI honestly don\u0027t know which solution is the best though... Both seems pretty valid/legit.","commit_id":"ffd56ef311ecce8b908663ec238b67e189747c97"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"db717e5aa5b6ba8e76593211d00f669fb98dd3bd","unresolved":false,"context_lines":[{"line_number":99,"context_line":"  case $::osfamily {"},{"line_number":100,"context_line":"    \u0027RedHat\u0027: {"},{"line_number":101,"context_line":"      $keepalived_name_is_process \u003d false"},{"line_number":102,"context_line":"      $keepalived_vrrp_script     \u003d \u0027test -f /var/run/haproxy.pid \u0026\u0026 pgrep -F /var/run/haproxy.pid\u0027"},{"line_number":103,"context_line":"    } # RedHat"},{"line_number":104,"context_line":"    \u0027Debian\u0027: {"},{"line_number":105,"context_line":"      $keepalived_name_is_process \u003d true"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5f7c97a3_10dad977","line":102,"range":{"start_line":102,"start_character":1,"end_line":102,"end_character":97},"in_reply_to":"5f7c97a3_b07685a2","updated":"2018-07-20 11:41:20.000000000","message":"@Michele, I think that other place shoud also be fixed, just tried on my UC:\n\n[zuul@undercloud ~]$ docker exec -it keepalived whoami echo \"show info\" | socat unix-connect:/var/lib/haproxy/haproxy.sock stdio\n-bash: socat: command not found\n[zuul@undercloud ~]$ echo \"show info\" | socat unix-connect:/var/lib/haproxy/haproxy.sock stdio\n-bash: socat: command not found","commit_id":"ffd56ef311ecce8b908663ec238b67e189747c97"}]}
