)]}'
{"templates/logrotate/containers_logrotate.conf.erb":[{"author":{"_account_id":17720,"name":"Masaki Hatada","email":"mas-hatada@rf.jp.nec.com","username":"hatada"},"change_message_id":"19dc73b1a2d99e01a47fb3f5faf2592a09065db3","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    # Httpd and neutron-server processes need to take another approach"},{"line_number":28,"context_line":"    /sbin/lsof -nPs +D /var/log/containers 2\u003e/dev/null |\\"},{"line_number":29,"context_line":"    grep -v -e /var/log/containers/httpd/ -e /var/log/containers/neutron/server |\\"},{"line_number":30,"context_line":"    awk \u0027/\\S+\\s+[0-9]+\\s.*\\/var\\/log\\/containers\\/\\S+\\.[0-9]+\\S+?$/ {print $2}\u0027 |\\"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    # USR1 to gracefully restart httpd processes owning rotated files"},{"line_number":33,"context_line":"    sort -u | /bin/xargs -n1 -r -t kill -HUP;"}],"source_content_type":"application/x-erb","patch_set":4,"id":"3f79a3b5_9751f010","line":30,"updated":"2018-08-28 05:29:29.000000000","message":"I\u0027d like to know why \"\\/var\\/log\\/containers\\/\\S+\\.[0-9]+$/\" was changed to \"\\/var\\/log\\/containers\\/\\S+\\.[0-9]+\\S+?$/\".\nThe strings like the following would come to be detected by the change, but I don\u0027t know why they have to be detected.\n\n- /var/log/containers/AAAA.log.1X\n- /var/log/containers/AAAA.log.1a2_3cdE\n\nIf you want to detect strings like \"/var/log/containers/AAAA.log.1 (deleted)\", it has to be changed to \"\\/var\\/log\\/containers\\/\\S+\\.[0-9]+\\s+?\\S+?$/\".\n(Although I\u0027m not sure you want to do that)","commit_id":"fb6d2e5fe10b250902ffb8dc4e735cf17c25519f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"50760b9d2d349eefcc884c8ad1e9af4ca75754cc","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    # Httpd and neutron-server processes need to take another approach"},{"line_number":28,"context_line":"    /sbin/lsof -nPs +D /var/log/containers 2\u003e/dev/null |\\"},{"line_number":29,"context_line":"    grep -v -e /var/log/containers/httpd/ -e /var/log/containers/neutron/server |\\"},{"line_number":30,"context_line":"    awk \u0027/\\S+\\s+[0-9]+\\s.*\\/var\\/log\\/containers\\/\\S+\\.[0-9]+\\S+?$/ {print $2}\u0027 |\\"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    # USR1 to gracefully restart httpd processes owning rotated files"},{"line_number":33,"context_line":"    sort -u | /bin/xargs -n1 -r -t kill -HUP;"}],"source_content_type":"application/x-erb","patch_set":4,"id":"3f79a3b5_3d71d3a9","line":30,"in_reply_to":"3f79a3b5_9751f010","updated":"2018-09-10 09:50:15.000000000","message":"I adjusted the filter to match the other possible dateext/dateformat/extension alterations as well, like foo.2018-09-06.log.tar.gz, foo.log.2018-09-10.tar.gz et al. note: no spaces allowed in file names to match it.","commit_id":"fb6d2e5fe10b250902ffb8dc4e735cf17c25519f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"23d8076b193bf03587f32af927731648177fca16","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    awk \u0027/\\S+\\s+[0-9]+\\s.*\\/var\\/log\\/containers\\/httpd\\/\\S+\\.[0-9]+\\S+?$/ {print $2}\u0027 |\\"},{"line_number":36,"context_line":"    sort -u | /bin/xargs -n1 -r -t kill -USR1;"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    # FIXME(bogdando): Unhealthy containers can\u0027t be restarted, until"},{"line_number":39,"context_line":"    # --exit-on-unhealthy supported. Therefore we cannot send TERM to self-heal."},{"line_number":40,"context_line":"    # LP#1780139: HUP does not work with neutron server API process."},{"line_number":41,"context_line":"    # Given above caveats, restart the neutron API container instead, if it is"}],"source_content_type":"application/x-erb","patch_set":4,"id":"3f79a3b5_0b741867","line":38,"updated":"2018-08-24 12:44:07.000000000","message":"there is an alternative to that part https://review.openstack.org/#/c/582661","commit_id":"fb6d2e5fe10b250902ffb8dc4e735cf17c25519f"},{"author":{"_account_id":17720,"name":"Masaki Hatada","email":"mas-hatada@rf.jp.nec.com","username":"hatada"},"change_message_id":"024df7df7870bb6094639d80b7e061aad7281815","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    # holding rotated server.log.X file."},{"line_number":43,"context_line":"    /sbin/lsof -nPs +D /var/log/containers/neutron 2\u003e/dev/null |\\"},{"line_number":44,"context_line":"    awk \u0027/\\S+\\s+[0-9]+\\s.*\\/var\\/log\\/containers\\/neutron\\/server\\S+\\.[0-9]+\\S+?$/ {print $1}\u0027 |\\"},{"line_number":45,"context_line":"    grep -q neutron-s \u0026\u0026 docker restart neutron_api ||:"},{"line_number":46,"context_line":"  endscript"},{"line_number":47,"context_line":"}"}],"source_content_type":"application/x-erb","patch_set":4,"id":"3f79a3b5_16008633","line":45,"updated":"2018-08-28 02:24:35.000000000","message":"Currently nova-compute has a bug about SIGHUP (lp#1715374).\nSo nova-compute should be restarted as well as neutron.\n(I don\u0027t know whether other OpenStack services also have a similar problem)","commit_id":"fb6d2e5fe10b250902ffb8dc4e735cf17c25519f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"50760b9d2d349eefcc884c8ad1e9af4ca75754cc","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    # holding rotated server.log.X file."},{"line_number":43,"context_line":"    /sbin/lsof -nPs +D /var/log/containers/neutron 2\u003e/dev/null |\\"},{"line_number":44,"context_line":"    awk \u0027/\\S+\\s+[0-9]+\\s.*\\/var\\/log\\/containers\\/neutron\\/server\\S+\\.[0-9]+\\S+?$/ {print $1}\u0027 |\\"},{"line_number":45,"context_line":"    grep -q neutron-s \u0026\u0026 docker restart neutron_api ||:"},{"line_number":46,"context_line":"  endscript"},{"line_number":47,"context_line":"}"}],"source_content_type":"application/x-erb","patch_set":4,"id":"3f79a3b5_dd653fe4","line":45,"in_reply_to":"3f79a3b5_16008633","updated":"2018-09-10 09:50:15.000000000","message":"ack, will do! thanks!","commit_id":"fb6d2e5fe10b250902ffb8dc4e735cf17c25519f"}]}
