)]}'
{"manifests/haproxy.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"84a7521c38215f0a8c1aff028394ae06d87224a3","unresolved":false,"context_lines":[{"line_number":639,"context_line":"  $ec2_api                     \u003d hiera(\u0027ec2_api_enabled\u0027, false),"},{"line_number":640,"context_line":"  $ec2_api_metadata            \u003d hiera(\u0027ec2_api_enabled\u0027, false),"},{"line_number":641,"context_line":"  $aodh                        \u003d hiera(\u0027aodh_api_enabled\u0027, false),"},{"line_number":642,"context_line":"  $metrics_qdr                  \u003d hiera(\u0027metrics_qdr_enabled\u0027, false),"},{"line_number":643,"context_line":"  $panko                       \u003d hiera(\u0027panko_api_enabled\u0027, false),"},{"line_number":644,"context_line":"  $barbican                    \u003d hiera(\u0027barbican_api_enabled\u0027, false),"},{"line_number":645,"context_line":"  $gnocchi                     \u003d hiera(\u0027gnocchi_api_enabled\u0027, false),"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"5fc1f717_a8af9429","line":642,"updated":"2019-04-02 15:56:52.000000000","message":"\u003d alignment","commit_id":"46a1bd2e466d4365173061302515ba829fdf85ea"}],"manifests/profile/base/metrics/qdr.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"84a7521c38215f0a8c1aff028394ae06d87224a3","unresolved":false,"context_lines":[{"line_number":44,"context_line":"#   Defaults to  \u0027no\u0027"},{"line_number":45,"context_line":"#"},{"line_number":46,"context_line":"# [*listener_require_ssl*]"},{"line_number":47,"context_line":"\u003c\u003c\u003c\u003c\u003c\u003c\u003c HEAD"},{"line_number":48,"context_line":"#   (optional) Require the use of SSL or TLS on the connection"},{"line_number":49,"context_line":"#   Defaults to \u0027no\u0027"},{"line_number":50,"context_line":"||||||| parent of c47790a9... Configuration changes to support Qdr-mesh topology."},{"line_number":51,"context_line":"#   (optional) Require the use of SSL on the connection"},{"line_number":52,"context_line":"#   Defaults to false"},{"line_number":53,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":54,"context_line":"#   (optional) Require the use of SSL on the connection"},{"line_number":55,"context_line":"#   Defaults to \u0027no\u0027"},{"line_number":56,"context_line":"\u003e\u003e\u003e\u003e\u003e\u003e\u003e c47790a9... Configuration changes to support Qdr-mesh topology."},{"line_number":57,"context_line":"#"},{"line_number":58,"context_line":"# [*listener_sasl_mech*]"},{"line_number":59,"context_line":"#   (optional) List of accepted SASL auth mechanisms"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"5fc1f717_28ee448b","line":56,"range":{"start_line":47,"start_character":0,"end_line":56,"end_character":71},"updated":"2019-04-02 15:56:52.000000000","message":"bad merge stuff here","commit_id":"46a1bd2e466d4365173061302515ba829fdf85ea"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"84a7521c38215f0a8c1aff028394ae06d87224a3","unresolved":false,"context_lines":[{"line_number":83,"context_line":"#   (optional) Path to file containing trusted certificates"},{"line_number":84,"context_line":"#   Defaults to \u0027UNSET\u0027"},{"line_number":85,"context_line":"#"},{"line_number":86,"context_line":"\u003c\u003c\u003c\u003c\u003c\u003c\u003c HEAD"},{"line_number":87,"context_line":"||||||| parent of c47790a9... Configuration changes to support Qdr-mesh topology."},{"line_number":88,"context_line":"# [*connector_require_encrypt*]"},{"line_number":89,"context_line":"#   (optional) Require the use of TLS encryption on the connection"},{"line_number":90,"context_line":"#   Defaults to false"},{"line_number":91,"context_line":"#"},{"line_number":92,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":93,"context_line":"# [*connector_require_encrypt*]"},{"line_number":94,"context_line":"#   (optional) Require the use of TLS encryption on the connection"},{"line_number":95,"context_line":"#   Defaults to false"},{"line_number":96,"context_line":"#"},{"line_number":97,"context_line":"# [*oslomsg_rpc_hosts*]"},{"line_number":98,"context_line":"#   list of oslo messaging rpc host fqdns"},{"line_number":99,"context_line":"#   Defaults to hiera(\u0027oslo_messaging_rpc_nodes_names\u0027, undef)"},{"line_number":100,"context_line":"#"},{"line_number":101,"context_line":"\u003e\u003e\u003e\u003e\u003e\u003e\u003e c47790a9... Configuration changes to support Qdr-mesh topology."},{"line_number":102,"context_line":"# [*connectors*]"},{"line_number":103,"context_line":"#   (optional) List of hashes containing configuration for outgoing connections"},{"line_number":104,"context_line":"#   from the router. Each hash should contain \u0027host\u0027, \u0027role\u0027 and \u0027port\u0027 key."}],"source_content_type":"text/x-puppet","patch_set":6,"id":"5fc1f717_48f39074","line":101,"range":{"start_line":86,"start_character":0,"end_line":101,"end_character":71},"updated":"2019-04-02 15:56:52.000000000","message":"same","commit_id":"46a1bd2e466d4365173061302515ba829fdf85ea"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"84a7521c38215f0a8c1aff028394ae06d87224a3","unresolved":false,"context_lines":[{"line_number":132,"context_line":"  $listener_ssl_key_file     \u003d undef,"},{"line_number":133,"context_line":"  $listener_ssl_pw_file      \u003d undef,"},{"line_number":134,"context_line":"  $listener_ssl_password     \u003d undef,"},{"line_number":135,"context_line":"  $listener_trusted_certs    \u003d undef, "},{"line_number":136,"context_line":"  $oslomsg_rpc_hosts         \u003d hiera(\u0027oslo_messaging_rpc_node_names\u0027, undef),"},{"line_number":137,"context_line":"  $connectors                \u003d [],"},{"line_number":138,"context_line":"  $addresses                 \u003d [],"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"5fc1f717_08ed888a","line":135,"range":{"start_line":135,"start_character":37,"end_line":135,"end_character":38},"updated":"2019-04-02 15:56:52.000000000","message":"trailing space","commit_id":"46a1bd2e466d4365173061302515ba829fdf85ea"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"84a7521c38215f0a8c1aff028394ae06d87224a3","unresolved":false,"context_lines":[{"line_number":132,"context_line":"  $listener_ssl_key_file     \u003d undef,"},{"line_number":133,"context_line":"  $listener_ssl_pw_file      \u003d undef,"},{"line_number":134,"context_line":"  $listener_ssl_password     \u003d undef,"},{"line_number":135,"context_line":"  $listener_trusted_certs    \u003d undef, "},{"line_number":136,"context_line":"  $oslomsg_rpc_hosts         \u003d hiera(\u0027oslo_messaging_rpc_node_names\u0027, undef),"},{"line_number":137,"context_line":"  $connectors                \u003d [],"},{"line_number":138,"context_line":"  $addresses                 \u003d [],"},{"line_number":139,"context_line":"  $extra_listeners           \u003d [],"},{"line_number":140,"context_line":"  $step                      \u003d Integer(hiera(\u0027step\u0027)),"},{"line_number":141,"context_line":") {"},{"line_number":142,"context_line":"  $qdr_controller_nodes \u003d $oslomsg_rpc_hosts"},{"line_number":143,"context_line":"  if $step \u003e\u003d 1 {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"5fc1f717_e89cbc0f","line":140,"range":{"start_line":135,"start_character":0,"end_line":140,"end_character":54},"updated":"2019-04-02 15:56:52.000000000","message":"please fix the \u003d alignment","commit_id":"46a1bd2e466d4365173061302515ba829fdf85ea"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"84a7521c38215f0a8c1aff028394ae06d87224a3","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    }"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    class { \u0027::qdr\u0027:"},{"line_number":173,"context_line":"      listener_addr             \u003d\u003e $listener_addr,"},{"line_number":174,"context_line":"      listener_port             \u003d\u003e $listener_port,"},{"line_number":175,"context_line":"      listener_require_encrypt  \u003d\u003e $listener_require_encrypt,"},{"line_number":176,"context_line":"      listener_require_ssl      \u003d\u003e $listener_require_ssl,"},{"line_number":177,"context_line":"      listener_ssl_cert_db      \u003d\u003e $listener_ssl_cert_db,"},{"line_number":178,"context_line":"      listener_ssl_cert_file    \u003d\u003e $listener_ssl_cert_file,"},{"line_number":179,"context_line":"      listener_ssl_key_file     \u003d\u003e $listener_ssl_key_file,"},{"line_number":180,"context_line":"      listener_ssl_pw_file      \u003d\u003e $listener_ssl_pw_file,"},{"line_number":181,"context_line":"      listener_ssl_password     \u003d\u003e $listener_ssl_password,"},{"line_number":182,"context_line":"      listener_trusted_certs    \u003d\u003e $listener_trusted_certs,"},{"line_number":183,"context_line":"      # TO-DO(mmagr): Metrics QDRs gonna run in edge mode as soon as we will"},{"line_number":184,"context_line":"      # have a newest version of qpid-dispatch-router. Until then we have to run"},{"line_number":185,"context_line":"      # in interior mode"},{"line_number":186,"context_line":"      #router_mode              \u003d\u003e \u0027edge\u0027,"},{"line_number":187,"context_line":"      router_mode               \u003d\u003e $qdr_router_mode,"},{"line_number":188,"context_line":"      connectors                \u003d\u003e $qdr_connectors,"},{"line_number":189,"context_line":"      extra_addresses           \u003d\u003e $addresses,"},{"line_number":190,"context_line":"      extra_listeners           \u003d\u003e $extra_listeners,"},{"line_number":191,"context_line":"    }"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    qdr_user { $username:"},{"line_number":194,"context_line":"      ensure   \u003d\u003e present,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"5fc1f717_e8b59c7f","line":191,"range":{"start_line":173,"start_character":0,"end_line":191,"end_character":5},"updated":"2019-04-02 15:56:52.000000000","message":"looks like you added a bunch of extra spaces before the \u003d\u003e that didn\u0027t need to be moved","commit_id":"46a1bd2e466d4365173061302515ba829fdf85ea"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"05ab539369b058af0e187c40d3081a40686c6902","unresolved":false,"context_lines":[{"line_number":133,"context_line":"  $extra_listeners          \u003d [],"},{"line_number":134,"context_line":"  $step                     \u003d Integer(hiera(\u0027step\u0027)),"},{"line_number":135,"context_line":") {"},{"line_number":136,"context_line":"  $qdr_node_names \u003d $oslomsg_rpc_hosts"},{"line_number":137,"context_line":"  if $step \u003e\u003d 1 {"},{"line_number":138,"context_line":"    if $connector_addr {"},{"line_number":139,"context_line":"      $qdr_connectors \u003d $node_names.reduce([]) |$memo, $node| {"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"dfbec78f_8de08598","line":136,"range":{"start_line":136,"start_character":21,"end_line":136,"end_character":38},"updated":"2019-05-09 07:14:22.000000000","message":"This var was not set before using it. I think it could be controller_node_names.\nhttp://logs.openstack.org/08/647908/15/check/puppet-openstack-lint-ubuntu-bionic/2407f78/job-output.txt.gz#_2019-05-08_20_39_37_424791","commit_id":"ba8b6803107b1316c859558f183925d417313836"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"05ab539369b058af0e187c40d3081a40686c6902","unresolved":false,"context_lines":[{"line_number":136,"context_line":"  $qdr_node_names \u003d $oslomsg_rpc_hosts"},{"line_number":137,"context_line":"  if $step \u003e\u003d 1 {"},{"line_number":138,"context_line":"    if $connector_addr {"},{"line_number":139,"context_line":"      $qdr_connectors \u003d $node_names.reduce([]) |$memo, $node| {"},{"line_number":140,"context_line":"        $memo + [{\u0027host\u0027 \u003d\u003e $node,"},{"line_number":141,"context_line":"                  \u0027port\u0027 \u003d\u003e \u00275668\u0027,"},{"line_number":142,"context_line":"                  \u0027role\u0027 \u003d\u003e \u0027edge\u0027,"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"dfbec78f_6dfe7138","line":139,"range":{"start_line":139,"start_character":25,"end_line":139,"end_character":35},"updated":"2019-05-09 07:14:22.000000000","message":"This var was not set before using it. I think it could be the qdr_node_names.\nhttp://logs.openstack.org/08/647908/15/check/puppet-openstack-lint-ubuntu-bionic/2407f78/job-output.txt.gz#_2019-05-08_20_39_37_424875","commit_id":"ba8b6803107b1316c859558f183925d417313836"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"05ab539369b058af0e187c40d3081a40686c6902","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        $memo + [{\u0027host\u0027 \u003d\u003e $node,"},{"line_number":141,"context_line":"                  \u0027port\u0027 \u003d\u003e \u00275668\u0027,"},{"line_number":142,"context_line":"                  \u0027role\u0027 \u003d\u003e \u0027edge\u0027,"},{"line_number":143,"context_line":"                  \u0027verifyHostname\u0027 \u003d\u003e \u0027false\u0027,"},{"line_number":144,"context_line":"                  \u0027sslProfile\u0027 \u003d\u003e $ssl_profile_name}]"},{"line_number":145,"context_line":"      }"},{"line_number":146,"context_line":"      $qdr_router_mode \u003d \u0027edge\u0027"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"dfbec78f_cd843db4","line":143,"range":{"start_line":143,"start_character":38,"end_line":143,"end_character":45},"updated":"2019-05-09 07:14:22.000000000","message":"false, without quotes.\nhttp://logs.openstack.org/08/647908/15/check/puppet-openstack-lint-ubuntu-bionic/2407f78/job-output.txt.gz#_2019-05-08_20_39_37_424052","commit_id":"ba8b6803107b1316c859558f183925d417313836"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"05ab539369b058af0e187c40d3081a40686c6902","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            $memo + [{\u0027host\u0027 \u003d\u003e $node,"},{"line_number":157,"context_line":"                      \u0027role\u0027 \u003d\u003e \u0027inter-router\u0027,"},{"line_number":158,"context_line":"                      \u0027port\u0027 \u003d\u003e \u00275667\u0027,"},{"line_number":159,"context_line":"                      \u0027verifyHostname\u0027 \u003d\u003e \u0027false\u0027,"},{"line_number":160,"context_line":"                      \u0027sslProfile\u0027 \u003d\u003e $ssl_profile_name}]"},{"line_number":161,"context_line":"          }"},{"line_number":162,"context_line":"        }"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"dfbec78f_2dbf1962","line":159,"range":{"start_line":159,"start_character":42,"end_line":159,"end_character":49},"updated":"2019-05-09 07:14:22.000000000","message":"false, without quotes.\nhttp://logs.openstack.org/08/647908/15/check/puppet-openstack-lint-ubuntu-bionic/2407f78/job-output.txt.gz#_2019-05-08_20_39_37_424306","commit_id":"ba8b6803107b1316c859558f183925d417313836"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"05ab539369b058af0e187c40d3081a40686c6902","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                      \u0027port\u0027 \u003d\u003e \u00275667\u0027,"},{"line_number":170,"context_line":"                      \u0027role\u0027 \u003d\u003e \u0027inter-router\u0027,"},{"line_number":171,"context_line":"                      \u0027authenticatePeer\u0027 \u003d\u003e \u0027no\u0027,"},{"line_number":172,"context_line":"                      \u0027verifyHostname\u0027 \u003d\u003e \u0027false\u0027,"},{"line_number":173,"context_line":"                      \u0027saslMechanisms\u0027 \u003d\u003e \u0027ANONYMOUS\u0027,"},{"line_number":174,"context_line":"                      \u0027sslProfile\u0027 \u003d\u003e $ssl_profile_name}]"},{"line_number":175,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"dfbec78f_4dc28deb","line":172,"range":{"start_line":172,"start_character":42,"end_line":172,"end_character":49},"updated":"2019-05-09 07:14:22.000000000","message":"false, without quotes.\nhttp://logs.openstack.org/08/647908/15/check/puppet-openstack-lint-ubuntu-bionic/2407f78/job-output.txt.gz#_2019-05-08_20_39_37_424464","commit_id":"ba8b6803107b1316c859558f183925d417313836"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"05ab539369b058af0e187c40d3081a40686c6902","unresolved":false,"context_lines":[{"line_number":177,"context_line":"                              \u0027port\u0027 \u003d\u003e \u00275668\u0027,"},{"line_number":178,"context_line":"                              \u0027role\u0027 \u003d\u003e \u0027edge\u0027,"},{"line_number":179,"context_line":"                              \u0027authenticatePeer\u0027 \u003d\u003e \u0027no\u0027,"},{"line_number":180,"context_line":"                              \u0027verifyHostname\u0027 \u003d\u003e \u0027false\u0027,"},{"line_number":181,"context_line":"                              \u0027saslMechanisms\u0027 \u003d\u003e \u0027ANONYMOUS\u0027,"},{"line_number":182,"context_line":"                              \u0027sslProfile\u0027 \u003d\u003e $ssl_profile_name}]"},{"line_number":183,"context_line":"      $qdr_connectors \u003d concat($connectors, $internal_connectors)"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"dfbec78f_adb22993","line":180,"range":{"start_line":180,"start_character":50,"end_line":180,"end_character":57},"updated":"2019-05-09 07:14:22.000000000","message":"false, without quotes.\nhttp://logs.openstack.org/08/647908/15/check/puppet-openstack-lint-ubuntu-bionic/2407f78/job-output.txt.gz#_2019-05-08_20_39_37_424611","commit_id":"ba8b6803107b1316c859558f183925d417313836"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"3e529cfc0f452a88c8d0a9bf3f164df2a072cb65","unresolved":false,"context_lines":[{"line_number":109,"context_line":"#   for more details."},{"line_number":110,"context_line":"#   Defaults to hiera(\u0027step\u0027)"},{"line_number":111,"context_line":"#"},{"line_number":112,"context_line":"class tripleo::profile::base::metrics::qdr ("},{"line_number":113,"context_line":"  $username                  \u003d undef,"},{"line_number":114,"context_line":"  $password                  \u003d undef,"},{"line_number":115,"context_line":"  $listener_addr             \u003d \u0027localhost\u0027,"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"bfb3d3c7_e3050d15","line":112,"updated":"2019-05-30 23:56:53.000000000","message":"please cover this with tests","commit_id":"4241017fe1c8bea963cb703d728c5a108cfbff66"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"2bf4d6d4ceb1cfa7140206db56ce9731770778d2","unresolved":false,"context_lines":[{"line_number":148,"context_line":"      $interior_connectors \u003d $interior_node_names.reduce([]) |$memo, $node| {"},{"line_number":149,"context_line":"        if $::hostname in $node {"},{"line_number":150,"context_line":"          $memo + true"},{"line_number":151,"context_line":"        } else {"},{"line_number":152,"context_line":"          if true in $memo {"},{"line_number":153,"context_line":"            $memo"},{"line_number":154,"context_line":"          } else {"},{"line_number":155,"context_line":"            $memo + [{\u0027host\u0027 \u003d\u003e $node,"},{"line_number":156,"context_line":"                      \u0027role\u0027 \u003d\u003e \u0027inter-router\u0027,"},{"line_number":157,"context_line":"                      \u0027port\u0027 \u003d\u003e \u00275667\u0027,"}],"source_content_type":"text/x-puppet","patch_set":24,"id":"7faddb67_41ee0a8c","line":154,"range":{"start_line":151,"start_character":10,"end_line":154,"end_character":18},"updated":"2019-08-09 11:55:59.000000000","message":"elif true not in $memo","commit_id":"1b0e6a23128505536dd279aaba6e75030453c28f"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"2bf4d6d4ceb1cfa7140206db56ce9731770778d2","unresolved":false,"context_lines":[{"line_number":160,"context_line":"          }"},{"line_number":161,"context_line":"        }"},{"line_number":162,"context_line":"      } - true"},{"line_number":163,"context_line":"      $listener_hostname \u003d hiera(\u0027fqdn_internal_api\u0027, undef)"},{"line_number":164,"context_line":"      $interior_qdr_listener \u003d size($interior_node_names) ? {"},{"line_number":165,"context_line":"        1        \u003d\u003e [],"},{"line_number":166,"context_line":"        default  \u003d\u003e [{\u0027host\u0027 \u003d\u003e $listener_hostname,"}],"source_content_type":"text/x-puppet","patch_set":24,"id":"7faddb67_41bcca6b","line":163,"range":{"start_line":163,"start_character":27,"end_line":163,"end_character":60},"updated":"2019-08-09 11:55:59.000000000","message":"this should be overridable by class\u0027 parameter","commit_id":"1b0e6a23128505536dd279aaba6e75030453c28f"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"db47127684f3cd1dfaf289beb152d82151b6fc7c","unresolved":false,"context_lines":[{"line_number":160,"context_line":"          }"},{"line_number":161,"context_line":"        }"},{"line_number":162,"context_line":"      } - true"},{"line_number":163,"context_line":"      $listener_hostname \u003d hiera(\u0027fqdn_internal_api\u0027, undef)"},{"line_number":164,"context_line":"      $interior_qdr_listener \u003d size($interior_node_names) ? {"},{"line_number":165,"context_line":"        1        \u003d\u003e [],"},{"line_number":166,"context_line":"        default  \u003d\u003e [{\u0027host\u0027 \u003d\u003e $listener_hostname,"}],"source_content_type":"text/x-puppet","patch_set":24,"id":"7faddb67_a901ce6c","line":163,"range":{"start_line":163,"start_character":27,"end_line":163,"end_character":60},"in_reply_to":"7faddb67_32031ec1","updated":"2019-08-12 09:58:11.000000000","message":"just move $listener_hostname \u003d hiera(\u0027fqdn_internal_api\u0027, undef) to line 135 ... eg. have listener_hostname as parameter.","commit_id":"1b0e6a23128505536dd279aaba6e75030453c28f"},{"author":{"_account_id":28504,"name":"Vinay Kapalavai","email":"vkapalav@redhat.com","username":"vkapalav"},"change_message_id":"0ce0476f0e57fe1d558571859a310fab8735914b","unresolved":false,"context_lines":[{"line_number":160,"context_line":"          }"},{"line_number":161,"context_line":"        }"},{"line_number":162,"context_line":"      } - true"},{"line_number":163,"context_line":"      $listener_hostname \u003d hiera(\u0027fqdn_internal_api\u0027, undef)"},{"line_number":164,"context_line":"      $interior_qdr_listener \u003d size($interior_node_names) ? {"},{"line_number":165,"context_line":"        1        \u003d\u003e [],"},{"line_number":166,"context_line":"        default  \u003d\u003e [{\u0027host\u0027 \u003d\u003e $listener_hostname,"}],"source_content_type":"text/x-puppet","patch_set":24,"id":"7faddb67_32031ec1","line":163,"range":{"start_line":163,"start_character":27,"end_line":163,"end_character":60},"in_reply_to":"7faddb67_41bcca6b","updated":"2019-08-09 14:01:38.000000000","message":"Okay, so do you have any other suggestion that I could do instead..?","commit_id":"1b0e6a23128505536dd279aaba6e75030453c28f"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"2bf4d6d4ceb1cfa7140206db56ce9731770778d2","unresolved":false,"context_lines":[{"line_number":197,"context_line":"      ssl_profiles             \u003d\u003e $ssl_profiles,"},{"line_number":198,"context_line":"      extra_addresses          \u003d\u003e $addresses,"},{"line_number":199,"context_line":"      autolink_addresses       \u003d\u003e $autolink_addresses,"},{"line_number":200,"context_line":"      extra_listeners          \u003d\u003e $extra_listeners_real,"},{"line_number":201,"context_line":"    }"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    qdr_user { $username:"}],"source_content_type":"text/x-puppet","patch_set":24,"id":"7faddb67_e15a964e","line":200,"range":{"start_line":200,"start_character":6,"end_line":200,"end_character":56},"updated":"2019-08-09 11:55:59.000000000","message":"So the question I have here is if we really need one listener for interior routers\u0027 communication and one listener for edge routers\u0027 communication ... can we achieve the same with just one listener per each router?","commit_id":"1b0e6a23128505536dd279aaba6e75030453c28f"},{"author":{"_account_id":28504,"name":"Vinay Kapalavai","email":"vkapalav@redhat.com","username":"vkapalav"},"change_message_id":"4f088036091172e3326be32000a8c8ae595f8736","unresolved":false,"context_lines":[{"line_number":197,"context_line":"      ssl_profiles             \u003d\u003e $ssl_profiles,"},{"line_number":198,"context_line":"      extra_addresses          \u003d\u003e $addresses,"},{"line_number":199,"context_line":"      autolink_addresses       \u003d\u003e $autolink_addresses,"},{"line_number":200,"context_line":"      extra_listeners          \u003d\u003e $extra_listeners_real,"},{"line_number":201,"context_line":"    }"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    qdr_user { $username:"}],"source_content_type":"text/x-puppet","patch_set":24,"id":"7faddb67_921c52c2","line":200,"range":{"start_line":200,"start_character":6,"end_line":200,"end_character":56},"in_reply_to":"7faddb67_1244e21a","updated":"2019-08-09 14:19:20.000000000","message":"just confirmed this from ansmith, since the roles of two listeners are different he recommended to have different listeners for each one.","commit_id":"1b0e6a23128505536dd279aaba6e75030453c28f"},{"author":{"_account_id":28504,"name":"Vinay Kapalavai","email":"vkapalav@redhat.com","username":"vkapalav"},"change_message_id":"0ce0476f0e57fe1d558571859a310fab8735914b","unresolved":false,"context_lines":[{"line_number":197,"context_line":"      ssl_profiles             \u003d\u003e $ssl_profiles,"},{"line_number":198,"context_line":"      extra_addresses          \u003d\u003e $addresses,"},{"line_number":199,"context_line":"      autolink_addresses       \u003d\u003e $autolink_addresses,"},{"line_number":200,"context_line":"      extra_listeners          \u003d\u003e $extra_listeners_real,"},{"line_number":201,"context_line":"    }"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    qdr_user { $username:"}],"source_content_type":"text/x-puppet","patch_set":24,"id":"7faddb67_1244e21a","line":200,"range":{"start_line":200,"start_character":6,"end_line":200,"end_character":56},"in_reply_to":"7faddb67_e15a964e","updated":"2019-08-09 14:01:38.000000000","message":"Ha that\u0027s really a good question for which I don\u0027t have an answer. I\u0027ll verify it manually to check if that works that way.","commit_id":"1b0e6a23128505536dd279aaba6e75030453c28f"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"2e90f4037ba646ab03311f97c5454a3bc0b2a946","unresolved":false,"context_lines":[{"line_number":182,"context_line":"    }"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    class { \u0027::qdr\u0027:"},{"line_number":185,"context_line":"      listener_addr            \u003d\u003e $listener_addr,"},{"line_number":186,"context_line":"      listener_port            \u003d\u003e $listener_port,"},{"line_number":187,"context_line":"      listener_require_encrypt \u003d\u003e $listener_require_encrypt,"},{"line_number":188,"context_line":"      listener_require_ssl     \u003d\u003e $listener_require_ssl,"},{"line_number":189,"context_line":"      listener_ssl_cert_db     \u003d\u003e $listener_ssl_cert_db,"},{"line_number":190,"context_line":"      listener_ssl_cert_file   \u003d\u003e $listener_ssl_cert_file,"},{"line_number":191,"context_line":"      listener_ssl_key_file    \u003d\u003e $listener_ssl_key_file,"},{"line_number":192,"context_line":"      listener_ssl_pw_file     \u003d\u003e $listener_ssl_pw_file,"},{"line_number":193,"context_line":"      listener_ssl_password    \u003d\u003e $listener_ssl_password,"},{"line_number":194,"context_line":"      listener_trusted_certs   \u003d\u003e $listener_trusted_certs,"},{"line_number":195,"context_line":"      router_mode              \u003d\u003e $router_mode,"},{"line_number":196,"context_line":"      connectors               \u003d\u003e $qdr_connectors,"},{"line_number":197,"context_line":"      ssl_profiles             \u003d\u003e $ssl_profiles,"},{"line_number":198,"context_line":"      extra_addresses          \u003d\u003e $addresses,"},{"line_number":199,"context_line":"      autolink_addresses       \u003d\u003e $autolink_addresses,"},{"line_number":200,"context_line":"      extra_listeners          \u003d\u003e $extra_listeners_real,"},{"line_number":201,"context_line":"    }"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    qdr_user { $username:"}],"source_content_type":"text/x-puppet","patch_set":26,"id":"7faddb67_51eeb88b","line":200,"range":{"start_line":185,"start_character":0,"end_line":200,"end_character":56},"updated":"2019-08-12 17:44:45.000000000","message":"These are the vars you\u0027d check in the tests with the .with(...)","commit_id":"6166e2597e08c61841b6db236be7def84bec8b04"}],"spec/classes/tripleo_profile_base_metrics_qdr_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"2e90f4037ba646ab03311f97c5454a3bc0b2a946","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"      it \u0027should setup interior router mode\u0027 do"},{"line_number":44,"context_line":"        is_expected.to contain_class(\u0027qdr\u0027).with("},{"line_number":45,"context_line":"          :interior_qdr_listener \u003d\u003e [],"},{"line_number":46,"context_line":"          :interior_qdr_extra_listener \u003d\u003e ["},{"line_number":47,"context_line":"            {\u0027host\u0027 \u003d\u003e \u0027node.example.com\u0027,\u0027port\u0027 \u003d\u003e \u00275668\u0027,\u0027role\u0027 \u003d\u003e \u0027edge\u0027,\u0027authenticatePeer\u0027 \u003d\u003e \u0027no\u0027,"},{"line_number":48,"context_line":"             \u0027saslMechanisms\u0027 \u003d\u003e \u0027ANONYMOUS\u0027,\u0027sslProfile\u0027 \u003d\u003e \u0027sslProfile\u0027}],"},{"line_number":49,"context_line":"          :interior_connectors \u003d\u003e [],"},{"line_number":50,"context_line":"        )"},{"line_number":51,"context_line":"      end"},{"line_number":52,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":26,"id":"7faddb67_d1d868f1","line":49,"range":{"start_line":45,"start_character":0,"end_line":49,"end_character":37},"updated":"2019-08-12 17:44:45.000000000","message":"These are not parameters to the qdr class.","commit_id":"6166e2597e08c61841b6db236be7def84bec8b04"}]}