)]}'
{"id":"openstack%2Fpuppet-tripleo~655422","triplet_id":"openstack%2Fpuppet-tripleo~stable%2Frocky~I5a757f88963270e77c8ec411cd292a30f89c6bc0","project":"openstack/puppet-tripleo","branch":"stable/rocky","topic":"bug/1825366-stable/rocky","hashtags":[],"change_id":"I5a757f88963270e77c8ec411cd292a30f89c6bc0","subject":"Fix keepalived VIP monitoring script","status":"MERGED","created":"2019-04-24 12:47:32.000000000","updated":"2019-04-25 02:00:10.000000000","submitted":"2019-04-25 02:00:10.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"655422-1556157610538-eaa21e4c","meta_rev_id":"6e291a0c86b1d6f948e4418fa5458264b5cfad31","_number":655422,"virtual_id_number":655422,"owner":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-04-25 02:00:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2019-04-24 15:52:00.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":2,"date":"2019-04-24 22:18:03.000000000","_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":1,"date":"2019-04-24 22:18:03.000000000","_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"date":"2019-04-24 12:47:32.000000000","_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-04-24 12:47:32.000000000","updated_by":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"reviewer":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"state":"REVIEWER"},{"updated":"2019-04-24 15:52:00.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-04-24 22:18:03.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2019-04-25 02:00:10.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"5b95020751e7fd38ae11354ea0120208691fe0a3","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2019-04-24 12:47:32.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"4ce17cd219a3931534a85f30ec4a2ece96f0673b","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-04-24 15:52:00.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001 http://logs.rdoproject.org/22/655422/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001/a05e0a8/ : FAILURE in 1h 27m 23s\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset035 http://logs.rdoproject.org/22/655422/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset035/db6b604/ : SUCCESS in 2h 31m 17s\n- tripleo-ci-centos-7-ovb-3ctlr_1comp_1supp-featureset039 http://logs.rdoproject.org/22/655422/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp_1supp-featureset039/51f6cf0/ : SUCCESS in 3h 01m 55s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"27b58a41c16f8b6d5d561b9f806e900d8ad56467","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-24 16:45:28.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-undercloud-oooq http://logs.openstack.org/22/655422/1/check/tripleo-ci-centos-7-undercloud-oooq/1dba07a/ : SUCCESS in 1h 12m 02s\n- tripleo-ci-centos-7-undercloud-upgrades http://logs.openstack.org/22/655422/1/check/tripleo-ci-centos-7-undercloud-upgrades/485acc9/ : SUCCESS in 1h 57m 42s\n- tripleo-ci-centos-7-undercloud-containers http://logs.openstack.org/22/655422/1/check/tripleo-ci-centos-7-undercloud-containers/fe2a1d9/ : SUCCESS in 1h 40m 41s\n- tripleo-ci-centos-7-containerized-undercloud-upgrades http://logs.openstack.org/22/655422/1/check/tripleo-ci-centos-7-containerized-undercloud-upgrades/9483d30/ : SUCCESS in 1h 58m 36s (non-voting)\n- tripleo-ci-centos-7-containers-multinode http://logs.openstack.org/22/655422/1/check/tripleo-ci-centos-7-containers-multinode/7c98e9c/ : SUCCESS in 2h 10m 37s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates http://logs.openstack.org/22/655422/1/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates/59fdf31/ : SUCCESS in 2h 15m 04s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades http://logs.openstack.org/22/655422/1/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades/8e3e8c8/ : SUCCESS in 2h 38m 46s (non-voting)\n- tripleo-ci-centos-7-standalone http://logs.openstack.org/22/655422/1/check/tripleo-ci-centos-7-standalone/f2d5c2e/ : SUCCESS in 1h 43m 16s\n- puppet-openstack-lint http://logs.openstack.org/22/655422/1/check/puppet-openstack-lint/693e7aa/ : SUCCESS in 4m 54s\n- puppet-openstack-syntax-4 http://logs.openstack.org/22/655422/1/check/puppet-openstack-syntax-4/9a3f328/ : SUCCESS in 4m 14s\n- puppet-openstack-unit-4.8-centos-7 http://logs.openstack.org/22/655422/1/check/puppet-openstack-unit-4.8-centos-7/24a2da3/ : SUCCESS in 32m 55s","accounts_in_message":[],"_revision_number":1},{"id":"9fb0dc665c8522472420abb13a8bf3c53f3d2a49","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-04-24 22:18:03.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"1d2aada0f23228c7701f935bf4a8681c9bf6ac1b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-24 22:18:30.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"901d13edd1a3a1e3a1c40c98ffb4b7f2cbc943bf","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-24 22:56:54.000000000","message":"Patch Set 1:\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"21c4359002a6a1ed220caa3fbaf5c005958748dc","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-25 02:00:10.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"a5394de868202f1264ed3823edee3d3af5c22992","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-25 02:00:10.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tripleo-ci-centos-7-undercloud-oooq http://logs.openstack.org/22/655422/1/gate/tripleo-ci-centos-7-undercloud-oooq/bf63a81/ : SUCCESS in 1h 09m 00s\n- tripleo-ci-centos-7-undercloud-containers http://logs.openstack.org/22/655422/1/gate/tripleo-ci-centos-7-undercloud-containers/519c3e2/ : SUCCESS in 1h 34m 00s\n- tripleo-ci-centos-7-containers-multinode http://logs.openstack.org/22/655422/1/gate/tripleo-ci-centos-7-containers-multinode/62149d4/ : SUCCESS in 2h 12m 51s\n- tripleo-ci-centos-7-standalone http://logs.openstack.org/22/655422/1/gate/tripleo-ci-centos-7-standalone/9f4709f/ : SUCCESS in 1h 33m 46s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates http://logs.openstack.org/22/655422/1/gate/tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates/c889cf3/ : SUCCESS in 2h 40m 05s\n- puppet-openstack-lint http://logs.openstack.org/22/655422/1/gate/puppet-openstack-lint/998cbe3/ : SUCCESS in 6m 02s\n- puppet-openstack-syntax-4 http://logs.openstack.org/22/655422/1/gate/puppet-openstack-syntax-4/1b54e6f/ : SUCCESS in 7m 53s\n- puppet-openstack-unit-4.8-centos-7 http://logs.openstack.org/22/655422/1/gate/puppet-openstack-unit-4.8-centos-7/bc99f80/ : SUCCESS in 32m 20s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"638ba0b92d881623483d2bc968c474bca1f2fc49","revisions":{"638ba0b92d881623483d2bc968c474bca1f2fc49":{"kind":"REWORK","_number":1,"created":"2019-04-24 12:47:32.000000000","uploader":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"ref":"refs/changes/22/655422/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-tripleo","ref":"refs/changes/22/655422/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/22/655422/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/22/655422/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/22/655422/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-tripleo refs/changes/22/655422/1"}}},"commit":{"parents":[{"commit":"9d0afafaea3fce22b5f2780ba27c084379fe015f","subject":"Merge \"Add httpd and tls support to manila-api\" into stable/rocky","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/9d0afafaea3fce22b5f2780ba27c084379fe015f"}]}],"author":{"name":"Damien Ciabrini","email":"dciabrin@redhat.com","date":"2019-04-18 13:29:33.000000000","tz":120},"committer":{"name":"Emilien Macchi","email":"emilien@redhat.com","date":"2019-04-24 12:47:32.000000000","tz":0},"subject":"Fix keepalived VIP monitoring script","message":"Fix keepalived VIP monitoring script\n\nCurrently keepalived monitors VIPs by running some shell commands\nthat target HAProxy. The generated shell command is invalid, which\nmakes keepalived log errors.\n\nTue Apr 16 11:55:57 2019:    Command \u003d \u0027/usr/bin/test\u0027 \u0027-S\u0027 \u0027/var/lib/haproxy/stats\u0027 \u0027\u0026\u0026\u0027 \u0027echo\u0027 \u0027show\u0027\nTue Apr 16 11:55:57 2019: Script `haproxy` now returning 2\nTue Apr 16 11:55:57 2019: VRRP_Script(haproxy) failed (exited with status 2)\n\nFix quoting and invoke /bin/sh explicitely to fix the error:\n\nThu Apr 18 13:16:35 2019:    Command \u003d \u0027/usr/bin/sh\u0027 \u0027-c\u0027 \u0027test -S /var/lib/haproxy/stats \u0026\u0026 echo show info | socat /var/lib/haproxy/stats stdio\u0027\nThu Apr 18 13:16:35 2019: VRRP_Script(haproxy) succeeded\n\nChange-Id: I5a757f88963270e77c8ec411cd292a30f89c6bc0\nCloses-Bug: #1825366\n(cherry picked from commit f5d6110a79ca11f00728429660428ab99f5292d1)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/638ba0b92d881623483d2bc968c474bca1f2fc49"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/638ba0b92d881623483d2bc968c474bca1f2fc49"}]},"branch":"refs/heads/stable/rocky"}},"requirements":[],"submit_records":[],"submit_requirements":[]}