)]}'
{"id":"openstack%2Fpuppet-tripleo~656244","triplet_id":"openstack%2Fpuppet-tripleo~stable%2Frocky~I14b540e6564c5b7c5d54b4f1fd5368b000744135","project":"openstack/puppet-tripleo","branch":"stable/rocky","topic":"bug/1826829","hashtags":[],"change_id":"I14b540e6564c5b7c5d54b4f1fd5368b000744135","subject":"remove ssh from tripleo::firewall::pre","status":"MERGED","created":"2019-04-29 05:46:01.000000000","updated":"2019-04-30 16:48:42.000000000","submitted":"2019-04-30 16:48:42.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"656244-1556642922503-21878039","meta_rev_id":"e7fa784e5e5e11aacb74577183ea209e10ab12b5","_number":656244,"virtual_id_number":656244,"owner":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-04-30 16:48:42.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-04-29 09:00:58.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},{"value":0,"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"value":0,"_account_id":8745,"name":"Lars Kellogg-Stedman","email":"lars@redhat.com","username":"lars"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},{"value":0,"_account_id":27898,"name":"Quique Llorente","email":"ellorent@redhat.com","username":"quiquell"},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":27898,"name":"Quique Llorente","email":"ellorent@redhat.com","username":"quiquell"},"recommended":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},{"value":0,"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"value":0,"_account_id":8745,"name":"Lars Kellogg-Stedman","email":"lars@redhat.com","username":"lars"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":1,"date":"2019-04-30 08:43:03.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},{"value":2,"date":"2019-04-30 08:56:53.000000000","_account_id":27898,"name":"Quique Llorente","email":"ellorent@redhat.com","username":"quiquell"},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":1,"date":"2019-04-30 12:23:12.000000000","_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},{"value":0,"date":"2019-04-29 06:17:59.000000000","_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"value":0,"date":"2019-04-29 05:46:01.000000000","_account_id":8745,"name":"Lars Kellogg-Stedman","email":"lars@redhat.com","username":"lars"},{"value":0,"date":"2019-04-29 06:17:56.000000000","_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},{"value":0,"_account_id":27898,"name":"Quique Llorente","email":"ellorent@redhat.com","username":"quiquell"},{"value":0,"date":"2019-04-29 06:17:52.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},{"_account_id":8745,"name":"Lars Kellogg-Stedman","email":"lars@redhat.com","username":"lars"},{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"_account_id":27898,"name":"Quique Llorente","email":"ellorent@redhat.com","username":"quiquell"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-04-29 05:46:01.000000000","updated_by":{"_account_id":8745,"name":"Lars Kellogg-Stedman","email":"lars@redhat.com","username":"lars"},"reviewer":{"_account_id":8745,"name":"Lars Kellogg-Stedman","email":"lars@redhat.com","username":"lars"},"state":"REVIEWER"},{"updated":"2019-04-29 06:17:52.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2019-04-29 06:17:56.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2019-04-29 06:17:59.000000000","updated_by":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"reviewer":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"state":"REVIEWER"},{"updated":"2019-04-29 09:00:58.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-04-30 08:43:03.000000000","updated_by":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"reviewer":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"state":"REVIEWER"},{"updated":"2019-04-30 08:56:53.000000000","updated_by":{"_account_id":27898,"name":"Quique Llorente","email":"ellorent@redhat.com","username":"quiquell"},"reviewer":{"_account_id":27898,"name":"Quique Llorente","email":"ellorent@redhat.com","username":"quiquell"},"state":"REVIEWER"},{"updated":"2019-04-30 12:23:12.000000000","updated_by":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"reviewer":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"state":"REVIEWER"},{"updated":"2019-04-30 16:48:42.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"a9dbf03685cc7cdf29b9654f72b40d6927ea5842","author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"date":"2019-04-29 05:46:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f2797d2527a9b768ea8fd74f982c5d5f0c1bbce3","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-29 08:27:42.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-undercloud-oooq http://logs.openstack.org/44/656244/1/check/tripleo-ci-centos-7-undercloud-oooq/ec64c38/ : SUCCESS in 1h 05m 30s\n- tripleo-ci-centos-7-undercloud-upgrades http://logs.openstack.org/44/656244/1/check/tripleo-ci-centos-7-undercloud-upgrades/2aef41d/ : SUCCESS in 2h 02m 20s\n- tripleo-ci-centos-7-undercloud-containers http://logs.openstack.org/44/656244/1/check/tripleo-ci-centos-7-undercloud-containers/562cebb/ : SUCCESS in 1h 27m 32s\n- tripleo-ci-centos-7-containerized-undercloud-upgrades http://logs.openstack.org/44/656244/1/check/tripleo-ci-centos-7-containerized-undercloud-upgrades/9cfb381/ : SUCCESS in 1h 52m 55s (non-voting)\n- tripleo-ci-centos-7-containers-multinode http://logs.openstack.org/44/656244/1/check/tripleo-ci-centos-7-containers-multinode/6580fe5/ : SUCCESS in 2h 26m 37s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates http://logs.openstack.org/44/656244/1/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates/4701718/ : SUCCESS in 2h 14m 48s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades http://logs.openstack.org/44/656244/1/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades/a1e485e/ : SUCCESS in 2h 27m 19s (non-voting)\n- tripleo-ci-centos-7-standalone http://logs.openstack.org/44/656244/1/check/tripleo-ci-centos-7-standalone/32a040a/ : SUCCESS in 1h 29m 20s\n- puppet-openstack-lint http://logs.openstack.org/44/656244/1/check/puppet-openstack-lint/8c0e42e/ : SUCCESS in 4m 13s\n- puppet-openstack-syntax-4 http://logs.openstack.org/44/656244/1/check/puppet-openstack-syntax-4/feb04ab/ : SUCCESS in 3m 48s\n- puppet-openstack-unit-4.8-centos-7 http://logs.openstack.org/44/656244/1/check/puppet-openstack-unit-4.8-centos-7/0b6966a/ : SUCCESS in 34m 16s","accounts_in_message":[],"_revision_number":1},{"id":"da8e30c0d1778ac6332e596bd6415cdc14edab0e","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-04-29 09:00:58.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001 http://logs.rdoproject.org/44/656244/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001/c2b54a8/ : SUCCESS in 2h 35m 34s\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset035 http://logs.rdoproject.org/44/656244/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset035/8dacd89/ : SUCCESS in 2h 54m 05s\n- tripleo-ci-centos-7-ovb-3ctlr_1comp_1supp-featureset039 http://logs.rdoproject.org/44/656244/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp_1supp-featureset039/a58b680/ : SUCCESS in 3h 12m 37s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"c8c447bfa2b02ba72dc39a9f0e3e72cfa6a4c5c4","author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"date":"2019-04-30 07:21:06.000000000","message":"Patch Set 1: Cherry Picked\n\nThis patchset was cherry picked to branch stable/queens as commit cdf209059defe1a9fa26a93769486c304d5f674d","accounts_in_message":[],"_revision_number":1},{"id":"78d442cd42852d9ece24f639869dc67ab8e253c9","author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"date":"2019-04-30 08:43:03.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"75593b0caf409900170e33e244e35e8aff97e39e","author":{"_account_id":27898,"name":"Quique Llorente","email":"ellorent@redhat.com","username":"quiquell"},"date":"2019-04-30 08:56:53.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"c2260ff49afe33c553aa3a34f097732d2291da5a","author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"date":"2019-04-30 12:23:12.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"d7c9ec2cf1c8f00eaa30cd3e573c61fce568ce55","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-30 14:17:42.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"0197a0b74d8383b2970b6b2f122d952ca4f35329","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-30 16:48:42.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"e1b873a02117b64689c88531ee03b4e146563e35","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-30 16:48:42.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tripleo-ci-centos-7-undercloud-oooq http://logs.openstack.org/44/656244/1/gate/tripleo-ci-centos-7-undercloud-oooq/49b6301/ : SUCCESS in 1h 11m 03s\n- tripleo-ci-centos-7-undercloud-containers http://logs.openstack.org/44/656244/1/gate/tripleo-ci-centos-7-undercloud-containers/c04a2d1/ : SUCCESS in 1h 34m 48s\n- tripleo-ci-centos-7-containers-multinode http://logs.openstack.org/44/656244/1/gate/tripleo-ci-centos-7-containers-multinode/f434c4d/ : SUCCESS in 2h 10m 32s\n- tripleo-ci-centos-7-standalone http://logs.openstack.org/44/656244/1/gate/tripleo-ci-centos-7-standalone/f5d8395/ : SUCCESS in 1h 31m 22s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates http://logs.openstack.org/44/656244/1/gate/tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates/483ae8b/ : SUCCESS in 2h 25m 29s\n- puppet-openstack-lint http://logs.openstack.org/44/656244/1/gate/puppet-openstack-lint/d6010c8/ : SUCCESS in 4m 32s\n- puppet-openstack-syntax-4 http://logs.openstack.org/44/656244/1/gate/puppet-openstack-syntax-4/09e1005/ : SUCCESS in 4m 55s\n- puppet-openstack-unit-4.8-centos-7 http://logs.openstack.org/44/656244/1/gate/puppet-openstack-unit-4.8-centos-7/6c6658a/ : SUCCESS in 30m 26s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"47034b224cd532c9b1d76f0aace0bdddbce9ea87","revisions":{"47034b224cd532c9b1d76f0aace0bdddbce9ea87":{"kind":"REWORK","_number":1,"created":"2019-04-29 05:46:01.000000000","uploader":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"ref":"refs/changes/44/656244/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-tripleo","ref":"refs/changes/44/656244/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/44/656244/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/44/656244/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/44/656244/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-tripleo refs/changes/44/656244/1"}}},"commit":{"parents":[{"commit":"638ba0b92d881623483d2bc968c474bca1f2fc49","subject":"Fix keepalived VIP monitoring script","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/638ba0b92d881623483d2bc968c474bca1f2fc49"}]}],"author":{"name":"Lars Kellogg-Stedman","email":"lars@redhat.com","date":"2018-07-12 19:22:10.000000000","tz":-240},"committer":{"name":"Cédric Jeanneret","email":"cjeanner@redhat.com","date":"2019-04-29 05:45:09.000000000","tz":120},"subject":"remove ssh from tripleo::firewall::pre","message":"remove ssh from tripleo::firewall::pre\n\nincluding global ssh access in tripleo::firewall::pre makes it\ndifficult for the operator to control ssh access to overcloud hosts.\nThis removes the hardcoded rule and the accompanying change in t-h-t\nconfigures the default firewall rules via hiera config_settings.\n\nDepends-On: I89cff59947dda3f51482486c41a3d67c4aa36a3e\nChange-Id: I14b540e6564c5b7c5d54b4f1fd5368b000744135\nRelated-Bug: #1826829\n(cherry picked from commit 9bdb8199cc394bd6283292a6964a089f012f2ae9)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/47034b224cd532c9b1d76f0aace0bdddbce9ea87"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/47034b224cd532c9b1d76f0aace0bdddbce9ea87"}]},"branch":"refs/heads/stable/rocky"}},"requirements":[],"submit_records":[],"submit_requirements":[]}