)]}'
{"manifests/profile/base/logging/rsyslog/file_input.pp":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"d03d568843be5e49c9a6150db3477a6a319d2b48","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    $fluentd_sources \u003d hiera(\"tripleo_fluentd_sources_${title}\")"},{"line_number":14,"context_line":"    $rsyslog_sources \u003d $fluentd_sources.reduce([]) |$memo, $config| {"},{"line_number":15,"context_line":"      if $config[\u0027startmsg.regex\u0027] {"},{"line_number":16,"context_line":"        $startmsg \u003d $config[\u0027startmsg.regex\u0027]"},{"line_number":17,"context_line":"      } else {"},{"line_number":18,"context_line":"        $default_startmsg"},{"line_number":19,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dfbec78f_b3cfd1ae","line":16,"updated":"2019-05-10 11:46:12.000000000","message":"this var looks not used","commit_id":"923d8e041d27ea357e92390690e0c44c69285b6b"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"d18469f42b50676b5f515e3013fefd5859854b26","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    $fluentd_sources \u003d hiera(\"tripleo_fluentd_sources_${title}\")"},{"line_number":14,"context_line":"    $rsyslog_sources \u003d $fluentd_sources.reduce([]) |$memo, $config| {"},{"line_number":15,"context_line":"      if $config[\u0027startmsg.regex\u0027] {"},{"line_number":16,"context_line":"        $startmsg \u003d $config[\u0027startmsg.regex\u0027]"},{"line_number":17,"context_line":"      } else {"},{"line_number":18,"context_line":"        $default_startmsg"},{"line_number":19,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dfbec78f_8e93775b","line":16,"in_reply_to":"dfbec78f_b3cfd1ae","updated":"2019-05-10 20:07:44.000000000","message":"Indeed, thanks will fix that.","commit_id":"923d8e041d27ea357e92390690e0c44c69285b6b"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0f870151d0370bc6636af786525f6ffea9ab2e00","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  # TODO(mmagr): As a deprecation path for fluentd we gonna use the fluentd THT parameters first."},{"line_number":16,"context_line":"  # We can remove below few lines after fluentd is removed and it\u0027s template outputs"},{"line_number":17,"context_line":"  # are renamed to provider-agnostic name in all composable services"},{"line_number":18,"context_line":"  $sources \u003d hiera(\"tripleo_logging_sources_${title}\")"},{"line_number":19,"context_line":"  if !$sources {"},{"line_number":20,"context_line":"    $fluentd_sources \u003d hiera(\"tripleo_fluentd_sources_${title}\")"},{"line_number":21,"context_line":"    $rsyslog_sources \u003d $fluentd_sources.reduce([]) |$memo, $config| {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bfb3d3c7_03286194","line":18,"updated":"2019-05-30 23:54:35.000000000","message":"Please don\u0027t use hiera in the class. It would be better to have these two as parameters so you can write tests for this logic. Please write tests for this logic.","commit_id":"3a06ce4b0a80d540912f4b74528175c707e8f1ea"}]}