)]}'
{"manifests/profile/base/nova/compute.pp":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"64c21ea4a8ccf3b7c8b92c525283f82d76a827b4","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":58,"context_line":"    # deploy basic bits for nova"},{"line_number":59,"context_line":"    include ::tripleo::profile::base::nova"},{"line_number":60,"context_line":"    include ::nova::cinder"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    if $keymgr_api_class {"},{"line_number":63,"context_line":"      warning(\u0027The keymgr_api_class parameter is deprecated, use keymgr_backend\u0027)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dfbec78f_d1cf8126","line":60,"updated":"2019-05-16 12:16:10.000000000","message":"There\u0027s a question in https://review.opendev.org/657918 over the nova::cinder::project_name default value. Depending on the resolution, this line might need to be updated to something like this:\n\n    class { \u0027::nova::cinder\u0027:\n      project_name \u003d\u003e hiera(\u0027keystone::roles::admin::service_tenant\u0027, \u0027service\u0027)\n    }","commit_id":"6a0cdf33a6f8eaf6f01789b353bc3bf7133b3c3b"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"46265569ecd6fe83e29d28a2f7579f13382bdf3f","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":58,"context_line":"    # deploy basic bits for nova"},{"line_number":59,"context_line":"    include ::tripleo::profile::base::nova"},{"line_number":60,"context_line":"    include ::nova::cinder"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    if $keymgr_api_class {"},{"line_number":63,"context_line":"      warning(\u0027The keymgr_api_class parameter is deprecated, use keymgr_backend\u0027)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bfb3d3c7_afefdae7","line":60,"in_reply_to":"dfbec78f_d1cf8126","updated":"2019-05-17 05:27:09.000000000","message":"Thank you for your suggestion Alan.\nI have changed project_name to \u0027services\u0027 in https://review.opendev.org/#/c/657918/8/manifests/cinder.pp so I think, we don\u0027t need to change here.","commit_id":"6a0cdf33a6f8eaf6f01789b353bc3bf7133b3c3b"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"2db615a0a61de726341f2fd53afdf62ec4b0b22f","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    include ::tripleo::profile::base::nova"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    class { \u0027::nova::cinder\u0027:"},{"line_number":62,"context_line":"      project_name \u003d\u003e hiera(\u0027keystone::roles::admin::service_tenant\u0027, \u0027services\u0027)"},{"line_number":63,"context_line":"    }"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    if $keymgr_api_class {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bfb3d3c7_b4edde26","line":62,"updated":"2019-05-17 20:00:18.000000000","message":"Sorry, my previous comment might have misled you. My point was that tripleo needs to enforce its standard of using \u0027service\u0027 for the default project name. This means the 2nd argument to hiera() would need to be \u0027service\u0027.\n\nHowever, you might be able to drop this and revert back to your original line, that just includes ::nova::class.\n\nThe reason is I see you override nova::cinder::project_name in tht [1].\n\n[1] https://review.opendev.org/#/c/657919/5/deployment/nova/nova-compute-container-puppet.yaml (L429)\n\nThe only thing slightly unusual is it means this puppet-tripleo patch would depends-on the tht patch (typically the dependency is the other way around).","commit_id":"7c6523a24199c83f3fe078c2c4b8a1463648de78"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"ddb0bac3066f761fb4cebb1d03d4170215546296","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    include ::tripleo::profile::base::nova"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    class { \u0027::nova::cinder\u0027:"},{"line_number":62,"context_line":"      project_name \u003d\u003e hiera(\u0027keystone::roles::admin::service_tenant\u0027, \u0027services\u0027)"},{"line_number":63,"context_line":"    }"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    if $keymgr_api_class {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bfb3d3c7_643815d3","line":62,"in_reply_to":"bfb3d3c7_4f9e4f08","updated":"2019-05-18 01:20:55.000000000","message":"Right. So, suggest reverting this file to what was proposed in the first patch set (sorry for the distraction), and update the commit message so this patch depends on the tht patch https://review.opendev.org/657919.","commit_id":"7c6523a24199c83f3fe078c2c4b8a1463648de78"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"59317037409795d53196b2f3b3bb05ea35153a92","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    include ::tripleo::profile::base::nova"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    class { \u0027::nova::cinder\u0027:"},{"line_number":62,"context_line":"      project_name \u003d\u003e hiera(\u0027keystone::roles::admin::service_tenant\u0027, \u0027services\u0027)"},{"line_number":63,"context_line":"    }"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    if $keymgr_api_class {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bfb3d3c7_4f9e4f08","line":62,"in_reply_to":"bfb3d3c7_8f78c7f8","updated":"2019-05-17 21:52:28.000000000","message":"you don\u0027t want to land them out of order so this one should be dependent on the THT patch","commit_id":"7c6523a24199c83f3fe078c2c4b8a1463648de78"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7f4669240ec36eb17742c46a0701b3c67d6daf4c","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    include ::tripleo::profile::base::nova"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    class { \u0027::nova::cinder\u0027:"},{"line_number":62,"context_line":"      project_name \u003d\u003e hiera(\u0027keystone::roles::admin::service_tenant\u0027, \u0027services\u0027)"},{"line_number":63,"context_line":"    }"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    if $keymgr_api_class {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bfb3d3c7_cf1a3f16","line":62,"in_reply_to":"bfb3d3c7_b4edde26","updated":"2019-05-17 21:18:04.000000000","message":"Also you don\u0027t need to specify this in puppet-tripleo. Use hiera to just define nova::cinder::project_name: service in the THT template that includes this class","commit_id":"7c6523a24199c83f3fe078c2c4b8a1463648de78"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"5cbd549168890638cb311ddfc7d58ff032b54b4f","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    include ::tripleo::profile::base::nova"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    class { \u0027::nova::cinder\u0027:"},{"line_number":62,"context_line":"      project_name \u003d\u003e hiera(\u0027keystone::roles::admin::service_tenant\u0027, \u0027services\u0027)"},{"line_number":63,"context_line":"    }"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    if $keymgr_api_class {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bfb3d3c7_8f78c7f8","line":62,"in_reply_to":"bfb3d3c7_cf1a3f16","updated":"2019-05-17 21:42:52.000000000","message":"Yup, and he has this in the tht patch. I was just flagging the possible corner case where this puppet-tripleo patch lands before the THT patch that sets the hiera. Unless he makes this patch dependent.","commit_id":"7c6523a24199c83f3fe078c2c4b8a1463648de78"}]}