)]}'
{"manifests/profile/base/pacemaker.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7bea9f32f19964feb6bfe950b8ffd1ac1cdc9d74","unresolved":false,"context_lines":[{"line_number":202,"context_line":"          tries              \u003d\u003e $remote_tries,"},{"line_number":203,"context_line":"          try_sleep          \u003d\u003e $remote_try_sleep,"},{"line_number":204,"context_line":"          pcs_user           \u003d\u003e \u0027hacluster\u0027,"},{"line_number":205,"context_line":"          pcs_password       \u003d\u003e hiera(\u0027hacluster_pwd\u0027),"},{"line_number":206,"context_line":"          before             \u003d\u003e Exec[\"exec-wait-for-${remote_short_node}\"],"},{"line_number":207,"context_line":"          notify             \u003d\u003e Exec[\"exec-wait-for-${remote_short_node}\"],"},{"line_number":208,"context_line":"        }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9fb8cfa7_53e91a7e","line":205,"range":{"start_line":205,"start_character":32,"end_line":205,"end_character":54},"updated":"2019-06-03 13:39:04.000000000","message":"This seems dangerous to make required (but only if $pacemaker_master).  Can we make this a param with a default of undef with a check here as well?","commit_id":"9218cd52711b2b4b016078ca7ab22c4a1fbbfcab"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"a1f463a26b4e432dd0a7e2b80f54719c80255f6d","unresolved":false,"context_lines":[{"line_number":202,"context_line":"          tries              \u003d\u003e $remote_tries,"},{"line_number":203,"context_line":"          try_sleep          \u003d\u003e $remote_try_sleep,"},{"line_number":204,"context_line":"          pcs_user           \u003d\u003e \u0027hacluster\u0027,"},{"line_number":205,"context_line":"          pcs_password       \u003d\u003e hiera(\u0027hacluster_pwd\u0027),"},{"line_number":206,"context_line":"          before             \u003d\u003e Exec[\"exec-wait-for-${remote_short_node}\"],"},{"line_number":207,"context_line":"          notify             \u003d\u003e Exec[\"exec-wait-for-${remote_short_node}\"],"},{"line_number":208,"context_line":"        }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9fb8cfa7_c7c21fea","line":205,"range":{"start_line":205,"start_character":32,"end_line":205,"end_character":54},"in_reply_to":"9fb8cfa7_53e91a7e","updated":"2019-06-03 20:56:19.000000000","message":"It is already pretty much required all over the place (see line 144 and we barf on line 93 more prominently?","commit_id":"9218cd52711b2b4b016078ca7ab22c4a1fbbfcab"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ae1200e036c32552359e02eabdd61fd3693b15f9","unresolved":false,"context_lines":[{"line_number":202,"context_line":"          tries              \u003d\u003e $remote_tries,"},{"line_number":203,"context_line":"          try_sleep          \u003d\u003e $remote_try_sleep,"},{"line_number":204,"context_line":"          pcs_user           \u003d\u003e \u0027hacluster\u0027,"},{"line_number":205,"context_line":"          pcs_password       \u003d\u003e hiera(\u0027hacluster_pwd\u0027),"},{"line_number":206,"context_line":"          before             \u003d\u003e Exec[\"exec-wait-for-${remote_short_node}\"],"},{"line_number":207,"context_line":"          notify             \u003d\u003e Exec[\"exec-wait-for-${remote_short_node}\"],"},{"line_number":208,"context_line":"        }"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9fb8cfa7_e69404eb","line":205,"updated":"2019-06-03 22:52:22.000000000","message":"Well then we should definitely make it a param so we stop making multiple hiera calls for the same var","commit_id":"8045e97de99e57365aed968adba3ba840c4493db"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"e02338e7ec3afff34b9a784d6d32cc851d75b224","unresolved":false,"context_lines":[{"line_number":202,"context_line":"          tries              \u003d\u003e $remote_tries,"},{"line_number":203,"context_line":"          try_sleep          \u003d\u003e $remote_try_sleep,"},{"line_number":204,"context_line":"          pcs_user           \u003d\u003e \u0027hacluster\u0027,"},{"line_number":205,"context_line":"          pcs_password       \u003d\u003e hiera(\u0027hacluster_pwd\u0027),"},{"line_number":206,"context_line":"          before             \u003d\u003e Exec[\"exec-wait-for-${remote_short_node}\"],"},{"line_number":207,"context_line":"          notify             \u003d\u003e Exec[\"exec-wait-for-${remote_short_node}\"],"},{"line_number":208,"context_line":"        }"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9fb8cfa7_72cf6a7f","line":205,"in_reply_to":"9fb8cfa7_e69404eb","updated":"2019-06-04 04:32:02.000000000","message":"agree, makes sense. will get to it today","commit_id":"8045e97de99e57365aed968adba3ba840c4493db"}],"manifests/profile/base/pacemaker_remote.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e8189dcec66f5d275e82d015ba1dfed50960253b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  $enable_fencing \u003d hiera(\u0027enable_fencing\u0027, false),"},{"line_number":42,"context_line":"  $step           \u003d Integer(hiera(\u0027step\u0027)),"},{"line_number":43,"context_line":") {"},{"line_number":44,"context_line":"  if hiera(\u0027hacluster_pwd\u0027, undef) \u003d\u003d undef {"},{"line_number":45,"context_line":"    fail(\"The \u0027hacluster_pwd\u0027 hiera key is undefined, this cannot happen\")"},{"line_number":46,"context_line":"  }"},{"line_number":47,"context_line":"  class { \u0027::pacemaker::remote\u0027:"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9fb8cfa7_61dc9a18","line":44,"updated":"2019-05-31 21:55:20.000000000","message":"If you make this a param we don\u0027t have to do the hiera call twice","commit_id":"195c9e43605373436fb605c57dd157cece6c02a5"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7bea9f32f19964feb6bfe950b8ffd1ac1cdc9d74","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  $step           \u003d Integer(hiera(\u0027step\u0027)),"},{"line_number":55,"context_line":") {"},{"line_number":56,"context_line":"  if $pcs_password \u003d\u003d undef {"},{"line_number":57,"context_line":"    fail(\"The $pcs_password param is and the hiera key \u0027hacluster_pwd\u0027 hiera key are both undefined, this is not allowed\")"},{"line_number":58,"context_line":"  }"},{"line_number":59,"context_line":"  class { \u0027::pacemaker::remote\u0027:"},{"line_number":60,"context_line":"    pcs_user       \u003d\u003e $pcs_user,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9fb8cfa7_33d7c6c2","line":57,"range":{"start_line":57,"start_character":9,"end_line":57,"end_character":122},"updated":"2019-06-03 13:39:04.000000000","message":"this should be single quoted or it\u0027s going to interpret $pcs_password as a variable (also lint doesn\u0027t like this because of the double quotes)","commit_id":"9218cd52711b2b4b016078ca7ab22c4a1fbbfcab"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"a1f463a26b4e432dd0a7e2b80f54719c80255f6d","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  $step           \u003d Integer(hiera(\u0027step\u0027)),"},{"line_number":55,"context_line":") {"},{"line_number":56,"context_line":"  if $pcs_password \u003d\u003d undef {"},{"line_number":57,"context_line":"    fail(\"The $pcs_password param is and the hiera key \u0027hacluster_pwd\u0027 hiera key are both undefined, this is not allowed\")"},{"line_number":58,"context_line":"  }"},{"line_number":59,"context_line":"  class { \u0027::pacemaker::remote\u0027:"},{"line_number":60,"context_line":"    pcs_user       \u003d\u003e $pcs_user,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9fb8cfa7_67e9f37e","line":57,"range":{"start_line":57,"start_character":9,"end_line":57,"end_character":122},"in_reply_to":"9fb8cfa7_33d7c6c2","updated":"2019-06-03 20:56:19.000000000","message":"ops right","commit_id":"9218cd52711b2b4b016078ca7ab22c4a1fbbfcab"}]}