)]}'
{"manifests/profile/pacemaker/manila/share_bundle.pp":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"a9b43014bcf50cc60a7d7075b17851c5cf915f63","unresolved":false,"context_lines":[{"line_number":92,"context_line":"      $manila_share_nodes_count \u003d count(hiera(\u0027manila_share_short_node_names\u0027, []))"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"      $manila_cephfs_protocol_helper_type \u003d hiera(\u0027manila::backend::cephfs::cephfs_protocol_helper_type\u0027, \u0027\u0027)"},{"line_number":95,"context_line":"      $manila_cephfs_nfs_ganesha_managed \u003d hiera(\u0027manila_cephfs_nfs_ganesha_managed\u0027, true)"},{"line_number":96,"context_line":"      $nfs_ganesha \u003d ($backend_cephfs_enabled and $manila_cephfs_protocol_helper_type \u003d\u003d \u0027NFS\u0027 and $manila_cephfs_nfs_ganesha_managed)"},{"line_number":97,"context_line":"      $docker_vol_arr \u003d delete(any2array($docker_volumes), \u0027\u0027).flatten()"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bfb3d3c7_d981eac4","line":95,"updated":"2019-05-30 10:23:26.000000000","message":"I think we could consume the _is_remote puppet parameter here?","commit_id":"9f1a57c81e734c07190cc870c5d75a3bca9a63f8"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"6958fad0030a19950e43a7850400290cb49011ba","unresolved":false,"context_lines":[{"line_number":92,"context_line":"      $manila_share_nodes_count \u003d count(hiera(\u0027manila_share_short_node_names\u0027, []))"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"      $manila_cephfs_protocol_helper_type \u003d hiera(\u0027manila::backend::cephfs::cephfs_protocol_helper_type\u0027, \u0027\u0027)"},{"line_number":95,"context_line":"      $manila_cephfs_nfs_ganesha_managed \u003d hiera(\u0027manila_cephfs_nfs_ganesha_managed\u0027, true)"},{"line_number":96,"context_line":"      $nfs_ganesha \u003d ($backend_cephfs_enabled and $manila_cephfs_protocol_helper_type \u003d\u003d \u0027NFS\u0027 and $manila_cephfs_nfs_ganesha_managed)"},{"line_number":97,"context_line":"      $docker_vol_arr \u003d delete(any2array($docker_volumes), \u0027\u0027).flatten()"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bfb3d3c7_9eacb0ed","line":95,"in_reply_to":"bfb3d3c7_cde5a4dd","updated":"2019-05-30 15:45:39.000000000","message":"or even better, only add $ceph_nfs_enabled to the condition on line 96","commit_id":"9f1a57c81e734c07190cc870c5d75a3bca9a63f8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2ee6a937fa513b335246d6e6cbd2f69a1a0e902e","unresolved":false,"context_lines":[{"line_number":92,"context_line":"      $manila_share_nodes_count \u003d count(hiera(\u0027manila_share_short_node_names\u0027, []))"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"      $manila_cephfs_protocol_helper_type \u003d hiera(\u0027manila::backend::cephfs::cephfs_protocol_helper_type\u0027, \u0027\u0027)"},{"line_number":95,"context_line":"      $manila_cephfs_nfs_ganesha_managed \u003d hiera(\u0027manila_cephfs_nfs_ganesha_managed\u0027, true)"},{"line_number":96,"context_line":"      $nfs_ganesha \u003d ($backend_cephfs_enabled and $manila_cephfs_protocol_helper_type \u003d\u003d \u0027NFS\u0027 and $manila_cephfs_nfs_ganesha_managed)"},{"line_number":97,"context_line":"      $docker_vol_arr \u003d delete(any2array($docker_volumes), \u0027\u0027).flatten()"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bfb3d3c7_cde5a4dd","line":95,"in_reply_to":"bfb3d3c7_d981eac4","updated":"2019-05-30 14:08:59.000000000","message":"ack, we can; I was using this patch as a temporary workaround without support for the new parameters you\u0027re introducing..","commit_id":"9f1a57c81e734c07190cc870c5d75a3bca9a63f8"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"507f226400d9813f2ea356d2059d36a8d2a894cf","unresolved":false,"context_lines":[{"line_number":34,"context_line":"#   (Optional) The list of environment variables set in the docker container"},{"line_number":35,"context_line":"#   Defaults to [\u0027KOLLA_CONFIG_STRATEGY\u003dCOPY_ALWAYS\u0027]"},{"line_number":36,"context_line":"#"},{"line_number":37,"context_line":"# [*backend_cephfs_enabled*]"},{"line_number":38,"context_line":"#   (Optional) Whether the CephFS Manila backend is enabled"},{"line_number":39,"context_line":"#   Defaults to hiera(\u0027manila_backend_cephfs_enabled\u0027, false)"},{"line_number":40,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9fb8cfa7_e593a34e","side":"PARENT","line":37,"updated":"2019-06-03 15:32:03.000000000","message":"apparently this was just defined twice","commit_id":"5424bbcea3749ee0d6518f600d3a60abbdd4d114"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"98f57f7f274b9e59a2557bbdbb201f83599a4b33","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  $manila_share_docker_image  \u003d hiera(\u0027tripleo::profile::pacemaker::manila::share_bundle::manila_share_docker_image\u0027, undef),"},{"line_number":58,"context_line":"  $docker_volumes             \u003d [],"},{"line_number":59,"context_line":"  $docker_environment         \u003d [\u0027KOLLA_CONFIG_STRATEGY\u003dCOPY_ALWAYS\u0027],"},{"line_number":60,"context_line":"  $ceph_nfs_enabled           \u003d hiera(\u0027ceph_nfs_enabled\u0027, false),"},{"line_number":61,"context_line":"  $container_backend          \u003d \u0027docker\u0027,"},{"line_number":62,"context_line":"  $pcs_tries                  \u003d hiera(\u0027pcs_tries\u0027, 20),"},{"line_number":63,"context_line":"  $step                       \u003d Integer(hiera(\u0027step\u0027)),"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9fb8cfa7_af9d785a","line":60,"range":{"start_line":60,"start_character":39,"end_line":60,"end_character":55},"updated":"2019-06-04 09:04:33.000000000","message":"i assume this is already done tht side? (no more passing of manila_backend_cephfs_enabled but now that ^\n\n(well actually i see neither of those at tht grep just now)...","commit_id":"44afda839aad275877e431e18131569c696e7aee"}]}