)]}'
{"id":"openstack%2Fpuppet-tripleo~666153","triplet_id":"openstack%2Fpuppet-tripleo~stable%2Frocky~Id9bdd36aa0ee81424212e3a89185311817a15aee","project":"openstack/puppet-tripleo","branch":"stable/rocky","topic":"rabbitmq-queues-stable/rocky","hashtags":[],"change_id":"Id9bdd36aa0ee81424212e3a89185311817a15aee","subject":"RabbitMQ: always allow promotion on HA queue during failover","status":"MERGED","created":"2019-06-18 19:42:47.000000000","updated":"2019-06-19 16:17:39.000000000","submitted":"2019-06-19 16:17:39.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"666153-1560961059750-ca750131","meta_rev_id":"3e2d5f4828061ed203e2b5265777c9c5677e98bb","_number":666153,"virtual_id_number":666153,"owner":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"value":2,"date":"2019-06-19 16:17:39.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-06-18 22:09:06.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":2,"date":"2019-06-19 13:11:09.000000000","_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"value":0,"date":"2019-06-19 12:16:07.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":1,"date":"2019-06-19 13:11:09.000000000","_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"date":"2019-06-18 19:42:47.000000000","_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"date":"2019-06-19 12:16:21.000000000","_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-18 19:42:47.000000000","updated_by":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"reviewer":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"state":"REVIEWER"},{"updated":"2019-06-18 22:09:06.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-06-19 12:16:07.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2019-06-19 12:16:21.000000000","updated_by":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"reviewer":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"state":"REVIEWER"},{"updated":"2019-06-19 13:11:09.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2019-06-19 16:17:39.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"00721f02d0de0e9fb41a03a15a018b39530a20b0","author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"date":"2019-06-18 19:42:47.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"953b91dd238f3f32524c991e6b9b62df91e95b3d","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-06-18 22:09:06.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001 http://logs.rdoproject.org/53/666153/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001/deb3184/ : SUCCESS in 2h 09m 10s\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset035 http://logs.rdoproject.org/53/666153/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset035/ddb00fe/ : SUCCESS in 2h 07m 57s\n- tripleo-ci-centos-7-ovb-3ctlr_1comp_1supp-featureset039 http://logs.rdoproject.org/53/666153/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp_1supp-featureset039/8b622dd/ : SUCCESS in 2h 25m 00s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"83ffcb2b21e4db3392cf55861cf0311a8e36ddf2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-19 04:57:39.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-undercloud-oooq http://logs.openstack.org/53/666153/1/check/tripleo-ci-centos-7-undercloud-oooq/1e95fda/ : SUCCESS in 1h 16m 42s\n- tripleo-ci-centos-7-undercloud-upgrades http://logs.openstack.org/53/666153/1/check/tripleo-ci-centos-7-undercloud-upgrades/f8d74c1/ : SUCCESS in 2h 02m 35s\n- tripleo-ci-centos-7-undercloud-containers http://logs.openstack.org/53/666153/1/check/tripleo-ci-centos-7-undercloud-containers/cff6e4b/ : SUCCESS in 1h 30m 05s\n- tripleo-ci-centos-7-containerized-undercloud-upgrades http://logs.openstack.org/53/666153/1/check/tripleo-ci-centos-7-containerized-undercloud-upgrades/b9ac89f/ : SUCCESS in 2h 00m 13s (non-voting)\n- tripleo-ci-centos-7-containers-multinode http://logs.openstack.org/53/666153/1/check/tripleo-ci-centos-7-containers-multinode/08205e7/ : SUCCESS in 2h 18m 10s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates http://logs.openstack.org/53/666153/1/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates/8c1d906/ : SUCCESS in 2h 43m 01s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades http://logs.openstack.org/53/666153/1/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades/5171c83/ : SUCCESS in 2h 29m 59s (non-voting)\n- tripleo-ci-centos-7-standalone-rocky http://logs.openstack.org/53/666153/1/check/tripleo-ci-centos-7-standalone-rocky/e9580c5/ : SUCCESS in 1h 33m 04s\n- build-openstack-releasenotes http://logs.openstack.org/53/666153/1/check/build-openstack-releasenotes/744e928/html/ : SUCCESS in 3m 21s\n- puppet-openstack-lint http://logs.openstack.org/53/666153/1/check/puppet-openstack-lint/f54f4f7/ : SUCCESS in 4m 32s\n- puppet-openstack-syntax-4 http://logs.openstack.org/53/666153/1/check/puppet-openstack-syntax-4/7b05c29/ : SUCCESS in 4m 00s\n- puppet-openstack-unit-4.8-centos-7 http://logs.openstack.org/53/666153/1/check/puppet-openstack-unit-4.8-centos-7/44e8b68/ : SUCCESS in 31m 35s","accounts_in_message":[],"_revision_number":1},{"id":"059a58f8c206266081dbd1d02e6713dd1db5b1e4","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-06-19 13:11:09.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"b7f5b3c92423cd9e7b71986f1e560f583d7414e0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-19 13:11:23.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"fe2a171e70331d4f534f5e518c9e8b64d76303e7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-19 16:17:39.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"5db6dcd9469b78cb7559a2426bead0c50692b6f3","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-19 16:17:39.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tripleo-ci-centos-7-undercloud-oooq http://logs.openstack.org/53/666153/1/gate/tripleo-ci-centos-7-undercloud-oooq/ce18178/ : SUCCESS in 1h 14m 44s\n- tripleo-ci-centos-7-undercloud-containers http://logs.openstack.org/53/666153/1/gate/tripleo-ci-centos-7-undercloud-containers/1fd3ea7/ : SUCCESS in 1h 33m 44s\n- tripleo-ci-centos-7-containers-multinode http://logs.openstack.org/53/666153/1/gate/tripleo-ci-centos-7-containers-multinode/2cafbb9/ : SUCCESS in 2h 13m 28s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates http://logs.openstack.org/53/666153/1/gate/tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates/94f0f8c/ : SUCCESS in 2h 29m 34s\n- build-openstack-releasenotes http://logs.openstack.org/53/666153/1/gate/build-openstack-releasenotes/c3dff58/html/ : SUCCESS in 3m 36s\n- puppet-openstack-lint http://logs.openstack.org/53/666153/1/gate/puppet-openstack-lint/74d3dcc/ : SUCCESS in 5m 10s\n- puppet-openstack-syntax-4 http://logs.openstack.org/53/666153/1/gate/puppet-openstack-syntax-4/a20a153/ : SUCCESS in 5m 35s\n- puppet-openstack-unit-4.8-centos-7 http://logs.openstack.org/53/666153/1/gate/puppet-openstack-unit-4.8-centos-7/a2e228e/ : SUCCESS in 31m 27s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"76101c8971f8e66e59bf43ce636a09029a080a6d","revisions":{"76101c8971f8e66e59bf43ce636a09029a080a6d":{"kind":"REWORK","_number":1,"created":"2019-06-18 19:42:47.000000000","uploader":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"ref":"refs/changes/53/666153/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-tripleo","ref":"refs/changes/53/666153/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/53/666153/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/53/666153/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/53/666153/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-tripleo refs/changes/53/666153/1"}}},"commit":{"parents":[{"commit":"1bcd64dc2e9440800d807a007833534d479522d9","subject":"Remove scenario008 jobs","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/1bcd64dc2e9440800d807a007833534d479522d9"}]}],"author":{"name":"Michele Baldessari","email":"michele@acksyn.org","date":"2019-04-03 18:15:19.000000000","tz":120},"committer":{"name":"Damien Ciabrini","email":"dciabrin@redhat.com","date":"2019-06-18 19:42:47.000000000","tz":0},"subject":"RabbitMQ: always allow promotion on HA queue during failover","message":"RabbitMQ: always allow promotion on HA queue during failover\n\nWhen the RabbitMQ experience a rolling restart of its peers, the\nmaster of an HA queue fails over from one replica to another.\n\nIf there are messages sent to the HA queue while some rabbit\nnodes are restarting, the latter will reconnect as unsynchronized\nslaves. It can happen that during a rolling restart, all rabbit\nnodes reconnect as unsynchronized, which prevents RabbitMQ to\nautomatically elect a new Master for failover. This has other\nside effects on fanout queues and may prevent OpenStack\nnotification to be consumed properly.\n\nChange the HA policy to always allow a promotion even when all\nreplicas are unsynchronized. When such rare condition happens,\nrely on OpenStack client to retry RPC if they need to.\n\nCloses-Bug: #1823305\nCo-Authored-By: Damien Ciabrini \u003cdciabrin@redhat.com\u003e\nChange-Id: Id9bdd36aa0ee81424212e3a89185311817a15aee\n(cherry picked from commit 610c8d8d41cd4b6bfd228ce1012416e424db625d)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/76101c8971f8e66e59bf43ce636a09029a080a6d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/76101c8971f8e66e59bf43ce636a09029a080a6d"}]},"branch":"refs/heads/stable/rocky"}},"requirements":[],"submit_records":[],"submit_requirements":[]}