)]}'
{"manifests/profile/base/apache.pp":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"d727fdbc6f591c8e3fa2bb0c7867901a8b738b02","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    }"},{"line_number":44,"context_line":"  } else {"},{"line_number":45,"context_line":"    class { \u0027::apache\u0027:"},{"line_number":46,"context_line":"      mpm_module \u003d\u003e \u0027event\u0027,"},{"line_number":47,"context_line":"    }"},{"line_number":48,"context_line":"  }"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9fb8cfa7_823d02df","line":46,"updated":"2019-07-03 13:47:58.000000000","message":"I suppose we want to always use it, I mean in all the situations and with all the OS/distros.\n\nI\u0027m not familiar with puppet-tripleo and with \nfuel-library but fuel-library have introduced some tests related to the OS in use:\n\n```\nif $::osfamily \u003d\u003d \u0027RedHat\u0027 {\n    $mpm_module \u003d \u0027event\u0027\n  } else {\n$mpm_module \u003d \u0027worker\u0027\n```\n\nhttps://github.com/openstack/fuel-library/blob/master/deployment/puppet/osnailyfacter/manifests/apache_mpm.pp#L25","commit_id":"72a386152fbc5e0feae754441b2af49e12a5d243"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"f6b0d07e13430737d89d0c93faee2c044f337814","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    }"},{"line_number":44,"context_line":"  } else {"},{"line_number":45,"context_line":"    class { \u0027::apache\u0027:"},{"line_number":46,"context_line":"      mpm_module \u003d\u003e \u0027event\u0027,"},{"line_number":47,"context_line":"    }"},{"line_number":48,"context_line":"  }"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9fb8cfa7_4e8171fb","line":46,"in_reply_to":"9fb8cfa7_2e643de5","updated":"2019-07-03 15:15:24.000000000","message":"Yeah I agree too","commit_id":"72a386152fbc5e0feae754441b2af49e12a5d243"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"fbd4b41c553e706c506f7b545363bbf32ea40b6f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    }"},{"line_number":44,"context_line":"  } else {"},{"line_number":45,"context_line":"    class { \u0027::apache\u0027:"},{"line_number":46,"context_line":"      mpm_module \u003d\u003e \u0027event\u0027,"},{"line_number":47,"context_line":"    }"},{"line_number":48,"context_line":"  }"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9fb8cfa7_2e643de5","line":46,"in_reply_to":"9fb8cfa7_823d02df","updated":"2019-07-03 15:00:08.000000000","message":"Here I was mostly thinking of backporting this to Queens et al, whereas OS RHEL 7.x family, not supporting other OS families... I think we should stick to event for the else path as well.","commit_id":"72a386152fbc5e0feae754441b2af49e12a5d243"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"138e3d519e6ec17a18c5cdad8809eabc7cb2eb69","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  if ($::os[\u0027name\u0027] \u003d\u003d \u0027Fedora\u0027) or ($::os[\u0027family\u0027] \u003d\u003d \u0027RedHat\u0027 and Integer.new($::os[\u0027release\u0027][\u0027major\u0027]) \u003e 7) {"},{"line_number":39,"context_line":"    class { \u0027::apache\u0027:"},{"line_number":40,"context_line":"      mod_packages \u003d\u003e merge($::apache::params::mod_packages, { \u0027wsgi\u0027 \u003d\u003e  \u0027python3-mod_wsgi\u0027 }),"},{"line_number":41,"context_line":"      mod_libs     \u003d\u003e merge($::apache::params::mod_libs, { \u0027wsgi\u0027 \u003d\u003e \u0027mod_wsgi_python3.so\u0027 }),"},{"line_number":42,"context_line":"      mpm_module   \u003d\u003e \u0027event\u0027,"},{"line_number":43,"context_line":"    }"},{"line_number":44,"context_line":"  } else {"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7faddb67_c5c831a7","line":41,"updated":"2019-07-17 10:41:02.000000000","message":"Should we add variable to allow user to configure behavior via THT?","commit_id":"dec62a3341cfeca0ed3904e778095dfaf63b7f47"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"b0cf544fc6c7ca4c9c0ff9a2efc1a2bdd68c3f67","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  if ($::os[\u0027name\u0027] \u003d\u003d \u0027Fedora\u0027) or ($::os[\u0027family\u0027] \u003d\u003d \u0027RedHat\u0027 and Integer.new($::os[\u0027release\u0027][\u0027major\u0027]) \u003e 7) {"},{"line_number":39,"context_line":"    class { \u0027::apache\u0027:"},{"line_number":40,"context_line":"      mod_packages \u003d\u003e merge($::apache::params::mod_packages, { \u0027wsgi\u0027 \u003d\u003e  \u0027python3-mod_wsgi\u0027 }),"},{"line_number":41,"context_line":"      mod_libs     \u003d\u003e merge($::apache::params::mod_libs, { \u0027wsgi\u0027 \u003d\u003e \u0027mod_wsgi_python3.so\u0027 }),"},{"line_number":42,"context_line":"      mpm_module   \u003d\u003e \u0027event\u0027,"},{"line_number":43,"context_line":"    }"},{"line_number":44,"context_line":"  } else {"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7faddb67_e8f7448a","line":41,"in_reply_to":"7faddb67_c5c831a7","updated":"2019-07-17 12:23:30.000000000","message":"Do you mean the MPM engine to use?\nI think this is doable.","commit_id":"dec62a3341cfeca0ed3904e778095dfaf63b7f47"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"c2edf38851744d3d004206442c0453e53637fd24","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  if ($::os[\u0027name\u0027] \u003d\u003d \u0027Fedora\u0027) or ($::os[\u0027family\u0027] \u003d\u003d \u0027RedHat\u0027 and Integer.new($::os[\u0027release\u0027][\u0027major\u0027]) \u003e 7) {"},{"line_number":39,"context_line":"    class { \u0027::apache\u0027:"},{"line_number":40,"context_line":"      mod_packages \u003d\u003e merge($::apache::params::mod_packages, { \u0027wsgi\u0027 \u003d\u003e  \u0027python3-mod_wsgi\u0027 }),"},{"line_number":41,"context_line":"      mod_libs     \u003d\u003e merge($::apache::params::mod_libs, { \u0027wsgi\u0027 \u003d\u003e \u0027mod_wsgi_python3.so\u0027 }),"},{"line_number":42,"context_line":"      mpm_module   \u003d\u003e \u0027event\u0027,"},{"line_number":43,"context_line":"    }"},{"line_number":44,"context_line":"  } else {"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7faddb67_1be9ccb5","line":41,"in_reply_to":"7faddb67_e8f7448a","updated":"2019-07-17 13:20:15.000000000","message":"On the oslo side we have choosen to introduce our heartbeat fix (using a native python thread without epoll) as an experimental feature, who can be turned on by using config too, so, I think that introduce a variable to set the MPM engine to use through THT is a good idea too.\n\nOn oslo we want to modify some services like the nova-api in a first time to \"turn on\" the pthread feature and then observe behaviour and if everything is ok after few months/releases, then removing the config part to use it everytime.","commit_id":"dec62a3341cfeca0ed3904e778095dfaf63b7f47"}]}