)]}'
{"id":"openstack%2Fpuppet-tripleo~669803","triplet_id":"openstack%2Fpuppet-tripleo~stable%2Fstein~I3fa07e28c4e37197890664d12a265f1673c780f2","project":"openstack/puppet-tripleo","branch":"stable/stein","topic":"ovn-fixes-stable/stein","hashtags":[],"change_id":"I3fa07e28c4e37197890664d12a265f1673c780f2","subject":"Close OVN VIP race by adding an ordering constraint","status":"MERGED","created":"2019-07-09 07:12:02.000000000","updated":"2019-07-10 07:20:16.000000000","submitted":"2019-07-10 07:01:47.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"669803-1562742107341-31ef7618","meta_rev_id":"e705d3e703082383ee929770e254af1356da4bf2","_number":669803,"virtual_id_number":669803,"owner":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},{"value":0,"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"value":2,"date":"2019-07-10 07:01:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},{"value":1,"date":"2019-07-09 22:34:34.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":30381,"name":"Jean-Pierre REN","email":"renzp@awcloud.com","username":"jpren"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"value":2,"date":"2019-07-09 19:38:18.000000000","_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},{"value":0,"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":1,"date":"2019-07-09 23:18:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":30381,"name":"Jean-Pierre REN","email":"renzp@awcloud.com","username":"jpren"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"all":[{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},{"value":1,"date":"2019-07-10 04:46:51.000000000","_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":30381,"name":"Jean-Pierre REN","email":"renzp@awcloud.com","username":"jpren"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},{"_account_id":30381,"name":"Jean-Pierre REN","email":"renzp@awcloud.com","username":"jpren"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-09 07:22:10.000000000","updated_by":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"reviewer":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"state":"REVIEWER"},{"updated":"2019-07-09 14:17:13.000000000","updated_by":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"reviewer":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"state":"REVIEWER"},{"updated":"2019-07-09 19:38:18.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2019-07-09 22:34:34.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-07-09 23:18:52.000000000","updated_by":{"_account_id":30381,"name":"Jean-Pierre REN","email":"renzp@awcloud.com","username":"jpren"},"reviewer":{"_account_id":30381,"name":"Jean-Pierre REN","email":"renzp@awcloud.com","username":"jpren"},"state":"REVIEWER"},{"updated":"2019-07-10 07:01:47.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"5ee0c55ec86fd8b0244bddd8cbb407197f25840a","author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"date":"2019-07-09 07:12:02.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"e3eb95ab8c1a96504dc3ff504292a495bff5dce5","author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"date":"2019-07-09 07:12:14.000000000","message":"Patch Set 1: Workflow-1\n\nwaiting for master to merge","accounts_in_message":[],"_revision_number":1},{"id":"e08bf00123c6db4a7604fbae01cf1c9f588ba7d6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-09 11:04:37.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic http://logs.openstack.org/03/669803/1/check/puppet-openstack-lint-ubuntu-bionic/1c1a41c/ : SUCCESS in 5m 20s\n- puppet-openstack-syntax-4-ubuntu-bionic http://logs.openstack.org/03/669803/1/check/puppet-openstack-syntax-4-ubuntu-bionic/8c75eac/ : SUCCESS in 4m 53s\n- puppet-openstack-syntax-5-ubuntu-bionic http://logs.openstack.org/03/669803/1/check/puppet-openstack-syntax-5-ubuntu-bionic/ed9bda1/ : SUCCESS in 4m 38s\n- puppet-openstack-syntax-6-ubuntu-bionic http://logs.openstack.org/03/669803/1/check/puppet-openstack-syntax-6-ubuntu-bionic/5417d92/ : SUCCESS in 3m 59s\n- puppet-openstack-unit-4.8-centos-7 http://logs.openstack.org/03/669803/1/check/puppet-openstack-unit-4.8-centos-7/d87927e/ : SUCCESS in 34m 43s\n- puppet-openstack-unit-5.5-centos-7 http://logs.openstack.org/03/669803/1/check/puppet-openstack-unit-5.5-centos-7/39eb23f/ : SUCCESS in 31m 14s\n- tripleo-ci-centos-7-undercloud-containers http://logs.openstack.org/03/669803/1/check/tripleo-ci-centos-7-undercloud-containers/0846a06/ : SUCCESS in 2h 00m 17s\n- tripleo-ci-centos-7-containerized-undercloud-upgrades http://logs.openstack.org/03/669803/1/check/tripleo-ci-centos-7-containerized-undercloud-upgrades/91bf306/ : FAILURE in 1h 36m 37s (non-voting)\n- tripleo-ci-centos-7-containers-multinode http://logs.openstack.org/03/669803/1/check/tripleo-ci-centos-7-containers-multinode/0337194/ : SUCCESS in 2h 05m 22s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates http://logs.openstack.org/03/669803/1/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates/8dd0212/ : SUCCESS in 2h 36m 15s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades http://logs.openstack.org/03/669803/1/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades/f119049/ : SUCCESS in 2h 37m 47s (non-voting)\n- tripleo-ci-centos-7-standalone http://logs.openstack.org/03/669803/1/check/tripleo-ci-centos-7-standalone/127c48e/ : SUCCESS in 2h 10m 47s\n- tripleo-ci-fedora-28-standalone http://logs.openstack.org/03/669803/1/check/tripleo-ci-fedora-28-standalone/c632110/ : SUCCESS in 1h 53m 29s (non-voting)\n- tripleo-ci-centos-7-scenario007-multinode-oooq-container http://logs.openstack.org/03/669803/1/check/tripleo-ci-centos-7-scenario007-multinode-oooq-container/d461fd3/ : SUCCESS in 2h 33m 24s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"72aac184ec6e560934446e1cc8c21eb49f0ddf14","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-07-09 11:06:58.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-ovb-3ctlr_1comp_1supp-featureset039 finger://ze01.softwarefactory-project.io:7979/833098632d6a407e9b4b712ffdb10072 : POST_FAILURE in 3h 53m 08s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"89e3f9393982bab5bc35b00dbc0755a835f41963","author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"date":"2019-07-09 14:16:56.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"614239d5dbe1cd78b3d5524e2ab6574aafc11015","author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"date":"2019-07-09 14:17:13.000000000","message":"Patch Set 2: Code-Review+1\n\nops! Sorry, my bad","accounts_in_message":[],"_revision_number":2},{"id":"2ac08cc00de9d4f2f8ad2324a5fc03a11a9d4164","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-07-09 14:17:49.000000000","message":"Patch Set 2: Code-Review-1\n\nneed to wait for the other to land or manual cherry-pick -x to get the (cherry-picked from ....)","accounts_in_message":[],"_revision_number":2},{"id":"8597f155c9a08d0572bda1cb70e1cb40c10d594f","author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"date":"2019-07-09 14:18:14.000000000","message":"Removed Code-Review+1 by Daniel Alvarez \u003cdalvarez@redhat.com\u003e\n","accounts_in_message":[],"_revision_number":2},{"id":"91118eee52bbf7571c4539ece5668a22a0b45ef0","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-07-09 17:16:18.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-ovb-3ctlr_1comp_1supp-featureset039 http://logs.rdoproject.org/03/669803/2/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp_1supp-featureset039/2c6d055/ : SUCCESS in 2h 56m 59s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"79c7be1e6d5b2962914a04c739993e581da64023","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-07-09 19:38:11.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"a82dd35ea9ed7e34f531df95b7f5202beadd4986","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-07-09 19:38:18.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"ce2eb8f6015cce6a9a840c09803c347f5cee229c","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-07-09 22:34:34.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-ovb-3ctlr_1comp_1supp-featureset039 http://logs.rdoproject.org/03/669803/3/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp_1supp-featureset039/e9eccf6/ : SUCCESS in 2h 55m 30s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"0b859845f1a7e9dcc60d1bda3c774c2e9a7bf3d4","author":{"_account_id":30381,"name":"Jean-Pierre REN","email":"renzp@awcloud.com","username":"jpren"},"date":"2019-07-09 23:18:52.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"fb82e0c74833294c6024b572cf77e5fb62d7018a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-10 03:02:52.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic http://logs.openstack.org/03/669803/3/check/puppet-openstack-lint-ubuntu-bionic/d0eb869/ : SUCCESS in 5m 22s\n- puppet-openstack-syntax-4-ubuntu-bionic http://logs.openstack.org/03/669803/3/check/puppet-openstack-syntax-4-ubuntu-bionic/4ff5cab/ : SUCCESS in 4m 55s\n- puppet-openstack-syntax-5-ubuntu-bionic http://logs.openstack.org/03/669803/3/check/puppet-openstack-syntax-5-ubuntu-bionic/bc9b388/ : SUCCESS in 4m 23s\n- puppet-openstack-syntax-6-ubuntu-bionic http://logs.openstack.org/03/669803/3/check/puppet-openstack-syntax-6-ubuntu-bionic/d5b3392/ : SUCCESS in 4m 52s\n- puppet-openstack-unit-4.8-centos-7 http://logs.openstack.org/03/669803/3/check/puppet-openstack-unit-4.8-centos-7/650c198/ : SUCCESS in 49m 20s\n- puppet-openstack-unit-5.5-centos-7 http://logs.openstack.org/03/669803/3/check/puppet-openstack-unit-5.5-centos-7/6d944aa/ : SUCCESS in 26m 57s\n- tripleo-ci-centos-7-undercloud-containers http://logs.openstack.org/03/669803/3/check/tripleo-ci-centos-7-undercloud-containers/478e529/ : SUCCESS in 1h 40m 12s\n- tripleo-ci-centos-7-containerized-undercloud-upgrades http://logs.openstack.org/03/669803/3/check/tripleo-ci-centos-7-containerized-undercloud-upgrades/a467ccd/ : FAILURE in 1h 29m 45s (non-voting)\n- tripleo-ci-centos-7-containers-multinode http://logs.openstack.org/03/669803/3/check/tripleo-ci-centos-7-containers-multinode/dc0a15d/ : SUCCESS in 2h 10m 48s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates http://logs.openstack.org/03/669803/3/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates/a396070/ : SUCCESS in 2h 21m 54s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades http://logs.openstack.org/03/669803/3/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades/62ac22e/ : SUCCESS in 2h 42m 38s (non-voting)\n- tripleo-ci-centos-7-standalone http://logs.openstack.org/03/669803/3/check/tripleo-ci-centos-7-standalone/b77116c/ : SUCCESS in 1h 52m 00s\n- tripleo-ci-fedora-28-standalone http://logs.openstack.org/03/669803/3/check/tripleo-ci-fedora-28-standalone/6d97c69/ : SUCCESS in 1h 31m 29s (non-voting)\n- tripleo-ci-centos-7-scenario007-multinode-oooq-container http://logs.openstack.org/03/669803/3/check/tripleo-ci-centos-7-scenario007-multinode-oooq-container/360d2e4/ : SUCCESS in 2h 36m 00s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"554f6ebf3ccefa7f2ee4af7aa22008f699a6b200","author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"date":"2019-07-10 04:46:51.000000000","message":"Patch Set 3: Workflow+1\n\nThanks Alex!","accounts_in_message":[],"_revision_number":3},{"id":"757a5943b7a9810e7b22a86bfda4ec783b3b9331","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-10 04:47:23.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"d1be859819feb7866c0f014fb7a2297b9d14af31","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-10 07:01:47.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic http://logs.openstack.org/03/669803/3/gate/puppet-openstack-lint-ubuntu-bionic/a191172/ : SUCCESS in 5m 12s\n- puppet-openstack-syntax-4-ubuntu-bionic http://logs.openstack.org/03/669803/3/gate/puppet-openstack-syntax-4-ubuntu-bionic/706b688/ : SUCCESS in 5m 01s\n- puppet-openstack-syntax-5-ubuntu-bionic http://logs.openstack.org/03/669803/3/gate/puppet-openstack-syntax-5-ubuntu-bionic/0d67b21/ : SUCCESS in 5m 02s\n- puppet-openstack-syntax-6-ubuntu-bionic http://logs.openstack.org/03/669803/3/gate/puppet-openstack-syntax-6-ubuntu-bionic/2d43f19/ : SUCCESS in 4m 59s\n- puppet-openstack-unit-4.8-centos-7 http://logs.openstack.org/03/669803/3/gate/puppet-openstack-unit-4.8-centos-7/0cfea02/ : SUCCESS in 31m 33s\n- puppet-openstack-unit-5.5-centos-7 http://logs.openstack.org/03/669803/3/gate/puppet-openstack-unit-5.5-centos-7/a9c9df6/ : SUCCESS in 28m 15s\n- tripleo-ci-centos-7-undercloud-containers http://logs.openstack.org/03/669803/3/gate/tripleo-ci-centos-7-undercloud-containers/8bf9902/ : SUCCESS in 1h 29m 52s\n- tripleo-ci-centos-7-containers-multinode http://logs.openstack.org/03/669803/3/gate/tripleo-ci-centos-7-containers-multinode/fc4ee59/ : SUCCESS in 2h 09m 08s\n- tripleo-ci-centos-7-standalone http://logs.openstack.org/03/669803/3/gate/tripleo-ci-centos-7-standalone/dff33db/ : SUCCESS in 1h 48m 03s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates http://logs.openstack.org/03/669803/3/gate/tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates/355ab44/ : SUCCESS in 2h 12m 22s","accounts_in_message":[],"_revision_number":3},{"id":"6e64765cec3d8f15c64b9507008852705cf1a104","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-10 07:01:47.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"58f3baa7ccb48cc8bce431c3251542804f2c0999","author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"date":"2019-07-10 07:20:16.000000000","message":"Patch Set 3: Cherry Picked\n\nThis patchset was cherry picked to branch stable/rocky as commit bcea8ea1aac2a4b892007ced0b28d34b7651fecc","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"dc4bb7e7cb652e41f55b5b7ba8b93628afab10cf","revisions":{"a1801b0c7dbf45891ceedf6d6f2db07bea672fb2":{"kind":"REWORK","_number":1,"created":"2019-07-09 07:12:02.000000000","uploader":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"ref":"refs/changes/03/669803/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-tripleo","ref":"refs/changes/03/669803/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/03/669803/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/03/669803/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/03/669803/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-tripleo refs/changes/03/669803/1"}}},"commit":{"parents":[{"commit":"1c96d897663c5160754b8e56407cc1d8b10ad97b","subject":"Fix amphora provider driver description","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/1c96d897663c5160754b8e56407cc1d8b10ad97b"}]}],"author":{"name":"Michele Baldessari","email":"michele@acksyn.org","date":"2019-07-08 06:53:27.000000000","tz":120},"committer":{"name":"Michele Baldessari","email":"michele@acksyn.org","date":"2019-07-09 07:12:02.000000000","tz":0},"subject":"Close OVN VIP race by adding an ordering constraint","message":"Close OVN VIP race by adding an ordering constraint\n\nCurrently there is a race with the high-availability of ovn when resetting a\ncontroller. Namely, the VIP that OVN uses (namely the internal_api VIP\nby default) only has a colocation constraint with the master role of the\novn-dbs resource. This leaves the following race open:\n1) We reboot ctrl-0 hosting the master role of ovn-dbs\n2) OVN becomes master on ctrl-1 from pacemaker\u0027s POV (but the\n   promotion operation running in the background is not completed)\n3) OVN VIP moves to ctrl-1 even though it is still in slave mode\n  (there is only a colocation constraint between vip and master role for\novn)\n4) OVN controllers on the overcloud connect to the VIP but it is in\n  read-only mode because it was a slave\n5) OVN controllers that connected at 4) stay in read-only forever\n   until they get restarted manually.\n\nWith the addition of this constraint we force the VIP move only after\nthe master role has been promoted. This makes it much more unlikely\nfor a client to connect to the VIP and get a read-only db in the\nbackground. With only this patch applied I did not manage to reproduce\nthe issue (even after 7 reboots of controllers).\nNote that there is still a small race window possible because the\ncurrent OVN resource agent has a bug: it promotes a resource to master\nafter issuing the promotion command to the DB but without waiting for\nthis promotion to complete. A patch for OVN-ra will also be submitted\nbut from initial testing this change seems to be largely sufficient.\n\nAlso note that this change introduces a small less desirable\nside-effect:\nA failover of the internal VIP will now take a bit longer because it\nwill happen only after ovn-dbs gets promoted to master.\nWe plan to take care of this fully by decoupling the OVN VIP from the\ninternal_api one. This change addresses the immediate issue related\nto ovn_controllers being stuck in read-only due to premature promotion.\n(OVN upstream is discussing how to make connections to read-only VIP\ntrigger a reconnection eventually)\n\nCloses-Bug: #1835830\n\nChange-Id: I3fa07e28c4e37197890664d12a265f1673c780f2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/a1801b0c7dbf45891ceedf6d6f2db07bea672fb2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/a1801b0c7dbf45891ceedf6d6f2db07bea672fb2"}]},"branch":"refs/heads/stable/stein"},"ae7f71c7f44fd9dea5ff62c3e1aa7f68c9fcacb6":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2019-07-09 14:16:56.000000000","uploader":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"ref":"refs/changes/03/669803/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-tripleo","ref":"refs/changes/03/669803/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/03/669803/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/03/669803/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/03/669803/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-tripleo refs/changes/03/669803/2"}}},"commit":{"parents":[{"commit":"acbede75844ed549e292a5dc25ba01fa240ab624","subject":"Merge \"Fix rabbitmq staged upgrade\" into stable/stein","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/acbede75844ed549e292a5dc25ba01fa240ab624"}]}],"author":{"name":"Michele Baldessari","email":"michele@acksyn.org","date":"2019-07-08 06:53:27.000000000","tz":120},"committer":{"name":"Daniel Alvarez","email":"dalvarez@redhat.com","date":"2019-07-09 14:16:56.000000000","tz":0},"subject":"Close OVN VIP race by adding an ordering constraint","message":"Close OVN VIP race by adding an ordering constraint\n\nCurrently there is a race with the high-availability of ovn when resetting a\ncontroller. Namely, the VIP that OVN uses (namely the internal_api VIP\nby default) only has a colocation constraint with the master role of the\novn-dbs resource. This leaves the following race open:\n1) We reboot ctrl-0 hosting the master role of ovn-dbs\n2) OVN becomes master on ctrl-1 from pacemaker\u0027s POV (but the\n   promotion operation running in the background is not completed)\n3) OVN VIP moves to ctrl-1 even though it is still in slave mode\n  (there is only a colocation constraint between vip and master role for\novn)\n4) OVN controllers on the overcloud connect to the VIP but it is in\n  read-only mode because it was a slave\n5) OVN controllers that connected at 4) stay in read-only forever\n   until they get restarted manually.\n\nWith the addition of this constraint we force the VIP move only after\nthe master role has been promoted. This makes it much more unlikely\nfor a client to connect to the VIP and get a read-only db in the\nbackground. With only this patch applied I did not manage to reproduce\nthe issue (even after 7 reboots of controllers).\nNote that there is still a small race window possible because the\ncurrent OVN resource agent has a bug: it promotes a resource to master\nafter issuing the promotion command to the DB but without waiting for\nthis promotion to complete. A patch for OVN-ra will also be submitted\nbut from initial testing this change seems to be largely sufficient.\n\nAlso note that this change introduces a small less desirable\nside-effect:\nA failover of the internal VIP will now take a bit longer because it\nwill happen only after ovn-dbs gets promoted to master.\nWe plan to take care of this fully by decoupling the OVN VIP from the\ninternal_api one. This change addresses the immediate issue related\nto ovn_controllers being stuck in read-only due to premature promotion.\n(OVN upstream is discussing how to make connections to read-only VIP\ntrigger a reconnection eventually)\n\nCloses-Bug: #1835830\n\nChange-Id: I3fa07e28c4e37197890664d12a265f1673c780f2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/ae7f71c7f44fd9dea5ff62c3e1aa7f68c9fcacb6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/ae7f71c7f44fd9dea5ff62c3e1aa7f68c9fcacb6"}]},"branch":"refs/heads/stable/stein"},"dc4bb7e7cb652e41f55b5b7ba8b93628afab10cf":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2019-07-09 19:38:11.000000000","uploader":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"ref":"refs/changes/03/669803/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-tripleo","ref":"refs/changes/03/669803/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/03/669803/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/03/669803/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/03/669803/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-tripleo refs/changes/03/669803/3"}}},"commit":{"parents":[{"commit":"acbede75844ed549e292a5dc25ba01fa240ab624","subject":"Merge \"Fix rabbitmq staged upgrade\" into stable/stein","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/acbede75844ed549e292a5dc25ba01fa240ab624"}]}],"author":{"name":"Michele Baldessari","email":"michele@acksyn.org","date":"2019-07-08 06:53:27.000000000","tz":120},"committer":{"name":"Alex Schultz","email":"aschultz@redhat.com","date":"2019-07-09 19:38:11.000000000","tz":0},"subject":"Close OVN VIP race by adding an ordering constraint","message":"Close OVN VIP race by adding an ordering constraint\n\nCurrently there is a race with the high-availability of ovn when resetting a\ncontroller. Namely, the VIP that OVN uses (namely the internal_api VIP\nby default) only has a colocation constraint with the master role of the\novn-dbs resource. This leaves the following race open:\n1) We reboot ctrl-0 hosting the master role of ovn-dbs\n2) OVN becomes master on ctrl-1 from pacemaker\u0027s POV (but the\n   promotion operation running in the background is not completed)\n3) OVN VIP moves to ctrl-1 even though it is still in slave mode\n  (there is only a colocation constraint between vip and master role for\novn)\n4) OVN controllers on the overcloud connect to the VIP but it is in\n  read-only mode because it was a slave\n5) OVN controllers that connected at 4) stay in read-only forever\n   until they get restarted manually.\n\nWith the addition of this constraint we force the VIP move only after\nthe master role has been promoted. This makes it much more unlikely\nfor a client to connect to the VIP and get a read-only db in the\nbackground. With only this patch applied I did not manage to reproduce\nthe issue (even after 7 reboots of controllers).\nNote that there is still a small race window possible because the\ncurrent OVN resource agent has a bug: it promotes a resource to master\nafter issuing the promotion command to the DB but without waiting for\nthis promotion to complete. A patch for OVN-ra will also be submitted\nbut from initial testing this change seems to be largely sufficient.\n\nAlso note that this change introduces a small less desirable\nside-effect:\nA failover of the internal VIP will now take a bit longer because it\nwill happen only after ovn-dbs gets promoted to master.\nWe plan to take care of this fully by decoupling the OVN VIP from the\ninternal_api one. This change addresses the immediate issue related\nto ovn_controllers being stuck in read-only due to premature promotion.\n(OVN upstream is discussing how to make connections to read-only VIP\ntrigger a reconnection eventually)\n\nCloses-Bug: #1835830\n\nChange-Id: I3fa07e28c4e37197890664d12a265f1673c780f2\n(cherry picked from commit 5c10f331977152d4e69e91ed67cd14304cef6a18)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/dc4bb7e7cb652e41f55b5b7ba8b93628afab10cf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/dc4bb7e7cb652e41f55b5b7ba8b93628afab10cf"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}