)]}'
{"id":"openstack%2Fpuppet-tripleo~669996","triplet_id":"openstack%2Fpuppet-tripleo~stable%2Frocky~I3fa07e28c4e37197890664d12a265f1673c780f2","project":"openstack/puppet-tripleo","branch":"stable/rocky","topic":"ovn-fixes-stable/stein-stable/rocky","hashtags":[],"change_id":"I3fa07e28c4e37197890664d12a265f1673c780f2","subject":"Close OVN VIP race by adding an ordering constraint","status":"MERGED","created":"2019-07-10 07:20:16.000000000","updated":"2019-08-12 10:06:20.000000000","submitted":"2019-07-15 17:33:44.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"669996-1563212024298-3eb45556","meta_rev_id":"0d88ffc69e8f420ddd92136755a8c9f6086694c8","_number":669996,"virtual_id_number":669996,"owner":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},{"value":0,"date":"2019-07-11 17:23:29.000000000","_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"value":2,"date":"2019-07-15 17:33:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-07-10 08:16:17.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":2,"date":"2019-07-15 13:41:52.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":1,"date":"2019-07-10 07:34:08.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},{"value":0,"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":1,"date":"2019-07-15 13:41:52.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},{"value":0,"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-10 07:34:08.000000000","updated_by":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"reviewer":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"state":"REVIEWER"},{"updated":"2019-07-10 08:16:17.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-07-15 13:41:52.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2019-07-15 17:33:44.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f25e14ff367d9157a8f8e0c5d6e15ab41802ff27","author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"date":"2019-07-10 07:20:16.000000000","message":"Patch Set 1: Cherry Picked from branch stable/stein.","accounts_in_message":[],"_revision_number":1},{"id":"9e149e98f43cc557c1175d04fa05521106ce73aa","author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"date":"2019-07-10 07:34:08.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"9a81a5199ac9c0967fd0328d281b6a587b043298","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-07-10 08:16:17.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-ovb-3ctlr_1comp_1supp-featureset039 http://logs.rdoproject.org/96/669996/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp_1supp-featureset039/fb524c7/ : FAILURE in 54m 38s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"149e1450ebed4993a37cec7704ac58fa0055a8e2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-10 09:46:34.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tripleo-ci-centos-7-undercloud-oooq http://logs.openstack.org/96/669996/1/check/tripleo-ci-centos-7-undercloud-oooq/2f3500d/ : SUCCESS in 1h 01m 03s\n- tripleo-ci-centos-7-undercloud-upgrades http://logs.openstack.org/96/669996/1/check/tripleo-ci-centos-7-undercloud-upgrades/ef5804e/ : SUCCESS in 2h 01m 04s\n- tripleo-ci-centos-7-undercloud-containers http://logs.openstack.org/96/669996/1/check/tripleo-ci-centos-7-undercloud-containers/8cde612/ : FAILURE in 38m 39s\n- tripleo-ci-centos-7-containerized-undercloud-upgrades http://logs.openstack.org/96/669996/1/check/tripleo-ci-centos-7-containerized-undercloud-upgrades/b1b6b05/ : SUCCESS in 2h 08m 18s (non-voting)\n- tripleo-ci-centos-7-containers-multinode http://logs.openstack.org/96/669996/1/check/tripleo-ci-centos-7-containers-multinode/38aa310/ : FAILURE in 40m 23s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates http://logs.openstack.org/96/669996/1/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates/39cccc4/ : FAILURE in 47m 03s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades http://logs.openstack.org/96/669996/1/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades/1ab7430/ : FAILURE in 44m 25s (non-voting)\n- tripleo-ci-centos-7-standalone-rocky http://logs.openstack.org/96/669996/1/check/tripleo-ci-centos-7-standalone-rocky/dad1c2a/ : FAILURE in 32m 39s\n- puppet-openstack-lint http://logs.openstack.org/96/669996/1/check/puppet-openstack-lint/080df55/ : SUCCESS in 5m 16s\n- puppet-openstack-syntax-4 http://logs.openstack.org/96/669996/1/check/puppet-openstack-syntax-4/7f5f00e/ : SUCCESS in 6m 34s\n- puppet-openstack-unit-4.8-centos-7 http://logs.openstack.org/96/669996/1/check/puppet-openstack-unit-4.8-centos-7/dc15586/ : SUCCESS in 30m 26s\n- tripleo-ci-centos-7-scenario007-multinode-oooq-container http://logs.openstack.org/96/669996/1/check/tripleo-ci-centos-7-scenario007-multinode-oooq-container/a11e6bf/ : FAILURE in 41m 13s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"2856b35025ba42758d540bcb2a5d9c0f347bce8e","author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"date":"2019-07-11 17:23:29.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"9675fab29ec774a4e1e7211ce79f56699d6205a4","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-07-11 17:47:28.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-ovb-3ctlr_1comp_1supp-featureset039 http://logs.rdoproject.org/96/669996/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp_1supp-featureset039/23e7bad/ : RETRY_LIMIT in 4m 20s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"8df3a9524deb6bcc98f9ded6ca3459b2ac4a48d2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-11 22:58:20.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-undercloud-oooq http://logs.openstack.org/96/669996/1/check/tripleo-ci-centos-7-undercloud-oooq/638c20e/ : SUCCESS in 1h 04m 26s\n- tripleo-ci-centos-7-undercloud-upgrades http://logs.openstack.org/96/669996/1/check/tripleo-ci-centos-7-undercloud-upgrades/ee9fe18/ : SUCCESS in 1h 54m 58s\n- tripleo-ci-centos-7-undercloud-containers http://logs.openstack.org/96/669996/1/check/tripleo-ci-centos-7-undercloud-containers/bf88a26/ : SUCCESS in 1h 40m 31s\n- tripleo-ci-centos-7-containerized-undercloud-upgrades http://logs.openstack.org/96/669996/1/check/tripleo-ci-centos-7-containerized-undercloud-upgrades/a8061ce/ : SUCCESS in 2h 00m 45s (non-voting)\n- tripleo-ci-centos-7-containers-multinode http://logs.openstack.org/96/669996/1/check/tripleo-ci-centos-7-containers-multinode/973d76b/ : SUCCESS in 2h 22m 49s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates http://logs.openstack.org/96/669996/1/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates/e899df9/ : SUCCESS in 2h 20m 45s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades http://logs.openstack.org/96/669996/1/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades/88bb625/ : SUCCESS in 2h 52m 27s (non-voting)\n- tripleo-ci-centos-7-standalone-rocky http://logs.openstack.org/96/669996/1/check/tripleo-ci-centos-7-standalone-rocky/76b361e/ : SUCCESS in 1h 44m 40s\n- puppet-openstack-lint http://logs.openstack.org/96/669996/1/check/puppet-openstack-lint/ab6e7fc/ : SUCCESS in 5m 50s\n- puppet-openstack-syntax-4 http://logs.openstack.org/96/669996/1/check/puppet-openstack-syntax-4/b7cc6ef/ : SUCCESS in 4m 04s\n- puppet-openstack-unit-4.8-centos-7 http://logs.openstack.org/96/669996/1/check/puppet-openstack-unit-4.8-centos-7/e31e92c/ : SUCCESS in 32m 50s\n- tripleo-ci-centos-7-scenario007-multinode-oooq-container http://logs.openstack.org/96/669996/1/check/tripleo-ci-centos-7-scenario007-multinode-oooq-container/748fc2c/ : SUCCESS in 2h 13m 40s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"64d5d62fed059ecf317be4f304e212b2b9655ac9","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2019-07-15 13:41:52.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"ec19ad612d4575deadd133f3a1057a3595cd8a0c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-15 13:42:10.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"6f7930897ccb2931f1dfdf50359c297a17366eb8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-15 17:33:44.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"7e2152072663fc4aa0d92a6b64a3c159f4448b52","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-15 17:33:44.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tripleo-ci-centos-7-undercloud-oooq http://logs.openstack.org/96/669996/1/gate/tripleo-ci-centos-7-undercloud-oooq/db409ba/ : SUCCESS in 1h 09m 32s\n- tripleo-ci-centos-7-undercloud-containers http://logs.openstack.org/96/669996/1/gate/tripleo-ci-centos-7-undercloud-containers/4cfa1d0/ : SUCCESS in 1h 40m 18s\n- tripleo-ci-centos-7-containers-multinode http://logs.openstack.org/96/669996/1/gate/tripleo-ci-centos-7-containers-multinode/508367b/ : SUCCESS in 2h 26m 37s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates http://logs.openstack.org/96/669996/1/gate/tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates/6a66cd9/ : SUCCESS in 2h 35m 28s\n- puppet-openstack-lint http://logs.openstack.org/96/669996/1/gate/puppet-openstack-lint/dfa9676/ : SUCCESS in 5m 29s\n- puppet-openstack-syntax-4 http://logs.openstack.org/96/669996/1/gate/puppet-openstack-syntax-4/63ab3c2/ : SUCCESS in 5m 28s\n- puppet-openstack-unit-4.8-centos-7 http://logs.openstack.org/96/669996/1/gate/puppet-openstack-unit-4.8-centos-7/528b953/ : SUCCESS in 31m 47s","accounts_in_message":[],"_revision_number":1},{"id":"34e3a2ca32f2d21e698c0eaf0cb7c0c6b32943dd","author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"date":"2019-08-12 10:06:20.000000000","message":"Patch Set 1: Cherry Picked\n\nThis patchset was cherry picked to branch stable/queens as commit a0cfe0afddc24a17b9ef5ac9d24f22086a45055f","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"bcea8ea1aac2a4b892007ced0b28d34b7651fecc","revisions":{"bcea8ea1aac2a4b892007ced0b28d34b7651fecc":{"kind":"REWORK","_number":1,"created":"2019-07-10 07:20:16.000000000","uploader":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"ref":"refs/changes/96/669996/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-tripleo","ref":"refs/changes/96/669996/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/96/669996/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/96/669996/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/96/669996/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-tripleo refs/changes/96/669996/1"}}},"commit":{"parents":[{"commit":"5eb012b4f62615519707a926cc62528f5dc54a44","subject":"Fix interface_for_ip for newer facter versions","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/5eb012b4f62615519707a926cc62528f5dc54a44"}]}],"author":{"name":"Michele Baldessari","email":"michele@acksyn.org","date":"2019-07-08 06:53:27.000000000","tz":120},"committer":{"name":"Michele Baldessari","email":"michele@acksyn.org","date":"2019-07-10 07:20:16.000000000","tz":0},"subject":"Close OVN VIP race by adding an ordering constraint","message":"Close OVN VIP race by adding an ordering constraint\n\nCurrently there is a race with the high-availability of ovn when resetting a\ncontroller. Namely, the VIP that OVN uses (namely the internal_api VIP\nby default) only has a colocation constraint with the master role of the\novn-dbs resource. This leaves the following race open:\n1) We reboot ctrl-0 hosting the master role of ovn-dbs\n2) OVN becomes master on ctrl-1 from pacemaker\u0027s POV (but the\n   promotion operation running in the background is not completed)\n3) OVN VIP moves to ctrl-1 even though it is still in slave mode\n  (there is only a colocation constraint between vip and master role for\novn)\n4) OVN controllers on the overcloud connect to the VIP but it is in\n  read-only mode because it was a slave\n5) OVN controllers that connected at 4) stay in read-only forever\n   until they get restarted manually.\n\nWith the addition of this constraint we force the VIP move only after\nthe master role has been promoted. This makes it much more unlikely\nfor a client to connect to the VIP and get a read-only db in the\nbackground. With only this patch applied I did not manage to reproduce\nthe issue (even after 7 reboots of controllers).\nNote that there is still a small race window possible because the\ncurrent OVN resource agent has a bug: it promotes a resource to master\nafter issuing the promotion command to the DB but without waiting for\nthis promotion to complete. A patch for OVN-ra will also be submitted\nbut from initial testing this change seems to be largely sufficient.\n\nAlso note that this change introduces a small less desirable\nside-effect:\nA failover of the internal VIP will now take a bit longer because it\nwill happen only after ovn-dbs gets promoted to master.\nWe plan to take care of this fully by decoupling the OVN VIP from the\ninternal_api one. This change addresses the immediate issue related\nto ovn_controllers being stuck in read-only due to premature promotion.\n(OVN upstream is discussing how to make connections to read-only VIP\ntrigger a reconnection eventually)\n\nCloses-Bug: #1835830\n\nChange-Id: I3fa07e28c4e37197890664d12a265f1673c780f2\n(cherry picked from commit 5c10f331977152d4e69e91ed67cd14304cef6a18)\n(cherry picked from commit dc4bb7e7cb652e41f55b5b7ba8b93628afab10cf)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/bcea8ea1aac2a4b892007ced0b28d34b7651fecc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/bcea8ea1aac2a4b892007ced0b28d34b7651fecc"}]},"branch":"refs/heads/stable/rocky"}},"requirements":[],"submit_records":[],"submit_requirements":[]}